wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-09-24 02:39:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply unseen notifications colours to all skins by default

Browse source 
Colours were previously defined only in the monobook- and vector-specific
styles, but with the same styles in each, and appear to work consistently
accross all tested skins (modern, timeless, cologneblue, anisa,
hassomecolours...). Given the UX importance of these colours, better to
apply them as the default for all skins and leave it to any others for
which this doesn't work to resolve any issues on their end.

bug: T181142
Change-Id: Idc22881d6c51aa12adc9a053ce08adfdf0fad2b0
This commit is contained in:
Isarra 2019-02-20 14:56:06 +00:00
parent decb91d9dc
commit 91cd3b3b98
3 changed files with 11 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/nojs/mw.echo.badge.less
View file

@ -95,5 +95,16 @@
background-image: url( ../icons/tray.svg );
}
}
&.oo-ui-flaggedElement-unseen,
&.mw-echo-unseen-notifications {
#pt-notifications-alert &:after {
background-color: @badge-counter-background-unseen-alert;
}
#pt-notifications-notice &:after {
background-color: @badge-counter-background-unseen-message;
}
}
}
/* stylelint-enable no-descending-specificity */

11
modules/nojs/mw.echo.badge.monobook.less
View file

@ -17,17 +17,6 @@
top: @badge-offscreen-offset + 3px;
}
}
&.oo-ui-flaggedElement-unseen,
&.mw-echo-unseen-notifications {
#pt-notifications-alert &:after {
background-color: @badge-counter-background-unseen-alert;
}
#pt-notifications-notice &:after {
background-color: @badge-counter-background-unseen-message;
}
}
}
#p-personal #pt-notifications-alert,

14
modules/nojs/mw.echo.badge.vector.less
View file

@ -1,19 +1,5 @@
@import '../echo.variables';
/* We have to include the #pt-notifications selector due to monobook */
.mw-echo-notifications-badge {
&.oo-ui-flaggedElement-unseen,
&.mw-echo-unseen-notifications {
#pt-notifications-alert &:after {
background-color: @badge-counter-background-unseen-alert;
}
#pt-notifications-notice &:after {
background-color: @badge-counter-background-unseen-message;
}
}
}
#p-personal #pt-notifications-alert,
#p-personal #pt-notifications-notice {
margin-right: 0.4em;