Commit graph

1565 commits

Author SHA1 Message Date
Cmcmahon b3df4d0814 QA: Refactoring and making the nojs test dtrt
* add @custom_browser tag so we don't create an extra browser instance
* remove @chrome tag because this only works in Firefox
* alphabetize within G/W/T buckets in commons_steps.rb
* alphabetize flyout_steps.rb
* bring env.rb up to date with the modern situation
* make assertions about the URL and heading on the final destination page
* update Ruby gems, especially mediawiki-selenium with a @custom_browser improvement
** use modern RSpec assert syntax
*** we're going to have to update all the repos for this soon

Change-Id: I6cb20126a662bd2a20e2b4bbebe91e8f3b04c7df
2014-09-23 13:35:50 -07:00
Translation updater bot c973ccd906 Localisation updates from https://translatewiki.net.
Change-Id: I4cbbbbf9b6c1f958c828a0feb917dc9345404d66
2014-09-22 21:44:27 +02:00
Translation updater bot 3cd4e6bbd9 Localisation updates from https://translatewiki.net.
Change-Id: I9688d30c8805aa0228d412efb6800a99b433d59d
2014-09-21 21:56:13 +02:00
Translation updater bot cac254f317 Localisation updates from https://translatewiki.net.
Change-Id: Ibdb68eebd836b1f800f3379b8ee771b5340bcd71
2014-09-20 21:41:01 +02:00
grunny 3093c7a69f Remove use of deprecated "hover" pseudo-event
The "hover" pseudo-event was deprecated in jQuery 1.8 and removed in
1.9. This is logged as "JQMIGRATE: 'hover' pseudo-event is deprecated,
use 'mouseenter mouseleave'". This fix switches to using the .hover()
method which appears to be the original intent as two functions have
been used which .hover() supports, whereas .on() only accepts one
handler. Now the class change works as expected.

Change-Id: Ib28801293b72f8f344455b5f308876d185abc8bd
2014-09-19 03:02:43 +10:00
jenkins-bot 45f450ac52 Merge "QA: refactor for consistent Ruby practice" 2014-09-18 01:28:50 +00:00
Cmcmahon 50790b2965 QA: refactor for consistent Ruby practice
* use symbols not strings for element labels
* use double quotes except where single quotes required

Change-Id: I4eef50206c526611da535e529035c076d5bce266
2014-09-17 16:27:24 -07:00
Translation updater bot d2abb52264 Localisation updates from https://translatewiki.net.
Change-Id: Id3b5692442545c284d3fda8c4959bc4b54c874f1
2014-09-17 22:44:35 +02:00
S Page a1864d71c8 QA: Update selenium-webdriver so Firefox 32 works
I did `bundle update`.
Without this, browser tests on Firefox 32 fail with
`unable to obtain stable firefox connection in 60 seconds
(127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError)`

Change I26190cca06ee gave Flow the same update, this Gemfile.lock is
identical except Echo has a "chunky_png" gem.

Change-Id: I0b62134d38f3262b734af83cc58b644040857645
2014-09-16 17:49:38 -07:00
Translation updater bot 01e72b82e6 Localisation updates from https://translatewiki.net.
Change-Id: Ibed94dceebd02a9ab53f898d74c5cbb386eb9cc6
2014-09-16 19:43:22 +02:00
Cmcmahon 7eacda1306 QA: get messages test to pass properly
This is lieu of

https://gerrit.wikimedia.org/r/#/c/159685/

If we merge this patch, we should abandon 159685

Change-Id: I84e0a1df6076a68ee7e97feb929195da9937c412
2014-09-15 11:07:45 -07:00
Translation updater bot eefc096490 Localisation updates from https://translatewiki.net.
Change-Id: If7fcc322db851335bb44cff0b33bd92770878de9
2014-09-15 02:02:46 +02:00
jenkins-bot 8635a9cc9f Merge "Hygiene: Dont quote object property keys" 2014-09-12 23:16:06 +00:00
Erik Bernhardson 8ee843fab5 Hygiene: Dont quote object property keys
Change-Id: I93d669a26f85b4eb5c5e0e06e314b89894f12385
2014-09-12 16:00:07 -07:00
jenkins-bot acce7cc9fb Merge "Hygiene: Alter how initialisation of the overlay works" 2014-09-12 22:59:50 +00:00
jenkins-bot 5bfdd22235 Merge "Hygiene: Convert value to constant and clarify outlier use case" 2014-09-12 22:54:36 +00:00
jdlrobson 4ff74ddd50 Hygiene: Alter how initialisation of the overlay works
Restructure code so MobileFrontend can make use of it
Kill ext.echo.desktop

Change-Id: I984373ba54206d447c54a435dbf60e8f6e814be1
2014-09-12 22:49:51 +00:00
Translation updater bot 8a6c792cb5 Localisation updates from https://translatewiki.net.
Change-Id: Id8f5a320167984b4713eb260c451fc1a4aa4dbbb
2014-09-13 00:45:58 +02:00
bsitu b63e704f79 Add emailsubject as a distribution type
so that we could skip parameters escaping  when formatting email
subject. This is not a great solution but works for now.

Probably should re-think all the use case of echo formatting and
refactor the formatter

Change-Id: Ic1f6aa0f72d637558466db5cb2ee8d36038dd0b2
2014-09-12 20:32:27 +00:00
Erik Bernhardson 0f36db727e Hygiene: Convert value to constant and clarify outlier use case
Change-Id: I7a82fa99b41362368a9f58cfb84241cca97bfb15
2014-09-11 20:07:29 -07:00
Shahyar c0446f683f Set text colors in overlay to mwui light gray, and increase title font size
Change-Id: I24f796df1abee02557db2f4817ad70c227dd8d8f
2014-09-11 19:13:44 -04:00
Translation updater bot 2909923b7e Localisation updates from https://translatewiki.net.
Change-Id: I669e3049416317430a4047dc2f834cccf7b38b01
2014-09-11 23:56:18 +02:00
bsitu b320555cb1 wfDebugLog exception if thrown during formatting
Some exception is not loggable, which won't be logged by
MWExceptionhandler::logException(), we should log it in
the debug log for debugging purpose

Change-Id: I709c45f7e47afacb98be3a869eb5b70660e18f48
2014-09-11 11:37:25 -07:00
jenkins-bot 922990408f Merge "Make plural entries correct" 2014-09-11 11:35:58 +00:00
jenkins-bot 9e925cf021 Merge "Switch the order of Alerts and Messages tabs" 2014-09-10 22:00:17 +00:00
Translation updater bot 72f33a532b Localisation updates from https://translatewiki.net.
Change-Id: I0c6dc2045c64e5e185e3bbee555e06045f975ae1
2014-09-10 23:38:55 +02:00
jenkins-bot 34290fb80a Merge "Localize numbers of alerts and messages" 2014-09-10 16:08:45 +00:00
Matthias Mullie adfb235de0 Switch the order of Alerts and Messages tabs
Change-Id: I864d45336c23331543ff6aaea8ec6512d4fba0c3
2014-09-10 15:31:09 +00:00
S Page b634890634 QA: Fix missing "Given I am logged in as a new user"
Echo browser tests pass, but are skipping
  Scenario: New user gets a sign up notification
because a step definition is missing.

I simply adapted
  ^I am logged in as a new user with no notifications$
and the scenario passes in chrome.

Change-Id: I9f2bd10d05b689eaacbf2890913786eb157d6af9
2014-09-10 15:26:53 +00:00
lokal-profil 4f84120386 Make plural entries correct
Changes three singular forms of messages already supporting plural.
Affected messages:
* echo-notification-alert
* echo-notification-message
* echo-overlay-title-overflow

First reported at:
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Echo-notification-alert/es
* https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Echo-notification-message/es

Change-Id: Ifcaade5e141c801c6e546d2098578c933d60434e
2014-09-10 09:27:59 +02:00
jenkins-bot 4156e030c8 Merge "Remove (X) next to Alerts/Messages if there is one section" 2014-09-09 23:28:35 +00:00
jdlrobson 2cacf82efa Restore QUnit tests to reflect alert as default tab
This reverts the tests and amends them after the
application of commit 5da9eac08a.

Luckily nothing appears to be broken.

Change-Id: I67acfe5dc74ef750d5443dd619dbb114623ee233
2014-09-09 13:23:37 -07:00
bsitu 75d5c9b9a3 Remove (X) next to Alerts/Messages if there is one section
Change-Id: Ibf66328e31bfefb3d588196c3f4babfa65bb52f3
Eg: Alerts(X) becomes Alerts
2014-09-09 11:12:38 -07:00
Matthias Mullie b090b749de Messages/Alerts text is tiny in Monobook
Just like all other text elements in the overlay: set the font-size to 13px
Not sure why this was em & rest px. 13px is equivalent to the current 0.8em in
Vector.

Change-Id: I29d67f21cc2af7209469299ab228ebe7dac98af7
2014-09-09 18:01:36 +02:00
bsitu 9c55aa0fc8 Colors are backwards for flyout section link
Also make active section link not clickable

Change-Id: I7f391929382489e8bad5ab56fea9f2ef7b2978b0
2014-09-09 16:31:23 +02:00
jenkins-bot 4aa508b6a8 Merge "Default to alerts tab" 2014-09-08 21:42:29 +00:00
jenkins-bot 91d102131e Merge "Mark notifications as read if they fail rendering" 2014-09-08 21:27:26 +00:00
Erik Bernhardson 97417af20c Mark notifications as read if they fail rendering
The only issue is that the badge is not up to date till
you refresh the page, I think that's fine for now

Change-Id: I585b4cc185bf859ddb06829df75309ff3d56d8b8
2014-09-08 14:22:10 -07:00
jenkins-bot f39ad2d842 Merge "mw.echo.overlay.updateCount() no longer exists" 2014-09-08 20:44:09 +00:00
Erik Bernhardson 5da9eac08a Default to alerts tab
The only exception is when there are new message notifications but no new
alert notifications.

Bug: 70461
Change-Id: I06daa3f7d526beeb878eb343c169e01acd49e71f
2014-09-08 13:18:51 -07:00
jenkins-bot 66cdad22c8 Merge "Hygiene: Give ApiStub modes names instead of numbers" 2014-09-08 19:11:36 +00:00
Amir E. Aharoni ce6b730e74 Localize numbers of alerts and messages
Change-Id: Ifc502afaed3fc04e7addb5383e3ed0c3c4efe439
2014-09-08 16:14:19 +03:00
jenkins-bot ad0bf2dadd Merge "Hygiene: Dont run jshint against .less files" 2014-09-08 10:40:37 +00:00
Translation updater bot b89163bbfd Localisation updates from https://translatewiki.net.
Change-Id: I681e050ecb04cc85dae46b0715edf096e9a72615
2014-09-07 21:59:02 +02:00
Erik Bernhardson 584394fcde Hygiene: Give ApiStub modes names instead of numbers
Change-Id: Ia01ba14a1b2ab179454f14e5a1595ff468c46fc5
2014-09-05 16:52:42 -07:00
Erik Bernhardson c88261148d Hygiene: Dont run jshint against .less files
Change-Id: Ib90f706160b5404fa278e09e5a79bb83e8911500
2014-09-05 16:45:34 -07:00
bsitu d9f697414f mw.echo.overlay.updateCount() no longer exists
If you have an unread notifications not in the initial
load of special page, clicking load more would throw
an error

Bug: 69714
Change-Id: I9af588780b2ab8481ba252ddc21bad0601de7a0b
2014-09-05 21:37:12 +00:00
Translation updater bot f8a8caa93b Localisation updates from https://translatewiki.net.
Change-Id: If0a6fa28d14803765880f0de57407fc517062ed1
2014-09-05 22:45:14 +02:00
jenkins-bot f89a4a5a71 Merge "Allow .mw-echo-title-heading outside special page" 2014-09-05 10:06:13 +00:00
Erik Bernhardson f5985169cc Allow .mw-echo-title-heading outside special page
This class was only being applied to notification output
on special pages and not in the overlay, move it so it can.

Additionally:
* bolds .mw-echo-title-heading same as the anchors it works with
* clean up a repeated rule against `.mw-echo-title a`

Change-Id: I579252399b39746f5aa2cfc51b5cd3b9b8b2cdb0
2014-09-04 18:59:30 -07:00