Commit graph

4980 commits

Author SHA1 Message Date
Thiemo Kreuz 8fd66d4281 Make use of the …::class feature in production code
This codebase already used the …::class feature a lot. This is more
about making the code consistent and easier to refactor in the future.

Change-Id: If5b2456b825aae753ed97445160ec191c18df8e3
2019-02-20 19:13:54 +00:00
jenkins-bot decb91d9dc Merge "Replace @expectedException with $this->expectException()" 2019-02-19 21:39:28 +00:00
jenkins-bot 539d2fd485 Merge "Simplify a few overly complex code snippets" 2019-02-19 21:38:00 +00:00
Translation updater bot 774ec6a93e Localisation updates from https://translatewiki.net.
Change-Id: I70bfb566da24629951d967bfbcc5bf3668d3c04e
2019-02-19 22:19:49 +01:00
Thiemo Kreuz 5941ef476c Replace @expectedException with $this->expectException()
The @expectedException annotation got deprecated in PHPUnit 7.5, and
removed in PHPUnit 8.0. This was done because the annotation does have
two disadvantages:
* The class name is encoded in string, where it is not easy to find for
  all IDEs and tools.
* it did not allow to say exactly *when* the exception is expected.

Change-Id: I96862a18874f36355e817accd64d8703c1965c86
2019-02-19 20:54:15 +00:00
Thiemo Kreuz e649551e5e Simplify a few overly complex code snippets
* preg_match_all already returns the number of matches. We can just use
  this number instead of counting it.
* Checking for a strlen() of 0 is a little tooo expressive, because we
  don't really care about the actual length of the string.

Change-Id: I0537a7740e5d369b79364f24aecf71c4e8fa7db1
2019-02-19 20:39:26 +00:00
Thiemo Kreuz c36d2bd0e8 Prefer the …::class feature over hard-coded strings in all tests
The codebase already used the …::class feature in many places. So this
is more for consistency than anything. The …::class feature makes it
much easier to do refactoring in the future.

Note this patch is exclusively touching tests. That should make it
relatively easy to review this. As long as the CI is fine with it, it
should be ok. Right? ;-)

Change-Id: I4d2adee76b4adbc83b2061161fd4e863ba833fcb
2019-02-19 14:35:14 +00:00
Translation updater bot 2e45f12018 Localisation updates from https://translatewiki.net.
Change-Id: Ie15e132d0ed4e52e0566badde9654b71eb1218b6
2019-02-18 22:22:58 +01:00
Translation updater bot fd82365276 Localisation updates from https://translatewiki.net.
Change-Id: I83fca921e52bed62901b8ce7bec819a67028311c
2019-02-17 22:14:11 +01:00
jenkins-bot 3fd6549ced Merge "Improve param docs and add @var to clarify types" 2019-02-17 01:29:48 +00:00
Matěj Suchánek cd4e510201 Fix undeclared var
Credit goes to Umherirrender who pointed this out.

Change-Id: I4d590b3574ea1310fa795cfd94a129e3046e6e3c
2019-02-15 21:25:27 +01:00
Umherirrender cdae062d47 Improve param docs and add @var to clarify types
Change-Id: I44f872b3a2921e75aab8e22fec57735f17ee1d8b
2019-02-15 21:23:02 +01:00
Translation updater bot 3b3f5a419f Localisation updates from https://translatewiki.net.
Change-Id: I5cf6ccb9e7cd6128f35a67bd06463b6bd0c97572
2019-02-14 22:29:04 +01:00
Translation updater bot 8a4fba0e3e Localisation updates from https://translatewiki.net.
Change-Id: Ide6d49a9f5ceb37fa120a53c69b9e6d284e4341d
2019-02-12 22:25:34 +01:00
Translation updater bot 0e3745b131 Localisation updates from https://translatewiki.net.
Change-Id: Id9865d23678e87a45825ba665864474563ef7968
2019-02-10 22:18:32 +01:00
Ed Sanders aee27014e9 SpecialHelpMenuWidget: Remove button handle hack
This leads to broken styling in OOUI 0.30, and is only
a marginal improvement in the Apex theme.

Bug: T215509
Change-Id: Id7d000be7c9dcd50e050f067c6f1fbdc06f332af
2019-02-07 14:41:55 +00:00
libraryupgrader 5bd2eaf70e build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: Ifd3dde125bae36b1076576ddc0c8b09eadd18a72
2019-02-06 13:01:32 +00:00
Ed Sanders 7ed027ddcf build: Update eslint-config-wikimedia to 0.10.1
Change-Id: I776585adab962c2b1d353d18d3a02b6662941b13
2019-02-06 01:42:53 +00:00
Translation updater bot d9fb41dbf6 Localisation updates from https://translatewiki.net.
Change-Id: If3495e3f283f899bfc0372388c7a7a39a41e2801
2019-02-05 22:37:39 +01:00
Translation updater bot 13c95f444b Localisation updates from https://translatewiki.net.
Change-Id: I9386291c36d625963680b0d6a06c3629a2a8d6b0
2019-02-03 22:38:19 +01:00
Translation updater bot e679fdc8af Localisation updates from https://translatewiki.net.
Change-Id: I9029910b668eeeed7c63a41697385e5e1caa9a6f
2019-01-31 22:25:58 +01:00
Translation updater bot ec98683850 Localisation updates from https://translatewiki.net.
Change-Id: Ia05fdba596ca9f006c7988cc3a0d1a02f48861d8
2019-01-30 22:13:57 +01:00
Translation updater bot 33cae175f5 Localisation updates from https://translatewiki.net.
Change-Id: I7bc8c7c42c7ef587a76bc27cf3867e7d61becdc9
2019-01-28 22:26:49 +01:00
Translation updater bot 3b0a2887bc Localisation updates from https://translatewiki.net.
Change-Id: Ica01eef8836499a76f8886de2b889253fe3ceeec
2019-01-25 22:28:54 +01:00
Translation updater bot 71a815e445 Localisation updates from https://translatewiki.net.
Change-Id: I79698a52b276c09765063cbe5223957de17f9ed8
2019-01-22 22:17:15 +01:00
Translation updater bot c9e9024cd1 Localisation updates from https://translatewiki.net.
Change-Id: I55578d3c3145be734db8010a4e49c02dfa2081e8
2019-01-20 22:35:50 +01:00
Translation updater bot 5ad88e20e3 Localisation updates from https://translatewiki.net.
Change-Id: Ic62104ff7996fd1e9a9d15bf92d63a92a8015e0b
2019-01-18 22:18:54 +01:00
Translation updater bot 2acd3aa6a7 Localisation updates from https://translatewiki.net.
Change-Id: I83130ec85a0ef25973fcd6563d6f99e9a6f5764e
2019-01-17 09:12:29 +01:00
Matěj Suchánek 8994407a7d Remove duplicate notifications after merging users
Bug: T103747
Change-Id: Ic2612e5d7861ef7c6a22ab66fd3b9d6ea71f959f
2019-01-16 18:38:34 +01:00
Translation updater bot cfffc7aa0c Localisation updates from https://translatewiki.net.
Change-Id: I77bc85cc44eceaa766a02fb2d1b58c74a5a830ea
2019-01-13 22:12:57 +01:00
Translation updater bot dc85a66bac Localisation updates from https://translatewiki.net.
Change-Id: I20744e31a83db90caa0ebb011ad9280fdab55495
2019-01-12 22:39:40 +01:00
Volker E c2dba98a9d build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass
Change-Id: I2789e3b93d1fc5743ea94b946fcd3e3ba8798e5e
2019-01-09 18:42:06 -08:00
Translation updater bot 4fcd539252 Localisation updates from https://translatewiki.net.
Change-Id: Iaffdf523f4d980e3141e93f718167b2bda6001fa
2019-01-08 22:29:39 +01:00
jenkins-bot 729111443e Merge "Display the full title in notifications about mention in summary" 2019-01-07 22:10:51 +00:00
jenkins-bot 86ec338346 Merge "Avoid double escaping of select options" 2019-01-07 22:10:48 +00:00
Translation updater bot cf1406d42e Localisation updates from https://translatewiki.net.
Change-Id: I3b153d4c8d0eb56795c05868cf4980dcf368eab1
2019-01-06 22:30:15 +01:00
Translation updater bot 21950eeb6a Localisation updates from https://translatewiki.net.
Change-Id: Ifd97ad391f76e54ebb26d2366a338d9560975e11
2019-01-05 22:33:44 +01:00
Matěj Suchánek ed171889bf Avoid double escaping of select options
Since the correct transformation method is unclear, change them to plain message keys.

Bug: T211876
Change-Id: I055c089574e7dcf5d634da402290a2ad024126f9
2019-01-05 11:06:20 +01:00
Translation updater bot 16f0d41e2f Localisation updates from https://translatewiki.net.
Change-Id: Iafbb9e5399c81b64a3cf549bd84058f29f9bbbf1
2019-01-03 22:52:17 +01:00
jenkins-bot b6fab8150a Merge "Add missing use for Wikimedia\Rdbms\Database" 2019-01-02 21:22:48 +00:00
Umherirrender d042257d40 Add missing use for Wikimedia\Rdbms\Database
Change-Id: I0c4beb49d1042c3ebe09b3d6e036b1028426715f
2019-01-02 19:40:58 +01:00
Umherirrender 795d48d539 Required argument follows optional
Remove default value, it is already list in param doc

Change-Id: Icbea3afce6abfbc075136798959521046ce86ab0
2019-01-02 14:52:14 +01:00
Translation updater bot 61385eaaea Localisation updates from https://translatewiki.net.
Change-Id: I907d1ac543930a55b2daa7631d7fe65cd31db81d
2019-01-01 22:20:40 +01:00
Matěj Suchánek cb1051ce19 Display the full title in notifications about mention in summary
It always puzzles and confuses me when I get this notification without the namespace.

Change-Id: I03711575d8ddbdfb07879982640dfdcb7b69b3ab
2018-12-31 16:43:56 +01:00
jenkins-bot 7a8ea37e6f Merge "Avoid expensive array_shift where possible" 2018-12-28 22:51:39 +00:00
Paladox 51c5f06094 phpcs: exclude the vendor folder
Change-Id: Ib836123a35cb632544285631ba5ee56a671b82c3
2018-12-27 21:32:39 +00:00
Translation updater bot 4c55aa08d5 Localisation updates from https://translatewiki.net.
Change-Id: Ic2fdd9da7dda32223ab52bcf583e01489699a8ac
2018-12-27 09:51:09 +01:00
jenkins-bot 858521dca8 Merge "Some more specific array and array[] type hints" 2018-12-21 23:41:17 +00:00
Translation updater bot 7c100ccb0d Localisation updates from https://translatewiki.net.
Change-Id: Icd9e75ef3ce6f4df30fff7d8ca69e32a83e48930
2018-12-20 22:41:35 +01:00
Translation updater bot 90556007d0 Localisation updates from https://translatewiki.net.
Change-Id: I83af3cf3f8bc059f4d2d23570753cb80b91c75af
2018-12-18 22:48:16 +01:00