wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity
5687 commits 164 branches 0 tags 74 MiB
Commit graph

5687 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 8dd53eb8a8 Merge "Fix notification popup header always showing a scrollbar" 2020-08-10 23:38:53 +00:00
jenkins-bot 0d414cf1ec Merge "Add all ResourceLoaderModules using supported hook" 2020-08-10 20:21:21 +00:00
Thiemo Kreuz a5d35141f4 Fix notification popup header always showing a scrollbar 
This issue was introduced in patch I41ad96b (T190397). The head
element is set to 44px height. However, the box-sizing is set
to border-box, which means these 44px include the 1px border at
the bottom. This leaves only 43px inside the head. The label is
meant to fit in there. Since the previous 44px don't fit, there
was always a scrollbar.

This could as well be fixed by changing the head to 45px.
However, this would make it different from the footer. I
believe both should have the same size for consistency.

Bug: T190397
Change-Id: Id0946d872a99fb8a1fbb33e6365fd78cd22eddd3
 2020-08-10 14:59:06 +00:00
jenkins-bot f6e3ee52fd Merge "Remove obsolete property name from @var docs" 2020-08-10 11:46:27 +00:00
Thiemo Kreuz 9d988e50b4 Use more specific PHPUnit assertions for type checks 
Change-Id: I22d3cddfb5d3d3f2ac49d075e885a3241b8360bc
 2020-08-10 12:54:10 +02:00
Thiemo Kreuz d046adfd99 Remove obsolete property name from @var docs 
Change-Id: I72faac7f0f88b0e3c4f145aa1def0acae0398488
 2020-08-10 12:53:14 +02:00
Translation updater bot b2e643a47f Localisation updates from https://translatewiki.net. 
Change-Id: I3d31aea0511741e8fd4f1f61941a07f3a279c1b2
 2020-08-10 09:00:52 +02:00
Ammar Abdulhamid 95a0dff88c Add all ResourceLoaderModules using supported hook 
PersonalUrls hooks is not meant to be used to add RL modules,
its documentation says it's meant to "alter the user-specific
navigation links (e.g. "my page, * my talk page, my contributions" etc)."

Echo is already using BeforePageDisplay hook to add modules, let's
now register all our modules via that

Bug: T259872
Change-Id: I12616a9947ea0e574287443361e2180c42e48d4b
 2020-08-09 00:35:56 +01:00
Translation updater bot 2919e371c7 Localisation updates from https://translatewiki.net. 
Change-Id: Ic83bb9382e52c62e29e16e9584dab97dd0951143
 2020-08-07 08:22:55 +02:00
Translation updater bot 173311d796 Localisation updates from https://translatewiki.net. 
Change-Id: I54e81da8933aca75738e82960f1a7ff71b19c018
 2020-08-06 08:27:41 +02:00
Translation updater bot 9527958227 Localisation updates from https://translatewiki.net. 
Change-Id: Iaef8f9b66a0bba52dd233b17aab38f847361b904
 2020-08-05 08:22:27 +02:00
Translation updater bot 060ab77258 Localisation updates from https://translatewiki.net. 
Change-Id: If9aeb60ba8c0525b3d03e0d074b84f3879cbfe10
 2020-08-04 08:32:17 +02:00
jenkins-bot 6eee04f614 Merge "Fix layout of action buttons use display:flex" 2020-08-04 05:17:04 +00:00
Ed Sanders ee65e8b426 Remove text decoration on whole item widget when focused 
Change-Id: I910b4cf3ef5503a4e38195cd588f327870e87d5e
 2020-08-03 15:14:36 +01:00
Amir Sarabadani 532fdbf294 Stop using ResourceLoaderTestModules hook 
This hook is deprecated and we should use QUnitTestModule in extension.json instead

Bug: T232875
Change-Id: I7b3e22856adc64ee36e0b696e2371bb9673e4899
 2020-08-03 13:18:29 +02:00
Translation updater bot fd6ad873f9 Localisation updates from https://translatewiki.net. 
Change-Id: I20be6d8ce6f55d6f3b7d5f4661681b59fd8c774e
 2020-08-03 08:32:00 +02:00
Translation updater bot de284c56fc Localisation updates from https://translatewiki.net. 
Change-Id: I63373bd4f25ab3498aebfbdf6b24e90b442448cb
 2020-07-31 08:45:49 +02:00
Roan Kattouw bf1a124475 Mobile Special:Notifications: Properly close overlay on selection 
Calling overlay.hide() doesn't invoke the onBeforeExit handler
(anymore? not sure if it ever did), so we have to call this handler
ourselves when manually closing the overlay.

Bug: T258954
Change-Id: Ife5926241c0b8473607c14df0f89c794728566dd
 2020-07-30 15:31:01 -07:00
Translation updater bot db8b71f67f Localisation updates from https://translatewiki.net. 
Change-Id: I4f3c3daeccd86e0416acf45689ce33c5b61835fa
 2020-07-30 08:35:21 +02:00
Ed Sanders 5161a2c40e Fix layout of action buttons use display:flex 
Bug: T258990
Change-Id: If0ece6e7ff6fef9abfcd4996a9158e86a5ffece0
 2020-07-29 14:13:02 +01:00
Translation updater bot fa29360bfc Localisation updates from https://translatewiki.net. 
Change-Id: I1ed75d8686121fa2bfa324504deca68bf649f448
 2020-07-29 08:35:23 +02:00
jenkins-bot 95505cdfca Merge "Fix width of buttons-as-option-widgets" 2020-07-28 19:49:23 +00:00
jenkins-bot d3690320f6 Merge "Minerva popup: Fix scope of border-left/right rule" 2020-07-28 19:45:40 +00:00
jenkins-bot d8d0e52c03 Merge "Use user IDs, not User objects, for reverted-user-id" 2020-07-28 12:11:24 +00:00
jenkins-bot e504ed86a6 Merge "Merge in styles from Minerva" 2020-07-28 10:53:47 +00:00
Ed Sanders 6492fc380d Fix width of buttons-as-option-widgets 
Change-Id: I7001815850a829a07c941e94548ea5a65d2fd1d5
 2020-07-28 09:51:20 +00:00
Ed Sanders 344cccb5fa Minerva popup: Fix scope of border-left/right rule 
We only hide side borders from top level notifications,
not notifications in bundles.

Change-Id: Iba680bda1dcd69b8f907413fbeec088e3ee1b43a
 2020-07-28 09:51:15 +00:00
Translation updater bot 7c9c39d6b8 Localisation updates from https://translatewiki.net. 
Change-Id: I4f2145777a1bff4720592b0931408f10b50c9838
 2020-07-28 08:24:32 +02:00
Ed Sanders d43ceb8978 Merge in styles from Minerva 
Drops some no-JS styles (.mw-echo-notification) which didn't do anything useful.

Bug: T258936
Change-Id: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
 2020-07-27 23:19:51 +00:00
Ed Sanders eb0603c9af Fix layout of NotificationsInboxWidget on narrow screens 
Bug: T258939
Change-Id: I17b968297baf630b71e832f6af0b0b534c9c08b4
 2020-07-27 16:11:38 +01:00
Ed Sanders bc5b569719 Fix styling of action popup menu 
* Fix icon position
* Fix border widths and colour

Change-Id: I06f45baa4c90e43d7e50eed83888d57ede69a517
 2020-07-27 16:11:03 +01:00
Ed Sanders d22ca3b44c Fix popup font size in Minerva 
Bug: T258937
Change-Id: I91ff2c49cfa7aa0805d7e0444c87599226c79291
 2020-07-27 12:56:24 +01:00
Translation updater bot 1d0001c602 Localisation updates from https://translatewiki.net. 
Change-Id: I11fcd308eb88f1b80a7d4b2fea4b19d749db6678
 2020-07-27 08:37:15 +02:00
jenkins-bot c582cfc673 Merge "Make Echo QUnit tests run again" 2020-07-25 18:34:32 +00:00
jenkins-bot 34b8f1050e Merge "Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook" 2020-07-25 18:08:15 +00:00
jenkins-bot 833fcdfd1e Merge "Fix font size in monobook" 2020-07-25 00:00:11 +00:00
jenkins-bot 407e55dd00 Merge "Remove padding reset from markAllReadButton" 2020-07-24 23:59:51 +00:00
Ed Sanders 34c70f8501 Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook 
Dummy icon is not position absolute in monobook, so hide it.

Change-Id: I24edfbc1afcb81da8ef4db6bb685792ee56bc49a
 2020-07-24 23:31:45 +00:00
Ed Sanders 5b216bfad3 Fix font size in monobook 
Content font size should be 12.7px and this can be achieved
by just applying the 127% from globalWrapper.

This matches the font sizes on Special:Notifications.

Change-Id: I5369231da52343029ea2cdbfc790296c2257807a
 2020-07-24 23:31:35 +00:00
Ed Sanders 3ead305c27 Remove padding reset from markAllReadButton 
Buttons should be positioned with margin, not padding,
as changing padding breaks hover and focus states.

In this case the position is already fine without
additional adjustment.

Change-Id: I8a7726b2e0988117084a1d0b060b4f649ba4cc75
 2020-07-24 23:31:00 +00:00
Roan Kattouw c87cae39d7 Make Echo QUnit tests run again 
The automatic registration for these was broken, because
$wgResourceModules no longer contains Echo's modules (since they are now
registered in extension.json).

Instead, add the test files in tests/qunit/model/ explicitly in
onResourceLoaderTestModules. The tests in tests/qunit/mobile/ are
already added through QUnitTestModule in extension.json.

Delete the ext.echo.overlay tests, they were testing code that was
removed years ago.

Bug: T258818
Change-Id: I7b996dc8631a86033830cf532f1b8e85251788ad
 2020-07-24 13:26:34 -07:00
Ed Sanders 2faa1fe512 Fix hover styles, remove link underline on special page 
Change-Id: Ie144eed5295a8c8fa6239c28f7f2a15d493fd775
 2020-07-24 20:34:43 +01:00
jenkins-bot f44df2f728 Merge "Make default snippet length (150) a constant" 2020-07-24 00:03:15 +00:00
Ed Sanders ec87876f59 Set min-width on action buttons 
Bug: T130109
Change-Id: I0a763aa7d73a84854daf43696d5751c58b3d067d
 2020-07-23 18:19:34 +01:00
Ed Sanders e91e0c410b Simplify styling of notification bundles 
Bug: T258714
Change-Id: Ia73fe2d2a96c070dacd8d9744242148ab4eca390
 2020-07-23 18:19:34 +01:00
Ed Sanders 769d6579f9 Make MenuItemWidgets inherit from ButtonOptionWidgets 
This gives them a consistent appearance with the expand/collapse
button. Only requires a small visual tweak to work in the popup
menu.

Bug: T258701
Bug: T258703
Change-Id: Ib3d074d1117e08d11136791354184e2e4b655290
 2020-07-23 18:19:32 +01:00
Ed Sanders 3abe6b77bd Make mark as read/unread buttons properly focusable 
Bug: T258710
Change-Id: I1ed9d386083d94bf6b5696bb71385169c0ccb807
 2020-07-23 15:27:01 +01:00
Ed Sanders 42e2e5efbc Make NotificationItemWidget an <a> tag to fix focus issues 
Bug: T258705
Change-Id: Ib44e04dd08e2818eb99ffb0cba73c775256d66d5
 2020-07-23 15:27:01 +01:00
Ed Sanders 25e2fb4a8f De-activate toggleExpandButton after clicking 
Bug: T258706
Change-Id: I810d7733e1f5f89c521e733713641b28b1ae6237
 2020-07-23 15:27:01 +01:00
Ed Sanders d39d944bf0 Remove light background from dynamic-action hover state 
Bug: T258703
Change-Id: I7b306b63c56da11ab7ce0492111f594f8b60593e
 2020-07-23 14:02:34 +01:00