Commit graph

5224 commits

Author SHA1 Message Date
shivanshbindal9 8821563955 Add unseen class to alert/message icons
When there are some new notifications during polling,
the unseen state of alert/message icons does not change.

Bug: T226127
Change-Id: I8cdeb9ee920d3ec943e270eb00a6ef7f3a7449e2
2019-08-16 20:32:11 +05:30
Translation updater bot 8012d23a00 Localisation updates from https://translatewiki.net.
Change-Id: If0fe62fa6254119fb7ac0c7c3ac395dab6154b8f
2019-08-10 22:48:41 +02:00
Translation updater bot 750e6bce8f Localisation updates from https://translatewiki.net.
Change-Id: Id5883075571f185e7aca2752480703426647a764
2019-08-09 09:08:46 +02:00
Translation updater bot a8317ea0eb Localisation updates from https://translatewiki.net.
Change-Id: I7642f397bcc85e31e815765d5f6f03fec058923a
2019-08-08 09:32:15 +02:00
Translation updater bot 8d44b87536 Localisation updates from https://translatewiki.net.
Change-Id: I861dc8624e22378a5b022f201d6a3b6385c465c1
2019-08-07 09:37:32 +02:00
jenkins-bot 358bdad695 Merge "Define preference for poll updates" 2019-08-06 23:14:49 +00:00
shivanshbindal9 2528e3394f Define preference for poll updates
New preference added so that user can set
* Displaying (n) total unread count in the title
* Displaying notification snippet for incoming notification

Bug: T229732
Change-Id: I35eb68dedf1e087b4668bfec404935f1244b3d0b
2019-08-06 19:42:49 +05:30
jenkins-bot a37ecff5df Merge "Improve EchoPresentationModelSection" 2019-08-05 22:16:51 +00:00
Translation updater bot 127b513894 Localisation updates from https://translatewiki.net.
Change-Id: If66612e9db8ef99b0181fed096fc68dc3ffbbb71
2019-08-05 09:40:52 +02:00
Matěj Suchánek 19c55cd7ca Improve EchoPresentationModelSection
Add documentation and recommendation to one public method
and make getTitleWithSection safer.

Change-Id: I9c17032a80e736751d21c16ca0178b54c498bded
2019-08-02 12:24:59 +02:00
libraryupgrader 9bb30f1629 build: Updating npm dependencies
* lodash: 4.17.11 → 4.17.15
  * https://npmjs.com/advisories/1065
  * CVE-2019-10744
* wdio-mediawiki: 0.3.0 → 0.4.0

Change-Id: I06517f1a052ca42a8b62ccfa9c055c409b96837f
2019-08-02 01:47:20 +00:00
Translation updater bot 36e7005d83 Localisation updates from https://translatewiki.net.
Change-Id: Ib53858690cb6808184835b81073a9c89416fc77a
2019-08-01 09:16:22 +02:00
jenkins-bot e751428cbd Merge "ext.echo.init: Un-dim badge if loading RL modules failed" 2019-08-01 02:30:37 +00:00
jenkins-bot 495a6c8acd Merge "Remove ext.echo.base" 2019-08-01 00:24:25 +00:00
Roan Kattouw 092615db27 ext.echo.init: Un-dim badge if loading RL modules failed
We didn't have any error handling for this scenario previously, but the
recent refactor of this code made it more obvious that it was missing.

Change-Id: I146de3ed2cde1a9bd553fc4825c0e4e06130de65
2019-07-31 22:55:25 +00:00
Roan Kattouw 5c3e30b78a Remove ext.echo.base
It became unused and was deprecated in 1ac72cc01a.
That was almost 4 years ago, back when these definitions were
in PHP instead of JSON.

Change-Id: Icbd5ee8df1fc339ffb2df9f05c35a9dcd545a3d1
2019-07-31 22:53:23 +00:00
shivanshbindal9 6be1eee1db Display notification text for incoming notification
As now polling is used to update the notification count on header icons.
If there are any new notifications then a snippet containing the header
part of the notification will appear using mw.notify().

Bug: T226130
Change-Id: Id38c8ebedebd4c68b9cef0635043d6f9304784dd
2019-07-31 17:54:20 +05:30
Kosta Harlan efd759402f Skip broken Selenium test
Caused failure in
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/524520#message-7f1addb6b8b09919581014fe18c6dddef32fb078

Bug: T227009
Change-Id: Iae088bc7c966f927a15d06a4de5966a76913dbe4
2019-07-30 16:54:31 +02:00
Translation updater bot de434e1306 Localisation updates from https://translatewiki.net.
Change-Id: Idcb8f0277c195f9316d93c0d1205c7ee67033bf7
2019-07-29 09:14:21 +02:00
Translation updater bot 13f318508f Localisation updates from https://translatewiki.net.
Change-Id: Icfa17e84d5ba72436952af3f61a5a61dbf8f0cc6
2019-07-26 08:55:22 +02:00
Translation updater bot 809c9a9abc Localisation updates from https://translatewiki.net.
Change-Id: Iea9647556690e162c88e170cad3bf74f6758a624
2019-07-24 22:28:41 +02:00
Roan Kattouw a3bfd725ea Bundle logger-related config vars with ext.echo.logger module
There's no real reason for these to be in MakeGlobalVariablesScript
because they don't really depend on the request context: they were being
omitted if the user was not logged in, but we can just check the user's
logged-in status in JS instead.

Bug: T221151
Change-Id: I2df6d7e061545d342bc3068dccd5ce2f6e85fe78
2019-07-23 21:48:42 +00:00
Translation updater bot 90b1f09ec5 Localisation updates from https://translatewiki.net.
Change-Id: I6eed108fc3768699c1a6e3b9c37067eb6ef15923
2019-07-23 08:53:56 +02:00
Translation updater bot a6eaf7dfb3 Localisation updates from https://translatewiki.net.
Change-Id: Icbd5f18426725c96793108ade91962655c691272
2019-07-22 22:40:49 +02:00
Roan Kattouw cf760b8d84 Use Config parameter instead of deprecated ResourceLoaderContext::getConfig()
Depends-On: Ia4666914e9b07f298ee5ae30ae8c70a3e83b0910
Change-Id: I4578bfc93d8a4615d54d99340ed9cceaa8bb76da
2019-07-18 15:30:41 -07:00
Roan Kattouw d378e4e3b9 Use packageFiles instead of startup module for config vars
Remove wgEchoMaxNotificationCount and wgEchoPollForUpdates from the
startup module and put them in the ext.echo.init module.

Change-Id: I03f9a3953aa97ead1a29c13a992a02404a6d0b68
2019-07-18 15:29:27 -07:00
Dayllan Maza b3df45dc34 Add option to mute/unmute notifications on Special:Mute
The hook (SpecialMuteModifyFormFields) is used to append
the option to mute/unmute echo notifications from a specified user.

Special:Mute handles posting and saving the fields, the only
requirement is that the field name is the same as the property
that wants to be modified, in this case 'echo-notifications-blacklist'

Bug: T220163
Depends-On: I2b3eee0802cb086091f35ecce13ae77a8e7d518d
Change-Id: I77b3ccfdce9b501eb8ecd58c0d7bbecb78029a7e
2019-07-18 15:47:24 +00:00
Translation updater bot 64eb55c290 Localisation updates from https://translatewiki.net.
Change-Id: I0027444ddbda96a92c9cb35cf07da8383381428b
2019-07-18 08:53:14 +02:00
Roan Kattouw e6e7541531 MentionInSummaryPresentationModel: Fix PHP error
RevisionRecord::getComment() can return null. When it does, accessing
->text on it fails.

Bug: T226681
Change-Id: I069cd5d5bef51a3e2b8f4e7b50d478cf47f65e00
2019-07-15 17:06:15 -07:00
jenkins-bot c2a61e22fc Merge "Move unit tests, round II" 2019-07-15 21:01:30 +00:00
jenkins-bot d22bcaddc4 Merge "Change polling rate when document not visible" 2019-07-15 19:00:10 +00:00
Amir Sarabadani 7a27d13a7b Move unit tests, round II
Change-Id: I4a419ae44a73ece55f2519dddc1aac4bedebc9e4
2019-07-15 18:10:01 +02:00
Translation updater bot e5d185c96d Localisation updates from https://translatewiki.net.
Change-Id: I1df3bf4bcebd840d770966bcfa638ae34e63dfcf
2019-07-15 08:34:09 +02:00
libraryupgrader 4bf8a6736a build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 24.0.0 → 26.0.0

npm:
* set-value: 2.0.0 → 2.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* union-value: 1.0.0 → 1.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* mixin-deep: 1.3.1 → 1.3.2
  * https://npmjs.com/advisories/1013
  * CVE-2019-10746

Change-Id: I6d3efdf65c207b98447565e2df6f0698aaa8ea6b
2019-07-14 10:57:49 +00:00
shivanshbindal9 795b87d55b Change polling rate when document not visible
We currently poll for the count of notifications after some fixed amount of time even when the user is not using it.
There is no need to poll at same rate in that case and we can poll at slower rate.
The rate now is decreased by 5 times.

Bug: T227501
Change-Id: Id53a88e0d5659edb0dac77dd3e346e2d88e95f94
2019-07-13 17:11:08 +05:30
Amir Sarabadani 1c93cba790 Move unit tests to the new structure
Change-Id: I02e2a33149eee859ec10ab7f8265609b0f17d1cc
2019-07-12 18:22:52 +02:00
Translation updater bot ba607772dc Localisation updates from https://translatewiki.net.
Change-Id: I956a55722aa78ab32e62282bf7288fbf6a7c0f7c
2019-07-12 08:43:20 +02:00
jenkins-bot eca3df8519 Merge "Add mediawiki.jqueryMsg as a dependency to ext.echo.init" 2019-07-11 22:11:40 +00:00
jenkins-bot c6a693a0dc Merge "build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1" 2019-07-11 14:41:47 +00:00
James D. Forrester 1b2c8eebfc build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Bonus: unset loop variable after mutable foreach.

Change-Id: I652fe65e4691a92175569a72f081f4553c4459c5
2019-07-11 13:40:37 +00:00
shivanshbindal9 d6e740ac86 Add mediawiki.jqueryMsg as a dependency to ext.echo.init
On certain special pages, either notification count in the title is not displayed or is displayed in an improper format.
This was because mediawiki.jqueryMsg is not loaded. This patch adds mediawiki.jqueryMsg as a dependency to ext.echo.init module

Bug: T225259
Change-Id: I6b76742b326d66ca08b4bf5c53ab95c4919249e7
2019-07-11 12:03:36 +00:00
Amir Sarabadani 67246b9873 Stop autoloading test classes
There's no need to laod test classes, phpunit finds them
and it just makes $wgAutoloadClasses in production bigger with no value.

Also it makes moving tests around harder

Change-Id: I59ed7bb55cf6d57bdaf614476cf6db7640b1143b
2019-07-10 17:38:35 +02:00
Translation updater bot d1eac9bf06 Localisation updates from https://translatewiki.net.
Change-Id: Ie4dc154af2606e3ea1da5e4162b983efa7e62457
2019-07-07 22:39:06 +02:00
ephemeralwaves 05f3e66a9d Selenium: Fix failing test by only running tests tagged @daily
Changed `selenium-daily` npm script to only run tests tagged `@daily`
and removed `it.skip` on tests failing in beta cluster.

Bug:T227009
Change-Id: Id2edbfd941df098d326fa30ed9dc9f68e228f021
2019-07-05 10:58:19 +00:00
Translation updater bot cecd9e3fa4 Localisation updates from https://translatewiki.net.
Change-Id: I13b87616d176a6b0d6164dde80c9143f934e798a
2019-07-03 22:44:10 +02:00
jenkins-bot e5cd928e13 Merge "Add visual cue to indicate change in notification count" 2019-07-02 00:19:37 +00:00
shivanshbindal9 1a035e1287 Add visual cue to indicate change in notification count
* Adds notification count(alert+messages) to the title
* The count is updated immediately when notification count changes
* This functionality is feature flagged(wgEchoPollForUpdates)

Bug: T225259
Change-Id: Ic92c50d9885b0e4325b253338023d37adf8d35d0
2019-07-01 14:31:36 -07:00
jenkins-bot ca4e1fbba8 Merge "Use {{formatnum:}} for 99+ in default echo-badge-count message" 2019-07-01 18:39:04 +00:00
Željko Filipin e76e9f9b5c Selenium: Fix failing Jenkins job by disabling failing tests
Bug: T227009
Change-Id: I5d2fcc1e6f50e73375c834e1167726273c82025c
2019-07-01 17:49:29 +02:00
Translation updater bot 3d5483d4c2 Localisation updates from https://translatewiki.net.
Change-Id: Ie8af8fa0ecbcc7c7e70bed10d45d6f417da378c3
2019-06-30 22:37:35 +02:00