Commit graph

1873 commits

Author SHA1 Message Date
Matthias Mullie 58e1c765d6 Improve signature detection
Previously, there were a couple of hacks in play.
It was also not picking up ~~~ (signature without timestamp)
And it relied an a nasty regular expression which, although
based on Parser, may some day get out of date.
And it relied heavily on a specific signature format, which
isn't guaranteed (it's an i18n msg)

This patch changes the approach: it will use a very simple
regex to match links, and will send those through Parser to
generate the signature anew. My reasoning is that that should
be exactly the same as what Echo just received (should've
also gone through parser)

Biggest discomfort of this approach is that it's much stricter.
It should still match whatever it generated from a ~~~ or ~~~~,
but no longer the e.g. not-real signatures we were doing in
our tests. Also had to update our tests, because signatures
change depending on anon. So I had to generate all the users.
And fix some of the signature formats used in the tests.

Bug: T75426
Bug: T87852
Bug: T75366
Bug: T78424
Change-Id: Ibeff36397129fdd5d376f3668a23a45f9a014525
2015-02-05 20:45:19 +01:00
Translation updater bot 7408aba1ca Localisation updates from https://translatewiki.net.
Change-Id: I34227f2ec5788b338a3d3861fa8b0e4bb2f4d2e0
2015-02-03 22:54:03 +01:00
bearND e359b304db Make current Echo overlay tab dark gray and bold
mw-ui-quiet gets dark gray and bold.
This way it is easier to see which is the current tab.

Bug: T71929
Change-Id: Ie7e21cd71a385d216402d393344cf76d3ed45d23
2015-02-02 15:22:59 -07:00
Translation updater bot f6421760b1 Localisation updates from https://translatewiki.net.
Change-Id: I1722701309784bf0c78c255d7eac70514877561d
2015-02-02 22:26:43 +01:00
jenkins-bot d53857c7c3 Merge "Add 'license-name' matching SPDX conventions" 2015-01-31 23:54:18 +00:00
jenkins-bot 028388aa6c Merge "Bug: Fails signature detection with extra long signature" 2015-01-31 01:13:43 +00:00
Kunal Mehta 3e94bfac8b Start tests for the built-in notification types
* Only covers EchoHooks::onUserRights right now, more
  patches to follow

Change-Id: Ie93eff0a9a75a4a9816c81d57b7530149a14bb7a
2015-01-30 18:09:04 +00:00
jenkins-bot df2d335261 Merge "Rework broken echo test to make less assumptions" 2015-01-30 00:50:27 +00:00
Erik Bernhardson bf5ff9b8ea Rework broken echo test to make less assumptions
Change-Id: Id73794e3555ef18e5dde0c40b8f9ab8eba53eb96
2015-01-29 16:45:05 -08:00
Translation updater bot 4d05657b6d Localisation updates from https://translatewiki.net.
Change-Id: Ia667160b7a5c58e434de1e6afb906abc5e66cfd1
2015-01-29 23:00:11 +01:00
Ricordisamoa 01773a6d97 Add 'license-name' matching SPDX conventions
References:
http://spdx.org/licenses/
https://www.mediawiki.org/wiki/Manual:$wgExtensionCredits#license-name

Change-Id: I3debc1db6b821efeca07be05e1795f223d2fa621
2015-01-29 14:58:20 +01:00
jenkins-bot 6c8e3a0c3a Merge "Clarify alert/messages meaning" 2015-01-27 21:57:38 +00:00
Translation updater bot 75f1435462 Localisation updates from https://translatewiki.net.
Change-Id: I647c0bf62b6579f9f3b2e4c00fc3c96f76296378
2015-01-27 22:14:51 +01:00
Translation updater bot d1e36cd038 Localisation updates from https://translatewiki.net.
Change-Id: I5a0828d8bf22741bb90ef5179425126f18310206
2015-01-26 22:38:37 +01:00
Translation updater bot 85e844c51d Localisation updates from https://translatewiki.net.
Change-Id: I4dd7fe07a58631b45e316b910fac72bd04f87f6e
2015-01-25 21:46:02 +01:00
Translation updater bot 0e6be09906 Localisation updates from https://translatewiki.net.
Change-Id: I5b9f8d58e07e4fe3e69b9ccaba15f278cd72e83b
2015-01-23 22:25:57 +01:00
Translation updater bot c50c13eebf Localisation updates from https://translatewiki.net.
Change-Id: I5d813bd9984dea80d8e9345bd7b17c4cf25731ca
2015-01-21 22:19:46 +01:00
Translation updater bot 89b61ad4e7 Localisation updates from https://translatewiki.net.
Change-Id: I3261231613dc1ada471b1319c35e3233f9d434c8
2015-01-20 21:57:35 +01:00
Translation updater bot 851265edc2 Localisation updates from https://translatewiki.net.
Change-Id: I5948090ba055b4b2fec8e9029d6ae7ce2192c67f
2015-01-19 22:01:39 +01:00
Translation updater bot e6d3702434 Localisation updates from https://translatewiki.net.
Change-Id: I7c52991a193fc7e6d0451c61ff430f468e92a9e4
2015-01-18 22:17:17 +01:00
Translation updater bot cd1810d0bb Localisation updates from https://translatewiki.net.
Change-Id: I70994f4da0b20060281cf02e73295585edbc6445
2015-01-16 21:17:46 +01:00
Translation updater bot 1a1da10e69 Localisation updates from https://translatewiki.net.
Change-Id: I1f3eac902fcb1bede107951a26bdd1f9a3ff4f13
2015-01-15 22:47:11 +01:00
Translation updater bot 3d21abe511 Localisation updates from https://translatewiki.net.
Change-Id: If96219bacceb0f91cadb11fb9f89649877d7fd96
2015-01-12 22:37:09 +01:00
Translation updater bot 4db0c7ca94 Localisation updates from https://translatewiki.net.
Change-Id: Ic7b45d2662a107f8d91b4763cb5fa83f2b5a8346
2015-01-11 22:15:12 +01:00
Translation updater bot d2ed2faf13 Localisation updates from https://translatewiki.net.
Change-Id: I6a07d4d7edabddd52759dd2c06fde01b5d3fcc7f
2015-01-10 22:01:31 +01:00
Translation updater bot 8120175707 Localisation updates from https://translatewiki.net.
Change-Id: Ibc380b7f5b1a8221be330309d2eda43e050fff59
2015-01-09 22:07:42 +01:00
Amir E. Aharoni 91847e96c6 Fix the overlay chevron position for RTL
Bug: T78330
Change-Id: Ie438042bc24b8ace429eec68c8b75c09da56aa95
2015-01-09 17:50:51 +00:00
Amir E. Aharoni 94cb6103c2 Cleanup whitespace in modules/overlay/ext.echo.overlay.less
According to
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS

Change-Id: I361909fcea67fa5e0e3cbb69711ede91417c4e2e
2015-01-09 19:50:08 +02:00
Antoine Musso 7f5b0c1793 Fix EchoTitleLocalCacheTest::testGet corner case
EchoTitleLocalCache title cache resolution ends up querying the database
to resolve title id to Title object.

In some corner case, we might only have one page in the database (UTPage
as provided by MediaWikiTestCase), thus the id 2 would not resolve to a
Title breaking the test.

Use insertPage() to ensure we have a second page.

Bug: T78592
Change-Id: Ia9dbb256f566e489e1c81d89b6a6077831e07fc3
2015-01-09 13:54:08 +01:00
Translation updater bot 171c863a48 Localisation updates from https://translatewiki.net.
Change-Id: I76346aacc6cb42cae123bc0afe511cb5d6707476
2015-01-08 22:43:34 +01:00
Ori Livneh ef502ed0ef Test if 'EventLogging' class exists, rather than deprecated function
efLogServerSideEvent() is deprecated and will be removed soon.

Change-Id: I79969b443e59a36a6d92ad33b3df98fb21f7f3b6
2015-01-07 10:27:52 -08:00
Timo Tijhof 4fdae24555 overlay: Remove needless specifity in .mw-echo-grey-link selector
Binding it to the element name should rarely be needed as it only
adds complexity with no clear benefit.

Nesting classes should also rarely be necessary as it basically
requires the code will never be embedded in or itself embed something
from another component (otherwise you'd clash with that other component's
class name, and if you don't clash, then it wasn't neccecary to
nest the class in the first place).

If the class is overlay-specfic it should be renamed to something
like '.mw-echo-overlay-grey-link'. Keeping it as-is and applying
directly though, as it doesn't appear overlay-specific.

Change-Id: Ied601058c8e501914113d542f88542c83157d5a0
2015-01-06 22:04:12 +00:00
Translation updater bot 6d9a04ac8b Localisation updates from https://translatewiki.net.
Change-Id: I604a6cf2efafdda418cb0679ffed6bf0d9eb5b54
2015-01-05 23:07:18 +01:00
Translation updater bot 26e4db7ff7 Localisation updates from https://translatewiki.net.
Change-Id: I02ca232b29c641c4315e6b0f672187f3033ad63c
2015-01-03 23:01:33 +01:00
Translation updater bot 58b5f77815 Localisation updates from https://translatewiki.net.
Change-Id: Ic9ff06b4b5dc40e5a677a48758bc920dea426a20
2015-01-02 22:33:21 +01:00
Translation updater bot d11b75687e Localisation updates from https://translatewiki.net.
Change-Id: I7442645e759f8cbf83c5e24e88a5f7b73adbc83c
2014-12-30 21:08:42 +01:00
Translation updater bot 703b2db08b Localisation updates from https://translatewiki.net.
Change-Id: I21d71ddcf0927cc379191584c696aaa968915e8e
2014-12-28 21:43:55 +01:00
Translation updater bot 12932894c5 Localisation updates from https://translatewiki.net.
Change-Id: Ib983da41ca63c5bf95181707c92812a82aad8813
2014-12-27 19:51:03 +01:00
Translation updater bot 43dab3cbfa Localisation updates from https://translatewiki.net.
Change-Id: I8602662fd0f152b013b526d4974e19a882e0ca16
2014-12-22 22:42:46 +01:00
Translation updater bot 8abd52b439 Localisation updates from https://translatewiki.net.
Change-Id: Ib6ca99a1dcac8134663d69d4f36e37f7d61769ee
2014-12-20 22:22:06 +01:00
Translation updater bot f693796c8e Localisation updates from https://translatewiki.net.
Change-Id: I3a8d7636767e5ecd34b39b178f3d30b76198707c
2014-12-18 23:19:06 +01:00
Matthias Mullie 607c864608 Page linked by another user : link to the original article
Fixes T55647

Bug: T55647
Change-Id: I09c2cfdfe165a0df262848d9287ce2ff962b4b8a
2014-12-18 12:12:17 +01:00
Translation updater bot aad65479a2 Localisation updates from https://translatewiki.net.
Change-Id: I694bb63c1290261f847403aaef3c39b18867d5bd
2014-12-17 21:48:10 +01:00
Translation updater bot 10653bb27e Localisation updates from https://translatewiki.net.
Change-Id: I73bf6da53dc839fd2376b1626067b632e3bbd074
2014-12-16 21:56:43 +01:00
Matthias Mullie f048d248bd Clarify alert/messages meaning
Bug: T72255
Change-Id: I2dde0c2e2c7bbd89f11112ceb738b19a49fda21b
2014-12-16 14:27:10 +01:00
Translation updater bot 875bccdc40 Localisation updates from https://translatewiki.net.
Change-Id: I4ce6d25fd8beda07ddc027adee882d0bbb5db690
2014-12-15 22:18:31 +01:00
Translation updater bot 46c8edb9b0 Localisation updates from https://translatewiki.net.
Change-Id: Iddf4e00009d26ff816d6aa1cc9ae948bca1e9c54
2014-12-14 22:20:19 +01:00
Translation updater bot 893624d650 Localisation updates from https://translatewiki.net.
Change-Id: I5f098e0ee8a7dd7fb2736b2fc132481c2e6fd6fd
2014-12-13 22:29:08 +01:00
Translation updater bot f2e7c8056d Localisation updates from https://translatewiki.net.
Change-Id: I94bebbd8f03253e4ab2cbaf75045339e204f494b
2014-12-11 23:50:31 +01:00
jenkins-bot 968b05b944 Merge "Prevent undefined index warnings" 2014-12-09 23:32:51 +00:00