Commit graph

1871 commits

Author SHA1 Message Date
Tina Johnson 0e810f0510 Make links in Echo's notification footer blue on hover
Links on the notification footer, "View edit" / "View changes", needs
to be blue instead of grey to be consistent with the Mediawiki interface.
The link turns blue upon hovering, just the way it is currently set
for other links on notifications like the page title.

Bug: T57367
Change-Id: Ibaaff52b9d4bdfc5beca442e10734dd5cf8886d7
2015-03-14 00:41:11 +05:30
Translation updater bot 3c8bbbece1 Localisation updates from https://translatewiki.net.
Change-Id: I2e0b284b9ae447406c7826e2a22a0f632b122cb7
2015-03-11 22:13:17 +01:00
Translation updater bot c13d005779 Localisation updates from https://translatewiki.net.
Change-Id: I2d340d14b1c121b54e476abfdf96d14cca63226e
2015-03-10 22:32:58 +01:00
Tony Thomas db10450622 Update 'notification-page-linked-email-subject' message
Bug: T53996
Change-Id: I79ea30eeeec3f6970df54faa266bc59878f525c7
2015-03-10 21:45:21 +05:30
jenkins-bot d7a466273f Merge "Don't log missing user-locators" 2015-03-10 00:18:01 +00:00
Erik Bernhardson a70320d268 Don't log missing user-locators
While user-locators are the "new hotness", most events still get their
list of users by calling a hook.  That means this log message basically
just spams up the prod echo log for no benefit.

Change-Id: Iba5a8267c4ecc5a7446b287759d8b66adf0e2387
2015-03-09 23:41:00 +00:00
Cmcmahon 4631bc8d94 QA: insert one-second sleep for Chrome workaround
As of about 4 March, Chrome has begun failing to wait for javascript
event listeners on pages. The only workaround we've found is to
pause for a bit before clicking any element that brings up a WMF
"overlay"

This is the failure see at
https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/399/testReport/

Change-Id: I984f394a55423f17feae85236e18d16dd00239bc
2015-03-09 18:43:24 -04:00
Translation updater bot 8b944d9f4a Localisation updates from https://translatewiki.net.
Change-Id: I4477e52a7cfa991cda8a6491c5ab3159bb378709
2015-03-09 22:06:43 +01:00
Translation updater bot c6b0b471a3 Localisation updates from https://translatewiki.net.
Change-Id: Ib7a8c354f06eb1df5e348932f5bd3b76fb5568ea
2015-03-08 21:44:04 +01:00
jenkins-bot c847af17c7 Merge "Use mw-ui-anchor class" 2015-03-06 01:02:43 +00:00
Translation updater bot 5599aee518 Localisation updates from https://translatewiki.net.
Change-Id: If3f7be9b739563c57e9347e942eb1a4b2912a26a
2015-03-05 22:21:02 +01:00
Matthew Flaschen b930dfaf47 Use mw-ui-anchor class
This is now required to actually pick up the MW UI progressive
color, so there's a slight visual change (wrong blue => right blue).

Fixes T72818

Bug: T72818
Change-Id: I719eb20a3940904ab45f8376280e20432a3b2d80
2015-03-02 20:16:31 -05:00
Translation updater bot cf394a0fe5 Localisation updates from https://translatewiki.net.
Change-Id: I5b004a6f214b440c7b71db1d436b76ac7a4ea032
2015-03-02 22:07:58 +01:00
Translation updater bot 74754f93f6 Localisation updates from https://translatewiki.net.
Change-Id: Ifaac3f1c75c45edf67d96cd928ada093bd7ebfa2
2015-03-01 22:04:06 +01:00
Translation updater bot 933cd8cb5c Localisation updates from https://translatewiki.net.
Change-Id: I5f1970d1fe09233ddf8139bcdd0e7c1f196cc26f
2015-02-28 22:05:15 +01:00
Translation updater bot c5aa8f2fc6 Localisation updates from https://translatewiki.net.
Change-Id: Ie753b8a2868e3168a4c4395a2d4b64bd94ddeec3
2015-02-27 21:55:57 +01:00
jenkins-bot 3e5b783e7a Merge ""More info" link on Special:Notifications has broken localisation" 2015-02-27 00:05:16 +00:00
Translation updater bot 88e9eb25d5 Localisation updates from https://translatewiki.net.
Change-Id: I49c5ec16b1a8d0d7f6ed4c57c10dd253897533aa
2015-02-26 21:33:52 +01:00
Erik Bernhardson 37cb659f0a "More info" link on Special:Notifications has broken localisation
Bug: T58036
Change-Id: I56f89ecc022dc648d55928ab5b8f02bb01f67617
2015-02-26 12:18:58 -08:00
Translation updater bot 906862da4c Localisation updates from https://translatewiki.net.
Change-Id: Ic1383bd3bc3f833e3302af462fae84bf1e71fbce
2015-02-25 22:53:45 +01:00
Translation updater bot ac8c676cd7 Localisation updates from https://translatewiki.net.
Change-Id: I94102355db1d4193c98882aa619ae33be2dcc9fe
2015-02-24 21:59:45 +01:00
Translation updater bot d0acb0e552 Localisation updates from https://translatewiki.net.
Change-Id: I297e362a029a1339c0c00430756c1ba917b534e4
2015-02-23 21:55:42 +01:00
Cmcmahon 68c8a7a65a QA: rubocop fixes broke the tests in the builds
regenerated rubocop config so those checks also stay green

Change-Id: Ib8a88c88c02d1638e758d62eb86f2ac59feefe5d
2015-02-23 09:44:41 -07:00
Translation updater bot bd64eafe84 Localisation updates from https://translatewiki.net.
Change-Id: Ida9b1502caa8f96d4f0456ef8dd0c45d6a74928f
2015-02-22 21:34:42 +01:00
Translation updater bot 0d6200d86a Localisation updates from https://translatewiki.net.
Change-Id: If31d7f4142c21e6971a09c3d333c012c4c27e868
2015-02-21 23:31:55 +01:00
jenkins-bot f0cd4d5076 Merge "QA: update for rubocop offenses" 2015-02-20 17:02:37 +00:00
Cmcmahon 7d607dbfb6 QA: update for rubocop offenses
Do not name methods starting with "get"

Change-Id: If4adf0c775b031d6a462e00aed8b588077169413
2015-02-20 10:00:01 -07:00
jenkins-bot 5f93e4defe Merge "QA: more rubocop updates" 2015-02-20 16:57:10 +00:00
Cmcmahon 60a0e05c7c QA: more rubocop updates
No change to function at all

Change-Id: I150aed4379c75f716633cc4904cb9d8f388c9d45
2015-02-20 09:54:06 -07:00
jenkins-bot 1ae16a6358 Merge "QA: update for rubocop offenses" 2015-02-20 16:52:11 +00:00
Cmcmahon fcd695a076 QA: update for rubocop offenses
No change to function, just cleaning up

Change-Id: I1b0b4fe8e4f785cbeebc2d1415a45f831dc75f5c
2015-02-20 09:49:38 -07:00
Translation updater bot 18b22e5d5a Localisation updates from https://translatewiki.net.
Change-Id: I3b41496a08ca3d2b755479f82e5c4f18c70df980
2015-02-19 22:06:33 +01:00
Translation updater bot 873ea5eeb2 Localisation updates from https://translatewiki.net.
Change-Id: I3234f11c96b0ed6aa95152297a74e01031402eb5
2015-02-18 22:02:56 +01:00
jenkins-bot bf0378e57a Merge "Fixed CPB flyout notification count" 2015-02-18 04:33:41 +00:00
Divya 562168b261 Fixed CPB flyout notification count
Added ext.echo.updateNotificationCount to notify other extensions
about updates to the notification count.

Bug: T67178
Change-Id: I7f4e34f2c1808b249db010018dd1b49a8dde246a
2015-02-18 04:31:34 +00:00
Erik Bernhardson 91abb657c8 More gracefully handle unavailability of ParserFunctions in phpunit
Change-Id: I375c13e937892062b061940b2b9ac5bdd832ac9d
2015-02-17 14:53:51 -08:00
Matthias Mullie 0dee3d3587 Pass title along to signature parser
* Parser generates signature to compare against
* Signature can be overwritten per wiki, in NS_MEDIAWIKI
* Such overwritten default can be different depending on
  page the signature is on[1]
* Our comparison signature generation was page-agnostic
  (always from Title::newMainPage)
* Signatures didn't match up on own talk pages, where
  default signature is different

Also added 2 new tests cases & improved tests by also
setting the page

1: https://en.wikipedia.org/w/index.php?title=MediaWiki%3ASignature&diff=176507985&oldid=176229132

Bug: T78424
Change-Id: Ice151d4d16236a5d1556ef62805b61310c7beb85
2015-02-17 10:24:12 -08:00
Translation updater bot d503ae5932 Localisation updates from https://translatewiki.net.
Change-Id: I47aadb602ff969167b92cab5730341ad80b64a17
2015-02-16 21:53:08 +01:00
Translation updater bot 5337b46bbe Localisation updates from https://translatewiki.net.
Change-Id: Ib6f19c027e3cacbf7145a79cf2eabc4030153de2
2015-02-12 21:33:01 +01:00
Chad Horohoe 4a09f730e3 Remove obvious function-level profiling
Change-Id: I498d79d99ab6016cadf502f4c606a7a911470250
2015-02-10 14:32:58 -08:00
Cmcmahon 46f2d7c46d QA: robustify Notification no-javascript test
Identify the first heading better

Change-Id: Idb029c43b20915022f4d566a7795c3e0ec55cea2
2015-02-09 13:48:02 -07:00
Cmcmahon f5052ed4ef QA: update Ruby gems for mediawiki-selenium
This should get around the error with later Firefox versions

Change-Id: I879b39d2b1ee83f307c2efa2c82b5832eec38dc0
2015-02-09 13:38:16 -07:00
Translation updater bot c08d8cc02d Localisation updates from https://translatewiki.net.
Change-Id: I236e219249f5f60f59560941a066db08cc444bfb
2015-02-08 21:47:23 +01:00
Translation updater bot 5c3b460878 Localisation updates from https://translatewiki.net.
Change-Id: I80e8448122f24954451583f9b43a3939256e070f
2015-02-07 21:46:06 +01:00
jenkins-bot 6f4d2b68fb Merge "Add tests for generateEventsForRevision" 2015-02-06 13:49:16 +00:00
Matthias Mullie 682eff7022 Add tests for generateEventsForRevision
Change-Id: I54d6904c613d6f58beaa4d8202a07f1bf5850e7e
2015-02-06 14:37:58 +01:00
jenkins-bot d3bfc5a5b9 Merge "Improve signature detection" 2015-02-06 01:21:27 +00:00
Translation updater bot cfc4e5389b Localisation updates from https://translatewiki.net.
Change-Id: I2f9c4a8c383d3f7a466121351a2f12346c5bdd9f
2015-02-05 23:05:35 +01:00
Matthias Mullie 58e1c765d6 Improve signature detection
Previously, there were a couple of hacks in play.
It was also not picking up ~~~ (signature without timestamp)
And it relied an a nasty regular expression which, although
based on Parser, may some day get out of date.
And it relied heavily on a specific signature format, which
isn't guaranteed (it's an i18n msg)

This patch changes the approach: it will use a very simple
regex to match links, and will send those through Parser to
generate the signature anew. My reasoning is that that should
be exactly the same as what Echo just received (should've
also gone through parser)

Biggest discomfort of this approach is that it's much stricter.
It should still match whatever it generated from a ~~~ or ~~~~,
but no longer the e.g. not-real signatures we were doing in
our tests. Also had to update our tests, because signatures
change depending on anon. So I had to generate all the users.
And fix some of the signature formats used in the tests.

Bug: T75426
Bug: T87852
Bug: T75366
Bug: T78424
Change-Id: Ibeff36397129fdd5d376f3668a23a45f9a014525
2015-02-05 20:45:19 +01:00
Translation updater bot 7408aba1ca Localisation updates from https://translatewiki.net.
Change-Id: I34227f2ec5788b338a3d3861fa8b0e4bb2f4d2e0
2015-02-03 22:54:03 +01:00