wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-09-24 18:59:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
4615 commits 155 branches 0 tags 71 MiB
Commit graph

967 commits

Author SHA1 Message Date
Ed Sanders 3b4be7b6c5 NotificationItemWidgets: Remove property setting duplicated from parents 
Change-Id: I03c83d3cfb6ce22ccca0cc2dc1d1e20b36d739c8
 2018-05-22 15:54:55 +01:00
Ed Sanders e204977063 Make 'links' a required argument of NotificationBadgeWidget 
Change-Id: Ib1ae2cf1edc1d0a280eb62558d93d081f365ca84
 2018-05-22 15:42:45 +01:00
Roan Kattouw af323781ab Follow-up 8b84ed2a3: fix eslint failure that snuck in somehow 
Change-Id: Iad32afab81d1fc161b2f1e7f04bd8cd89937527e
 2018-05-19 14:36:55 +02:00
jenkins-bot b926673987 Merge "Sticky toolbar: Add missing vendor prefix" 2018-04-30 22:56:43 +00:00
jenkins-bot 4538925597 Merge "Conditionally rearrange date and button in notif list" 2018-04-13 18:25:38 +00:00
jenkins-bot f5d47b3ee7 Merge "Revert "Revert "Remove unused 'trash' icon""" 2018-04-12 15:37:42 +00:00
Catrope ee44f96e2f Revert "Revert "Remove unused 'trash' icon"" 
Can be removed now that it's been moved to PageTriage.

This reverts commit b59eedd251.

Change-Id: If829148d09cb28f21bd48d5073886b44174b274d
Depends-On: I370391d7460c5b04a5a1ddb2e191f29044b30e5e
 2018-04-11 19:54:35 +00:00
jenkins-bot caa28b5e6b Merge "Revert "Remove unused 'trash' icon"" 2018-04-05 19:53:44 +00:00
Catrope b59eedd251 Revert "Remove unused 'trash' icon" 
Still being used by PageTriage.

The proper solution is to move the icon to PageTriage, but
for now let's bring it back in Echo to unbreak things.

This reverts commit 54f49875e9.

Bug: T191335
Change-Id: If4c709d9932ac0d063f6211c5ddd82846f0f6a6d
 2018-04-05 19:07:04 +00:00
Moriel Schottlender 5a42e71171 Add extra margin for the badge when count is 99+ 
Bug: T183539
Change-Id: I57060bc9c442d4fc030608f9f6de98b77f5e1133
 2018-03-28 19:44:38 +03:00
Moriel Schottlender 8b84ed2a3b Conditionally rearrange date and button in notif list 
When there isn't enough space for both date and button,
separate them each on its own line.

Bug: T146288
Change-Id: I7ad022da82503f35ae630d171faeed1815c97f7a
 2018-03-28 16:19:47 +03:00
Roan Kattouw 1eef6eeee3 Remove footer notice code 
But keep the widget files in case we need them again.

Bug: T190481
Change-Id: Iec7dd472cebbee98ea88a0318c017707c7460ae8
 2018-03-28 14:57:44 +02:00
jenkins-bot 2cf4bd1df3 Merge "Align Notifications popup header/footer with OOUI's default size" 2018-03-27 21:03:38 +00:00
jenkins-bot bc511b4af2 Merge "NotificationsOptionWidget: Fix icon alignment" 2018-03-27 21:00:26 +00:00
jenkins-bot ae9ee9bc35 Merge "Prevent FOUC when loading OOUI notification badges" 2018-03-27 19:58:37 +00:00
Ed Sanders 52cd0f9b05 Prevent FOUC when loading OOUI notification badges 
Change-Id: I216d1f7ff90380040742e6c78df830a9dcb0b261
 2018-03-27 13:54:27 +01:00
Ed Sanders 0fd6d64a29 Fix DOM structure of mw.echo.ui.MenuItemWidget 
* Inherit from DecoratedOptionWidget as it comes with
  an icon mixin.
* Keep the DOM structure as similar to its parent as
  possible, to avoid breaking upstream child selectors.
* To this end, replace <a> wrapping hack with override
  of getTagName to set this.$element to <a>.

Change-Id: Ifde70785a1bc996eb09e581b06ed30708323e9f7
 2018-03-27 12:33:40 +01:00
Volker E 77021e370c Align Notifications popup header/footer with OOUI's default size 
Bug: T190397
Change-Id: I41ad96bbc7d3922772ecb026cb251476882601c7
 2018-03-26 20:13:08 -07:00
Volker E cc3df57d71 NotificationsOptionWidget: Fix icon alignment 
Change-Id: Ieb5c9a8e378608e096e921fdb6795949a119c8a8
 2018-03-26 02:15:36 -07:00
jenkins-bot 05e42c6a6a Merge "Use updated bell/tray icons from OOUI 0.26" 2018-03-24 17:05:50 +00:00
Ed Sanders 4523cc4ac5 Follow-Up Ie6252a8c: Fix suffices of constructive icons 
Also fix title of mention-success.

Change-Id: I699ae249ea7c4b3da869cc10bf6ee240c666547d
 2018-03-24 15:22:03 +00:00
Ed Sanders 15a3443384 Use updated bell/tray icons from OOUI 0.26 
As these are smaller canvases, fix positioning
hacks accordingly.

Change-Id: I472f8cdd5887243c3fd86ab1431532a99dba1ce9
 2018-03-24 15:06:47 +00:00
Ed Sanders 91076ef7c0 Update OOUI-copied icons 
* Rename to match their upstream names.
* For icons without upstream versions, fix canvas to 20x20.
* Use consistent suffices to indicator colour.

Change-Id: Ie6252a8ccbba79143a0f77536c6470b4350be1ad
 2018-03-23 09:41:15 -07:00
jenkins-bot 9c57911f97 Merge "Replace double-check with checkAll from OOUI" 2018-03-22 23:42:11 +00:00
Ed Sanders 34e3d5feba Replace double-check with checkAll from OOUI 
checkAll was specifically designed as a
replacement for double-check.

Change-Id: Ibdd6865213107650b9004ab40e12c6a7453b6251
 2018-03-22 21:23:33 +00:00
jenkins-bot b5780d0d1a Merge "Remove unused 'trash' icon" 2018-03-22 20:11:29 +00:00
Ed Sanders 54f49875e9 Remove unused 'trash' icon 
There are no references to 'trash' in the code.

Change-Id: Icbc50f6e0f647466a8f4a2a47ee7014c5d411ffe
 2018-03-22 19:52:44 +00:00
Ed Sanders ff78ed310a Remove unused bellOn icons 
Change-Id: I40903bb8a8ea964482b6603436af27caaf73f574
 2018-03-22 19:40:43 +00:00
Moriel Schottlender cb43a785b8 Place the notification page settings popup in an overlay 
Bug: T189428
Change-Id: I4d8ccb76b7fe46333f65a5f7caa15a1203b662ce
 2018-03-11 15:18:24 -07:00
jenkins-bot 09177edf91 Merge "Prevent double-clicking on badge when initializing" 2018-02-23 22:47:02 +00:00
Moriel Schottlender b2f2ef9114 Prevent double-clicking on badge when initializing 
Double-clicking would just recreate the badge midway while it is
being created, and produce 2 popups simultaneously. This patch
ignores the second click in a double-click until the widget is
being replaced anyways.

Bug: T184883
Change-Id: I2fda8df36b3828dbbe0d9b7892f159e598c630bd
 2018-02-23 14:36:39 -08:00
jenkins-bot 30a265ef88 Merge "build: Bring SVGO optimization to build step" 2018-02-22 20:41:48 +00:00
Fomafix a447c3e65f Use jQuery 3 .catch( fn ) instead of .then( null, fn ) 
https://api.jquery.com/deferred.catch/ Since jQuery 3
deferred.catch( fn ) is an alias to deferred.then( null, fn )

Change-Id: I120ec780c9b008b5e7bf12491fed83ccc8ae2420
 2018-02-10 11:48:26 +01:00
Volker E c9403011c8 build: Bring SVGO optimization to build step 
Enabling SVGO automation with 'grunt-svgmin' and conservative
plugin settings to build step, among those:
- enable removeRasterImages and sortAttrs,
- disable cleanupIDs, removeDesc, removeTitle, removeViewBox &
  removeXMLProcInst and
- don't use multipass.

Also updating SVGs accordingly.

Bug: T185596
Change-Id: I2288c7576ac96f8b5c4d5b8671218fceefaf6037
 2018-02-09 23:06:28 -08:00
Ed Sanders 17be84ec51 Sticky toolbar: Add missing vendor prefix 
Change-Id: Ib1a68298295e7c0ae276a1cec92c5c67adb7b643
 2018-02-04 21:26:06 +00:00
Stephane Bisson ac4b0ea899 Make icon not overlap with confirmation message 
Use widgets instead of mixins to compose the ConfirmationPopupWidget.

Bug: T184733
Change-Id: I608e820ef81b01efc54a13df5de189ef40ce335f
 2018-02-02 20:31:43 +00:00
Ed Sanders 2121daac96 Don't hide notification popup when scrolling 
hideWhenOutOfView is for preventing popups from appearing
outside their container, but in this case the container
is the document, so it is already clipped.

Bug: T178384
Change-Id: Ie0cd83849446cf74b61e708f0a1fa79f2384a94a
 2018-01-22 15:32:35 -08:00
jenkins-bot e63b9f9ac0 Merge "Fix help menu icon placement for monobook" 2018-01-19 18:44:00 +00:00
jenkins-bot f321dc1250 Merge "Align the icon in the popup action sub menus" 2018-01-19 18:38:39 +00:00
jenkins-bot d0550c9f6c Merge "Truncate page name in the sidebar and organize into table view" 2018-01-18 11:43:47 +00:00
Volker E 4bb614b5fd Use “OOUI” as unified name for code comments 
Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
 2018-01-16 23:30:18 -08:00
Moriel Schottlender aecacd9443 Align the icon in the popup action sub menus 
Also bring the icon rules up to a rule that actually
overrides ooui ruleset.

Bug: T185046
Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
 2018-01-16 16:40:46 -08:00
Moriel Schottlender 1e9f4a106c Fix help menu icon placement for monobook 
Bug: T184023
Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
 2018-01-16 14:09:58 -08:00
Moriel Schottlender df4aa8ea0b Truncate page name in the sidebar and organize into table view 
Organize into table view for consistency and truncate the title.

Bug: T184143
Change-Id: I0ae3105ea60dcc2ae6c0f7f2545368a5f86cb2c4
 2018-01-16 12:09:01 -08:00
jenkins-bot 9e56017681 Merge "Use findItem(s)FromData instead getItem(s)FromData" 2018-01-11 01:37:27 +00:00
petarpetkovic 309ea8e936 Fix "Mark as read" button icon on no-JS 
Bug: T182167
Change-Id: I2c386e1ab2c95d2d1034c8d366d39c12827b3d22
 2018-01-03 15:50:45 +01:00
Bartosz Dziewoński ada3be576c mw.echo.ui.NotificationBadgeWidget: Do not flip popups 
Bug: T183296
Change-Id: I3850cf71626d700a73bbefae7da9870d59491347
 2017-12-30 00:51:18 +01:00
Bartosz Dziewoński 7cc225ca33 mw.echo.ui.MenuItemWidget: Override OOUI styles harder 
Bug: T183435
Change-Id: I949de77ac8221bdc4bb35ae7b75e3df91d861d07
 2017-12-27 14:07:53 +00:00
jenkins-bot 010bb75603 Merge "Move the popups to the overlay" 2017-12-21 18:14:50 +00:00
Moriel Schottlender 77acb5b3ee Move the popups to the overlay 
This will solve multiple issues with the design having to overcome
the theme-based design for the #p-tools.

Bug: T156080
Change-Id: Ibfcdfeea649e566059fd88485e146fbad2201016
 2017-12-20 15:44:27 -08:00