wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-23 21:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
7042 commits 15 branches 19 tags 79 MiB
Commit graph

7042 commits

This branch
This branch
All branches
Author SHA1 Message Date
Daimona Eaytoy ef50bfeda5 Make Title and Revision caches proper services 
Singletons are bad, amongst other reasons, because they're never reset
in tests. They can therefore occasionally cause test failures if the
cached data stored in one of these singletons becomes stale.

As noted on the task, ideally these two classes shouldn't exist at all,
and core should be responsible for caching the information it deems
expensive to compute.

As a temporary (TM) workaround, make both classes actual services, so
that the setUp/tearDown logic in MediaWikiIntegrationTestCase can
properly reset them between tests.

Dependencies are intentionally not being injected, precisely because
these classes should just be deleted, not improved.

Bug: T344124
Change-Id: I58b8d9610f9447468235b94d25732528ab6acce6
 2023-08-14 17:41:23 +02:00
Translation updater bot 3a4578c456 Localisation updates from https://translatewiki.net. 
Change-Id: I5c10993ec34c291bed5d5d586329c522aedadf1f
 2023-08-14 09:17:33 +02:00
Umherirrender 9de512d59c tests: Resolve phpunit filename deprecation errors 
PHPUnit wants the filenames of the tests to match the class name being
tested.

Bug: T337333
Change-Id: I44f626d1bfdf151fecafc29c51b2cf2bb90481b0
 2023-08-12 21:07:15 +02:00
Translation updater bot 154acac786 Localisation updates from https://translatewiki.net. 
Change-Id: I2a0fbf70cf65c6e8579643c73cbf49659beead3b
 2023-08-11 09:00:09 +02:00
C. Scott Ananian 26aeebd301 Use OutputPage::setPageTitleMsg() instead of ::setPageTitle() 
Bug: T343994
Depends-On: I384a12bdb66dfc8fa6650e76e27c671fae5163d6
Change-Id: I1464c9f7db3b30ad9bb12377cc39cfcd5d540f78
 2023-08-10 16:28:23 -04:00
Jon Robson c50d129b02 Disable Echo behaviour on Minerva desktop 
Bug: T342907
Change-Id: Ibd311593eb7f153ff0dea8aad516759d54cc1cd2
 2023-08-08 10:47:19 -07:00
Translation updater bot 0974aebf1d Localisation updates from https://translatewiki.net. 
Change-Id: I50df240fcb2896c997ae6072ea692b2d4cb49815
 2023-08-08 09:00:52 +02:00
Daimona Eaytoy 9f44f98e81 Do not assume what user IDs might be in DiscussionParserTest 
The test was assuming that the ID 1 belongs to a user other than the one
being created in the test. This is not necessarily the case, so make it
use an ID that is guaranteed to be different.

Also rename the test fail to avoid a PHPUnit deprecation of test class
name not matching file name.

Bug: T342428
Change-Id: Ied1869e380b023c1a726a5be610e1de1b68c78c0
 2023-08-07 16:27:28 +02:00
Translation updater bot 9ad06f78b6 Localisation updates from https://translatewiki.net. 
Change-Id: I31b5ad5938849dc9578d2cb1bf3a7fdb54a18f22
 2023-08-07 08:38:16 +02:00
Daimona Eaytoy f7b0638ff0 Mock DB services in NotificationTest::testNewFromRowWithException 
The test doesn't need the database, but it's currently trying to use it.
Mock all services used by EchoDbFactory to avoid that (the Factory
cannot be mocked directly because it's created with a static method and
not injected).

Change-Id: I359489ed3f8de6e868a590d5c7c02f81f0a2049d
 2023-08-06 22:48:58 +02:00
Umherirrender e52a792060 Create HookRunner class and the hook handler interfaces 
Bug: T315938
Change-Id: Iffa2b409502b4269c9746e0304feb4aaee37a86e
 2023-08-06 10:30:46 +00:00
jenkins-bot c1d81f724f Merge "Replace deprecated Linker::formatComment" 2023-08-06 07:17:44 +00:00
jenkins-bot 7d765515b7 Merge "Avoid DB access in non-Database tests" 2023-08-05 04:17:03 +00:00
bwang a5d62502ad Finish updating echo tests to use new MobileFrontend icon class 
Change-Id: I304f894c7b55544b7907ee81525604811db6e8e1
 2023-08-04 13:41:17 -05:00
Translation updater bot 8294a154b0 Localisation updates from https://translatewiki.net. 
Change-Id: I3b0a9c28bda8585d62c6417f4b1d46f774aca7cb
 2023-08-04 09:20:22 +02:00
Daimona Eaytoy 713f60aaa5 Avoid DB access in non-Database tests 
Use mocks when possible, and add the test to the Database group
otherwise.

Also rename 2 test files to avoid a PHPUnit deprecation of file name not
matching class name.

Change-Id: I16b2392daf01f63511c82b4ed0e67a38e35ddbe1
 2023-08-04 02:31:24 +02:00
Umherirrender 9017ad5d76 Replace deprecated Linker::formatComment 
Bug: T324906
Follow-Up: Ibe0092a96d96f6fa9d93991418b723f3e70e1b75
Change-Id: I375fe9114429057f7a0220fee50cb75d4e39864b
 2023-08-03 23:37:32 +02:00
Translation updater bot 8a3f47e070 Localisation updates from https://translatewiki.net. 
Change-Id: Iaa22f93e9c77828022d4cb53026dc2e91aa8299e
 2023-08-03 08:48:28 +02:00
jenkins-bot ba4fa27bd9 Merge "Update notification badge to not rely on mw-ui-icon" 2023-08-02 21:44:24 +00:00
bwang ddaf43c5a0 Update notification badge to not rely on mw-ui-icon 
This will essentially all be deleted after I55c18cf723a32f80b93a01dd0687e005162c4e93, but thats fine\

Bug: T343053
Change-Id: Ifb382af388cdc24dc1ecef105ec89c9129194c19
 2023-08-02 19:10:34 +00:00
gerritbot db44be03bb Migrate ILB::getConnectionRef() calls to ILB::getConnection() 
Deprecated since 1.39 (I6e7544763bd)

Bug: T343277
Change-Id: Ia5dd9a2db1d00148fe84e5ba791fd073368adcc4
 2023-08-01 20:58:25 +00:00
jenkins-bot 562ffe2dab Merge "Revert "Fixes: Echo notification count disappears on load in mobile skin"" 2023-08-01 09:14:25 +00:00
Urbanecm c6dd920800 Revert "Fixes: Echo notification count disappears on load in mobile skin" 
This reverts commit 38c26f66d0.

Reason for revert: causes T343192

Bug: T335273
Bug: T343192
Change-Id: I807c2b35bba86c2905931b61e9ef9d726d60a1da
 2023-08-01 08:56:59 +00:00
Translation updater bot 88eeacf012 Localisation updates from https://translatewiki.net. 
Change-Id: I855c34c77a16840571fb891595b63a9575a6868a
 2023-08-01 08:36:27 +02:00
jenkins-bot 1a50f5041f Merge "Fixes: Echo notification count disappears on load in mobile skin" 2023-07-31 20:01:31 +00:00
Translation updater bot eac8f2b4e4 Localisation updates from https://translatewiki.net. 
Change-Id: Ied37b044122f2da218e0ce05bb1f7b5e53df8924
 2023-07-31 08:57:22 +02:00
Jon Robson 38c26f66d0 Fixes: Echo notification count disappears on load in mobile skin 
Bug: T335273
Change-Id: Ife0f3093c145d10e2432d3130ba71b03cc4817a1
 2023-07-28 18:52:59 +00:00
bwang d002532295 Update Echo to use MobileFrontend IconButton.js 
Bug: T340262
Depends-on: I186e3d22aa9c2b331a80d35514d578949a4b9e86
Change-Id: I415f5092df5b757576a67b612a7691e9038a696f
 2023-07-26 21:05:43 +00:00
Translation updater bot 24d6ddcc1b Localisation updates from https://translatewiki.net. 
Change-Id: I07c07566a6056a6f16ccb50f6f403ad9a82659d0
 2023-07-26 10:26:44 +02:00
Translation updater bot c82f9d046f Localisation updates from https://translatewiki.net. 
Change-Id: Ia1ca448e29522e54e2772e4c38903238fbf15d87
 2023-07-24 09:37:22 +02:00
Translation updater bot 36087d6ac5 Localisation updates from https://translatewiki.net. 
Change-Id: Ic5f92e8b987179fd6f089fc1f213543b3d568174
 2023-07-21 08:41:27 +02:00
Translation updater bot 39bb085d10 Localisation updates from https://translatewiki.net. 
Change-Id: Ie986e6df0f87d700e955011286374fa7536ded76
 2023-07-20 09:32:26 +02:00
jenkins-bot b33a8a36a4 Merge "Set a fixed default for echo-email-format" 2023-07-18 23:23:27 +00:00
Daimona Eaytoy f305c2d778 Set a fixed default for echo-email-format 
Always set the default value to HTML, and then potentially change it in
onUserGetDefaultOptions.

Bug: T341931
Change-Id: I19efaa2361cd936125b623f90d9a564caa51d4f1
 2023-07-19 01:00:46 +02:00
jenkins-bot 8b365dca6f Merge "tests: Call editPage() with WikiPage when used for same page" 2023-07-17 20:48:18 +00:00
Daimona Eaytoy 0d8422a569 Avoid DB access in tests when possible 
Use mocks where that makes sense, and add `@group Database` otherwise.

Change-Id: I8f8ec8f4b2c73066cc8e7a6f8e38b3fc286a1070
 2023-07-17 20:12:04 +02:00
Translation updater bot b3c74b1412 Localisation updates from https://translatewiki.net. 
Change-Id: Id234bc5f4ac076e2f4663cd329931e6e5d7ec79b
 2023-07-17 10:17:01 +02:00
Umherirrender 36970ce54c tests: Call editPage() with WikiPage when used for same page 
When calling editPage() with a string it converts it to a WikiPage each
time it is called. When edit a page only once that is okay,
but when adding more revision to the same page it is better to pass a
WikiPage instead to allow reuse of internal states of WikiPage to speed
up the tests

Change-Id: Iac4ef3a3838ba22cd98b944e3ac7f596d540b405
 2023-07-15 22:32:16 +02:00
Translation updater bot c416143ea4 Localisation updates from https://translatewiki.net. 
Change-Id: Ia3ace1858ebaed0a6d8c767c5f94c19a0360246c
 2023-07-14 09:33:35 +02:00
Translation updater bot 7a7a5ef55d Localisation updates from https://translatewiki.net. 
Change-Id: I80a2c5c0df7e4402be7c7ed07a30c9dff89b4463
 2023-07-12 08:55:23 +02:00
Translation updater bot 8d462ce627 Localisation updates from https://translatewiki.net. 
Change-Id: I899f42b09b2ad0317a77b306ac2f170b0c560c02
 2023-07-10 09:37:30 +02:00
Translation updater bot 7e4ffb3df4 Localisation updates from https://translatewiki.net. 
Change-Id: I36cd150ca3057b2696dd3ddcbb1c8470c9ff9a81
 2023-07-06 10:11:55 +02:00
jenkins-bot 714da902cf Merge "Add special page name translations in Norwegian Bokmål and Nynorsk" 2023-07-05 14:24:32 +00:00
Translation updater bot 6852646e38 Localisation updates from https://translatewiki.net. 
Change-Id: I24ce383e22811d26ed51e853619db0b516df51da
 2023-07-05 08:29:11 +02:00
Translation updater bot a885b8f44d Localisation updates from https://translatewiki.net. 
Change-Id: I4bdca740dd303f1dab6004d6a0c195dd8bc19c39
 2023-07-03 10:14:58 +02:00
WMDE-Fisch ef8a472299 selenium: run tests concurrently 
Bug: T226869
Change-Id: I55572d5427877364c21631db2f44f8d39b774f95
 2023-06-29 15:30:28 +02:00
Tim Starling bc7a6fc65b Use the new Wikimedia\Diff namespace 
Bug: T339184
Change-Id: Ibe96f4301996f4c5e05a3de78d3e2787152393e4
 2023-06-29 12:01:20 +10:00
Translation updater bot 57dfb49c86 Localisation updates from https://translatewiki.net. 
Change-Id: I4effd94ec9e50f6fc111c95a9a443d8d2258c4ce
 2023-06-28 17:32:52 +02:00
Translation updater bot 271ead7d67 Localisation updates from https://translatewiki.net. 
Change-Id: I478c5fa03254d3c27356c37a3ea6f487c58bdff2
 2023-06-27 19:27:05 +02:00
Translation updater bot d28116e315 Localisation updates from https://translatewiki.net. 
Change-Id: I20a732701ff2865fdfab8369d2351b91dea20a28
 2023-06-26 12:38:51 +02:00