wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-11 17:00:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update notification badge to not rely on mw-ui-icon

Browse source 
This will essentially all be deleted after I55c18cf723a32f80b93a01dd0687e005162c4e93, but thats fine\

Bug: T343053
Change-Id: Ifb382af388cdc24dc1ecef105ec89c9129194c19
This commit is contained in:
bwang 2023-08-01 14:39:42 -05:00 committed by Bernard Wang
parent 562ffe2dab
commit ddaf43c5a0
4 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
extension.json
View file

@ -317,7 +317,8 @@
},
"styles": [
"mobile/overlay.less",
"mobile/notificationsFilterOverlay.less"
"mobile/notificationsFilterOverlay.less",
"mobile/NotificationBadge.less"
],
"messages": [
"notifications",

4
modules/mobile/NotificationBadge.js
View file

@ -3,9 +3,9 @@ var
View = mobile.View,
IconButton = mobile.IconButton,
notificationIconButton = new IconButton( {
icon: 'bellOutline-base20',
icon: 'bellOutline-subtle',
tagName: 'a',
glyphPrefix: 'wikimedia'
glyphPrefix: 'echo'
} );
/**

6
modules/mobile/NotificationBadge.less Normal file
View file

@ -0,0 +1,6 @@
@import 'mediawiki.skin.variables.less';
@import 'mediawiki.mixins.less';
.mw-ui-icon-echo-bellOutline-subtle {
.cdx-mixin-css-icon( @cdx-icon-bell-outline, @param-fill-color: @color-subtle );
}

2
tests/qunit/mobile/test_NotificationBadge.js
View file

@ -8,7 +8,7 @@ QUnit.module( 'ext.echo.mobile - NotificationBadge', function () {
hasUnseenNotifications: true,
notificationCountRaw: 5
} );
initialExpectationsMet = badge.$el.find( '.mw-ui-icon' ).length === 0;
initialExpectationsMet = badge.$el.find( '.mf-icon' ).length === 0;
badge.setCount( 0 );
assert.true( initialExpectationsMet, 'No icon.' );