If you click "Expand" on a notification bundle, the list of individual
notifications appears below. The list has a thin band of whitespace
around it (with grey background). Clicking inside that whitespace,
outside of the list items, would activate the bundle's primary link,
even though the cursor state did not show that would happen.
Change-Id: Id8c60503fa45f61df5bfaa07e0184634a5263c61
Follow-up to 00d6928144. I simplified
the styles too much :( They worked for cross-wiki notifications, but
not regular bundled notifications. I didn't realize they were styled
differently…
* Add the border to bundled non-cross-wiki notifs
(this requires changes in SortedListWidget.js to add a wrapper)
* Hide the border until the list loads
* Remove unnecessary margin
Change-Id: I30c5bec11ddb49defa5957f0917f01057a3c21e7
While loading or when there were 0 notifications, the popup displayed
with a scrollbar gutter, in a displeasingly different color.
When there weren't enough notifications to require a scrollbar,
the scrollbar was shown anyway.
These issues were caused by these rules, which don't seem necessary
any more. They were added for T130153 and T159888 (and a mysterious
scrollbar rendering bug), and I can't reproduce any of these bugs.
Bug: T351481
Change-Id: I370166ce31c86ae531080490c455286879999ae5
Completely remove the EchoMail and EchoInteraction instruments,
supporting code, and config variables. Note well that the
EchoEventLoggingSchemas config included an entry for the
already-decommissioned Echo instrument so remove that too.
Bug: T344167
Change-Id: Ic0c44737d2c4a78ec19e67b8b8cd4e6cfb8e14fa
This code has been moved to Minerva and is no longer serving any
purpose. The handlers are replaced with an already standardized
mw.hook for Minerva to subscribe and respond to.
Bug: T342907
Depends-On: I55c18cf723a32f80b93a01dd0687e005162c4e93
Change-Id: I2f923e509d24524a2375ffbe6b3ef336487574bb
This will essentially all be deleted after I55c18cf723a32f80b93a01dd0687e005162c4e93, but thats fine\
Bug: T343053
Change-Id: Ifb382af388cdc24dc1ecef105ec89c9129194c19
svgo 2.8.0 → 3.0.2
Amending to new `cleanupIds` plugin name.
Re-crushing SVGs while at it.
Bug: T339162
Change-Id: I37021bc12b29143a8a05ebbb183547df29aa1f6a
Pass a relevant number of unread notifications to the messages
'echo-mark-all-as-read' and 'echo-mark-wiki-as-read' each time
they are used, in order to facilitate the use of PLURAL in
the messages. This allows translators to say e.g. "mark both as
read" when there are two unread notifications, for instance.
Bug: T321462
Change-Id: Ida65be2d7f2663d9802f71c7ea1eb588db8cd254
Replacing 'mediawiki.ui/variables.less' `@import`
with new skin-aware 'mediawiki.skin.variables.less' standard.
Also replacing and removing scattered WikimediaUI Base v0.15.0 variables
with new skin variables.
Also
- replacing several static values with new Codex design tokens featuring
skin variables for following properties:
- background-color
- color
- border-width, border-style, border-color and border shorthand
- border-radius
- box-shadow colors
- outline-width, outline-style, outline-color and outline shorthand
- opacity
- replacing equal-value Echo variables with new skin variables
- replacing `opacity: 0` with `opacity: 1px solid transparent`, which
improves accessibility in Windows High Contrast mode
Bump required MediaWiki core version to >= v1.41.0.
Bug: T332541
Co-Authored-by: Volker E. <volker.e@wikimedia.org>
Depends-On: I04f9e48a1cf9dee915cf51e1e12b17ff0a595a06
Change-Id: If3863f07d7c3a8b58808fb03401c1060a92bc2ab
Creates a notification type to notify users when their
user page is edited.
Co-authored-by: Kunal Mehta <legoktm@debian.org>
Co-authored-by: Ed Sanders <esanders@wikimedia.org>
Bug: T3876
Change-Id: Ibe0092a96d96f6fa9d93991418b723f3e70e1b75
This reverts commit 39c6e6f7b6.
Reason for revert: Caused a regression in Vector 2010 where notification icons are black instead of gray.
Bug: T331502
Bug: T329300
Change-Id: I3eb8c847feb67eb0abb08ee13a1071eb01bef9f9
This was originally decided in T115845 and then the decision
was reversed in T329300.
Bug: T329300
Change-Id: Ife3ab7501af00420965282adc0a6ee31990a68b1
Hardcoded width interferes with OOUI's attempts to make the popup
narrower on narrow screens.
Minerva low resolution styles are now applied to all skins at
mobile/tablet breakpoints
Bug: T287132
Change-Id: Ifffe8c6330385356d35b7950ce9803f3a9f01b6f
Ensure there is always a 2px outline, and have that
outline cover the outer border where possible.
Change-Id: I3667d01e112f40663bc370ecd5bd6c3bb71ed219
Some versions of OOUI also accepted single non-array items. But this
was never official. Let's follow the spec.
Change-Id: Ie14431be802a6c71127c1b418e750ce5c9beb863
Badge rendering is a responsibility of the skin (since badges
must work with JavaScript disabled). Because of this, we move the
styles to their associated skin (Monobook and Minerva)
Bug: T257143
Depends-On: I1999185d19e171900f2da5acbd39125013d3582c
Depends-On: Ib148e90a3fde42ebcf271432dce3ccfc8985c677
Change-Id: I9319c72183a312cf0f55942ba1f78aa974ce5e84
These have been moved to the Vector skin
Bug: T257143
Depends-On: If52986fe56b65479adabe8233b0fc6df164b5376
Change-Id: Ibf11821e863d3089d60cf5c0959c4c5ddc5ce4f2
This should result in no visual change to Echo, but allows
us to change the Vector implementation here.
Removes all styling when vectorvisualenhancementnext=1
is enabled.
Bug: T257143
Change-Id: Ice602ba246b51252ff0527a531aa4d5d3baee64e
This allows skins to make modifications to the final output.
This will be used in Vector to make the Echo icon consistent with
other icons.
Bug: T257143
Change-Id: I9fe8c921956ede164d93cb1f42647cf4b80ca976
