Bsitu
271d192f69
Revert "Make timestamp in consistent format after loaded from database"
...
It should handle NULL
This reverts commit 31a986bebd
.
Change-Id: I202a7c6f8deaf0b6bbf3af1981f4f25077e916db
2014-08-22 21:50:34 +00:00
Erik Bernhardson
ae3b1f2944
Hygiene: Move notification type detection to method
...
* Moved most of the content from notify to getEventNotifyTypes
* Added phpunit test verifying per-event config overrides defaults
* Remove special-snowflake welcome handling with proper configuration
Change-Id: Ic1aae11d37f23f2b7b8abe3c1edaa414e29be021
2014-08-22 14:05:47 -07:00
Erik Bernhardson
57130aadf1
Hygiene: Move master/slave code to MWEchoDbFactory
...
Change-Id: I1b36bab2126b12359b00c5623885117ef17d0768
2014-08-22 14:01:57 -07:00
jenkins-bot
620c063910
Merge "Make timestamp in consistent format after loaded from database"
2014-08-22 18:11:00 +00:00
bsitu
31a986bebd
Make timestamp in consistent format after loaded from database
...
timestamp is generated in MW format (YYYYMMDDHHMMSS)
for notification but it's
loaded into model in the database specific format. We just need
to convert it back to MW format, it just happens that MW
format is the same as MySQL timestamp format
Change-Id: I1f7f2aeb32b63d47e92631d6daa711d9c32e4017
2014-08-22 18:09:39 +00:00
jenkins-bot
6bd1dc99b7
Merge "efLogServerSideEvent is deprecated"
2014-08-21 23:06:01 +00:00
bsitu
092127726b
Hygiene: Echo/tests/phpunit/ directory structure should mimic Echo/
...
Change-Id: I4867d09bb815d621f9feaaf7b8a541e5d817e0d2
2014-08-21 22:58:27 +00:00
Matthias Mullie
411f0151dc
efLogServerSideEvent is deprecated
...
Change-Id: I3fb95ff95dd9371d55285e64a37b32cec35b029a
2014-08-21 15:19:27 +02:00
jenkins-bot
9e71c87d5b
Merge "QA: Add missing browser test steps"
2014-08-21 07:05:36 +00:00
jdlrobson
5c73416b4c
QA: Add missing browser test steps
...
Change-Id: I3a54902ae1cf2d2b7263243722bb0b7f57bcba95
2014-08-21 00:02:42 -07:00
Translation updater bot
3e226df165
Merge "Localisation updates from https://translatewiki.net ."
2014-08-20 20:45:05 +00:00
Translation updater bot
a98d18221d
Localisation updates from https://translatewiki.net .
...
Change-Id: I3d4ec6676475c969edb465fc64f418b415a236ee
2014-08-20 22:25:56 +02:00
jenkins-bot
abb7655297
Merge "Add support to retrieve unread + read notifcations for section"
2014-08-20 17:37:51 +00:00
bsitu
8e2de3f02b
Add support to retrieve unread + read notifcations for section
...
Change-Id: Ife3750400315f545f5f3e54ac9847f56c2efe9be
2014-08-19 16:54:48 -07:00
jenkins-bot
eb74ba01a5
Merge "Reset per-user notify types for each user"
2014-08-19 23:29:58 +00:00
jenkins-bot
b392deda1d
Merge "Delete invalid records from echo_target_page"
2014-08-19 22:29:37 +00:00
jenkins-bot
6ae565e1e8
Merge "[5] Code cleanup and miscellneous fix"
2014-08-19 22:20:14 +00:00
jenkins-bot
715ad180a2
Merge "Hygiene: Mega clean up the Echo footer code"
2014-08-19 20:25:04 +00:00
jenkins-bot
5f27ea2c8d
Merge "Add waitForSlave() wrapper function to Echo Database wrapper"
2014-08-19 20:16:18 +00:00
Erik Bernhardson
768d0fc513
Reset per-user notify types for each user
...
The code was passing the notifyTypes in the hook for each user, but
the second user would get passed whatever made it through the first
user.
It is unlikely this is intended. Give each user a fresh set of the
configured notify types.
Change-Id: I13059d380ea54c71cd1c062fd803897f5e5ad2b8
2014-08-19 18:58:44 +00:00
jenkins-bot
8d5421c9cb
Merge "Fix line height/size of notifications"
2014-08-19 18:55:10 +00:00
bsitu
b35f27c291
Delete invalid records from echo_target_page
...
Remove the records:
* If a page is no longer valid
* If a notification somehow has been read
* If a notification is no longer a bundle base and has not been removed
Change-Id: I282568691d6649c6e3263aea598c3bba29119a29
2014-08-19 11:34:01 -07:00
jenkins-bot
e11614bc85
Merge "[4] Add revision local cache holder object"
2014-08-19 17:58:28 +00:00
bsitu
25d6d71a61
[5] Code cleanup and miscellneous fix
...
* cache function result in local variables
* Update the logic of generating notification date header
Change-Id: I04c3ed853076f17c819da8f27bfdb169e99b2a3a
2014-08-19 17:58:07 +00:00
jenkins-bot
bda4fd83a6
Merge "[3] Use title local cache to cache title object"
2014-08-19 17:57:29 +00:00
jenkins-bot
51dda5473c
Merge "[2] Add title local cache holder objects"
2014-08-19 17:57:22 +00:00
bsitu
55fb42b681
[4] Add revision local cache holder object
...
Change-Id: I85f68b3ca269c711a8a177e013bd8eba38833444
2014-08-19 10:28:38 -07:00
jenkins-bot
4ec639ec50
Merge "[1] Make title lazy loaded in EchoEvent"
2014-08-18 22:41:23 +00:00
bsitu
f781a594d4
Add waitForSlave() wrapper function to Echo Database wrapper
...
Plus a couple of comments update
Change-Id: I1678cd1cfde88806a15b280532ecfc6cf2672e38
2014-08-18 15:00:46 -07:00
jdlrobson
75cda20a31
Hygiene: Remove unused directory
...
Let's not use old unused things lying around... it just confuses
people.
Change-Id: I30cecb58fbdce0129e0385be3680ca4a2c6c36f8
2014-08-18 21:11:19 +00:00
bsitu
49350a5b52
[3] Use title local cache to cache title object
...
Change-Id: Ibfbe99be8ebf3ca8d7241e4ed991a183bd0e3f27
2014-08-18 14:09:15 -07:00
bsitu
1270da19e8
[2] Add title local cache holder objects
...
Core titleCache doesn't do what I expect it to do, issuing
Title::newFromId( 1 ) mulitple times would issue multiple
idential queries to the database. It doesn't return what's
already in the cache.
The goal of this patch is to batch load titles via newFromIDs,
and save the number of mysql queries
Change-Id: I8fe767ac2669e67bdf7d17eecccfc0dcb6b5fc7d
2014-08-18 13:52:40 -07:00
Translation updater bot
1242f6ec12
Localisation updates from https://translatewiki.net .
...
Change-Id: I81dfe6ab41bf2291cd2ec89a43babda8e980e5d2
2014-08-18 22:38:11 +02:00
Cmcmahon
37812e4bab
QA: add test2 tag for Jenkins builds
...
Change-Id: I3d5195e58ac4f617baa358624543ffdfdc8fb7bd
2014-08-18 10:44:00 -07:00
jenkins-bot
a3449bfb67
Merge "Hygiene: Stop using id for footer"
2014-08-18 17:27:00 +00:00
jdlrobson
088ba0a152
Hygiene: Mega clean up the Echo footer code
...
Lots of duplicate unused css. This simplifies it drastically.
Change-Id: Idfcca27840410f0287e30478e7978255234127d0
2014-08-18 17:26:40 +00:00
jenkins-bot
7fac1c3ee8
Merge "Use batch queries for users-watching-title"
2014-08-18 08:33:13 +00:00
Translation updater bot
f392895fdb
Localisation updates from https://translatewiki.net .
...
Change-Id: I6c9076dd44487056f41cc4a63f8a011f9aad091d
2014-08-17 23:03:17 +02:00
bsitu
d6ff5a54c2
[1] Make title lazy loaded in EchoEvent
...
* We can batch load titles and load it when requested
Change-Id: I063ca44ddbd8cb3f61537d8b160a10cf390d7926
2014-08-15 20:19:08 -07:00
jdlrobson
dc45eb246f
Fix line height/size of notifications
...
Previously too cramped and not in relative font.
Change-Id: Idfc2d24a4896883630aee7c105cf67c8a8005a57
2014-08-15 14:02:17 -07:00
Cmcmahon
2b472785ef
QA: add @login tag for Jenkins build
...
Change-Id: I0f2aa8f2f42c2fbb986a14e7ab50d6ccbe814b48
2014-08-15 13:13:15 -07:00
jenkins-bot
124cbbd036
Merge "Auto mark notification as read if it doesn't have target page"
2014-08-15 18:35:27 +00:00
Erik Bernhardson
1667e25854
Use batch queries for users-watching-title
...
The new locateUsersWatchingTitle implementation could end up returning
thousands of users, currently on enwiki there are 25 titles with more
than 10k subscribed users and aprox 550 titles with more than 1k subscribed
users.
This switches the user collection to an iterator based implementation so that
we no longer need to have the entire users list at any one time.
Change-Id: I3d3fa9328f348bb48682d3658622952ce82d3925
2014-08-15 10:44:55 -07:00
jdlrobson
965a8b8a2f
Hygiene: Stop using id for footer
...
No need. Class works perfectly fine here.
Change-Id: I8188e759ad3eed971d5847b23d49b333d80b509f
2014-08-15 17:43:56 +00:00
jenkins-bot
a615482a20
Merge ""put a comment nearby with the resulting keys""
2014-08-15 16:55:29 +00:00
bsitu
1cc0f83829
Move 'notification count refresh' logic out of mapper
...
Change-Id: I4c10b66e537dea5f9c5bc7ccba8f558cafd103d7
2014-08-15 16:02:23 +02:00
jenkins-bot
32dd2e314b
Merge "Create TargetPage data if specified by EchoEvent"
2014-08-15 13:47:48 +00:00
Raimond Spekking
6da76b9c6e
Merge "Localisation updates from https://translatewiki.net ."
2014-08-15 09:10:23 +00:00
S Page
af2abe84a5
"put a comment nearby with the resulting keys"
...
Per https://www.mediawiki.org/wiki/I18n#Using_messages
Comment-only change.
Change-Id: I468a79bee19fc5486b564b1a0ec7eb66c9dfa852
2014-08-14 19:01:45 -07:00
bsitu
61fea56641
Create TargetPage data if specified by EchoEvent
...
Change-Id: I71039eb03b4b7e617ce03d515a6d51c4f3666ab8
2014-08-15 00:16:41 +00:00