Commit graph

6614 commits

Author SHA1 Message Date
jenkins-bot d8d0e52c03 Merge "Use user IDs, not User objects, for reverted-user-id" 2020-07-28 12:11:24 +00:00
jenkins-bot e504ed86a6 Merge "Merge in styles from Minerva" 2020-07-28 10:53:47 +00:00
Ed Sanders 6492fc380d Fix width of buttons-as-option-widgets
Change-Id: I7001815850a829a07c941e94548ea5a65d2fd1d5
2020-07-28 09:51:20 +00:00
Ed Sanders 344cccb5fa Minerva popup: Fix scope of border-left/right rule
We only hide side borders from top level notifications,
not notifications in bundles.

Change-Id: Iba680bda1dcd69b8f907413fbeec088e3ee1b43a
2020-07-28 09:51:15 +00:00
Translation updater bot 7c9c39d6b8 Localisation updates from https://translatewiki.net.
Change-Id: I4f2145777a1bff4720592b0931408f10b50c9838
2020-07-28 08:24:32 +02:00
Ed Sanders d43ceb8978 Merge in styles from Minerva
Drops some no-JS styles (.mw-echo-notification) which didn't do anything useful.

Bug: T258936
Change-Id: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
2020-07-27 23:19:51 +00:00
Ed Sanders eb0603c9af Fix layout of NotificationsInboxWidget on narrow screens
Bug: T258939
Change-Id: I17b968297baf630b71e832f6af0b0b534c9c08b4
2020-07-27 16:11:38 +01:00
Ed Sanders bc5b569719 Fix styling of action popup menu
* Fix icon position
* Fix border widths and colour

Change-Id: I06f45baa4c90e43d7e50eed83888d57ede69a517
2020-07-27 16:11:03 +01:00
Ed Sanders d22ca3b44c Fix popup font size in Minerva
Bug: T258937
Change-Id: I91ff2c49cfa7aa0805d7e0444c87599226c79291
2020-07-27 12:56:24 +01:00
Translation updater bot 1d0001c602 Localisation updates from https://translatewiki.net.
Change-Id: I11fcd308eb88f1b80a7d4b2fea4b19d749db6678
2020-07-27 08:37:15 +02:00
jenkins-bot c582cfc673 Merge "Make Echo QUnit tests run again" 2020-07-25 18:34:32 +00:00
jenkins-bot 34b8f1050e Merge "Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook" 2020-07-25 18:08:15 +00:00
jenkins-bot 833fcdfd1e Merge "Fix font size in monobook" 2020-07-25 00:00:11 +00:00
jenkins-bot 407e55dd00 Merge "Remove padding reset from markAllReadButton" 2020-07-24 23:59:51 +00:00
Ed Sanders 34c70f8501 Follow-up I1ed9d3860: Fix ToggleReadCircle in monobook
Dummy icon is not position absolute in monobook, so hide it.

Change-Id: I24edfbc1afcb81da8ef4db6bb685792ee56bc49a
2020-07-24 23:31:45 +00:00
Ed Sanders 5b216bfad3 Fix font size in monobook
Content font size should be 12.7px and this can be achieved
by just applying the 127% from globalWrapper.

This matches the font sizes on Special:Notifications.

Change-Id: I5369231da52343029ea2cdbfc790296c2257807a
2020-07-24 23:31:35 +00:00
Ed Sanders 3ead305c27 Remove padding reset from markAllReadButton
Buttons should be positioned with margin, not padding,
as changing padding breaks hover and focus states.

In this case the position is already fine without
additional adjustment.

Change-Id: I8a7726b2e0988117084a1d0b060b4f649ba4cc75
2020-07-24 23:31:00 +00:00
Roan Kattouw c87cae39d7 Make Echo QUnit tests run again
The automatic registration for these was broken, because
$wgResourceModules no longer contains Echo's modules (since they are now
registered in extension.json).

Instead, add the test files in tests/qunit/model/ explicitly in
onResourceLoaderTestModules. The tests in tests/qunit/mobile/ are
already added through QUnitTestModule in extension.json.

Delete the ext.echo.overlay tests, they were testing code that was
removed years ago.

Bug: T258818
Change-Id: I7b996dc8631a86033830cf532f1b8e85251788ad
2020-07-24 13:26:34 -07:00
Ed Sanders 2faa1fe512 Fix hover styles, remove link underline on special page
Change-Id: Ie144eed5295a8c8fa6239c28f7f2a15d493fd775
2020-07-24 20:34:43 +01:00
jenkins-bot f44df2f728 Merge "Make default snippet length (150) a constant" 2020-07-24 00:03:15 +00:00
Ed Sanders ec87876f59 Set min-width on action buttons
Bug: T130109
Change-Id: I0a763aa7d73a84854daf43696d5751c58b3d067d
2020-07-23 18:19:34 +01:00
Ed Sanders e91e0c410b Simplify styling of notification bundles
Bug: T258714
Change-Id: Ia73fe2d2a96c070dacd8d9744242148ab4eca390
2020-07-23 18:19:34 +01:00
Ed Sanders 769d6579f9 Make MenuItemWidgets inherit from ButtonOptionWidgets
This gives them a consistent appearance with the expand/collapse
button. Only requires a small visual tweak to work in the popup
menu.

Bug: T258701
Bug: T258703
Change-Id: Ib3d074d1117e08d11136791354184e2e4b655290
2020-07-23 18:19:32 +01:00
Ed Sanders 3abe6b77bd Make mark as read/unread buttons properly focusable
Bug: T258710
Change-Id: I1ed9d386083d94bf6b5696bb71385169c0ccb807
2020-07-23 15:27:01 +01:00
Ed Sanders 42e2e5efbc Make NotificationItemWidget an <a> tag to fix focus issues
Bug: T258705
Change-Id: Ib44e04dd08e2818eb99ffb0cba73c775256d66d5
2020-07-23 15:27:01 +01:00
Ed Sanders 25e2fb4a8f De-activate toggleExpandButton after clicking
Bug: T258706
Change-Id: I810d7733e1f5f89c521e733713641b28b1ae6237
2020-07-23 15:27:01 +01:00
Ed Sanders d39d944bf0 Remove light background from dynamic-action hover state
Bug: T258703
Change-Id: I7b306b63c56da11ab7ce0492111f594f8b60593e
2020-07-23 14:02:34 +01:00
Ed Sanders 1b40b69481 Make default snippet length (150) a constant
Change-Id: Idb53b226618fa0d625c7e4713c780538bd6a76ea
2020-07-23 13:00:44 +01:00
jenkins-bot 3ea911c8a9 Merge "DiscussionParser: Use strict (in)equality" 2020-07-23 10:03:45 +00:00
Translation updater bot 471aa89b74 Localisation updates from https://translatewiki.net.
Change-Id: I2f310c588f25ef24a52033f3230539bcbcc4d7c5
2020-07-23 08:27:46 +02:00
Ed Sanders b5c919db25 DiscussionParser: Use strict (in)equality
Change-Id: I7c6a8453a5f7a6603c8f8c173e5bcfd3cafc25d6
2020-07-22 21:50:54 +01:00
jenkins-bot 1d6f4a6dcb Merge "Rename variable to revertedUser" 2020-07-22 20:49:34 +00:00
Translation updater bot 72519a3da5 Localisation updates from https://translatewiki.net.
Change-Id: I398842408dd32ee483d3f5d2f8468b777401810e
2020-07-22 08:26:22 +02:00
Kosta Harlan 910df7a190 Use user IDs, not User objects, for reverted-user-id
The Revision->RevisionStore migration accidentally injected User
objects for reverted-user-id in two different places at different times.
This doesn't break, because there's backwards compatibility logic that
handles User objects appropriately, but we shouldn't be doing this.

Co-authored-by: Roan Kattouw <roan.kattouw@gmail.com>
Change-Id: I4170c207c3d4fc7f0d869c0b367b53389a70ce80
2020-07-21 13:19:30 +02:00
Kosta Harlan 07dc8ef425 Rename variable to revertedUser
See https://en.wiktionary.org/wiki/victim

"Reverted user" is more descriptive in any case.

Bug: T254646
Change-Id: I70964850e63cdd832b2cc1799161c480f283d08c
2020-07-21 13:15:09 +02:00
Translation updater bot a312b09731 Localisation updates from https://translatewiki.net.
Change-Id: I98a249f45de65ed737042d315c17805254c36e37
2020-07-21 09:11:19 +02:00
Translation updater bot af49551393 Localisation updates from https://translatewiki.net.
Change-Id: I8a592dde3857d724b007d46f1af96a67dc5140fe
2020-07-20 09:00:59 +02:00
libraryupgrader 866a9e064b build: Updating grunt to 1.2.1
Change-Id: I84f446bb1b5de9262dcca5008ca17eb068bb7202
2020-07-18 05:30:44 +00:00
Base ec8d947669 Fixing typo in apihelp-echopushsubscriptions+delete-example:
Unegister → Unregister

Please mark it as not requiring translations update.

Change-Id: Ib096a89818f3e0f7b76a8a884e0b35ecceb3d353
2020-07-17 19:59:00 +00:00
Translation updater bot ec03128c78 Localisation updates from https://translatewiki.net.
Change-Id: I32fb84d5070a74f738ac030339e3cf15b6babbbb
2020-07-17 08:28:35 +02:00
Translation updater bot 6501650155 Localisation updates from https://translatewiki.net.
Change-Id: I63228d13c53515d3359b0ed5fcba23c2a6d4cb50
2020-07-16 08:21:04 +02:00
libraryupgrader d5641dd909 build: Updating eslint-config-wikimedia to 0.16.2
Change-Id: I87b42cbabd1eadfeebd8e988ef13d198837ee358
2020-07-15 23:12:00 +00:00
Translation updater bot cab0559595 Localisation updates from https://translatewiki.net.
Change-Id: Id674903a152dbf812645e5450199026b27aa194e
2020-07-15 09:04:00 +02:00
jenkins-bot 3c62654c2f Merge "NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link" 2020-07-13 20:47:55 +00:00
Nikerabbit 84f473fe27 Revert "Localisation updates from https://translatewiki.net."
This reverts commit 42351da940.

Reason for revert: Broken export

Change-Id: I5fa3837b1134d5ac6bdd10df817267f3f3899b3b
2020-07-13 11:43:50 +00:00
Translation updater bot 42351da940 Localisation updates from https://translatewiki.net.
Change-Id: I9b31d3bec7971006e7eda215b8830548c272e1be
2020-07-13 08:42:14 +02:00
Translation updater bot 281b03814d Localisation updates from https://translatewiki.net.
Change-Id: I066eac810dd95e42113adbb5c26439f0b4d36367
2020-07-10 08:25:39 +02:00
libraryupgrader 524cf15a75 build: Updating lodash to 4.17.19
* https://npmjs.com/advisories/1523
* CVE-2019-10744

Change-Id: Ide1f2c2b9b4e731a0afb48d773c888c50e42c04d
2020-07-09 09:30:09 +00:00
Translation updater bot f2ae65866f Localisation updates from https://translatewiki.net.
Change-Id: Ia1ce1cae1595b86287e0bc0455303272c3059926
2020-07-09 08:24:52 +02:00
Translation updater bot 4cc13c88d8 Localisation updates from https://translatewiki.net.
Change-Id: Iad3938ac3c6dc61b4acb320fbc93ada15b0e684c
2020-07-08 09:10:39 +02:00