wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Never show a negative number in the notifications badge"

Browse source
This commit is contained in:
jenkins-bot 2016-04-11 08:47:33 +00:00 committed by Gerrit Code Review
parent d51ac74ee8 f35251fce6
commit ebe216e4c1
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Hooks.php
View file

@ -787,6 +787,10 @@ class EchoHooks {
$msgCount = $notifUser->getMessageCount() - $subtractMessages; $msgCount = $notifUser->getMessageCount() - $subtractMessages;
$alertCount = $notifUser->getAlertCount() - $subtractAlerts; $alertCount = $notifUser->getAlertCount() - $subtractAlerts;
// But make sure we never show a negative number (T130853)
$msgCount = max( 0, $msgCount );
$alertCount = max( 0, $alertCount );
$msgNotificationTimestamp = $notifUser->getLastUnreadMessageTime(); $msgNotificationTimestamp = $notifUser->getLastUnreadMessageTime();
$alertNotificationTimestamp = $notifUser->getLastUnreadAlertTime(); $alertNotificationTimestamp = $notifUser->getLastUnreadAlertTime();