wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-17 18:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link"

Browse source
This commit is contained in:
jenkins-bot 2020-07-13 20:47:55 +00:00 committed by Gerrit Code Review
parent 84f473fe27 dd46c6f665
commit 3c62654c2f
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ui/mw.echo.ui.NotificationBadgeWidget.js
View file

@ -89,6 +89,7 @@
href: links.notifications, href: links.notifications,
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ] classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ]
} ); } );
allNotificationsButton.$element.children().first().removeAttr( 'role' );
preferencesButton = new OO.ui.ButtonWidget( { preferencesButton = new OO.ui.ButtonWidget( {
icon: 'settings', icon: 'settings',
@ -96,6 +97,7 @@
href: links.preferences, href: links.preferences,
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ] classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ]
} ); } );
preferencesButton.$element.children().first().removeAttr( 'role' );
footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( { footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( {
items: [ allNotificationsButton, preferencesButton ], items: [ allNotificationsButton, preferencesButton ],