From dd46c6f665622b3c25b2e5c16f11aa33615f13bd Mon Sep 17 00:00:00 2001 From: bkudiess-msft Date: Mon, 25 May 2020 13:12:53 -0700 Subject: [PATCH] NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link Bug: T253585 Change-Id: Icb1dfca98d0950e6beda91592c18c877f28214ac --- modules/ui/mw.echo.ui.NotificationBadgeWidget.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js index 500455086..131b8f785 100644 --- a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js +++ b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js @@ -89,6 +89,7 @@ href: links.notifications, classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ] } ); + allNotificationsButton.$element.children().first().removeAttr( 'role' ); preferencesButton = new OO.ui.ButtonWidget( { icon: 'settings', @@ -96,6 +97,7 @@ href: links.preferences, classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ] } ); + preferencesButton.$element.children().first().removeAttr( 'role' ); footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( { items: [ allNotificationsButton, preferencesButton ],