mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo
synced 2024-12-18 02:40:50 +00:00
Merge "NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link"
This commit is contained in:
commit
3c62654c2f
|
@ -89,6 +89,7 @@
|
||||||
href: links.notifications,
|
href: links.notifications,
|
||||||
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ]
|
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ]
|
||||||
} );
|
} );
|
||||||
|
allNotificationsButton.$element.children().first().removeAttr( 'role' );
|
||||||
|
|
||||||
preferencesButton = new OO.ui.ButtonWidget( {
|
preferencesButton = new OO.ui.ButtonWidget( {
|
||||||
icon: 'settings',
|
icon: 'settings',
|
||||||
|
@ -96,6 +97,7 @@
|
||||||
href: links.preferences,
|
href: links.preferences,
|
||||||
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ]
|
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ]
|
||||||
} );
|
} );
|
||||||
|
preferencesButton.$element.children().first().removeAttr( 'role' );
|
||||||
|
|
||||||
footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( {
|
footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( {
|
||||||
items: [ allNotificationsButton, preferencesButton ],
|
items: [ allNotificationsButton, preferencesButton ],
|
||||||
|
|
Loading…
Reference in a new issue