Merge "NotificationBadgeWidget: Removes role button from footer elements so screen reader announces it as link"

This commit is contained in:
jenkins-bot 2020-07-13 20:47:55 +00:00 committed by Gerrit Code Review
commit 3c62654c2f

View file

@ -89,6 +89,7 @@
href: links.notifications, href: links.notifications,
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ] classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-allnotifs' ]
} ); } );
allNotificationsButton.$element.children().first().removeAttr( 'role' );
preferencesButton = new OO.ui.ButtonWidget( { preferencesButton = new OO.ui.ButtonWidget( {
icon: 'settings', icon: 'settings',
@ -96,6 +97,7 @@
href: links.preferences, href: links.preferences,
classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ] classes: [ 'mw-echo-ui-notificationBadgeButtonPopupWidget-footer-preferences' ]
} ); } );
preferencesButton.$element.children().first().removeAttr( 'role' );
footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( { footerButtonGroupWidget = new OO.ui.ButtonGroupWidget( {
items: [ allNotificationsButton, preferencesButton ], items: [ allNotificationsButton, preferencesButton ],