wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-20 03:53:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
3527 commits 13 branches 4 tags 131 MiB
Commit graph

3527 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kosta Harlan 351891a063 overflow menu: Display menu next to comments on mobile 
Why:

- We want to provide contextual actions adjacent to comments, not just
  topic headings.

What:

- Consolidate the logic for embedding the overflow menu button HTML into
  a function, and add this for both topic and comment items.
- For this patch, this is done only for mobile; in a follow-up patch, we
  can add support for desktop
- This doesn't use a feature flag as 1) no one is implementing the
  DiscussionTools hook yet, 2) the 'edit' menu item is disabled at the
  comment level. Merging this change would be a no-op until an extension
  implements the DiscussionToolsAddOverflowMenuItemsHook.

Bug: T342251
Change-Id: I15a151f151e2fa04398876b559d93d45c42f6ef6
 2023-10-05 15:50:38 +01:00
Kosta Harlan c6c7dd2fb0 overflow menu: Add hooks for registering and interacting with items 
Why:

- We want to allow extensions to register interactive menu items in the
  overflow menu.

What:

- Create a PHP hook to allow extensions to provide menu items
  for rendering in the overflow menu
  - The hook allows for registering resource loader modules required by
    the menu item
  - The hook passes in some contextual information, like the thread
    item data, context source object, and if the page is editable
- Create a JS hook that fires when a user selects one of the menu items
- Example implementation: Ie9afbedb4f24cbd75eb48bb21dc9f6d8d732d853

Misc:

- Remove b/c code that existed to handle a transitional period where
  JSON encoded overflow menu data did not necessarily exist in the
  parser cache
- Rename code instances of ellipsis button / data / menu to refer to
  "overflow menu"
  - Some renames will have to wait until parser cache is updated; these
    are noted with TODOs

Bug: T342251
Change-Id: I5f2a51791f8ba7619d1399a4b93111e9bb44e172
 2023-10-05 15:50:33 +01:00
Ed Sanders 3b9128bdff Permalinks: Fix scroll restoration on mobile 
Change-Id: Icc60f089764a31f352fc89982d832653b7f14e07
 2023-10-05 14:13:55 +01:00
jenkins-bot f10e95fccb Merge "Permalinks: Factor out copyLink clipboard functionality" 2023-10-05 10:37:34 +00:00
jenkins-bot 4bd631a4e7 Merge "Factor out permalink code into separate file" 2023-10-05 10:33:38 +00:00
Ed Sanders d4819367aa Permalinks: Factor out copyLink clipboard functionality 
Change-Id: I8092e8f831b67a32b652a5cb88808f6e463d9b4c
 2023-10-05 11:04:01 +01:00
Ed Sanders 58cb277ced Factor out permalink code into separate file 
Change-Id: Ib56a0b9766529f517ae8c5f743f891b06f3cf690
 2023-10-05 10:55:00 +01:00
jenkins-bot c21ee0057f Merge "Fix mobile section expand icon size after changes in MobileFrontend" 2023-10-05 09:20:31 +00:00
Bartosz Dziewoński fe07a8914e Fix mobile section expand icon size after changes in MobileFrontend 
Reverts I0af2707141 due to I5ca0870862f5.

Change-Id: Ib9a0a38774b85b2b80fbac7a0d9b81b7045c9e59
 2023-10-05 09:15:00 +00:00
Translation updater bot f01ff88a79 Localisation updates from https://translatewiki.net. 
Change-Id: If3e0a39fce3e8020b4ed06ff90996c7092e87051
 2023-10-05 09:11:35 +02:00
David Lynch 2b3f430ad2 Mobile reply buttons were overlapping the expanded advanced options 
Follow-up to 5b6018b244 which put an
element between the advanced box and the actions wrapper. We can have
the rule use the subsequent sibling selector rather than direct sibling.

Bug: T348143
Change-Id: Ibe1b25bf15d320b17601a0d9471d4b7e6ca4ef19
 2023-10-04 10:20:45 -05:00
Translation updater bot 912a4b2245 Localisation updates from https://translatewiki.net. 
Change-Id: Iabb6c5d70e3743e547884d834c478c2ef01eddd1
 2023-10-04 09:08:02 +02:00
jenkins-bot 364cf45156 Merge "Permalinks: Don't prevent default when clicking links" 2023-10-03 14:50:29 +00:00
jenkins-bot a475754d68 Merge "Permalinks: Replace hard-coded notification with i18n string" 2023-10-03 14:49:01 +00:00
jenkins-bot 0e6ca97067 Merge "Show a hint for ctrl-enter for comment submission if just enter is used" 2023-10-03 14:41:11 +00:00
Ed Sanders d24ef5396a Permalinks: Don't prevent default when clicking links 
The gadget version doesn't do this, and we already have code
to prevent your scroll position from changing.

Allowing default rewrites the address bar and highlights the
copied comment.

Change-Id: I9aec2b2be7498a268d7b2eb3d2b4a4f76e658042
 2023-10-03 15:32:30 +01:00
Ed Sanders 8405305f2a Permalinks: Replace hard-coded notification with i18n string 
Change-Id: Id68006b67a055c32e2ecccdac94a37e03c0d722e
 2023-10-03 15:31:48 +01:00
David Lynch 5b6018b244 Show a hint for ctrl-enter for comment submission if just enter is used 
Bug: T326500
Change-Id: I7dc0e2ed7ccc101e896c18969b1f7d679150190b
 2023-10-03 09:04:59 -05:00
Translation updater bot c0bcceec3d Localisation updates from https://translatewiki.net. 
Change-Id: I58c58015a0372f168ed61cce1bef17769a74bf0c
 2023-10-03 09:32:31 +02:00
jenkins-bot 70c62667ce Merge "Turn comment timestamps into permalinks" 2023-10-02 21:06:09 +00:00
jenkins-bot 3d633a0717 Merge "HookUtils: Fix checking page props" 2023-10-02 16:22:11 +00:00
Bartosz Dziewoński 9fb16a40dc HookUtils: Fix checking page props 
Follow-up to b4def00ed0.

Bug: T347878
Change-Id: Ia834b0f8d5cf48fce85e83af48d9fdcc789fc8e2
 2023-10-02 16:59:57 +02:00
Ed Sanders b63884f561 Turn comment timestamps into permalinks 
Bug: T275729
Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
 2023-10-02 14:53:47 +01:00
Translation updater bot 906a4f1c36 Localisation updates from https://translatewiki.net. 
Change-Id: I612faa30fb4b483cce596eee9abe04c4c38b7150
 2023-10-02 10:57:12 +02:00
Translation updater bot 8da1d467d8 Localisation updates from https://translatewiki.net. 
Change-Id: Ia74015315f257723dd6b5bdde5d3ae2cf9ee77fa
 2023-09-27 09:20:04 +02:00
jenkins-bot 82bab7a4e6 Merge "Show new topics subscription button on history pages" 2023-09-26 17:40:55 +00:00
jenkins-bot ae2f2dcde8 Merge "topicsubscriptions.js: Factor out initNewTopicsSubscription and expose" 2023-09-26 17:40:54 +00:00
Translation updater bot 16ef89d96b Localisation updates from https://translatewiki.net. 
Change-Id: I9a43b85363c52f9ebeae638e4d7526052c4988c9
 2023-09-26 08:43:45 +02:00
jenkins-bot 5bd37d6e6d Merge "Fix visibility of preview of new topic on mobile" 2023-09-25 18:22:59 +00:00
Ed Sanders a77fd29c67 Fix visibility of preview of new topic on mobile 
Bug: T335220
Change-Id: I048e73c7579d822c28e9c648c26401c00b2c471b
 2023-09-25 18:17:15 +00:00
Translation updater bot 3d5f4b7953 Localisation updates from https://translatewiki.net. 
Change-Id: I032ae6ab8310e18ce3c379ebaafa6926b4e248c7
 2023-09-25 08:46:10 +02:00
jenkins-bot e0b34b46d8 Merge "HookUtils: Fetch all needed props in one query" 2023-09-24 00:12:58 +00:00
Bartosz Dziewoński b4def00ed0 HookUtils: Fetch all needed props in one query 
Bug: T347123
Change-Id: I54e5dfeb8ee07f0c3b6df4bffd2c6112cc1ad145
 2023-09-23 06:35:49 +02:00
jenkins-bot e886923d4a Merge "Action::getPageTitle() should return a Message" 2023-09-22 07:09:07 +00:00
jenkins-bot 9db3ebb3e0 Merge "SpecialPage::getDescription() should return a Message" 2023-09-22 07:08:22 +00:00
Translation updater bot 584b0fb620 Localisation updates from https://translatewiki.net. 
Change-Id: I1450870dc40cf3d700775e453894c9cc5cdd9125
 2023-09-22 08:46:46 +02:00
Bartosz Dziewoński 19fa706693 Action::getPageTitle() should return a Message 
Bug: T343994
Change-Id: Ice968d8a5651a21260b9389526b4f7694b3deca8
 2023-09-21 22:17:15 +02:00
Bartosz Dziewoński e825084546 SpecialPage::getDescription() should return a Message 
Bug: T343994
Change-Id: I9902a7f0c2c74c34a887e4429f1de857bd087d28
 2023-09-21 22:10:57 +02:00
Translation updater bot 7a1337e430 Localisation updates from https://translatewiki.net. 
Change-Id: If6bc6ad58c1a7e527c6bbb000e70148f4d1055e1
 2023-09-21 10:15:40 +02:00
Bartosz Dziewoński 97dbe19a34 ThreadItemStore: Fix rows with itr_items_id=0 corrupted by T339882 
In T339882 we thought that these rows are harmless, but for the
specific case of itr_items_id that's not true.

Bug: T343859
Change-Id: Iebfa583d7d4b00a59291f91ec84c41241d5469d4
 2023-09-21 03:51:48 +02:00
Translation updater bot e59761b8e2 Localisation updates from https://translatewiki.net. 
Change-Id: I5667b562f9aee1a6e1cd2333a0743ffbf620a7d5
 2023-09-20 08:54:58 +02:00
Translation updater bot 713932e296 Localisation updates from https://translatewiki.net. 
Change-Id: I3a4122506556717de78038b606e1bfc8af1f1b1d
 2023-09-19 09:25:22 +02:00
jenkins-bot 50811cf28c Merge "Fix interaction of "Add topic" button with categories" 2023-09-18 16:42:35 +00:00
Translation updater bot 080616dffd Localisation updates from https://translatewiki.net. 
Change-Id: Ib438fcc78562df548ff03a1c5eb365cc09d9a157
 2023-09-18 08:42:57 +02:00
Bartosz Dziewoński 0c1ec851bf Fix interaction of "Add topic" button with categories 
For real this time. I hope.

Follow-up to 52de4b0b1b.

Bug: T335219
Change-Id: I0f073cf660f221c1e996f7f46d161316e0b0b79e
 2023-09-17 23:49:14 +02:00
Ed Sanders 2aafd08c4b Require CTRL+Enter to submit a comment, regardless of the input 
Bug: T326500
Depends-On: I408adfe2b04f0d0a3e819e615e0db91c85997a9c
Change-Id: I5a4c482348b5e7dd9a4780bc4aedd8253a82ca72
 2023-09-17 20:18:05 +00:00
Bartosz Dziewoński 6b633803c8 ThreadItemStore: Add details to row insertion exceptions 
Bug: T343859
Change-Id: Ic0d741c192f42a3bd54276259820f25edcb0705b
 2023-09-14 19:05:04 +00:00
jenkins-bot d315c901f2 Merge "SubscriptionStore: Tweak comment to fix Gerrit syntax highlighting" 2023-09-14 16:19:42 +00:00
Bartosz Dziewoński 70ff6fa463 SubscriptionStore: Tweak comment to fix Gerrit syntax highlighting 
For some reason this apostrophe is treated like the start of a string
by Gerrit's syntax highlighting, messing up the whole file. It annoys
me very much.

Change-Id: Ie1ce88eefda6ae2a8a73237556affba4cbc6db4b
 2023-09-14 17:58:16 +02:00
Translation updater bot 73bd70c9df Localisation updates from https://translatewiki.net. 
Change-Id: Iac3317d9daa28545c56fc8156cf546c95d5aac28
 2023-09-14 09:29:37 +02:00