wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-18 11:02:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
3985 commits 13 branches 4 tags 131 MiB
Commit graph

3985 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 6a1f2accee Parser: Minor code cleanup 
We had some unused variables and roundabout checks.

Change-Id: I454b60ffa05c1cc12288c5de88c849a25aa35447
 2024-02-08 16:59:04 +01:00
Bartosz Dziewoński f4090865d4 Add test cases for the main loop getting stuck on some signatures 
Follow-up to 9db35873a4.

Bug: T356884
Change-Id: Ifef490209fdee2b9f52d3ef81a92ea20c5ff2155
 2024-02-08 16:59:01 +01:00
Translation updater bot ddba94eb88 Localisation updates from https://translatewiki.net. 
Change-Id: I98c45b2a474188dbc1dc088fbf62100b920beb88
 2024-02-08 09:15:03 +01:00
jenkins-bot 297f4f01dd Merge "Parser: Fix the main loop getting stuck on some signatures" 2024-02-07 22:01:56 +00:00
jenkins-bot c1049da7d5 Merge "Use Parsoid HTML to drive notifications" 2024-02-07 21:36:56 +00:00
Bartosz Dziewoński 9db35873a4 Parser: Fix the main loop getting stuck on some signatures 
In certain cases the parser could go back rather than forward after
finding a signature, causing it to find the same signature forever
until it ran out of memory.

Test cases coming later in a separate patch.

Bug: T356884
Change-Id: I8ac72b05e5e4ed45e6119c012a69708c9d8eda29
 2024-02-07 22:33:57 +01:00
Translation updater bot f9fb45a455 Localisation updates from https://translatewiki.net. 
Change-Id: Ia1507f94f836a987298444ed9be072a9d5b97927
 2024-02-07 08:26:43 +01:00
jenkins-bot 6816c15a03 Merge "Fix exceptions on weirdly encoded URLs" 2024-02-05 22:22:02 +00:00
jenkins-bot 4c2442eeb6 Merge "Ignore transcluded items when finding permalinks" 2024-02-05 21:46:08 +00:00
jenkins-bot e4e8cab1da Merge "Fix unexpected margin on footer links in new topic tool" 2024-02-05 17:20:35 +00:00
Translation updater bot f608a94941 Localisation updates from https://translatewiki.net. 
Change-Id: I9cfd8d819d5590e1c85cd6c71efb5be973dc7be9
 2024-02-05 08:49:36 +01:00
Bartosz Dziewoński 3957d7ac25 Fix collapsed sections when recovering autosave on mobile, take 2 
Follow-up to 8a8c7270cf.

I think this wasn't working becase we were doing it in the wrong
order (reply tool initialization would disable toggling section
state before toggler toggled it open).

Bug: T338920
Change-Id: I7ed3d5c149ddb3d33cb67010f032c63e175687f2
 2024-02-04 00:21:45 +01:00
Bartosz Dziewoński f7a8ba08fb Ignore transcluded items when finding permalinks 
* Keep the information about this in the API result, which we were
  previously omitting
* Use it instead of duplicating the logic client-side

Bug: T356131
Change-Id: I7e7342e9d94a171b5ef56e646871c18c8c39c44c
 2024-02-04 00:07:37 +01:00
Bartosz Dziewoński 1bb3b597ec Fix exceptions on weirdly encoded URLs 
`decodeURI( fragment )` can throw if the fragment isn't correctly
encoded – e.g. when it's just '#%'.

Use mw.util.percentDecodeFragment() instead, which uses a more
resilient algorithm.

Change-Id: I8447771ad2ae33da52b71d4127981dd8a2018a7d
 2024-02-03 23:48:54 +01:00
Bartosz Dziewoński d0c72f155a Fix unexpected margin on footer links in new topic tool 
The new topic tool is not nested in .mw-content-ltr/-rtl,
so the rule did not apply.

Change-Id: If231170f7ab394be075d4d936b8be4c8ae97931c
 2024-02-03 23:37:21 +01:00
Bartosz Dziewoński 0f6bdcf9cb Add first basic tests for ThreadItemStore::find*() methods 
Just covering the basic scenarios of having comments on the page and
archiving them.

Bug: T356575
Change-Id: I9022b0a7cf3b02bd9f2f2d5605823eec21b92642
 2024-02-03 23:14:08 +01:00
jenkins-bot 9f650c92ee Merge "Add more search methods to findNewestRevisionsByHeading" 2024-02-03 21:47:55 +00:00
Ed Sanders df7d101cd2 Use decodeURI for comment ID searches as well as heading searches 
Bug: T356199
Change-Id: I8d366c706692caf89a2af9f11c14a9aad9422b7c
 2024-02-02 17:34:26 +00:00
Translation updater bot 6feddf4938 Localisation updates from https://translatewiki.net. 
Change-Id: I2346f70e62b7c62d4d38ec4afd83631760dd0599
 2024-02-02 08:53:19 +01:00
Ed Sanders 8b99c1fbbe Add more search methods to findNewestRevisionsByHeading 
In production, indexing the full history of every page will take
too long, so we can't rely on being able to find the target heading
text in the history of the current page.

When this search fails, fall back to the following searches:
* The heading appears in the current revision of a sub-page
* The heading appears anywhere on the wiki, but only once

Bug: T356276
Change-Id: I90e92cb9c85aaf6fb2355f842450981bbe6abf2d
 2024-02-01 18:32:36 +00:00
Translation updater bot 4bb3ae7d1f Localisation updates from https://translatewiki.net. 
Change-Id: Id0a4cfbe24def17ad1bf866655a1472e47ef3a41
 2024-02-01 09:01:39 +01:00
Translation updater bot 6408fe3a41 Localisation updates from https://translatewiki.net. 
Change-Id: Ie3796fb8ba5676d97c7e0f82ff0efa0d30c82e63
 2024-01-31 08:28:59 +01:00
David Lynch 7b941aae1c Add an exception for ConvenientDiscussions-style permalinks 
Bug: T349653
Change-Id: I775774084bb8abf2bc99475b426d581bed306306
 2024-01-30 16:44:30 -06:00
David Lynch c4bbf8756a decodeURI fragments before sending them to discussiontoolsfindcomment 
Section titles containing non-ASCII characters were being passed through
URL-encoded, resulting in no results being found.

Bug: T356199
Change-Id: Iac56ee434a37baf3d170aec992d2f2d8679b6f1f
 2024-01-30 14:14:18 -06:00
Ed Sanders 8069585489 CommentParser: Ignore generated timestamp links 
This will be present in parser cache output and can
sometimes be mistaken for user page links.

Bug: T356142
Change-Id: I800b23d8466f72affcadfa336aab07abf7f8d79e
 2024-01-30 10:29:36 +00:00
Translation updater bot 150736016b Localisation updates from https://translatewiki.net. 
Change-Id: Ia9a84ce398a630d8f0c9354e20a99f5b6e83abeb
 2024-01-30 09:38:57 +01:00
Translation updater bot 83d8cd4aea Localisation updates from https://translatewiki.net. 
Change-Id: I29f301a8f72ef1501c364ca30ca061f3f9eef232
 2024-01-28 16:06:15 +01:00
David Lynch 87c8a26483 Require is still required to load CommentTarget 
Follow-up to d647870dca.

Change-Id: I63dbedbbd156a8b1619849170eac9dc6da262ddd
 2024-01-23 14:58:23 -06:00
Ed Sanders d647870dca Use ve.init.mw.targetFactory.create() 
Change-Id: Ie30d813ba933e03e9c712f78eac155a41052d4b0
 2024-01-23 19:42:10 +00:00
Umherirrender 94a5c86ceb Stop writing to tablesUsed in tests 
Bug: T351733
Change-Id: I4e8feb7f60b45bb7fe5259d72ee29d964caefdfd
 2024-01-20 12:27:39 +01:00
Translation updater bot 443653e521 Localisation updates from https://translatewiki.net. 
Change-Id: I18c4b24f4b0c5c3d8e40ab8878a1677112d3020a
 2024-01-19 09:16:45 +01:00
C. Scott Ananian e2fbc0704c Remove TemporaryParsoidHandlerParserCacheWriteRatio hack 
This was originally supposed to be released before MW 1.40.

Bug: T355375
Change-Id: I9cf0631ebb25db5ad7cf1c3c1011fc40c33c9891
 2024-01-18 19:23:36 -05:00
C. Scott Ananian e2c9ca37b0 Use Parsoid HTML to drive notifications 
This reuses the existing comment parser code in HookUtils and makes the
DataUpdatesHooks and EventDispatcher code consistent.

Bug: T354792
Change-Id: I58a71b26b3f47898a68a29098a8105ee844403dd
 2024-01-18 19:23:13 -05:00
Translation updater bot 99bae67a4b Localisation updates from https://translatewiki.net. 
Change-Id: Ie14b988d0ac50d7eb246f0431b6f3638a04c46bf
 2024-01-18 09:25:15 +01:00
jenkins-bot 184cd048f1 Merge "Refactor CommentFormatter->addTopicContainer()" 2024-01-18 01:16:07 +00:00
jenkins-bot 55daf9b617 Merge "Re-enable: "Temporarily disable isPreview in Parsoid's rendering""" 2024-01-17 19:47:11 +00:00
jenkins-bot 095502a73e Merge "Comment-not-found toast not showing when enablePermalinksFrontend==false" 2024-01-17 19:45:20 +00:00
Subramanya Sastry 3f2f5dd237 Re-enable: "Temporarily disable isPreview in Parsoid's rendering"" 
This reverts commit 1cf6000d18.

Reason for revert: Want to do another round of visual diff testing
on wikitech as an anonymous user. Will revert this after test is done.

Change-Id: Ic3facb7ecd9c932be348d47d6a38cff71cd7e1db
 2024-01-17 18:02:16 +00:00
Translation updater bot 73bb8f997b Localisation updates from https://translatewiki.net. 
Change-Id: I87fc32b3ab8d91f04ac96f4b4df711242c51cc11
 2024-01-17 08:37:10 +01:00
David Lynch d74eccad34 Comment-not-found toast not showing when enablePermalinksFrontend==false 
results[ 0 ] would be undefined, causing a later JS error before the
toast could be shown.

Bug: T355165
Change-Id: Ia591a1e4db0acfa377201c355938a32f680393ce
 2024-01-16 11:13:18 -06:00
Translation updater bot e2b0ebe4ee Localisation updates from https://translatewiki.net. 
Change-Id: I353ed0624d0eacdce616bec6adc39bfc82831b45
 2024-01-16 08:25:34 +01:00
Translation updater bot b754509c8d Localisation updates from https://translatewiki.net. 
Change-Id: Id01adbf082130a48fb2860550664c6d01a2fcf6c
 2024-01-15 08:24:13 +01:00
James D. Forrester e0fa5168fa extension.json: Drop RL targets definitions, no longer honoured 
Bug: T328497
Change-Id: I0b6639e6e08373c5425a8035761d9a0b73e0e7d7
 2024-01-12 08:44:20 -05:00
Translation updater bot 9467f10ed8 Localisation updates from https://translatewiki.net. 
Change-Id: Iceabbd2c07cb2be4af29bd2939ce8505f640c703
 2024-01-12 09:00:06 +01:00
Ed Sanders c076f170c4 Update TODO documentation around parsing 
Change-Id: I14fb4874fdc3e97418b5f41665334e122c17d862
 2024-01-10 18:29:40 +00:00
Translation updater bot 317b293b3d Localisation updates from https://translatewiki.net. 
Change-Id: I0a2fa0bb3ea449822742fd7e32ee912a1908c7f0
 2024-01-10 08:32:46 +01:00
Translation updater bot 8863c80f91 Localisation updates from https://translatewiki.net. 
Change-Id: Ie52085f12002555ad6c59695e25fc40092430cea
 2024-01-09 08:59:28 +01:00
jenkins-bot 91c5151575 Merge "controller: Use replyWidgetPromise when opening new topic tool" 2024-01-08 21:15:24 +00:00
jenkins-bot 088a4c9d43 Merge "CommentController/ReplyWidget: Document events" 2024-01-08 21:15:23 +00:00
jenkins-bot 1f0a6b9f80 Merge "CommentController#showAndFocus: Use replyWidgetPromise" 2024-01-08 20:50:45 +00:00