wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-26 14:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
3563 commits 13 branches 4 tags 132 MiB
Commit graph

3563 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 91e1bb15cc Use Sanitizer::stripAllTags() when generating notification snippets 
It adds white-space between block tags and strips invisible tags.

It may be slightly slower (it takes HTML as input rather than DOM, so
we need to serialize the HTML first and then call it, rather than only
find and concatenate text nodes), but the difference is negligible,
and it seems better to use this method than to try to re-implement it.

Test runtime went from ~9.0s to ~9.5s locally, when testing using:
  php tests/phpunit/phpunit.php \
  extensions/DiscussionTools/tests/phpunit/ThreadItemTest.php \
  --filter getText

Bug: T219138
Change-Id: I0cb89ebd2160e1ef499b78573c6688f493a4c42f
 2022-02-10 22:23:24 +01:00
Translation updater bot 92e3a5bb42 Localisation updates from https://translatewiki.net. 
Change-Id: I1acdee01d5cfe2b22f99c73df8068f86a1f3529d
 2022-02-10 08:41:31 +01:00
jenkins-bot 8bcaf75372 Merge "Replace use of deprecated OutputPage::enableClientCache( false )" 2022-02-10 07:01:26 +00:00
Bartosz Dziewoński 4ff65cf5e2 Update references to warningbox class 
Bug: T301401
Depends-On: I632e42ee9065b38dca443beae1cb01ef714cae7b
Depends-On: I7a7046bf9b9765cbb82ec3caa1530de7f05e0da4
Change-Id: Ia42cf9cd5b63cfe679bdf90bfcbf528f14f9ebcc
 2022-02-09 21:36:50 +01:00
jenkins-bot 548c0d12c9 Merge "build: Update eslint-config-wikimedia to 0.22.1" 2022-02-09 15:38:41 +00:00
jenkins-bot aa64257169 Merge "Don't refer to non-existent fields when using 'hide-if'" 2022-02-09 15:37:30 +00:00
Bartosz Dziewoński 8b6ffc945f Don't refer to non-existent fields when using 'hide-if' 
Bug: T301317
Change-Id: I40577b41e0c957281a45b71802808ec535b65653
 2022-02-09 15:38:47 +01:00
Ed Sanders f0940557ee build: Update eslint-config-wikimedia to 0.22.1 
Change-Id: I18a5ceae9e8fdc6398cd27c24c1a97fe87e3c016
 2022-02-09 13:50:55 +00:00
Translation updater bot a88dafba19 Localisation updates from https://translatewiki.net. 
Change-Id: I4e4ceaed5a09c6713c4669aba7a054dfc5113db9
 2022-02-09 08:12:45 +01:00
jenkins-bot 9b2b887675 Merge "ThreadItem: Use DOMUtils to get HTML of DocumentFragment" 2022-02-09 00:53:43 +00:00
Ed Sanders 16c24d6f0a ThreadItem: Use DOMUtils to get HTML of DocumentFragment 
This fixes a warning this was thrown when the fragment
was empty (e.g. a placeholder heading).

Change-Id: I5d44993014280b210f48be6be8db0c58ab8e0352
 2022-02-08 23:51:38 +00:00
jenkins-bot 362206e572 Merge "Improve check for HTML comments after multiple line breaks" 2022-02-08 20:17:26 +00:00
jenkins-bot e8e9ba5f98 Merge "Fix some typos in comments" 2022-02-08 20:00:11 +00:00
jenkins-bot 4593a9fe91 Merge "Don't count leading/trailing whitespace against signature scan limit" 2022-02-08 20:00:08 +00:00
jenkins-bot e82a4d86f3 Merge "Don't clear target comment highlight when Ctrl-clicking" 2022-02-08 19:49:44 +00:00
Ed Sanders aa03dc971e Add discussiontoolscompare API 
For two given revisions, this API tells us which comments have
been added and which have been removed.

Can be used to highlight new comments, or check if the page
has been updated since we first loaded it.

Bug: T281624
Bug: T300504
Change-Id: Ia4d95ffe3b7cf2317cd8e7c0f034e09f64777ef3
 2022-02-08 15:53:27 +00:00
Translation updater bot f8c7887adf Localisation updates from https://translatewiki.net. 
Change-Id: I4baeb2087e91695285486af51734ac759eb88d59
 2022-02-08 08:28:29 +01:00
Bartosz Dziewoński fa01395acc Improve check for HTML comments after multiple line breaks 
In the example in T301214, there is a space character between the line
breaks.

Bug: T301214
Change-Id: Ia1a8279ba0c60f92c1a30463c2a39d9e954ae3ca
 2022-02-08 01:38:56 +01:00
Ed Sanders 025130fcd2 Don't prompt to reload the page if the reply widget is open 
Only show the reload prompt if the 'disappeared' error is detected
when the reply widget is loading. Don't show it if we failed
to save, as it suggests you will not lose content if you reload.

Change-Id: I106f274e180dc97b540d729e31aae575c43f29f0
 2022-02-07 22:45:35 +00:00
Ed Sanders 3d0849112a ReplyWidget: Factor out #createErrorMessage 
Change-Id: Ie7e34154d74c24ce8379552fdf13feba31fd401f
 2022-02-07 22:44:09 +00:00
jenkins-bot 4ac8e94084 Merge "ReplyWidget: Introduce a 'refresh' teardown mode that preserves auto-save" 2022-02-07 21:45:13 +00:00
Bartosz Dziewoński 909f1383d4 Don't clear target comment highlight when Ctrl-clicking 
It annoys me when Ctrl-click clears it but middle-click does not.

Change-Id: I8636140df25d44ac79cb2bc0d1aebecc62c4db5d
 2022-02-07 21:29:01 +00:00
jenkins-bot 6a23be0bb5 Merge "Move ApiDiscussionTools to ApiDiscussionToolsPageInfo" 2022-02-07 20:43:26 +00:00
jenkins-bot 283aa46865 Merge "extension.json: Sort ApiModules" 2022-02-07 20:43:24 +00:00
Ed Sanders 7cad692afa Move ApiDiscussionTools to ApiDiscussionToolsPageInfo 
Also remove 'paction' param, and instead make 'transcludedFrom' a
property of the result object.

Change-Id: I0a289f6d71e4708afff0b52066b1ed6faf76b9ae
 2022-02-07 16:50:02 +00:00
Ed Sanders ee2749d34a extension.json: Sort ApiModules 
Change-Id: I0fea49bd7f86dd6ca48fb1960e47c62abeaf41aa
 2022-02-07 16:49:40 +00:00
Translation updater bot 413b7bd487 Localisation updates from https://translatewiki.net. 
Change-Id: I0ad51f8f4a6c5501a5def55689fbcd5622031dac
 2022-02-07 08:21:57 +01:00
libraryupgrader faab80cd8d build: Updating nanoid to 3.2.0 
* https://github.com/advisories/GHSA-qrpm-p2h7-hrv2

Change-Id: I397685f0d9b0f77fcfd6f9f9524136d718870320
 2022-02-06 09:18:30 +00:00
jenkins-bot c86029397e Merge "Remove DiscussionToolsEnableTopicSubscriptionBackend config" 2022-02-05 00:49:17 +00:00
Bartosz Dziewoński 5945a4a0eb Fix some typos in comments 
Change-Id: I699d9d105b8706cef0800ccc086cde687de54078
 2022-02-04 20:36:28 +01:00
Bartosz Dziewoński 13ab1db6da Don't count leading/trailing whitespace against signature scan limit 
It's an arbitrary limit, it seems harmless to relax it to support the
use case in the task, even if it's weird.

Bug: T300949
Change-Id: I7c895c7019726758bbae3183b9c3ecbd9eabcf38
 2022-02-04 19:35:29 +00:00
Ed Sanders 0b42aea276 CommentParser: Cache variables in getUsernameFromLink 
Change-Id: I625e6ded3badd75a7a658c8d000576d0d165a18b
 2022-02-04 19:35:18 +00:00
Ed Sanders 8ad1df7dc8 CommentParser: Name parts of return value from findSignature 
Change-Id: I3a5ad36df0afdedc0aa9a15e5d83c5426b03b790
 2022-02-04 19:34:18 +00:00
C. Scott Ananian fe35a7324c Replace use of deprecated OutputPage::enableClientCache( false ) 
Replaced with the more readable ::disableClientCache() method, added
in 1.38.  Minimum MW version for this extension is already at 1.38.

Depends-On: I7c89e20528a0d91173f0edcb997dcae631935ee5
Change-Id: Idf1cf2fac3311f50ed3cbc420f7772b5c71b1992
 2022-02-04 14:30:33 -05:00
Ed Sanders 6d655dee0a Remove DiscussionToolsEnableTopicSubscriptionBackend config 
This is now deployed on all wikis, and going forward I don't think
we need to make this configurable.

Change-Id: I231976267ba6cdfeec622efaa15983a84c330649
 2022-02-04 18:22:10 +00:00
jenkins-bot 37c09cd3ac Merge "Improve CommentModifier::addReply() API for re-use and testing" 2022-02-04 18:12:59 +00:00
Translation updater bot c1160b0dae Localisation updates from https://translatewiki.net. 
Change-Id: I4bcd77c31de2fb44c441ee3796eb1125b7b2a3a9
 2022-02-04 08:22:02 +01:00
Bartosz Dziewoński 165ca9b847 Improve CommentModifier::addReply() API for re-use and testing 
Goal: To be able to re-use or test the transformations we previously
  performed in addWikitextReply() / addHtmlReply(), without requiring
  a Comment object or adding the result as a reply.

Change-Id: I040c4be9b6b9bddba661f30fd0566f8850673074
 2022-02-03 21:12:48 +00:00
Translation updater bot 14b28f6483 Localisation updates from https://translatewiki.net. 
Change-Id: Ibfe6f2196800dfe948dedad2df52571147cf02f4
 2022-02-03 08:43:56 +01:00
Ed Sanders e2f3c2f264 ReplyWidget: Introduce a 'refresh' teardown mode that preserves auto-save 
Change-Id: Ibb04f7c2813b9d3cf2bb2434a414c86eb0a7f644
 2022-02-02 18:38:22 +00:00
jenkins-bot b0b965512e Merge "Create MemoryStorage wrapper around mw.SafeStorage" 2022-02-02 17:27:37 +00:00
jenkins-bot fabe580343 Merge "Limit where whitespaceParsoidHack() is used" 2022-02-02 17:25:02 +00:00
jenkins-bot fef06b195e Merge "Remove empty lines in visual mode in some more cases" 2022-02-02 17:23:07 +00:00
jenkins-bot 11892a9369 Merge "Remove unused code in JS modifier" 2022-02-02 17:21:37 +00:00
Ed Sanders 9e43f5c261 ReplyWidgetVisual: Fully clear sessionStorage when clearing 
Clearing the widget removes all the surfaces, meaning there are
no doc-state variables to cleanup. Switch the order of these
two calls.

Change-Id: I6c095a171096cd700ce4cd31b08fa3b982ab2401
 2022-02-02 16:46:57 +00:00
Ed Sanders cb5d585b93 Update wgCurRevisionId/wgRevisionId when refreshing the page 
Change-Id: I2b1a7a6fe539a8a4bd5e3f865e4bb7464913d9e0
 2022-02-02 16:46:57 +00:00
Ed Sanders dd9d37b555 Create MemoryStorage wrapper around mw.SafeStorage 
This means we can guarantee we will be able to recover
auto-saves if we don't reload the page.

Change-Id: Ic867ae6df0c949f35cb32ec4b835688778db29ef
 2022-02-02 14:59:47 +00:00
Bartosz Dziewoński fb474efb2b controller: Separate updating page contents from saving the page 
Bug: T300502
Change-Id: I52c0a648ee15cc61890413a269708a6cb2bd4df8
 2022-02-02 00:42:41 +01:00
Ed Sanders 7381d9d963 Cleanup CommentController and document 
* Document all methods
* Rename comment to threadItem
* Use this.threadItem instead of passing in identical
  threadItem in various methods.
* Don't pass threadItem to ReplyWidget as we already
  pass the whole CommentController.

Change-Id: If9aad0bcf9f0e4ebf3342b75631ddac8b57f7d87
 2022-02-02 00:05:19 +01:00
Translation updater bot dd9b3d517e Localisation updates from https://translatewiki.net. 
Change-Id: Ifae61fbc15016e3947fdf6d7da05c227ea066b83
 2022-02-01 08:26:56 +01:00