Commit graph

762 commits

Author SHA1 Message Date
DLynch aab80e8641 Merge "Log when the advanced mode panel is toggled" 2020-09-14 22:39:32 +00:00
jenkins-bot c02f54a848 Merge "Edit summary in advanced mode" 2020-09-14 22:29:59 +00:00
David Lynch 5b20503ec2 Log when the advanced mode panel is toggled
Bug: T261816
Change-Id: Iadd17b4f5280fc09d7a16a64bb709bab1a1a09d5
2020-09-14 22:14:40 +00:00
Ed Sanders ebaa132ebf Edit summary in advanced mode
Bug: T249391
Change-Id: Ibfd1cf77293d30b8e0d9869bbdc9aae2aa830a06
2020-09-14 22:29:54 +01:00
Translation updater bot ba64993927 Localisation updates from https://translatewiki.net.
Change-Id: I728a319eb4d188489499ad2807b57fa971d3a63d
2020-09-14 09:14:09 +02:00
jenkins-bot 97e8935ce6 Merge "Create preference for turning off reply tool once out of beta" 2020-09-12 19:18:26 +00:00
Ed Sanders 38b5a9c0fe Create preference for turning off reply tool once out of beta
Bug: T259943
Depends-On: I75d38560a649794effbfc07cab1de0cc2e18f57b
Change-Id: Iec472bddd92e821d924a18db1734e8da6188b3dd
2020-09-11 22:16:57 +00:00
jenkins-bot fa2ee6cfe6 Merge "Skip over whitespace when looking for trailing comments" 2020-09-11 18:46:17 +00:00
Bartosz Dziewoński 34fb7c6497 utils: Avoid Node#contains for IE 11 support
Bug: T260061
Change-Id: Ifd1e9067ab16a65349a460e935bb95f5895432db
2020-09-11 18:06:44 +00:00
Ed Sanders d4f67918b2 Skip over whitespace when looking for trailing comments
Bug: T257651
Change-Id: Icce377f1833b80bd066622d6be3e711a18c58eea
2020-09-11 15:37:09 +01:00
Translation updater bot 5c41597eb5 Localisation updates from https://translatewiki.net.
Change-Id: I8597ba6ffb19a0946b199142be5adf7010742dfe
2020-09-11 09:39:43 +02:00
jenkins-bot f98e7a32a1 Merge "Add "Advanced" & "Comment summary" messages for upcoming feature" 2020-09-10 23:08:16 +00:00
Ed Sanders c439b3c356 Add "Advanced" & "Comment summary" messages for upcoming feature
Will be used in Ibfd1cf77.

Change-Id: Iff03f40c2cf5ad991db7e303343129e54326661e
2020-09-10 19:30:59 +01:00
Ed Sanders f96678d562 Factor out availability check
Change-Id: Ibc3e43ea50b7a38cf36f3ee2e479701d4489182e
2020-09-10 15:25:49 +01:00
jenkins-bot 4940a9431f Merge "Use Language::formatNumNoSeparators where appropriate" 2020-09-10 09:00:00 +00:00
Translation updater bot bb734e92c8 Localisation updates from https://translatewiki.net.
Change-Id: I4666f1b5d3bfad00ebacaa1c0e3e841d5d59a449
2020-09-10 09:49:18 +02:00
C. Scott Ananian 965f317015 Use Language::formatNumNoSeparators where appropriate
Avoids using the deprecated $noSeparators parameter to Language::formatNum
in favor of Language::formatNumNoSeparators, which has been around since
MW 1.21.

Change-Id: I012434d5f6c749fec45a6c160e8d5d03686192e9
2020-09-09 18:15:08 -04:00
Bartosz Dziewoński a59dee8ec2 Fix 'discussiontoolsedit' API module description
The text of this message looks like a description for a 'summary'
parameter for the API (which doesn't exist, and if it did, we'd reuse
the message from core anyway). It's supposed to contain an overall
summary/description of the whole module.

Change-Id: I110d0ac6cd6fa9c2dc171615cbf1cd9629452d5a
2020-09-09 23:06:38 +02:00
Ed Sanders 2cc39f2b84 Add topic API
Bug: T259563
Change-Id: I93bb93c272f9b30df81f7f978a3952ca1d027fec
2020-09-09 20:26:41 +00:00
Ed Sanders ebe2071dfd Upstream setPending to ReplyWidget
Now consistently uses setReadOnly instead of setDisabled.

Slight styling regression was fixed in I01e11c2ed.

Change-Id: Ice7ce00929ff9a53d0fb533f1094e7324749f3a4
2020-09-09 19:23:34 +00:00
Translation updater bot 0ab29656b6 Localisation updates from https://translatewiki.net.
Change-Id: I79fb7660e898f47f71362bb2a8dbcb8fb31a1286
2020-09-09 09:54:28 +02:00
jenkins-bot 8736184d0b Merge "Match handling of "signature scan limit" between JS and PHP" 2020-09-08 11:09:34 +00:00
Translation updater bot fe8b9ec946 Localisation updates from https://translatewiki.net.
Change-Id: Icd04de603290ba820db353763e3fddf7d9d4c299
2020-09-08 10:24:02 +02:00
Bartosz Dziewoński 14fb013515 Match handling of "signature scan limit" between JS and PHP
PHP was counting UTF-8 bytes, JS was counting UTF-16 bytes.
Both should have been counting codepoints (although it doesn't
really matter as long as they both count the same things).

I noticed the issue after adding some tests using the Cyrillic
script, when one case had different results in PHP and JS:
Id25b537fecd789640c209ff7f30e777455a3aece.

Change-Id: Ic31240678f71ba48e6ec202126bf490cea12bb66
2020-09-08 03:27:01 +02:00
Translation updater bot 2ce305fcd0 Localisation updates from https://translatewiki.net.
Change-Id: I41e4d2cbd947dfa9093e1e73a49831966ed597cc
2020-09-06 20:55:30 +02:00
Translation updater bot 0af73e0e3f Localisation updates from https://translatewiki.net.
Change-Id: I069570b20447862c2cab1238699d3bd11c129ce9
2020-09-04 09:26:18 +02:00
jenkins-bot 37e6f64503 Merge "Improve error message for edit conflict" 2020-09-02 16:07:37 +00:00
Translation updater bot 8e96131491 Localisation updates from https://translatewiki.net.
Change-Id: Ie35073d495b233a3c79061f37b352c5b48b81617
2020-09-02 09:40:19 +02:00
Bartosz Dziewoński ff05e0c0b5 Improve error message for edit conflict
Bug: T261788
Change-Id: I079517ad6e258dd23b9048f4133f18cbb087acd9
2020-09-01 22:33:25 +02:00
jenkins-bot 48336f66b3 Merge "Add integration tests using pages from ckb.wp" 2020-09-01 17:17:33 +00:00
jenkins-bot 00b4f2217a Merge "Improve and document the files in tests/data/" 2020-09-01 17:17:10 +00:00
jenkins-bot 8bf420e869 Merge "Fix parsing localised digits in PHP discussion parser" 2020-09-01 17:16:29 +00:00
jenkins-bot 7e069cdb00 Merge "Update watchlist status from API result" 2020-09-01 00:29:03 +00:00
Bartosz Dziewoński 934872a170 Add integration tests using pages from ckb.wp
This is primarily to cover the handling of localised digits,
which previously wasn't being tested, leading to T261706.

Bug: T261706
Change-Id: I9de7f01f77e767e9048c85604b559af4bca0de91
2020-09-01 01:50:33 +02:00
Bartosz Dziewoński 084f45128c Improve and document the files in tests/data/
* Remove 'wgMetaNamespace' and 'wgMetaNamespaceTalk', the same data
  exists in 'wgFormattedNamespaces'.

* Rename 'wgContentLang' to 'wgContentLanguage', to match its real
  name in JS config. MediaWiki doesn't use 'wgContentLang' anywhere,
  although the related PHP global is called $wgContLang.

* Document how I made these files, previously only mentioned in the
  commit message of e9c401e3aa.

Change-Id: I67f962812c155aedf41154e0d837e7feb5af972d
2020-09-01 01:50:33 +02:00
Bartosz Dziewoński 2d3fe47ac1 Fix parsing localised digits in PHP discussion parser
The PHP code incorrectly assumed that the digits are single-byte in
UTF-8, which is never the case (except for 0-9).

The JS code worked correctly because it uses UTF-16 strings, so the
bug would only affect non-BMP digits there. This was noted in a TODO
comment, but we overlooked it when reimplementing in PHP.

Instead of a string of 10 characters, use an array of 10
single-character strings.

Bug: T261706
Change-Id: Ic5421382474c88f003424799c53ff473d99cce92
2020-09-01 01:50:33 +02:00
Thalia 240c766768 Remove extra blank line from .gitignore file
Change-Id: I883880f4552fa90ce9166440d026d49e1da10db6
2020-08-31 15:24:56 +01:00
Ed Sanders d664e0dae4 Update watchlist status from API result
Mirrors the change made in VE in I2c844223.

Bug: T260434
Change-Id: I013e6e7b3a267de09a4e8100b98c77c22cb5b1fd
2020-08-29 20:31:58 +00:00
Bartosz Dziewoński 5e1b6b1b81 Skip past our own reply buttons when displaying reply widget
Without this, the reply widget would be inserted before the reply button,
in the middle of the paragraph.

Follow-up to e36dc8e78a.

Change-Id: I5e22a0a0b70e8da395eb23dd6ae80af70840a2e2
2020-08-29 16:24:48 +02:00
jenkins-bot dbfbffd4f3 Merge "Improve documentation of source/visual tabs/tags" 2020-08-27 19:20:48 +00:00
jenkins-bot 8726e92b38 Merge "Pass through watchlist state to response data" 2020-08-27 19:20:46 +00:00
jenkins-bot d069b1c0f9 Merge "build: Update eslint-config-wikimedia to 0.17.0" 2020-08-27 19:20:44 +00:00
Ed Sanders 3ad904e143 Improve documentation of source/visual tabs/tags
This has lead to confusion where 'visual' as been translated
as 'VisualEditor', and 'source' has been translated as 'wikitext'
(although in the latter case that may be the least confusing
translation possible for some languages).

Change-Id: Ifa7897dfb9bafd8fe240fd84afc92ba88b978944
2020-08-27 19:53:10 +01:00
Translation updater bot 228efebaea Localisation updates from https://translatewiki.net.
Change-Id: I8599fa1945fdb751ea9289c48fef2af3866deff5
2020-08-27 09:51:38 +02:00
Ed Sanders c240f281a4 Pass through watchlist state to response data
This got lost when the watchlist updating code was refactored
out into controller.js, as it assumes that 'data' (the post data)
is still available.

Bug: T261362
Change-Id: Id274e7b8518b62dddbc3d4095d9f6cab17aa17cd
2020-08-26 23:50:06 +01:00
Ed Sanders d36ffeaa3d build: Update eslint-config-wikimedia to 0.17.0
Remove variable shadowing, and fix some documentation.

Change-Id: I08a7cbbdc0a1a409f9c4415b36c62c89535e12eb
2020-08-26 23:46:34 +01:00
jenkins-bot f167bfc5b1 Merge "Don't trust RESTBase to give us the correct revision" 2020-08-26 20:27:22 +00:00
jenkins-bot ca279832cc Merge "Fix reply widget documentation" 2020-08-25 19:10:11 +00:00
jenkins-bot bc80b51fcd Merge "Fix typo in API help message key" 2020-08-25 13:28:55 +00:00
Ed Sanders d3205b877f Fix typo in API help message key
Change-Id: Idb4e973f4adb3affa857f99680707e35676810fa
2020-08-25 13:24:31 +01:00