wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-04 12:58:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
2124 commits 12 branches 4 tags 130 MiB
Commit graph

2124 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bartosz Dziewoński 95c7824056 Fix closing the new topic tool hint 
Bug: T298224
Change-Id: I32494990dd8e3bb8ffa2af097bc1f6400687c823
 2021-12-23 19:59:33 +01:00
Translation updater bot 0e82a944c9 Localisation updates from https://translatewiki.net. 
Change-Id: Id2eb11ae435417f634963169d6b756de86605468
 2021-12-23 08:37:59 +01:00
Ed Sanders 423983f26e Filter username suggestions to accounts with edits 
Bug: T294774
Change-Id: I7346a7986d7caba473d31151495bb2263e43ca44
 2021-12-22 23:57:15 +00:00
Bartosz Dziewoński 704148bd44 Ensure [subscribe] buttons don't float too far away 
Set `overflow: hidden;` on the heading element to establish a new
block formatting context, which will contain floating elements.
Most skins already do this, but not Timeless.

https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context

Bug: T298069
Change-Id: Ic7afd82095b7440cf8b61b3f3fd0085e755a773e
 2021-12-22 22:20:29 +01:00
Translation updater bot a47775e591 Localisation updates from https://translatewiki.net. 
Change-Id: I4edadf5dc5a8693b3248e30b8e11a030d42f4ad3
 2021-12-22 08:34:06 +01:00
jenkins-bot 4c783d7b64 Merge "Replace usages of deprecated wfWikiID()" 2021-12-21 20:26:54 +00:00
Ed Sanders 238a6b49b4 Use new wikipage.watchlistChange hook 
Bug: T294254
Depends-On: I88af8585e8fc75f77ebef867d267199aeb2c6592
Change-Id: Ic7201de567329b5752dcf52602602030d7c347f0
 2021-12-21 13:00:48 +00:00
Translation updater bot 92a40190d8 Localisation updates from https://translatewiki.net. 
Change-Id: I89bd3309c596a9467bf6d1bed4e59728b0bacc7a
 2021-12-21 08:11:55 +01:00
Alexander Vorwerk 397dc2cea5 Replace usages of deprecated wfWikiID() 
The global function wfWikiID() is deprecated since 1.35 and it's usages
should be replaced with WikiMap::getCurrentWikiId().

Bug: T298059
Change-Id: Ie878a5479b7427e9ffab7d7f92ee2802997e3161
 2021-12-21 01:45:54 +00:00
Ed Sanders 8c6fadeb65 Remove getHeading from HeadingItem (JS) 
This matches the PHP implementation and was only used in
one place (when fetching authors in new topic tool).

Change-Id: I9d9e774616112e8dc6ab4919846e3abecc24553d
 2021-12-21 01:33:50 +00:00
jenkins-bot 793c8e990e Merge "Implement getSubscribableHeading/isSubscribable in JS and use" 2021-12-20 21:49:03 +00:00
jenkins-bot 6c1550b66e Merge "Better document {Object} types" 2021-12-20 21:38:09 +00:00
Bartosz Dziewoński 95780b0fab Fix some typos in doc comments 
Change-Id: I0f6c78e49e4eb30549f313d1a48f28a648cbd3f3
 2021-12-20 22:24:03 +01:00
Ed Sanders be9a9aa2a9 Implement getSubscribableHeading/isSubscribable in JS and use 
Bug: T298037
Change-Id: Ifbec49f6da51527f9634fda74b4fb4788a4a015e
 2021-12-20 17:29:43 +00:00
Ed Sanders 2e1241289c Better document {Object} types 
Change-Id: Ibfaf2ded443301c68552dbf98a1897a50bda9ef5
 2021-12-20 17:25:54 +00:00
Ed Sanders 640638b1dc ReplyWidget: Document all methods 
Change-Id: Iab509a7605c3b8e25bcc20fb7176fed23409aed4
 2021-12-20 15:59:47 +00:00
Ed Sanders fe18f5ba22 Controller: Use 'this' in $.each as intended 
Change-Id: Icd507d6726ca391fc39e5d89429e0eed35ba9873
 2021-12-20 15:59:47 +00:00
Ed Sanders ebd37369ce Controller: Document private methods 
Change-Id: I6f5fb0c282c0dc15e175ae278006d918601ccdda
 2021-12-20 15:59:46 +00:00
Translation updater bot e5036c83b4 Localisation updates from https://translatewiki.net. 
Change-Id: I84ef5e7400ca1e996f9ce086e56980347f590301
 2021-12-20 08:21:04 +01:00
libraryupgrader 99dda222ec build: Updating mediawiki/mediawiki-phan-config to 0.11.1 
Change-Id: Ife9812d74b86ddb2f6ba4f5a9b9eafbef0f86bce
 2021-12-20 07:00:31 +00:00
Umherirrender d32dcfbb3c Use ParserOptions::newFromAnon instead of ParserOptions::newCanonical 
ParserOptions::newCanonical is deprecated.

Change-Id: I26667c9102c37d962ceaa81c082566819b503744
 2021-12-18 20:15:02 +01:00
jenkins-bot 9d73ed5dfb Merge "Add beta preference discussiontools-betaenable to DefaultUserOptions" 2021-12-17 18:32:59 +00:00
jenkins-bot fb16305135 Merge "Show a hint on legacy interface when arriving from new topic tool hint" 2021-12-17 17:30:39 +00:00
jenkins-bot e568c62f85 Merge "Show a hint on the new topic tool to explain that it's new" 2021-12-17 17:30:37 +00:00
Bartosz Dziewoński 4242b848d8 Work around a Safari bug causing shadows to remain when the popup is removed 
Bug: T297266
Change-Id: Id6c4c140d8e49ad995dbabeb95ef0e41aabba024
 2021-12-17 17:57:54 +01:00
jenkins-bot a351710e8f Merge "Test cases for partially transcluded comments" 2021-12-17 16:48:09 +00:00
jenkins-bot be07ec8cfc Merge "Add Range::compareBoundaryPoints" 2021-12-17 16:48:04 +00:00
jenkins-bot 5299596882 Merge "Fix replying when comments with the same name have different transclusion data" 2021-12-17 16:43:12 +00:00
jenkins-bot c4fb0f7046 Merge "Change auto topic subs to re-subscribe you if you unsubscribed" 2021-12-17 15:32:40 +00:00
jenkins-bot d0144c0bbc Merge "Make preferences button in auto-subscription popup more obviously clickable" 2021-12-17 15:26:51 +00:00
Translation updater bot 66bcb1d4ae Localisation updates from https://translatewiki.net. 
Change-Id: I8fac6a781b92bad5968c9ad25d60b970378e236b
 2021-12-17 08:17:00 +01:00
jenkins-bot bdbd13ab9f Merge "Remove unused JS version of ThreadItem#getTranscludedFrom" 2021-12-17 01:02:29 +00:00
jenkins-bot 0f32a760b4 Merge "Move some helpers from CommentParser to CommentUtils" 2021-12-17 01:02:26 +00:00
Bartosz Dziewoński 4da9a13c45 Test cases for partially transcluded comments 
Bug: T289873
Change-Id: I115a46eb4858dccd6056534d727f88d8513b391b
 2021-12-17 00:55:33 +00:00
Bartosz Dziewoński 12aa136f54 Add Range::compareBoundaryPoints 
Change-Id: I7b8b9f196bb1ed95304d8b7755d51246c4515bc9
 2021-12-17 00:55:00 +00:00
Bartosz Dziewoński 52c09788a1 Remove unused JS version of ThreadItem#getTranscludedFrom 
We're probably not going to use it again, and I don't want to make the
effort of rewriting it in Id867b3005ebc46906d6df852a525fcaec9e6b19b.

Change-Id: I0b02533f7c9b8c1b0df271e03a74063f123d0dff
 2021-12-17 00:54:37 +00:00
Ed Sanders 4a88be8084 Move user subscription limit to config 
This makes it easier to change going forward, and
configurable on 3rd party wikis.

Bug: T294881
Change-Id: I9e5343cab42cb00ed6b62cf5adf9e02b072481f1
 2021-12-16 21:07:40 +01:00
Bartosz Dziewoński d0eec56f6d Show a hint on legacy interface when arriving from new topic tool hint 
Bug: T293962
Change-Id: I56823efb4e58839b3f121ff23d576984b86e4e81
 2021-12-16 17:43:23 +00:00
David Lynch f24a73a05a Show a hint on the new topic tool to explain that it's new 
This shows to users who are logged in and have more than 500 edits

Bug: T293962
Change-Id: Ic47fa897c6a4f43c27d4cfd5571e34f8acb01eb8
 2021-12-16 16:01:38 +01:00
Bartosz Dziewoński a89d6ca445 Make preferences button in auto-subscription popup more obviously clickable 
Bug: T295946
Change-Id: I3d30a91a2f4497bd5e222a507bdba853e8269162
 2021-12-16 01:07:38 +00:00
Bartosz Dziewoński e9f5819d92 Fix replying when comments with the same name have different transclusion data 
Follow-up to bfe6a36514.
We should only check the transclusion data for `comment.name` when
the data for `comment.id` is undefined, not when it's false.

Bug: T297850
Change-Id: Ia47462a7727edd551db88ec18b5b07017f669d2b
 2021-12-16 01:23:58 +01:00
Ed Sanders d2443f7785 Rename DiscussionToolsAutoTopicSubWhere to DiscussionToolsAutoTopicSubEditor 
Better describes that we are checking the editor used to make
the edit, rather than descibing some virtual "location".

Change options to 'discussiontoolsapi' and 'any'.

Change-Id: I3024517e70ed61c738e4bf46a2ac7b58c975d98a
 2021-12-15 16:24:35 +00:00
jenkins-bot f731b7a575 Merge "Update abtest bucketing for newtopictool usage" 2021-12-13 18:02:09 +00:00
David Lynch d228ca0f67 Update abtest bucketing for newtopictool usage 
Trigger off the (absence of the) new preference for tracking topic tool
usage.

Change the name of the bucket preference so anyone who was enrolled in
the prior abtest won't find themselves re-enrolled.

Update the abtest enrollment code so it explicitly sets the preference
for the feature. This is a trade-off -- it does mean that we'll need to
special-case *unenrollment* once the abtest is disabled if we want to
just quietly revert people to the wiki's default, but it also means that
Special:Preferences will be accurate.

Bug: T291307
Change-Id: I659679e05b65fc7db05e249114e5a7de4cf55816
 2021-12-13 18:45:37 +01:00
Bartosz Dziewoński ef7274d69e Move some helpers from CommentParser to CommentUtils 
Change-Id: I0e323d3b75f47459a5548a13e9684f4c6ff4ba0c
 2021-12-13 17:13:41 +01:00
Translation updater bot 0f5e3b3264 Localisation updates from https://translatewiki.net. 
Change-Id: If931c4c04558ee1ef38434065c45441c1e6132d8
 2021-12-13 08:21:25 +01:00
jenkins-bot 43c2a3204f Merge "Add 'legacyPrimary' links to API data for users without DT-enhanced HTML" 2021-12-10 18:03:23 +00:00
jenkins-bot 7dcb0ef4cf Merge "Revert "Split DiscussionToolsEnableMobile=true into 'behind-overlay' and 'remove-overlay'"" 2021-12-10 16:10:02 +00:00
Bartosz Dziewoński a96c52869b Fix PageRecord lookup 
According to Daniel it only worked by accident, and stopped working
after de63ad823abe:

getPageByReference() used to do an opportunistic lookup by ID when given
an instance of PageIdentity -- which is correct for EventDispatcher,
but problematic in the general case, causing T296063.

The correct thing to do here is to use getPageById(), since the canonical
association between revision and page is by page ID.

Bug: T297431
Change-Id: Icc1df0c9ca5345e65ef5f8daf0815013d7db0943
 2021-12-10 12:46:55 +00:00
Translation updater bot 76619f31a8 Localisation updates from https://translatewiki.net. 
Change-Id: Ic7fd79227b5d3342ddd15e8d2940769eeeee6a7f
 2021-12-10 08:23:53 +01:00