Ed Sanders
c15399568f
Wait for API response before updating suggestion list
...
We can update the local filtered list before then, but then we would
have to do two updates for each keystroke, one to do an instant local
filter and another to back-fill the list when the remote results
become available. Currently CompletionAction is not set up for this,
and this might be confusing behaviour.
Bug: T256974
Change-Id: I6194cdcd6459be17fb142e644d73c9ec4036ba08
2020-07-02 15:12:30 +01:00
Ed Sanders
94511c6bad
Add getHeading method to CommentItem
...
Change-Id: I14ccdbb432e835fe74760a52f07de172df2aba27
2020-07-01 17:21:15 +01:00
Ed Sanders
ed70d49285
CommentParser.php: Fix URL parsing
...
Change-Id: I406fd98b308dd4d975ea974f2369737a7052b556
2020-07-01 17:06:02 +01:00
Ed Sanders
6459e7dc82
Move wikitext modifiers to modifier.js
...
Re-create methods in PHP.
Change-Id: Iae6117b65e3b8f50ecc68e1e3ea17c8359bdcb06
2020-07-01 17:06:02 +01:00
Ed Sanders
978eae5547
Move createCommentContainer to modifier
...
Refactor and create PHP versions.
Change-Id: I0ae9785e5fa86bcc1ac6eef9bce4088d7507dd33
2020-07-01 17:06:02 +01:00
Ed Sanders
fb0d2cbe7f
Move some postReply logic to modifier.js
...
Re-create the function in PHP
Change-Id: I1c8b505542c3b82c10b7b258e48054bc59cb4836
2020-07-01 17:06:02 +01:00
Ed Sanders
6d4d0962ef
CommentController: Refactor postReply
...
Separate out conversion to DOM nodes, and update
now that postReply doesn't need to return a promise.
Change-Id: Iab6192ba252244009d2374c9423d14279e8d1c4f
2020-07-01 17:06:02 +01:00
Translation updater bot
be9b43fd19
Localisation updates from https://translatewiki.net .
...
Change-Id: I54a8e13292ca19d9132e3344d47e42f54e5cf14b
2020-07-01 08:43:26 +02:00
Ed Sanders
b1fe481324
Increase padding around warning icon
...
Bug: T255558
Change-Id: Ie9c384a3233e5079dcb49fbf295a8c81596dc83d
2020-06-30 15:19:13 +01:00
Translation updater bot
e9ca361ee4
Localisation updates from https://translatewiki.net .
...
Change-Id: I4e00b4454ecaa5d9835310f156d0a55370c30689
2020-06-29 16:25:51 +02:00
jenkins-bot
475cb40aa3
Merge "Set DiscussionToolsEnableVisual to true by default"
2020-06-29 11:54:25 +00:00
Ed Sanders
d75a340026
CommentModifierTest: Use DOMCompat::get/setInnerHTML to match JS code
...
Change-Id: Idd057ff1a5028b377903ff3798ca2bce22535337
2020-06-27 13:13:27 +00:00
Ed Sanders
3e6ab2c4d2
PHP: Use DOMUtils::parseHTML
...
Change-Id: Ifed0ab99b3da9f8b35ca815ada45f804a8756c1b
2020-06-26 20:06:47 +01:00
Ed Sanders
58f6d8ca56
Trigger username sequence even when deleting
...
This is helpful when you ping the wrong person and need to correct your input.
Logically depends on I4c34e9368692b0ee4e7ca0f18ba2940406c62a9a
Change-Id: Iea89bdb5d93fe64902b692f04dd3a2e84e5517c3
2020-06-26 17:19:10 +01:00
jenkins-bot
ea20ec6257
Merge "Improve ThreadItem documentation"
2020-06-26 13:12:58 +00:00
Ed Sanders
d5376e28fc
Improve ThreadItem documentation
...
Change-Id: Ia266fc22b02af0edbb32f356b4e0d92fe3a4da5f
2020-06-26 14:56:19 +02:00
jenkins-bot
dc07a5c2b1
Merge "Fire window-open-from-tool event for username completion from toolbar"
2020-06-25 20:29:18 +00:00
jenkins-bot
c7b7fe5d66
Merge "Another attempt to fix page re-initialization after updating"
2020-06-24 21:48:14 +00:00
jenkins-bot
dafb465481
Merge "Allow non-lists to be passed to unwrapList"
2020-06-24 21:09:45 +00:00
jenkins-bot
b51799ec2e
Merge "Load VisualEditor plugin modules with ReplyWidgetVisual"
2020-06-24 21:09:36 +00:00
Bartosz Dziewoński
ffafc1a752
Another attempt to fix page re-initialization after updating
...
* Run the 'wikipage.content' hook before our initialization.
This way collapsible elements and other changes to the page layout
are processed before we measure where the new reply is and try to
highlight and scroll it into view. (T252903)
* Remove the code dealing with 'mw-parser-output' and 'dt-init-done'.
This was needed to avoid initializing twice on the same element,
which can't happen now. (T254807)
This is much closer to the original approach Ed proposed in
I05a3c766668999f05cfe06473652429025595196 before I changed it:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/550693/7..8
Bug: T252903
Bug: T254807
Change-Id: Ibc3fcbd3c92c8eceda19b68cee9e69f6e92456f5
2020-06-24 22:56:40 +02:00
jenkins-bot
e55ac1ef79
Merge "Scroll the after-reply highlight into view"
2020-06-24 19:24:55 +00:00
Ed Sanders
811f8bdf02
Allow non-lists to be passed to unwrapList
...
Bug: T256292
Change-Id: I036e0fdf3dde51c33f64abb7df142e26ebe66554
2020-06-24 19:19:06 +01:00
Ed Sanders
e4645a47e6
Scroll the after-reply highlight into view
...
Bug: T252903
Change-Id: If9db634153572a045dd468cfa7f6316e93fddccd
2020-06-24 20:15:52 +02:00
Ed Sanders
e7a9185ab1
Load VisualEditor plugin modules with ReplyWidgetVisual
...
Bug: T256292
Change-Id: Id05ad1871093e8941e54b2db8c9a76cecaac1033
2020-06-24 19:09:27 +01:00
Ed Sanders
8ca9da66fd
UsernameCompletionTool: Use 'userAdd' icon
...
Depends-On: I6de36ca2ba279dc11d18bdff3c5d138444a13361
Change-Id: Ic09e18bf284b97bb135c3e8b0129fb9bc96cf72f
2020-06-24 12:33:33 +01:00
David Lynch
02fafccd23
Fire window-open-from-tool event for username completion from toolbar
...
The automatic event from core didn't catch this, because it's not an action
method called "open".
Bug: T255638
Change-Id: Ifa456e850a8edb374df098e21b46bb872416ae55
2020-06-23 10:25:03 -05:00
Translation updater bot
a00bc8411a
Localisation updates from https://translatewiki.net .
...
Change-Id: I559c4bc6ef39f6c09ad97aa73c83d36e733fdd37
2020-06-23 08:51:13 +02:00
Bartosz Dziewoński
b6edd8ddef
CommentController: Apply pre-save transform when switching to visual
...
Parsoid doesn't understand syntax expanded during pre-save transform,
e.g. [[User:Foo|]] or ~~~~, and it gets nowikied when switching back.
Change-Id: I791426d9d6c0a1399b1e95039b11e43a3e5bf79f
2020-06-22 21:01:55 +02:00
Ed Sanders
03665de09e
Move VE components to dt-ve
...
Change-Id: I4fba23e83d9ace833b55e67d1c3ef8b8da5ed19f
2020-06-22 20:09:18 +02:00
jenkins-bot
a2b31efb19
Merge "Remove unsupported argument from getWikitextFragment"
2020-06-22 17:59:57 +00:00
jenkins-bot
579853ce82
Merge "insertAndOpen: Call this.open directly now there is no precedingCharacter check"
2020-06-22 15:16:02 +00:00
jenkins-bot
c65cac5673
Merge "Don't try to avoid username completion appearing in email addresses"
2020-06-22 11:27:53 +00:00
Ed Sanders
b38e380ebf
insertAndOpen: Call this.open directly now there is no precedingCharacter check
...
Change-Id: I82b2fdd58fe512638a8f69d4df9adc4be98e814e
2020-06-22 12:22:08 +01:00
David Lynch
d7557d5ab3
Don't try to avoid username completion appearing in email addresses
...
Current code breaks in other languages which don't use whitespace as a
word separator. The word-separator message is (for reasons) not reliably
set to something other than " " on wikis for those languages, so we
can't use it as a trigger for just not caring.
Bug: T255153
Change-Id: I1ff929811af59fd7a7bf7e8dfc1cd121a2c4db4e
2020-06-22 12:21:32 +01:00
Translation updater bot
6c7e38446d
Localisation updates from https://translatewiki.net .
...
Change-Id: I80e9157b103aeec4520535d4ef00610f7f7fa26e
2020-06-22 08:43:11 +02:00
Ed Sanders
83968e4c00
Remove unsupported argument from getWikitextFragment
...
This was removed upstream due to a regression.
We don't need it right now, but may need it in the future to
support editing, so replace with a TODO.
Change-Id: Ia73657080241319df309f3b6566ac0ac36a5909d
2020-06-20 13:07:49 +01:00
Translation updater bot
303b233ca1
Localisation updates from https://translatewiki.net .
...
Change-Id: Iea52f433ee27ba4babe3a57a37d89214acab3610
2020-06-19 08:39:41 +02:00
Translation updater bot
8f5335aba3
Localisation updates from https://translatewiki.net .
...
Change-Id: I31057e462dd4c59348df0c08d7c34d6aaeb789ab
2020-06-18 08:37:08 +02:00
Ed Sanders
badbd823b2
Use $wgLocaltimezone global instead of request context
...
Bug: T255704
Change-Id: Ic26a1d77a64f52addcb45131ea2f9cd41c7c51e2
2020-06-17 23:14:13 +02:00
Translation updater bot
8d7168e666
Localisation updates from https://translatewiki.net .
...
Change-Id: I4ebd65a85d808155d34e07311e48a66f94f74e73
2020-06-17 08:47:53 +02:00
jenkins-bot
e4fc21ad37
Merge "Check the right page for lint errors by title"
2020-06-16 16:14:47 +00:00
Translation updater bot
0cc0172967
Localisation updates from https://translatewiki.net .
...
Change-Id: I8354dc3bfc5119b85dfeb5254167eb10558bc2b1
2020-06-16 08:33:41 +02:00
jenkins-bot
c678fffd49
Merge "Add user mention tool"
2020-06-15 19:46:19 +00:00
Ed Sanders
21b5ad037c
Set DiscussionToolsEnableVisual to true by default
...
At some point in the near future we can delete this config.
Bug: T251654
Change-Id: I87270af14fb0edf931ce98ae8a3b049a669487d4
2020-06-15 19:44:50 +01:00
jenkins-bot
a18cd2ccff
Merge "Tests: childNodes[0] -> firstChild"
2020-06-15 15:09:24 +00:00
jenkins-bot
68aa00e5b7
Merge "Remove various phan suppressions and fix issues"
2020-06-15 15:09:22 +00:00
jenkins-bot
74960b3ebd
Merge "Create ThreadItem classes"
2020-06-15 15:08:36 +00:00
Translation updater bot
62823da603
Localisation updates from https://translatewiki.net .
...
Change-Id: Ieade86359179c8a1d142865c68c7cc58ec765047
2020-06-15 08:39:16 +02:00
Ed Sanders
306faba93d
Tests: childNodes[0] -> firstChild
...
Change-Id: Iae53012f289552d80dad907bfb54a8b5d44cb484
2020-06-12 19:46:08 +00:00