wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-28 07:43:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
3545 commits 13 branches 4 tags 132 MiB
Commit graph

3545 commits

This branch
This branch
All branches
Author SHA1 Message Date
jenkins-bot 91a94fe9bb Merge "Pass empty string to unused argument of pushState/replaceState" 2022-08-09 20:48:12 +00:00
jenkins-bot 89607c6e25 Merge "Implement percentDecode for finding link fragment targets" 2022-08-09 20:18:58 +00:00
Ed Sanders b3b543040b Implement percentDecode for finding link fragment targets 
Relying on :target getting set means we can't use
history.pushState to change the URL without scrolling.

Should conform to https://url.spec.whatwg.org/#percent-decode

Change-Id: I4ccc3fd745884849a781a9f7fc8b00b8b689e20a
 2022-08-09 20:06:28 +00:00
Ed Sanders 9f27c55f8c Pass empty string to unused argument of pushState/replaceState 
Per https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState
this argument is treated as unused in all the browsers we support.

Change-Id: I515193fdafaaf1c19701bc77e590d6f66b1cf4bf
 2022-08-09 13:37:57 +01:00
Translation updater bot 8e52dbfdd6 Localisation updates from https://translatewiki.net. 
Change-Id: Ica8bdd209131bbf3be3394b2d0ac4382b4c5db42
 2022-08-09 08:19:34 +02:00
jenkins-bot eb260cc598 Merge "Don't display the empty state if the subject page or user doesn't exist" 2022-08-08 20:54:52 +00:00
Translation updater bot 4b7b106c4c Localisation updates from https://translatewiki.net. 
Change-Id: If2ed19a1227b15bafc97ff01b4a714b33c14be43
 2022-08-08 08:58:27 +02:00
Bartosz Dziewoński a27765319b CommentFormatter: Set 'data-mw-comment' even when reply tool disabled 
Move the code that generates these wrapper nodes and attributes
from postprocessReplyTool() (only called when reply tool is enabled)
to addDiscussionToolsInternal (always called).

This undoes some changes from 31c57d594a and 980b2c38bc.

Bug: T314707
Change-Id: I07ed210375d494047670015410430c087d67f21a
 2022-08-06 14:16:37 +00:00
Bartosz Dziewoński d9ccb115e4 Don't display the empty state if the subject page or user doesn't exist 
Bug: T288319
Bug: T312560
Change-Id: Ib069b2db639a699f7e28ffc24f7b196971acbe3e
 2022-08-06 14:15:32 +00:00
Bartosz Dziewoński d223626585 Add signature on separate line if wikitext comment ends with a list 
Bug: T263217
Change-Id: Idd15a9add798368493ae7af5270f972895470de9
 2022-08-06 16:08:13 +02:00
jenkins-bot a4d9455743 Merge "logger: Also log EditAttemptStep events via Metrics Platform" 2022-08-06 05:01:19 +00:00
jenkins-bot 7ba6443a05 Merge "Clear floats above the new topic empty state" 2022-08-05 08:16:27 +00:00
Translation updater bot 9fda66dda7 Localisation updates from https://translatewiki.net. 
Change-Id: I819c4608a3d19b4d3840b0c2bd2be9d10a32e94b
 2022-08-05 08:33:40 +02:00
Umherirrender 0a53b4d468 EventDispatcher: Remove use of UserFactory in logAddedComments 
Possible since 1828d40

Change-Id: I0cc49a101858177bd9f7e75c18003277dd97725d
 2022-08-05 01:43:16 +02:00
jenkins-bot 5c862b3244 Merge "Topic container latest comment link: Escape fragment for URL" 2022-08-04 19:10:27 +00:00
Ed Sanders ce567a1eeb Topic container latest comment link: Escape fragment for URL 
Bug: T314573
Change-Id: Ib6a95da5d458efebf9e54c154ce90de3f54c140e
 2022-08-04 14:28:23 +01:00
Translation updater bot f7cdcffbeb Localisation updates from https://translatewiki.net. 
Change-Id: I64e649a69b6b66ae469bb4bae41872a3dfd6a714
 2022-08-04 08:42:36 +02:00
Bartosz Dziewoński 0c80eeb88b Fix ReplyLinksController#teardown 
Follow-up to 31c57d594a. This was
causing an exception, preventing the page contents from updating after
saving changes.

Change-Id: I8c9ab51385172056be9032ec0087f64ff34b6709
 2022-08-03 20:46:19 +02:00
jenkins-bot 7ee49a2138 Merge "Make comment markers inline-block to fix comment wrapping in Safari (in headings only)" 2022-08-03 14:22:51 +00:00
Translation updater bot 1808b4f0f2 Localisation updates from https://translatewiki.net. 
Change-Id: Ia7807a1e20ceeed349be915d88f0fe78e10ee083
 2022-08-03 08:18:17 +02:00
Bartosz Dziewoński 69848614f8 Bring back [reply] links in old revisions without breaking preview 
It turns out that using the "enableSectionEditLinks" post-cache
transform option was not a good idea, as it is also set when viewing
old revisions and in some other cases.

However, in the pre-cache parsing, we have access to getIsPreview(),
which is exactly what we want. I think we can safely do this there.
We were already using that prior to 2bc76dabd7.

Bug: T314260
Change-Id: I7f769db48eff9fa434483902a4b5ac2f5fc96b3d
 2022-08-02 21:57:44 +02:00
Bartosz Dziewoński 2bb0a11d55 Clear floats above the new topic empty state 
It should appear below any page content, at full width.
Currently it gets squished by floats on some pages.

Change-Id: I4c4107d438dfd06eec21badce5f216aa2c137272
 2022-08-02 19:37:12 +02:00
Bartosz Dziewoński 9c68e058ef CommentFormatter: Add test cases for mobile version 
Also, rename the files, since CommentFormatter now does more than
replies.

Change-Id: I1ae432c06badd9790274db27881c2222c0439ba8
 2022-08-02 14:21:36 +01:00
jenkins-bot b1934c8a84 Merge "Don't infuse reply buttons if not in use" 2022-08-02 12:58:17 +00:00
jenkins-bot 1612bf96f1 Merge "Fix reply buttons not being available on mobile" 2022-08-02 12:47:32 +00:00
jenkins-bot 0b6733b48d Merge "Disable OOUI reply buttons for real, not with CSS hack" 2022-08-02 12:47:31 +00:00
Ed Sanders a0fa7c466f Don't infuse reply buttons if not in use 
Change-Id: I704cbf3f1a681c474ce5d44b7c5af5c8dbb82f3b
 2022-08-02 13:27:43 +01:00
jenkins-bot 80be7b0d98 Merge "Make "Add topic" button in Vector sticky header disabled after click" 2022-08-02 11:42:52 +00:00
jenkins-bot b2fb7c37f0 Merge "Fix focussing the reply button/link after closing the reply widget" 2022-08-02 11:42:50 +00:00
jenkins-bot 4ad71b7682 Merge "CommentFormatter: Avoid serializing and parsing HTML repeatedly" 2022-08-02 11:42:49 +00:00
Translation updater bot eb6485aebc Localisation updates from https://translatewiki.net. 
Change-Id: Ie1bfe7fae07e7bfde198ba7a04235e65b32ded44
 2022-08-02 08:13:23 +02:00
Bartosz Dziewoński 0868d40cbf Avoid dependency on Minerva for the mobile "Add topic" button label 
We might want to delete the code that defines it in the future.

The core message is the same in most translations, and available in
100+ more languages.

Change-Id: I230e051940fdd7b89989453eccbffac804a7ddea
 2022-08-02 00:58:14 +02:00
Bartosz Dziewoński f7606ffa57 Fix reply buttons not being available on mobile 
Change-Id: Ie78f66e61c7afc4b9d2310b11d84cf26f28a52e6
 2022-08-02 00:32:24 +02:00
Bartosz Dziewoński 35db93d9f5 Disable OOUI reply buttons for real, not with CSS hack 
We already infuse them, so might as well do this...

Change-Id: I962c052d3f5b5c15b3a15e6e4533bd87624eb6e2
 2022-08-02 00:32:24 +02:00
Bartosz Dziewoński 293df2438f Make "Add topic" button in Vector sticky header disabled after click 
Bug: T307726
Change-Id: I3077357d7753d9259c5c32b71dd23a0e21bde6de
 2022-08-02 00:32:24 +02:00
Bartosz Dziewoński 549fcc062b Fix focussing the reply button/link after closing the reply widget 
Change-Id: I0db0fc8a93512751f8a9bcc96b048c1ab1f24f95
 2022-08-02 00:32:24 +02:00
Bartosz Dziewoński 5b2f74ef5e CommentFormatter: Avoid serializing and parsing HTML repeatedly 
Well, we still do it repeatedly, but now we repeat it one time less.

Change-Id: Ic1f655f32e4596d179f4154d90c2fe8286bf3de3
 2022-08-02 00:32:24 +02:00
Bartosz Dziewoński 31c57d594a Do not duplicate item JSON in page HTML 
Rather than setting it on both the reply link and the reply button,
set it on their parent element.

Update ReplyLinksController to handle this.

Change-Id: I650e9c0ebd354a82b8f66a63c5b4c02b2e29b105
 2022-08-01 22:14:50 +00:00
jenkins-bot 47158f28dc Merge "Fire new 'wikipage.tableOfContents' hook to update TOC after save" 2022-08-01 19:49:39 +00:00
Ed Sanders 980b2c38bc Make reply links into buttons when visual enhancements enabled 
Bug: T255560
Bug: T309904
Change-Id: I3932f576086a43df89ff97a1b3dafdc27c54f71c
 2022-08-01 20:59:53 +02:00
jenkins-bot 9ceccd2d48 Merge "Fix styling of new comment notification on mobile" 2022-08-01 18:28:10 +00:00
jenkins-bot d247842772 Merge "Ignore "tracked" templates at the beginning of comments" 2022-08-01 14:52:39 +00:00
jenkins-bot 6b5352fb1c Merge "Add more tests cases using the "tracked" template" 2022-08-01 14:51:54 +00:00
jenkins-bot 96868976bf Merge "Re-enable keyboard sequences for template, table etc. in new topic tool" 2022-08-01 12:28:15 +00:00
Translation updater bot c0410ae47c Localisation updates from https://translatewiki.net. 
Change-Id: I85883950669be48a65cc96c3119cc78582925edd
 2022-08-01 08:22:09 +02:00
Ed Sanders 54eabe1f4f Fix styling of new comment notification on mobile 
* Keep buttons on the same line
* Reduce font size to align borders

Change-Id: I1cc44ae1bd8b5e45d9a5b2ea4f9352163d12e8e6
 2022-07-31 23:00:05 +01:00
jenkins-bot 437ced8e3e Merge "EventDispatcherTest: Use null instead of special placeholder file" 2022-07-31 15:52:13 +00:00
Bartosz Dziewoński ddd391b6db Ignore "tracked" templates at the beginning of comments 
This improves the behavior when replying to these comments
and the message snippets shown in notifications.

Bug: T313097
Change-Id: Ia10400472c9e999fa526c7437a03b72461c37b74
 2022-07-31 03:56:36 +02:00
Bartosz Dziewoński a0bcd6eb05 Add more tests cases using the "tracked" template 
Change-Id: I7327cd2140fb8622f65ab8f96daba99f16f9e3af
 2022-07-31 03:56:33 +02:00
Bartosz Dziewoński 612544de5f EventDispatcherTest: Use null instead of special placeholder file 
It's easier to read this way, not sure what I was thinking when I wrote this.

Change-Id: Ie59f86143885593214d85ec05576212dc4624995
 2022-07-31 03:29:48 +02:00