Commit graph

851 commits

Author SHA1 Message Date
Ed Sanders 5271b3eafd Move CommentController to separate file
Change-Id: I6dbf16801058e7e41d38a0ce5753c298d380b780
2020-04-30 17:05:04 +01:00
Ed Sanders 2aa6e5f583 Allow inspectors to position beyond the surface
Change-Id: I3cd0e433ea117b1b469e5a2111f4c7988c48abfd
2020-04-30 17:05:02 +01:00
Translation updater bot 9b581769a7 Localisation updates from https://translatewiki.net.
Change-Id: I6b6f7a007041ccca6fc136e477f1faf8fe697aab
2020-04-30 08:37:39 +02:00
Ed Sanders a5ed469843 Create CommentController class and move most Controller methods to it
This means we have an instance for each comment, which makes keeping
track of local variables much simpler, and will make switching out
the widgets easier.

Change-Id: I7584870225b1a14146852987d6a40ad05957387c
2020-04-29 22:21:32 +02:00
Ed Sanders 75da1e0b3a ReplyWidgetVisual: Use hasContent instead of hasBeenModified for isEmpty
Change-Id: I093a4b68573809e5222db01aead3ce00ed9a87ae
2020-04-29 16:32:00 +01:00
jenkins-bot 922443f68f Merge "ConfirmEdit CAPTCHA support" 2020-04-29 12:04:44 +00:00
Translation updater bot 66054cd76f Localisation updates from https://translatewiki.net.
Change-Id: I959d53131aeb4083933c22ba5466193cb86eabcb
2020-04-29 08:35:36 +02:00
jenkins-bot e624e17471 Merge "Remove client-side timeout when saving pages" 2020-04-28 22:38:27 +00:00
jenkins-bot bb096d8f50 Merge "Revise error messages when replying to comments affected by templates" 2020-04-28 22:35:47 +00:00
jenkins-bot 431716577b Merge "Add 'cursor: pointer' to the reply link" 2020-04-28 22:33:34 +00:00
jenkins-bot ba3fd84243 Merge "Minimum keyboard-accessibility for the reply link" 2020-04-28 22:33:33 +00:00
jenkins-bot 5fdf6ae466 Merge "Fix inserting replies inside a <pre>" 2020-04-28 22:31:45 +00:00
Bartosz Dziewoński 021c981817 Add utils.getNativeRange() method
Change-Id: Iab6c5fa092560ee9dff808bbcc405722914febe7
2020-04-28 23:11:26 +02:00
jenkins-bot 95ec3f4467 Merge "Implement auto-save for ReplyWidgetPlain" 2020-04-28 18:43:25 +00:00
jenkins-bot 483aac1fca Merge "Enable on all ExtraSignaturesNamespaces" 2020-04-28 18:32:36 +00:00
Ed Sanders 04f8e21554 Implement auto-save for ReplyWidgetPlain
Bug: T240257
Change-Id: Ica51fb51a5091b11aceb3cd5c484ef9c71b98af2
2020-04-28 20:32:20 +02:00
Translation updater bot 7c8579b85a Localisation updates from https://translatewiki.net.
Change-Id: Ib9a31ff775084b4b4d3ce15e69a489ebcbd3eacb
2020-04-28 08:31:55 +02:00
Bartosz Dziewoński 047e8eb82c Fix inserting replies inside a <pre>
In the future, we should think about a better solution that also
handles other elements (T250126), but this is an easy fix for now.

Bug: T250512
Change-Id: I1321f0da523ddb4a999b8c453b9094a267b38ae2
2020-04-27 23:23:31 +02:00
jenkins-bot f376230459 Merge "Move VE toolbar to top right" 2020-04-27 21:17:01 +00:00
Bartosz Dziewoński c07243c88f Add 'cursor: pointer' to the reply link
Bug: T250337
Change-Id: I77949f59ac4da27e7a25b5c35ca2a9df66f22872
2020-04-27 18:30:07 +00:00
Bartosz Dziewoński 7cb7722b76 Minimum keyboard-accessibility for the reply link
Using an approach similar to that in jquery.makeCollapsible.

Bug: T249915
Change-Id: Ia3dc43d23c29cd936a9445766e394f96f096da75
2020-04-27 18:30:00 +00:00
Bartosz Dziewoński 4ad9aa8449 parser: Don't crash on links to invalid titles
Bug: T251045
Change-Id: I1a7b8b9b34d38ec4e3edc12687bdf99bb0e61bd8
2020-04-27 19:59:26 +02:00
Ed Sanders cd7acc741b Move VE toolbar to top right
Change-Id: I97b322ded505df608eda73a7c6a04157e993d73b
2020-04-27 16:42:35 +01:00
Translation updater bot 0c098b1fab Localisation updates from https://translatewiki.net.
Change-Id: If29a12637e8ef8d920e080505aa5ff5109a43c24
2020-04-27 09:02:36 +02:00
Bartosz Dziewoński b1376413f0 Revise error messages when replying to comments affected by templates
Bug: T248607
Change-Id: Iea49d16bb0e5c71b36a79248f3f91f7987e65702
2020-04-26 19:50:32 +02:00
jenkins-bot ecb0a50d05 Merge "Add Special:MyLanguage for better user experience" 2020-04-26 17:49:33 +00:00
jenkins-bot 688cc0eefb Merge "Show error on pages with fostered content to avoid page corruption in Parsoid" 2020-04-26 16:29:42 +00:00
Yuki Shira 172bf5731e Add Special:MyLanguage for better user experience
Change-Id: I687fd5cd7b96d9cc991e122acdb3f86a03c5819c
2020-04-26 09:34:25 +09:00
Translation updater bot 6d4ed2b20f Localisation updates from https://translatewiki.net.
Change-Id: I6d120203bd1b42857438d307dbd07a3f242a6e84
2020-04-24 08:22:19 +02:00
Translation updater bot 9e867d4526 Localisation updates from https://translatewiki.net.
Change-Id: I30b2ab6b23620675cfc1dd5530a2133ed18d0e32
2020-04-23 08:42:50 +02:00
libraryupgrader 56a6bd090d build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 29.0.0 → 30.0.0

npm:
* eslint-config-wikimedia: 0.15.0 → 0.15.3
* grunt-stylelint: 0.14.0 → 0.15.0
* stylelint-config-wikimedia: 0.9.0 → 0.10.1

Change-Id: I4c59ac4a125dd87f7fb77219447f4987a137b4e7
2020-04-22 08:19:10 +00:00
Bartosz Dziewoński 7ef3bffb1e Show error on pages with fostered content to avoid page corruption in Parsoid
When the user clicks a "Reply" link on a page that is affected by the
'fostered' lint error (indicating fostered content in the HTML
representation), display an error and refuse to edit it, as Parsoid's
transformations will damage the page content.

The error message includes a link to documentation about lint errors,
and a link to the editor that will highlight the error location.

Depends-On: I723ec766d1244d117f8d624440026fe5af0d3403
Bug: T246481
Change-Id: Ic60cb58f98d10dc9b113469e5d3bbfb2d2b0564f
2020-04-21 17:40:39 +00:00
Bartosz Dziewoński 40c18508ec ConfirmEdit CAPTCHA support
Depends-On: I6605017fd31a4f96c529dd0beb69e9f4433cebc1
Bug: T247513
Change-Id: If9b3162969aa6ee67baff80aa84fa719bd3c3720
2020-04-21 18:55:38 +02:00
Ed Sanders d3c46a2967 eslint: Disable max-len
Change-Id: I7e49dc170dba62b88f1879ae670f806f6b54d4e9
2020-04-21 15:50:19 +01:00
Translation updater bot 9c9fc33fa8 Localisation updates from https://translatewiki.net.
Change-Id: I3ff903328d273597a47014702abc638f49ea1b5a
2020-04-21 08:45:14 +02:00
Bartosz Dziewoński e3e36e11ac Remove client-side timeout when saving pages
Bug: T249071
Change-Id: I367c5931c05cf944bfad0f9fff69f06b32880411
2020-04-20 23:29:10 +02:00
Ed Sanders 0f7eb2e36a Add "watch this page" checkbox
Bug: T245222
Depends-On: I1e0e9bb9da53a62f8a20126e579dcd6300bd2376
Change-Id: If966d2fa97648452a50a2318988a8b64d7c449cd
2020-04-20 12:40:44 +01:00
Translation updater bot 8fe44239f0 Localisation updates from https://translatewiki.net.
Change-Id: Ia01d569301438dc2ac350d287b2534b68d7b9b16
2020-04-20 08:41:17 +02:00
Ed Sanders 5565c7e4f0 Enable on all ExtraSignaturesNamespaces
For most Wikimedia wikis, this is Project (Wikipedia) and Help.

Bug: T249036
Change-Id: I535240dc5232b78f11d5003d1141ad8114f01be2
2020-04-19 14:53:40 +01:00
libraryupgrader 3b049210f0 build: Updating grunt-banana-checker to 0.9.0
Change-Id: Iea10293c46ef9f83fb68b634dc25fa5921da1a98
2020-04-19 03:36:51 +00:00
Translation updater bot 6f0e5d86f4 Localisation updates from https://translatewiki.net.
Change-Id: I32ab26e3fbd2819d651c4dc3b14ce7abecba8f40
2020-04-17 09:06:35 +02:00
Translation updater bot c6e365d332 Localisation updates from https://translatewiki.net.
Change-Id: I995ded03f89a2a56ff8336681e7b70485f6c423b
2020-04-16 08:50:31 +02:00
Translation updater bot e23b4ef3f3 Localisation updates from https://translatewiki.net.
Change-Id: Iad64b71f1d12f3295f16713125278d27632159d5
2020-04-15 08:23:40 +02:00
Ed Sanders ba89657994 Add a share feedback link
Bug: T249016
Change-Id: I64abeebeea332a7a4a37fd4bfd6d5f9a5defc8b5
2020-04-14 23:04:18 +00:00
Ed Sanders d40e427b5b Remove extra linebreaks from wikitext
Extra lines currently render empty list items which are invisible.
Remove these as the user probably didn't intend from them to appear
in the wikiext.

Bug: T249867
Change-Id: I75c1192a94b918783d362d38cd91a508bb169d56
2020-04-14 20:29:38 +00:00
Ed Sanders f04abd02d4 Improve autosign handling of 3/5 tilde sigs and add tests
3 or 5 tilde signatures will be assumed to be erroneous and fixed
to 4 tilde signatures. This will be visible in the preview so shouldn't
come as a suprise to users.

Bug: T245628
Change-Id: I741f0761a6fb10c99cf3239ac5c6c7e1a2b872c7
2020-04-14 20:29:31 +00:00
Ed Sanders 5597787eb4 ReplyWidget: Replace .mode with #getMode
.mode was only set the end of the constructor.

Change-Id: I1a14167d1b2e524742da31f78c6cbfaf96aec667
2020-04-14 19:42:29 +00:00
jenkins-bot c5e9185ae7 Merge "DiscussionToolsHooks: Only enable when viewing pages" 2020-04-14 15:29:04 +00:00
Translation updater bot d118f82003 Localisation updates from https://translatewiki.net.
Change-Id: If723b84c780154f9a10cdf348dd38ac03378c12a
2020-04-14 08:23:29 +02:00
jenkins-bot 3886ae6398 Merge "Add override config for instrumentation rates" 2020-04-13 20:15:28 +00:00