Commit graph

752 commits

Author SHA1 Message Date
jenkins-bot 3886ae6398 Merge "Add override config for instrumentation rates" 2020-04-13 20:15:28 +00:00
David Lynch e38aad96e4 Add override config for instrumentation rates
Bug: T250086
Change-Id: I32fbf3d6562fb0a93698a24bbd8177149a19fed3
2020-04-13 12:38:40 -05:00
Translation updater bot 850018b1c6 Localisation updates from https://translatewiki.net.
Change-Id: Ic5ccea73dd013f401e1e1591ab8f5bdeb8fb188a
2020-04-13 09:00:15 +02:00
Translation updater bot 7ba060dcd7 Localisation updates from https://translatewiki.net.
Change-Id: I58aba493b8b87feb3de07eef52dc2a88c47f6e41
2020-04-10 09:51:19 +02:00
Translation updater bot 371722ea40 Localisation updates from https://translatewiki.net.
Change-Id: Icecd16835884d14b0b9d1d1289051ddde01e3d84
2020-04-09 08:38:39 +02:00
Translation updater bot 784eb23736 Localisation updates from https://translatewiki.net.
Change-Id: I9f794e39700d102dc84ff44bcfb2042b98e925c3
2020-04-08 08:23:17 +02:00
Translation updater bot fa279f7507 Localisation updates from https://translatewiki.net.
Change-Id: I34c1046e79e104c957a0ab44d151e0f3b75c546d
2020-04-07 08:39:27 +02:00
Translation updater bot daadf25964 Localisation updates from https://translatewiki.net.
Change-Id: I34741fbe3c8eddeffe157e3936978c00ed57c478
2020-04-06 09:01:44 +02:00
Bartosz Dziewoński 55b43a70d4 Fix skipping to the end of the paragraph when there is no wrapper
Bug: T249217
Change-Id: I77847901d98f56dbcbcf379c6c17f41e06a3a939
2020-04-03 18:11:59 +00:00
jenkins-bot 660c9421f7 Merge "Remove Parsoid section wrappers before finding transclusions" 2020-04-03 14:07:46 +00:00
jenkins-bot 6b70d7b652 Merge "Remove dependency on 'ext.visualEditor.core.utils'" 2020-04-03 14:07:46 +00:00
jenkins-bot fecc23ecd7 Merge "Rename tests/qunit/utils.js to .../testUtils.js" 2020-04-03 14:07:45 +00:00
jenkins-bot 6020bef2b6 Merge "Save the reply directly to the transcluded page" 2020-04-03 14:07:44 +00:00
Translation updater bot 6c20d878fa Localisation updates from https://translatewiki.net.
Change-Id: Iffc943c6b0a966711642b90a87815a3b6ecc9e63
2020-04-03 08:28:20 +02:00
jenkins-bot dd8eee7b38 Merge "Treat pages with __NEWSECTIONLINK__ as talk pages" 2020-04-02 21:37:14 +00:00
Ed Sanders 13777278ff Bump MW dependency to 1.35
For example we are using Id7565018.

Change-Id: Idc453dd6b770e4a67e88b0d576dfa06ffcc136f0
2020-04-02 19:17:21 +01:00
Translation updater bot 47947d72d5 Localisation updates from https://translatewiki.net.
Change-Id: I618048edc612a5e5e4e5c9ead43b3fc2ef7eace8
2020-04-02 08:24:23 +02:00
Bartosz Dziewoński 3bd513374e DiscussionToolsHooks: Only enable when viewing pages
Previously we'd also run on action=history, action=info etc. (which did nothing).

Change-Id: I4bd10311a91433f357a6f5506c65364d399f3915
2020-04-01 22:48:51 +02:00
Ed Sanders bcd3fbfe9a Treat pages with __NEWSECTIONLINK__ as talk pages
Bug: T245890
Change-Id: Ibb9f6c675ce26c5a0e6e7934bd4659f5aaae6a25
2020-04-01 14:34:05 +01:00
jenkins-bot f92e07687f Merge "parser: Make #getTranscludedFrom return page title in text form" 2020-03-31 13:26:38 +00:00
libraryupgrader d3a5508f1b build: Updating gonzales-pe to 4.3.0
* https://npmjs.com/advisories/1179

Change-Id: I29b834bff150c980753e67db04066b17d449b13e
2020-03-31 02:29:52 +00:00
jenkins-bot f048b3fc50 Merge "Localisation updates from https://translatewiki.net." 2020-03-30 07:25:02 +00:00
Translation updater bot e79e8adf73 Localisation updates from https://translatewiki.net.
Change-Id: I218a77e9dfeb6d84045cf193096e462c7d9e8651
2020-03-30 09:13:36 +02:00
Translation updater bot e7a70661c3 Localisation updates from https://translatewiki.net.
Change-Id: I7252cd98b885e0af536d7f7357a7fc379ac75421
2020-03-30 08:38:53 +02:00
Bartosz Dziewoński a14293c8e7 Remove Parsoid section wrappers before finding transclusions
The section wrappers can be marked as template-affected when the
previous or next section is transcluded, causing comments to be
unnecessarily uneditable. The new test case demonstrates this.

Depends-On: I03bc455d5484a6c51f3fa2397c64936b829fe7e3
Change-Id: I895a04990d79a3475d778b4fef054ea0bb076f0b
2020-03-24 23:31:21 +01:00
Bartosz Dziewoński bb2b2f2648 Remove dependency on 'ext.visualEditor.core.utils'
We only need ve.resolveUrl, which has been moved
to 'ext.visualEditor.core.utils.parsing'
in Ib2911aaed02250e79a2238ce0a6080a34165d636.

Depends-On: Ib2911aaed02250e79a2238ce0a6080a34165d636
Change-Id: I054026fbfd67f9a64cc0d748b57693fc2237ff08
2020-03-24 22:30:02 +00:00
Bartosz Dziewoński 216516f719 Rename tests/qunit/utils.js to .../testUtils.js
We now also have modules/utils.js and I found the identical name confusing.

Change-Id: I6895748528241e0368a79eab9dcf3123afaf5f87
2020-03-24 22:29:48 +00:00
Bartosz Dziewoński 807afd1ec0 Save the reply directly to the transcluded page
* When we discover the comment comes from a transcluded page, follow
  the transclusion to find the source page. We follow transclusions
  recursively, up to an arbitrary limit of 10.
* In the reply widget, display the title of the page where we will
  save the reply, to avoid users confused why their edit won't show up
  in the history. In the wikitext workflow this is done by redirecting
  the user to the edited page at the end, but it seems less surprising
  to stay on the current page.
* After saving the reply, we must purge the current page, otherwise
  the new content will not be immediately visible on it.

Bug: T247535
Change-Id: I1c6631aa65a2fce6c1c2f0dd4a8c7aa6389caf94
2020-03-24 22:29:42 +00:00
Bartosz Dziewoński dab37fd7b4 parser: Make #getTranscludedFrom return page title in text form
It's more convenient for display or comparing it with other things.

Depends-On: I03bc455d5484a6c51f3fa2397c64936b829fe7e3
Change-Id: I88d7aa68977210b16860075ed52983a5e99ee0f7
2020-03-24 22:29:35 +00:00
Translation updater bot be609d1f9a Localisation updates from https://translatewiki.net.
Change-Id: I79cd0552ede738de728c9cecbce2f0fff3cf70a0
2020-03-24 08:49:00 +01:00
Translation updater bot 672e678598 Localisation updates from https://translatewiki.net.
Change-Id: If299b4f38c4c26adbb136d1d713a79c5023e92ff
2020-03-23 09:02:54 +01:00
libraryupgrader 19b8d8ef3f build: Updating npm dependencies
* mkdirp: 0.5.1 → 0.5.3
  * https://npmjs.com/advisories/1179
* eslint: 6.5.1 → 6.8.0
  * https://npmjs.com/advisories/1179

Change-Id: I50ea09f3d841ff08810d6a5371112edd7227cc39
2020-03-20 22:13:16 +00:00
jenkins-bot 85472b7e31 Merge "ReplyWidget: Double-check that we can post before posting" 2020-03-20 19:37:48 +00:00
jenkins-bot 5b8b801989 Merge "Use 'baserevid' instead of 'basetimestamp' for edit conflict detection" 2020-03-20 19:30:15 +00:00
Bartosz Dziewoński 7fcd880fa5 controller: Fix minor issues with error popup
The rejection handling callback was accidentally resolving the
promise, which resulted in an error like 'TypeError: Cannot read
property '$element' of undefined' when the resolution value was
used.

Fixing this reveals that we weren't removing the placeholder list
element correctly. This wasn't immediately visible because of the
.empty() call in the next resolution callback, but it would have
caused something similar to T245574.

Follow-up to 6964f0c965.

Change-Id: I3aeb9a86046c4ccaa6c39301edc7285d02b0320c
2020-03-20 19:01:03 +00:00
jenkins-bot 1705e61adf Merge "Also update 'jsconfigvars' when previewing" 2020-03-20 11:26:50 +00:00
Translation updater bot c47c2619d3 Localisation updates from https://translatewiki.net.
Change-Id: Id5502603700b45178a42ffeaaff488bc617ecb5a
2020-03-20 08:23:50 +01:00
Bartosz Dziewoński 9d2cb7bdd0 Also update 'jsconfigvars' when previewing
This fixes a warning in the API: 'Property "modules" was set but not
"jsconfigvars" or "encodedjsconfigvars". Configuration variables are
necessary for proper module usage.'

We were already updating them when saving.

Change-Id: I3e16e3fd4b43a438c27645cca90517b6b4be7db7
2020-03-19 18:19:15 +01:00
Bartosz Dziewoński a6ce1e23a7 ReplyWidget: Double-check that we can post before posting
Bug: T246058
Change-Id: Ic87b062c2fd6d7f48933a94e140ce392003ee65a
2020-03-19 01:03:09 +01:00
Translation updater bot 15e511f820 Localisation updates from https://translatewiki.net.
Change-Id: If22cb5c45daffe593f77336ed24dcc72af6fe284
2020-03-18 08:57:27 +01:00
libraryupgrader 6ca383e955 build: Updating minimist to 1.2.5
* https://npmjs.com/advisories/1179

Change-Id: Ie9ef24367748d271c875f817cefe821178ccbc4a
2020-03-18 07:03:16 +00:00
Translation updater bot 937a42e69f Localisation updates from https://translatewiki.net.
Change-Id: Ibe3a00b3271f93d7edd558b68ec24c54d65b0f3e
2020-03-16 16:00:52 +01:00
Bartosz Dziewoński e9b583d1c3 parser: Improve merging multiple comments on one line
Now also works if the "follow-up" comment is wrapped in e.g. `<small>`.

Change-Id: Ic37cb6afdb42021f109a1818f5c4299d907ed094
2020-03-14 13:34:42 +00:00
Bartosz Dziewoński 04365c0188 Merge RL modules which are only loaded by 'ext.discussionTools.init'
Bug: T240474
Change-Id: I1b83aa18666be8f1ea6a3602b299f92574d42cb7
2020-03-14 14:33:23 +01:00
Bartosz Dziewoński 92c3f079b8 controller: Make edit summary use the wiki's content language
Bug: T246043
Change-Id: I591e1a3ed3e7c8b68f5e203a0c77d057793fc767
2020-03-14 14:17:29 +01:00
jenkins-bot f97e6303a3 Merge "controller: Show error messages immediately when loading fails" 2020-03-13 22:13:19 +00:00
Ed Sanders 1be47f0599 Support saving multi-line comments in VE
Change-Id: I3e19fac750dbb8d10b6e1bf6081453c75768e625
2020-03-13 16:12:01 +00:00
Translation updater bot 820fe11584 Localisation updates from https://translatewiki.net.
Change-Id: I1ee41cfe541782b5736f05e1475b692d5d4958b8
2020-03-13 08:54:12 +01:00
Bartosz Dziewoński 6964f0c965 controller: Show error messages immediately when loading fails
Previously you'd only learn about the issue when saving failed.
Now a modal alert dialog with the error message appears.

This means that we have to wait for the loading to finish before we
can display the ReplyWidget now... this should not be noticeable,
since we preload in #init.

Bug: T247533
Change-Id: I5468e67c449d530a0d15f69bff954d37a5b6a14c
2020-03-12 19:24:00 +01:00
Bartosz Dziewoński 4e135c7f07 Use 'baserevid' instead of 'basetimestamp' for edit conflict detection
This has two benefits:
* Allows detecting a conflict if two edits are saved in the same second
* Doesn't ignore conflicts with yourself (T246726)

Depends-On: Id7565018f66860b5c2ba688777508db1b88700ae
Bug: T246726
Change-Id: I22eaa1af5692854870d31e08b171a070a2fda0de
2020-03-12 16:31:32 +00:00