parser: Improve merging multiple comments on one line

Now also works if the "follow-up" comment is wrapped in e.g. `<small>`.

Change-Id: Ic37cb6afdb42021f109a1818f5c4299d907ed094
This commit is contained in:
Bartosz Dziewoński 2020-03-08 15:32:38 +01:00
parent 04365c0188
commit e9b583d1c3
12 changed files with 45 additions and 63 deletions

View file

@ -40,6 +40,7 @@
},
"logger.js",
"modifier.js",
"utils.js",
"parser.js",
"lib/moment-timezone/moment-timezone-with-data-1970-2030.js",
{

View file

@ -25,5 +25,6 @@ module.exports = {
controller: require( './controller.js' ),
parser: require( './parser.js' ),
modifier: require( './modifier.js' ),
utils: require( './utils.js' ),
logger: require( './logger.js' )
};

View file

@ -1,5 +1,5 @@
var controller = require( 'ext.discussionTools.init' ).controller,
modifier = require( 'ext.discussionTools.init' ).modifier,
utils = require( 'ext.discussionTools.init' ).utils,
logger = require( 'ext.discussionTools.init' ).logger;
/**
@ -21,7 +21,7 @@ function ReplyWidget( comment, config ) {
ReplyWidget.super.call( this, config );
this.comment = comment;
contextNode = modifier.closestElement( this.comment.range.endContainer, [ 'dl', 'ul', 'ol' ] );
contextNode = utils.closestElement( this.comment.range.endContainer, [ 'dl', 'ul', 'ol' ] );
this.context = contextNode ? contextNode.nodeName.toLowerCase() : 'dl';
inputConfig = $.extend(

View file

@ -1,22 +1,8 @@
/* global $:off */
'use strict';
/**
* Find closest ancestor element using one of the given tag names.
*
* @param {Node} el
* @param {string[]} tagNames
* @return {HTMLElement|null}
*/
function closestElement( el, tagNames ) {
do {
if ( el.nodeType === Node.ELEMENT_NODE && tagNames.indexOf( el.tagName.toLowerCase() ) !== -1 ) {
return el;
}
el = el.parentNode;
} while ( el );
return null;
}
var
utils = require( './utils.js' );
function whitespaceParsoidHack( listItem ) {
// HACK: Setting data-parsoid removes the whitespace after the list item,
@ -105,7 +91,7 @@ function addListItem( comment ) {
// First, we need to find a block-level parent that we can mess with.
// If we can't find a surrounding list item or paragraph (e.g. maybe we're inside a table cell
// or something), take the parent node and hope for the best.
parent = closestElement( target, [ 'li', 'dd', 'p' ] ) || target.parentNode;
parent = utils.closestElement( target, [ 'li', 'dd', 'p' ] ) || target.parentNode;
while ( target.parentNode !== parent ) {
target = target.parentNode;
}
@ -240,7 +226,6 @@ function createWikitextNode( wt ) {
}
module.exports = {
closestElement: closestElement,
addReplyLink: addReplyLink,
addListItem: addListItem,
removeListItem: removeListItem,

View file

@ -1,8 +1,9 @@
/* eslint-disable no-console */
'use strict';
// DiscussionToolsHooks::getLocalData()
var
utils = require( './utils.js' ),
// DiscussionToolsHooks::getLocalData()
data = require( './parser/data.json' ),
moment = require( './lib/moment-timezone/moment-timezone-with-data-1970-2030.js' );
@ -746,7 +747,8 @@ function getComments( rootNode ) {
// notifications or something).
if (
curComment.type === 'comment' &&
node.parentNode === curComment.range.endContainer.parentNode
( utils.closestElement( node, [ 'li', 'dd', 'p' ] ) || node.parentNode ) ===
( utils.closestElement( curComment.range.endContainer, [ 'li', 'dd', 'p' ] ) || curComment.range.endContainer.parentNode )
) {
// Merge this with the previous comment. Use that comment's author and timestamp.
curComment.range.endContainer = range.endContainer;

22
modules/utils.js Normal file
View file

@ -0,0 +1,22 @@
'use strict';
/**
* Find closest ancestor element using one of the given tag names.
*
* @param {Node} el
* @param {string[]} tagNames
* @return {HTMLElement|null}
*/
function closestElement( el, tagNames ) {
do {
if ( el.nodeType === Node.ELEMENT_NODE && tagNames.indexOf( el.tagName.toLowerCase() ) !== -1 ) {
return el;
}
el = el.parentNode;
} while ( el );
return null;
}
module.exports = {
closestElement: closestElement
};

View file

@ -2543,13 +2543,13 @@ P-
<h2><span id="Not_running_.22Community_tech_bot.22_for_Popular_pages"></span><span class="mw-headline" id="Not_running_&quot;Community_tech_bot&quot;_for_Popular_pages">Not running "Community tech bot" for Popular pages</span></h2>
<p><img alt="" src="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/14px-Pictogram_voting_wait.svg.png" decoding="async" width="14" height="14" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/21px-Pictogram_voting_wait.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/28px-Pictogram_voting_wait.svg.png 2x" data-file-width="256" data-file-height="256"> <span style="font-size:85%;"><b>Bumping thread</b><span class="nowrap">&nbsp;</span>for 30 days. <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 02:46, 19 July 2019 (UTC)</span>
Greetings, Community tech bot appears to be down (not running) since April, 2019. Instructions are <i>To report bugs, please write on the <a href="https://meta.wikimedia.org/wiki/User_talk:Community_Tech_bot" class="extiw" title="meta:User talk:Community Tech bot">Community tech bot</a> talk page on Meta.</i> I did report in June, and with no response. Wondering if an expert here could fix? For example, <a href="//en.wikipedia.org/wiki/Wikipedia:WikiProject_Saints/Popular_pages" title="Wikipedia:WikiProject Saints/Popular pages">Wikipedia:WikiProject Saints/Popular pages</a> Updated: 6:32 pm, 26 April 2019, Friday (2 months, 13 days ago). Regards, <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 13:06, 8 July 2019 (UTC)
</p><dl><dd data-parsoid="{}">Reply to JoeHebda|2019-07-19T02:46:00.000Z|0</dd></dl>
</p>
<ul><li><span class="template-ping">@<a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> any insight in to this? — <a href="//en.wikipedia.org/wiki/User:Xaosflux" title="User:Xaosflux"><span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span></a> <sup><a href="//en.wikipedia.org/wiki/User_talk:Xaosflux" title="User talk:Xaosflux"><span style="color:#009933;">Talk</span></a></sup> 18:59, 8 July 2019 (UTC)
<dl><dd>The cron job for this month didn't start for some reason. I have manually triggered it. "Saints" is pretty far down the list so it may be a while before the bot gets to it. I don't have an answer as to why no report was created for May and June, but I will investigate. Also, don't forget about <a href="https://tools.wmflabs.org/massviews" class="extiw" title="toolforge:massviews">toolforge:massviews</a> which can give you the same information in real-time: <a class="external autonumber" href="https://tools.wmflabs.org/massviews/?platform=all-access&amp;agent=user&amp;source=category&amp;target=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FCategory%3AWikiProject_Saints_articles&amp;range=last-month&amp;subjectpage=1&amp;subcategories=1&amp;sort=views&amp;direction=1&amp;view=list">[45]</a>. That tool seems to be having problems of its own (lots of errors querying the pageviews API, tracked at <a href="https://phabricator.wikimedia.org/T219857" class="extiw" title="phab:T219857">phab:T219857</a>), which I'm starting to believe might be the same reason Popular Pages bot isn't finishing some reports. <a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a> (<a href="//en.wikipedia.org/wiki/User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)">talk</a>) 20:12, 8 July 2019 (UTC)
<dl><dd>Thanks <span class="template-ping">@<a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - I really like viewing Popular Pages on my fav. WPs; very helpful! Wondering if bot stalls out if it's not done running current month jobs &amp; at calendar new month (day 1) starts a second bot? Just curious... <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 12:26, 9 July 2019 (UTC)
<dl><dd>I suspect all the reports will be done within the next two weeks. If not, the reports for July will start populating on the 3rd. This is because it takes up to two full days for the previous month's data to be available. Best, <a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a> (<a href="//en.wikipedia.org/wiki/User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)">talk</a>) 17:28, 9 July 2019 (UTC)
<dl><dd>Hello <span class="template-ping">@<a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - Since starting at 15:41, 8 July 2019, the bot as of this morning has processed 60 WPs out of over 1,600 so it has a long ways to go to complete. At 30 perday, thats 53 days of runtime. <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 14:01, 10 July 2019 (UTC)
<dl><dd>The bot only goes through WPs configured at <a href="//en.wikipedia.org/wiki/User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json">User:Community Tech bot/Popular pages config.json</a>, which is about 800 or so. Most of these are quite small and will be processed quickly. That said I certainly can't guarantee they will all be finished before the month is over. We are monitoring and are discussing ways to improve performance. Thanks for your patience, <a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a> (<a href="//en.wikipedia.org/wiki/User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)">talk</a>) 18:39, 10 July 2019 (UTC)<dl><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-10T18:39:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-10T14:01:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-09T17:28:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-09T12:26:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-08T20:12:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to Xaosflux|2019-07-08T18:59:00.000Z|0</dd></dl></li><li data-parsoid="{}">Reply to JoeHebda|2019-07-08T13:06:00.000Z|0</li></ul>
<dl><dd>The bot only goes through WPs configured at <a href="//en.wikipedia.org/wiki/User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json">User:Community Tech bot/Popular pages config.json</a>, which is about 800 or so. Most of these are quite small and will be processed quickly. That said I certainly can't guarantee they will all be finished before the month is over. We are monitoring and are discussing ways to improve performance. Thanks for your patience, <a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a> (<a href="//en.wikipedia.org/wiki/User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)">talk</a>) 18:39, 10 July 2019 (UTC)<dl><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-10T18:39:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-10T14:01:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-09T17:28:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-09T12:26:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-08T20:12:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to Xaosflux|2019-07-08T18:59:00.000Z|0</dd></dl></li><li data-parsoid="{}">Reply to JoeHebda|2019-07-19T02:46:00.000Z|0</li></ul>
<p><span class="outdent-template" style="display:block;margin-top:-0.5em;color:#AAA;;position:relative;left:-0.25em"><span style="display:inline-block; overflow:hidden;"></span><span style="display:inline-block; overflow:hidden; word-wrap:normal; width:7.3em;">────────────</span><span style="display:inline-block; overflow:hidden;"></span></span>
</p>
<ul><li>Hi <span class="template-ping">@<a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - while checking "Community Tech bot" info. I found another bot-related table <a href="//en.wikipedia.org/wiki/Wikipedia:Lists_of_popular_pages_by_WikiProject" title="Wikipedia:Lists of popular pages by WikiProject">Lists of popular pages by WikiProject</a>. And it appears to be manually maintained. Comparing this table against <a href="//en.wikipedia.org/wiki/User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json">bot configuration table</a>, every config entry after <a href="//en.wikipedia.org/wiki/Wikipedia:WikiProject_U.S._Roads/Wyoming/Popular_pages" title="Wikipedia:WikiProject U.S. Roads/Wyoming/Popular pages">WikiProject U.S. Roads/Wyoming/Popular pages</a> is missing. Brings up questions:</li></ul>

View file

@ -2541,7 +2541,7 @@ P-
</p>
<dl><dd>People do not come here to read policy and disclaimers. --<a href="//en.wikipedia.org/wiki/User:Izno" title="User:Izno">Izno</a> (<a href="//en.wikipedia.org/wiki/User_talk:Izno" title="User talk:Izno">talk</a>) 14:34, 17 August 2019 (UTC)<a href="#">Reply</a></dd></dl>
<h2><span id="Not_running_.22Community_tech_bot.22_for_Popular_pages"></span><span class="mw-headline" id="Not_running_&quot;Community_tech_bot&quot;_for_Popular_pages">Not running "Community tech bot" for Popular pages</span></h2>
<p><img alt="" src="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/14px-Pictogram_voting_wait.svg.png" decoding="async" width="14" height="14" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/21px-Pictogram_voting_wait.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/28px-Pictogram_voting_wait.svg.png 2x" data-file-width="256" data-file-height="256"> <span style="font-size:85%;"><b>Bumping thread</b><span class="nowrap">&nbsp;</span>for 30 days. <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 02:46, 19 July 2019 (UTC)<a href="#">Reply</a></span>
<p><img alt="" src="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/14px-Pictogram_voting_wait.svg.png" decoding="async" width="14" height="14" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/21px-Pictogram_voting_wait.svg.png 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/28px-Pictogram_voting_wait.svg.png 2x" data-file-width="256" data-file-height="256"> <span style="font-size:85%;"><b>Bumping thread</b><span class="nowrap">&nbsp;</span>for 30 days. <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 02:46, 19 July 2019 (UTC)</span>
Greetings, Community tech bot appears to be down (not running) since April, 2019. Instructions are <i>To report bugs, please write on the <a href="https://meta.wikimedia.org/wiki/User_talk:Community_Tech_bot" class="extiw" title="meta:User talk:Community Tech bot">Community tech bot</a> talk page on Meta.</i> I did report in June, and with no response. Wondering if an expert here could fix? For example, <a href="//en.wikipedia.org/wiki/Wikipedia:WikiProject_Saints/Popular_pages" title="Wikipedia:WikiProject Saints/Popular pages">Wikipedia:WikiProject Saints/Popular pages</a> Updated: 6:32 pm, 26 April 2019, Friday (2 months, 13 days ago). Regards, <a href="//en.wikipedia.org/wiki/User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a href="//en.wikipedia.org/wiki/User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 13:06, 8 July 2019 (UTC)<a href="#">Reply</a>
</p>
<ul><li><span class="template-ping">@<a href="//en.wikipedia.org/wiki/User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> any insight in to this? — <a href="//en.wikipedia.org/wiki/User:Xaosflux" title="User:Xaosflux"><span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span></a> <sup><a href="//en.wikipedia.org/wiki/User_talk:Xaosflux" title="User talk:Xaosflux"><span style="color:#009933;">Talk</span></a></sup> 18:59, 8 July 2019 (UTC)<a href="#">Reply</a>

View file

@ -19425,34 +19425,20 @@
"author": "JoeHebda",
"range": [
"0/1514/0",
"0/1514/2/6/27"
"0/1514/11/26"
],
"signatureRanges": [
[
"0/1514/2/3",
"0/1514/2/6/27"
]
],
"level": 1,
"id": "JoeHebda|2019-07-19T02:46:00.000Z|0",
"replies": []
},
{
"type": "comment",
"timestamp": "2019-07-08T13:06:00.000Z",
"author": "JoeHebda",
"range": [
"0/1514/3",
"0/1514/11/26"
],
"signatureRanges": [
],
[
"0/1514/8",
"0/1514/11/26"
]
],
"level": 1,
"id": "JoeHebda|2019-07-08T13:06:00.000Z|0",
"id": "JoeHebda|2019-07-19T02:46:00.000Z|0",
"replies": [
{
"type": "comment",

View file

@ -2485,13 +2485,13 @@ P-
</section><section data-mw-section-id="185" id="mwHZI"><h2 id="Not_running_&quot;Community_tech_bot&quot;_for_Popular_pages"><span id="Not_running_.22Community_tech_bot.22_for_Popular_pages" typeof="mw:FallbackId"></span>Not running "Community tech bot" for Popular pages</h2>
<p id="mwHZM"><figure-inline typeof="mw:Image" id="mwHZQ"><span id="mwHZU"><img alt="" resource="./File:Pictogram_voting_wait.svg" src="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/14px-Pictogram_voting_wait.svg.png" data-file-width="256" data-file-height="256" data-file-type="drawing" height="14" width="14" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/28px-Pictogram_voting_wait.svg.png 2x, //upload.wikimedia.org/wikipedia/commons/thumb/6/6a/Pictogram_voting_wait.svg/21px-Pictogram_voting_wait.svg.png 1.5x" id="mwHZY"></span></figure-inline> <span style="font-size:85%;" about="#mwt805" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;Small&quot;,&quot;href&quot;:&quot;./Template:Small&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;'''Bumping thread'''{{space}}for 30 days. [[User:JoeHebda|JoeHebda]] ([[User talk:JoeHebda|talk]]) 02:46, 19 July 2019 (UTC)&quot;}},&quot;i&quot;:0}}]}" id="mwHZc"><b>Bumping thread</b><span class="nowrap"><span typeof="mw:Entity">&nbsp;</span></span>for 30 days. <a rel="mw:WikiLink" href="./User:JoeHebda" title="User:JoeHebda">JoeHebda</a> (<a rel="mw:WikiLink" href="./User_talk:JoeHebda" title="User talk:JoeHebda">talk</a>) 02:46, 19 July 2019 (UTC)</span><!-- [[Template:Bump]] --><!-- [[User:DoNotArchiveUntil]] 02:46, 18 August 2019 (UTC) --><span about="#mwt806" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;User:ClueBot III/DoNotArchiveUntil&quot;,&quot;href&quot;:&quot;./User:ClueBot_III/DoNotArchiveUntil&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;1566096361&quot;}},&quot;i&quot;:0}}]}" id="mwHZg"></span>
Greetings, Community tech bot appears to be down (not running) since April, 2019. Instructions are <i id="mwHZk">To report bugs, please write on the <a rel="mw:WikiLink/Interwiki" href="https://meta.wikimedia.org/wiki/User_talk:Community_Tech_bot" title="meta:User talk:Community Tech bot" id="mwHZo">Community tech bot</a> talk page on Meta.</i> I did report in June, and with no response. Wondering if an expert here could fix? For example, <a rel="mw:WikiLink" href="./Wikipedia:WikiProject_Saints/Popular_pages" title="Wikipedia:WikiProject Saints/Popular pages" id="mwHZs">Wikipedia:WikiProject Saints/Popular pages</a> Updated: 6:32 pm, 26 April 2019, Friday (2 months, 13 days ago). Regards, <a rel="mw:WikiLink" href="./User:JoeHebda" title="User:JoeHebda" id="mwHZw">JoeHebda</a> (<a rel="mw:WikiLink" href="./User_talk:JoeHebda" title="User talk:JoeHebda" id="mwHZ0">talk</a>) 13:06, 8 July 2019 (UTC)</p><dl><dd data-parsoid="{}">Reply to JoeHebda|2019-07-19T02:46:00.000Z|0</dd></dl>
Greetings, Community tech bot appears to be down (not running) since April, 2019. Instructions are <i id="mwHZk">To report bugs, please write on the <a rel="mw:WikiLink/Interwiki" href="https://meta.wikimedia.org/wiki/User_talk:Community_Tech_bot" title="meta:User talk:Community Tech bot" id="mwHZo">Community tech bot</a> talk page on Meta.</i> I did report in June, and with no response. Wondering if an expert here could fix? For example, <a rel="mw:WikiLink" href="./Wikipedia:WikiProject_Saints/Popular_pages" title="Wikipedia:WikiProject Saints/Popular pages" id="mwHZs">Wikipedia:WikiProject Saints/Popular pages</a> Updated: 6:32 pm, 26 April 2019, Friday (2 months, 13 days ago). Regards, <a rel="mw:WikiLink" href="./User:JoeHebda" title="User:JoeHebda" id="mwHZw">JoeHebda</a> (<a rel="mw:WikiLink" href="./User_talk:JoeHebda" title="User talk:JoeHebda" id="mwHZ0">talk</a>) 13:06, 8 July 2019 (UTC)</p>
<ul id="mwHZ4"><li id="mwHZ8"><span class="template-ping" about="#mwt807" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;ping&quot;,&quot;href&quot;:&quot;./Template:Ping&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;MusikAnimal (WMF)&quot;}},&quot;i&quot;:0}}]}" id="mwHaA">@<a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> any insight in to this? — <a rel="mw:WikiLink" href="./User:Xaosflux" title="User:Xaosflux" id="mwHaE"><span style="color:#FF9933; font-weight:bold; font-family:monotype;" id="mwHaI">xaosflux</span></a> <sup id="mwHaM"><a rel="mw:WikiLink" href="./User_talk:Xaosflux" title="User talk:Xaosflux" id="mwHaQ"><span style="color:#009933;" id="mwHaU">Talk</span></a></sup> 18:59, 8 July 2019 (UTC)
<dl id="mwHaY"><dd id="mwHac">The cron job for this month didn't start for some reason. I have manually triggered it. "Saints" is pretty far down the list so it may be a while before the bot gets to it. I don't have an answer as to why no report was created for May and June, but I will investigate. Also, don't forget about <a rel="mw:WikiLink/Interwiki" href="https://tools.wmflabs.org/massviews" title="toolforge:massviews" id="mwHag">toolforge:massviews</a> which can give you the same information in real-time: <a rel="mw:ExtLink" href="https://tools.wmflabs.org/massviews/?platform=all-access&amp;agent=user&amp;source=category&amp;target=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FCategory%3AWikiProject_Saints_articles&amp;range=last-month&amp;subjectpage=1&amp;subcategories=1&amp;sort=views&amp;direction=1&amp;view=list" class="external autonumber" id="mwHak"></a>. That tool seems to be having problems of its own (lots of errors querying the pageviews API, tracked at <a rel="mw:WikiLink/Interwiki" href="https://phabricator.wikimedia.org/T219857" title="phab:T219857" id="mwHao">phab:T219857</a>), which I'm starting to believe might be the same reason Popular Pages bot isn't finishing some reports. <a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)" id="mwHas">MusikAnimal (WMF)</a> (<a rel="mw:WikiLink" href="./User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)" id="mwHaw">talk</a>) 20:12, 8 July 2019 (UTC)
<dl id="mwHa0"><dd id="mwHa4">Thanks <span class="template-ping" about="#mwt808" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;Re&quot;,&quot;href&quot;:&quot;./Template:Re&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;MusikAnimal (WMF)&quot;}},&quot;i&quot;:0}}]}" id="mwHa8">@<a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - I really like viewing Popular Pages on my fav. WPs; very helpful! Wondering if bot stalls out if it's not done running current month jobs &amp; at calendar new month (day 1) starts a second bot? Just curious... <a rel="mw:WikiLink" href="./User:JoeHebda" title="User:JoeHebda" id="mwHbA">JoeHebda</a> (<a rel="mw:WikiLink" href="./User_talk:JoeHebda" title="User talk:JoeHebda" id="mwHbE">talk</a>) 12:26, 9 July 2019 (UTC)
<dl id="mwHbI"><dd id="mwHbM">I suspect all the reports will be done within the next two weeks. If not, the reports for July will start populating on the 3rd. This is because it takes up to two full days for the previous month's data to be available. Best, <a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)" id="mwHbQ">MusikAnimal (WMF)</a> (<a rel="mw:WikiLink" href="./User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)" id="mwHbU">talk</a>) 17:28, 9 July 2019 (UTC)
<dl id="mwHbY"><dd id="mwHbc">Hello <span class="template-ping" about="#mwt809" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;Re&quot;,&quot;href&quot;:&quot;./Template:Re&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;MusikAnimal (WMF)&quot;}},&quot;i&quot;:0}}]}" id="mwHbg">@<a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - Since starting at 15:41, 8 July 2019, the bot as of this morning has processed 60 WPs out of over 1,600 so it has a long ways to go to complete. At 30 perday, thats 53 days of runtime. <a rel="mw:WikiLink" href="./User:JoeHebda" title="User:JoeHebda" id="mwHbk">JoeHebda</a> (<a rel="mw:WikiLink" href="./User_talk:JoeHebda" title="User talk:JoeHebda" id="mwHbo">talk</a>) 14:01, 10 July 2019 (UTC)
<dl id="mwHbs"><dd id="mwHbw">The bot only goes through WPs configured at <a rel="mw:WikiLink" href="./User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json" id="mwHb0">User:Community Tech bot/Popular pages config.json</a>, which is about 800 or so. Most of these are quite small and will be processed quickly. That said I certainly can't guarantee they will all be finished before the month is over. We are monitoring and are discussing ways to improve performance. Thanks for your patience, <a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)" id="mwHb4">MusikAnimal (WMF)</a> (<a rel="mw:WikiLink" href="./User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)" id="mwHb8">talk</a>) 18:39, 10 July 2019 (UTC)<dl><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-10T18:39:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-10T14:01:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-09T17:28:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-09T12:26:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-08T20:12:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to Xaosflux|2019-07-08T18:59:00.000Z|0</dd></dl></li><li data-parsoid="{}">Reply to JoeHebda|2019-07-08T13:06:00.000Z|0</li></ul>
<dl id="mwHbs"><dd id="mwHbw">The bot only goes through WPs configured at <a rel="mw:WikiLink" href="./User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json" id="mwHb0">User:Community Tech bot/Popular pages config.json</a>, which is about 800 or so. Most of these are quite small and will be processed quickly. That said I certainly can't guarantee they will all be finished before the month is over. We are monitoring and are discussing ways to improve performance. Thanks for your patience, <a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)" id="mwHb4">MusikAnimal (WMF)</a> (<a rel="mw:WikiLink" href="./User_talk:MusikAnimal_(WMF)" title="User talk:MusikAnimal (WMF)" id="mwHb8">talk</a>) 18:39, 10 July 2019 (UTC)<dl><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-10T18:39:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-10T14:01:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-09T17:28:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to JoeHebda|2019-07-09T12:26:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to MusikAnimal (WMF)|2019-07-08T20:12:00.000Z|0</dd></dl></dd><dd data-parsoid="{}">Reply to Xaosflux|2019-07-08T18:59:00.000Z|0</dd></dl></li><li data-parsoid="{}">Reply to JoeHebda|2019-07-19T02:46:00.000Z|0</li></ul>
<p id="mwHcA"><span class="outdent-template" style="display:block;margin-top:-0.5em;color:#AAA;;position:relative;left:-0.25em" about="#mwt810" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;outdent&quot;,&quot;href&quot;:&quot;./Template:Outdent&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;5&quot;}},&quot;i&quot;:0}}]}" id="mwHcE"><span style="display:inline-block; overflow:hidden;"></span><span style="display:inline-block; overflow:hidden; word-wrap:normal; width:7.3em;">────────────</span><span style="display:inline-block; overflow:hidden;"></span></span></p>
<ul id="mwHcI"><li id="mwHcM">Hi <span class="template-ping" about="#mwt811" typeof="mw:Transclusion" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;Re&quot;,&quot;href&quot;:&quot;./Template:Re&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;MusikAnimal (WMF)&quot;}},&quot;i&quot;:0}}]}" id="mwHcQ">@<a rel="mw:WikiLink" href="./User:MusikAnimal_(WMF)" title="User:MusikAnimal (WMF)">MusikAnimal (WMF)</a>:</span> - while checking "Community Tech bot" info. I found another bot-related table <a rel="mw:WikiLink" href="./Wikipedia:Lists_of_popular_pages_by_WikiProject" title="Wikipedia:Lists of popular pages by WikiProject" id="mwHcU">Lists of popular pages by WikiProject</a>. And it appears to be manually maintained. Comparing this table against <a rel="mw:WikiLink" href="./User:Community_Tech_bot/Popular_pages_config.json" title="User:Community Tech bot/Popular pages config.json" id="mwHcY">bot configuration table</a>, every config entry after <a rel="mw:WikiLink" href="./Wikipedia:WikiProject_U.S._Roads/Wyoming/Popular_pages" title="Wikipedia:WikiProject U.S. Roads/Wyoming/Popular pages" id="mwHcc">WikiProject U.S. Roads/Wyoming/Popular pages</a> is missing. Brings up questions:</li></ul>
<ol id="mwHcg"><li id="mwHck">Should the Lists table be updated? So it matches the Config table.</li>

View file

@ -933,8 +933,7 @@
"PrimeHunter|2019-08-17T08:13:00.000Z|0": false,
"Monniasza|2019-08-17T14:19:00.000Z|0": false,
"Izno|2019-08-17T14:34:00.000Z|0": false,
"JoeHebda|2019-07-19T02:46:00.000Z|0": "Template:Small",
"JoeHebda|2019-07-08T13:06:00.000Z|0": false,
"JoeHebda|2019-07-19T02:46:00.000Z|0": false,
"Xaosflux|2019-07-08T18:59:00.000Z|0": false,
"MusikAnimal (WMF)|2019-07-08T20:12:00.000Z|0": false,
"JoeHebda|2019-07-09T12:26:00.000Z|0": false,

View file

@ -19424,34 +19424,20 @@
"author": "JoeHebda",
"range": [
"176/2/0/0/0",
"176/2/2/6/27"
"176/2/14/26"
],
"signatureRanges": [
[
"176/2/2/3",
"176/2/2/6/27"
]
],
"level": 1,
"id": "JoeHebda|2019-07-19T02:46:00.000Z|0",
"replies": []
},
{
"type": "comment",
"timestamp": "2019-07-08T13:06:00.000Z",
"author": "JoeHebda",
"range": [
"176/2/5",
"176/2/14/26"
],
"signatureRanges": [
],
[
"176/2/11",
"176/2/14/26"
]
],
"level": 1,
"id": "JoeHebda|2019-07-08T13:06:00.000Z|0",
"id": "JoeHebda|2019-07-19T02:46:00.000Z|0",
"replies": [
{
"type": "comment",