Bartosz Dziewoński
522b7932d7
ReplyWidget: Hide external links icons in the anon warning
...
Similar to 282c987efa
2021-03-17 15:50:34 +01:00
Ed Sanders
ece8ff69ff
Change dt- class prefix to ext-discussiontools-
...
Longer, but follows the style guide and less likely to conflict.
We need to account for init classes in the cache being around for
a while.
Change-Id: I738bc93393850db320fdbda2b003ca8ac40556da
2021-03-13 14:42:39 +00:00
Bartosz Dziewoński
1a52f06daf
Tweak signature formatting in previews for more accurate results
...
When posting a new topic, if your comment ends with a template
that has trailing line breaks, the signature will be added as a
preformatted text (which is arguably a bug: T255741).
Preview, however, did not reflect this bug, because of the <span>
markup added to fade out the automatic signature.
Change-Id: I062b01a035e22edfca752a49c5e2433b3f7fb4f6
2021-03-09 01:08:59 +01:00
Bartosz Dziewoński
44f2209abf
Trim signatures when added in an empty existing node, too
...
Add unit tests for appendSignature().
Bug: T276612
Change-Id: Ic44c52f4d54492e092f9396c626380e2637b6f0f
2021-03-08 23:38:46 +00:00
Ed Sanders
5324e60e84
Tracking changes from VE source mode
...
Change-Id: I5cafa7a21a0ab90fab9d09e44b7525ee07f56709
2021-03-08 21:13:10 +00:00
jenkins-bot
17a3657b6a
Merge "Follow-up I60e550ef: Don't show relevant user in mention list if it is you"
2021-03-04 22:09:57 +00:00
Ed Sanders
45cda20cf3
Don't attempt to put comment markers in <noscript> tags
...
Bug: T276455
Change-Id: Ia427d97528b137111145ac79680972a660f28e37
2021-03-04 22:24:04 +01:00
Ed Sanders
998bd206ae
Follow-up I60e550ef: Don't show relevant user in mention list if it is you
...
We have logic above to exclude mentioning yourself, but this
is overridden if you are commenting on your own talk page.
Change-Id: I2858c79bd9f1cb733f105825e17f9df75859e40a
2021-03-04 20:59:00 +00:00
jenkins-bot
3dc27a73b0
Merge "Don't detect comments within 'cite' elements too"
2021-03-02 23:50:14 +00:00
Bartosz Dziewoński
f5059e6ea6
Don't detect comments within 'cite' elements too
...
Follow-up to 024a978ffd
2021-03-01 21:40:43 +01:00
jenkins-bot
78260b97fe
Merge "Ensure most of the widget doesn't move when blur-validating"
2021-03-01 20:39:06 +00:00
jenkins-bot
6650eb56cd
Merge "Fix toolbar dialog placement"
2021-03-01 19:59:39 +00:00
jenkins-bot
f1d5a75f84
Merge "Pass replyWidget to target"
2021-03-01 19:59:38 +00:00
jenkins-bot
0eb37a87df
Merge "Don't detect comments within quotes"
2021-02-28 22:56:20 +00:00
Bartosz Dziewoński
024a978ffd
Don't detect comments within quotes
...
Bug: T275881
Change-Id: I8f7a4279837bd95ebf5b604ff350c0a3f29c2c05
2021-02-28 22:49:48 +00:00
Ed Sanders
665f68f838
Fix toolbar dialog placement
...
There are no available tools that use this, but it
can be tested using:
ve.init.target.surface.executeCommand('specialCharacter')
Change-Id: I853e6a3b9bd3caff018b6fe22cea9b1c6a428dff
2021-02-28 22:18:58 +00:00
Ed Sanders
f5c3da2a86
Pass replyWidget to target
...
This allows the target to access $headerWrapper directly
instead of using flaky DOM traversal.
Change-Id: I81f6616ea8fa7cbfb58e576fd5b2739c6158a216
2021-02-28 22:07:51 +00:00
Ed Sanders
c04a4c5c8f
Ensure most of the widget doesn't move when blur-validating
...
This ensures click events are interrupted on other controls.
Bug: T275923
Change-Id: Ib73d17a965f1fb7e2bc4870bdbb568a9f6d071d3
2021-02-28 15:00:12 +00:00
jenkins-bot
8bb5eea999
Merge "Improve signature detection to handle formatting on the timestamp"
2021-02-27 22:54:50 +00:00
jenkins-bot
c5874422df
Merge "CommentUtils: Fix edge case bug in getCoveredSiblings()"
2021-02-27 22:54:46 +00:00
jenkins-bot
49938a88dc
Merge "Improve merging multiple comments on one paragraph"
2021-02-27 22:54:43 +00:00
Ed Sanders
f62ce55671
Fix wikitext command registry inheritance
...
This fixes some missing commands in source mode, such as undo.
Change-Id: Ie470bd351e2fd67bcbb8cc839e70c3efcaaf1564
2021-02-27 18:24:36 +00:00
Bartosz Dziewoński
efe95494a8
Improve signature detection to handle formatting on the timestamp
...
Now it detect signatures generated by en.wp's {{Undated}} template,
and signatures of people who do weird stuff to the timestamps.
Bug: T275938
Change-Id: I27b07f6786ca5433a3c02a5fe68e4716d41401bb
2021-02-27 02:33:30 +01:00
Bartosz Dziewoński
e767ee1741
CommentUtils: Fix edge case bug in getCoveredSiblings()
...
In some cases it would return the parent node, instead of the siblings
it should return.
It's a private method only called by getFullyCoveredSiblings(), and
that method had a bug that cancelled out this one, so everything
worked correctly. But I want to use it elsewhere now and ran into it.
Change-Id: Ic12f007d57a8502a1bea5f0af17b29e9d59093d6
2021-02-27 02:26:42 +01:00
Bartosz Dziewoński
af082908a5
Improve merging multiple comments on one paragraph
...
The horrendous 11-line if() condition did not correctly handle
signatures wrapped in inline formatting markup, like <small>.
Instead, implement this logic in the code for skipping to the end
of a paragraph, which didn't exist yet when that condition was
added, but seems like a much better place to check this now.
Bug: T275934
Change-Id: I5cccff889b5e15b5f8fde0538bf4bccb22e762cf
2021-02-27 02:21:36 +01:00
Ed Sanders
01ac28540a
Support the enable2017Wikitext option
...
Bug: T257391
Change-Id: If2511609035c26063203512f4b860bd0060e08af
2021-02-26 19:13:54 +00:00
jenkins-bot
c4759bdcb1
Merge "CommentParser: Replace getThreadStartTimestamp with getThreadStartComment"
2021-02-24 16:46:56 +00:00
Bartosz Dziewoński
444e5deb62
Make sure the Visual/Source mode selector loses focus after switching
...
Bug: T274423
Change-Id: Icfa4d435e4cb0ecab123c5fbdb68f23ecde99b5f
2021-02-24 12:32:14 +00:00
Bartosz Dziewoński
35738b1f9b
CommentParser: Replace getThreadStartTimestamp with getThreadStartComment
...
Change-Id: Ia8d878594306b5ce4039ca06d6dcec753e5dea28
2021-02-24 12:26:58 +00:00
David Lynch
6ec1f39147
Change generation of logging session ID
...
Same pattern as is now used in VisualEditor. Generate an initial session
ID when the file loads, so if any VisualEditorFeatureUse events trigger
before the init there'll be a session ID for them to use.
Bug: T275051
Change-Id: I4f25e9e1e195c11129044868eb67fcc2f4494ffd
2021-02-23 15:37:22 -06:00
Ed Sanders
da72fb15c2
Only show reply links when body class in present
...
Bug: T273072
Bug: T274311
Change-Id: Ibe08c0eba0b80a5143845dcd1792d616ad8ffc61
2021-02-23 19:36:21 +00:00
jenkins-bot
f6cb81ce21
Merge "Show wikitext warnings for sequences not in reply tools"
2021-02-19 00:27:12 +00:00
Ed Sanders
6afb92d940
Show wikitext warnings for sequences not in reply tools
...
Bug: T274923
Change-Id: I56adc6524398805d3d6d582572e7524af8ba86a7
2021-02-18 22:52:35 +00:00
Ed Sanders
33c6181e79
Rename indent replacement methods
...
Change-Id: I8cb1b58dad068be7cfa62cab9e932463a23c6b12
2021-02-17 23:42:57 +00:00
jenkins-bot
c417d3279a
Merge "Make new topic autosave specific to page title"
2021-02-17 23:26:36 +00:00
jenkins-bot
872867c422
Merge "Fix highlight when new topic is posted without a title"
2021-02-17 23:26:34 +00:00
Bartosz Dziewoński
717955a513
Make new topic autosave specific to page title
...
Bug: T274949
Change-Id: I7e1bbcd6c606c7443f55fe3b1780021b07b28c5e
2021-02-17 20:09:13 +00:00
Bartosz Dziewoński
b7917f5fa4
Fix highlight when new topic is posted without a title
...
Bug: T272666
Change-Id: I9bf87d6e6e004001fa387e94623751eea694a14f
2021-02-17 21:08:54 +01:00
Bartosz Dziewoński
9ae59e6ddb
Disable VE indentation commands to allow tabbing out of the widget
...
Bug: T172694
Change-Id: I458271a82a2aba475007d94901bd14f405bccb24
2021-02-17 19:30:23 +00:00
Bartosz Dziewoński
1998c983f1
computeId() can't return null
...
It used to return null for headings, but now it doesn't. Simplify some
code checking for that.
Change-Id: I28131c4aee89b901879b4c49953d6b15ed91b5e7
2021-02-13 00:08:15 +01:00
jenkins-bot
f393fa5f03
Merge "Remove a TODO note about wrappers"
2021-02-11 00:09:50 +00:00
jenkins-bot
d5b2389ffa
Merge "Fix replying outside wrappers for partially indented comments"
2021-02-11 00:09:48 +00:00
Ed Sanders
b581883e7c
Show relevant user in local suggestions on user talk pages
...
Bug: T273324
Change-Id: I60e550efbea3d9e250dcaf13080407094a23aad3
2021-02-09 21:51:28 +00:00
Bartosz Dziewoński
3a1b8e09ea
Remove a TODO note about wrappers
...
Yes, this is still needed, removing it causes failures in tests
(and the old outputs look better).
Change-Id: I5bcedb0295a1f0ac4f6e51eaa9a9e072d8236f3c
2021-02-08 22:23:54 +01:00
Bartosz Dziewoński
9d2b35828d
Fix replying outside wrappers for partially indented comments
...
Top-level comments that start or end with a list (inconsistent
indentation) would not have triggered the logic for detecting
wrappers.
Bug: T273692
Change-Id: Idcb4eed73e391f5f86eca2eb05cb3cea0d86f30a
2021-02-08 22:18:37 +01:00
jenkins-bot
3da91953da
Merge "Adjust new comment highlight timings"
2021-02-08 18:51:06 +00:00
Bartosz Dziewoński
3c7c9c6e3a
Adjust new comment highlight timings
...
The new timing exactly matches MediaWiki's post-edit notification.
Bug: T268994
Change-Id: I8233f56ad6e0d95285fee7f514fce914e7897905
2021-02-08 16:49:50 +01:00
Ed Sanders
d05109b24d
Truncate user generated part of IDs to 80 characters
...
This ensures that IDs fit in a 255 character database field.
Bug: T273658
Change-Id: I3cfe4fce6a865b4343f0f01121cd696aa5f98b22
2021-02-03 15:04:58 +00:00
jenkins-bot
63a5916e53
Merge "Update warning about missing topic title immediately"
2021-02-02 12:11:21 +00:00
Ed Sanders
6c3dd3aaa9
Move Hooks to HookUtils
...
Now that all the real hooks have been separated out
Change-Id: Ibdb42f98614fc551068f8f8e5297dcc99251ab46
2021-02-01 22:35:11 +00:00
