wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-27 09:43:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix forwarding promise rejection arguments

Browse source 
Follow-up to arrow functions refactoring
(a74c00ba8c).

This caused API errors to be handled by showing an error box that
always used the message "Invalid response from server." (generated by
mw.Api#getErrorMessage) instead of the actual error message.

Change-Id: I1c347202f2c2d0a141ba09e6ad136f5d5dc2dc65
This commit is contained in:
Bartosz Dziewoński 2024-11-14 22:29:27 +01:00
parent 8821264a5e
commit d516f625c7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/controller.js
View file

@ -96,11 +96,11 @@ function getPageData( pageName, oldId, apiParams ) {
linterrors: linterrors, linterrors: linterrors,
transcludedfrom: transcludedfrom, transcludedfrom: transcludedfrom,
metadata: metadata metadata: metadata
} ), () => { } ), ( ...args ) => {
// Clear on failure // Clear on failure
pageDataCache[ pageName ][ oldId ] = null; pageDataCache[ pageName ][ oldId ] = null;
// Let caller handle the error // Let caller handle the error
return $.Deferred().rejectWith( this, arguments ); return $.Deferred().reject( ...args );
} ); } );
if ( $.isEmptyObject( apiParams ) ) { if ( $.isEmptyObject( apiParams ) ) {