wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-24 00:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ThreadItemStore: Omit redundant updates to avoid warnings"

Browse source
This commit is contained in:
jenkins-bot 2023-12-14 11:06:45 +00:00 committed by Gerrit Code Review
parent ab2a83601a 1e5dc67c36
commit 797bd2ea0b
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/ThreadItemStore.php
View file

@ -680,7 +680,11 @@ class ThreadItemStore {
// which are causing conflicts (T339882, T343859#9185559) // which are causing conflicts (T339882, T343859#9185559)
->onDuplicateKeyUpdate() ->onDuplicateKeyUpdate()
->uniqueIndexFields( [ 'itr_itemid_id', 'itr_revision_id' ] ) ->uniqueIndexFields( [ 'itr_itemid_id', 'itr_revision_id' ] )
->set( $newOrUpdateRevRow ) // Omit redundant updates to avoid warnings (T353432)
->set( array_diff_key(
$newOrUpdateRevRow,
[ 'itr_itemid_id' => true, 'itr_revision_id' => true ]
) )
->caller( $method ) ->caller( $method )
->execute(); ->execute();
return $dbw->affectedRows() ? $dbw->insertId() : null; return $dbw->affectedRows() ? $dbw->insertId() : null;