wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-09-23 18:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Call IDatabase::insertId only when a row was inserted

Browse source 
As docs says on IDatabase::insertId

Change-Id: I4a61ce625c4f31316bb9eee83f293a438bac2e0e
This commit is contained in:
Umherirrender 2023-08-16 20:54:09 +02:00
parent ca800cf631
commit 1a8ee0f3d1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/ThreadItemStore.php
View file

@ -416,7 +416,7 @@ class ThreadItemStore {
->ignore()
->caller( $method )
->execute();
return $dbw->insertId();
return $dbw->affectedRows() ? $dbw->insertId() : null;
},
$didInsert
);
@ -453,7 +453,7 @@ class ThreadItemStore {
->ignore()
->caller( $method )
->execute();
return $dbw->insertId();
return $dbw->affectedRows() ? $dbw->insertId() : null;
},
$didInsert
);
@ -613,7 +613,7 @@ class ThreadItemStore {
->ignore()
->caller( $method )
->execute();
return $dbw->insertId();
return $dbw->affectedRows() ? $dbw->insertId() : null;
},
$didInsert
);