From 1a8ee0f3d18ecdc87f55ecefb2724c4b9b7a4754 Mon Sep 17 00:00:00 2001
From: Umherirrender <umherirrender_de.wp@web.de>
Date: Wed, 16 Aug 2023 20:54:09 +0200
Subject: [PATCH] Call IDatabase::insertId only when a row was inserted

As docs says on IDatabase::insertId

Change-Id: I4a61ce625c4f31316bb9eee83f293a438bac2e0e
---
 includes/ThreadItemStore.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/includes/ThreadItemStore.php b/includes/ThreadItemStore.php
index 2de01f93f..dcc9c0c45 100644
--- a/includes/ThreadItemStore.php
+++ b/includes/ThreadItemStore.php
@@ -416,7 +416,7 @@ class ThreadItemStore {
 						->ignore()
 						->caller( $method )
 						->execute();
-					return $dbw->insertId();
+					return $dbw->affectedRows() ? $dbw->insertId() : null;
 				},
 				$didInsert
 			);
@@ -453,7 +453,7 @@ class ThreadItemStore {
 						->ignore()
 						->caller( $method )
 						->execute();
-					return $dbw->insertId();
+					return $dbw->affectedRows() ? $dbw->insertId() : null;
 				},
 				$didInsert
 			);
@@ -613,7 +613,7 @@ class ThreadItemStore {
 									->ignore()
 									->caller( $method )
 									->execute();
-								return $dbw->insertId();
+								return $dbw->affectedRows() ? $dbw->insertId() : null;
 							},
 							$didInsert
 						);