2019-09-26 07:06:56 +00:00
|
|
|
'use strict';
|
2020-05-22 16:26:05 +00:00
|
|
|
/* global $:off */
|
|
|
|
|
|
2019-10-18 12:12:55 +00:00
|
|
|
var
|
2020-03-08 14:32:38 +00:00
|
|
|
utils = require( './utils.js' ),
|
2022-05-16 22:48:24 +00:00
|
|
|
charAt = require( 'mediawiki.String' ).charAt,
|
2020-09-08 00:23:53 +00:00
|
|
|
codePointLength = require( 'mediawiki.String' ).codePointLength,
|
2021-02-02 17:40:18 +00:00
|
|
|
trimByteLength = require( 'mediawiki.String' ).trimByteLength,
|
2020-05-22 16:26:05 +00:00
|
|
|
CommentItem = require( './CommentItem.js' ),
|
|
|
|
|
HeadingItem = require( './HeadingItem.js' ),
|
2021-01-26 18:58:58 +00:00
|
|
|
ThreadItem = require( './ThreadItem.js' ),
|
2022-02-19 06:31:34 +00:00
|
|
|
ThreadItemSet = require( './ThreadItemSet.js' ),
|
2019-10-18 12:12:55 +00:00
|
|
|
moment = require( './lib/moment-timezone/moment-timezone-with-data-1970-2030.js' );
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
|
|
|
|
* Utilities for detecting and parsing components of discussion pages: signatures, timestamps,
|
|
|
|
|
* comments and threads.
|
|
|
|
|
*
|
2020-07-20 21:15:03 +00:00
|
|
|
* @class mw.dt.Parser
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
* @param {Array} data Language-specific data to be used for parsing
|
2022-01-11 15:50:44 +00:00
|
|
|
* @constructor
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
*/
|
|
|
|
|
function Parser( data ) {
|
|
|
|
|
this.data = data;
|
|
|
|
|
}
|
|
|
|
|
|
2022-02-21 21:42:14 +00:00
|
|
|
/**
|
|
|
|
|
* How far backwards we look for a signature associated with a timestamp before giving up.
|
|
|
|
|
* Note that this is not a hard limit on the length of signatures we detect.
|
|
|
|
|
*
|
|
|
|
|
* @constant {number}
|
|
|
|
|
*/
|
|
|
|
|
var SIGNATURE_SCAN_LIMIT = 100;
|
|
|
|
|
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
/**
|
|
|
|
|
* Parse a discussion page.
|
|
|
|
|
*
|
2022-01-11 15:50:44 +00:00
|
|
|
* @param {HTMLElement} rootNode Root node of content to parse
|
|
|
|
|
* @param {mw.Title} title Title of the page being parsed
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
* @chainable
|
|
|
|
|
* @return {Parser}
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
Parser.prototype.parse = function ( rootNode, title ) {
|
2020-07-20 21:15:03 +00:00
|
|
|
this.rootNode = rootNode;
|
2022-01-11 15:50:44 +00:00
|
|
|
this.title = title;
|
2022-02-19 06:31:34 +00:00
|
|
|
|
|
|
|
|
var result = this.buildThreadItems();
|
|
|
|
|
this.buildThreads( result );
|
|
|
|
|
this.computeIdsAndNames( result );
|
|
|
|
|
|
|
|
|
|
return result;
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
};
|
2020-07-20 21:15:03 +00:00
|
|
|
|
|
|
|
|
OO.initClass( Parser );
|
|
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
|
|
|
|
* Get text of localisation messages in content language.
|
|
|
|
|
*
|
|
|
|
|
* @private
|
2020-09-03 20:59:33 +00:00
|
|
|
* @param {string} contLangVariant Content language variant
|
|
|
|
|
* @param {string[]} messages Message keys
|
|
|
|
|
* @return {string[]} Message values
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
Parser.prototype.getMessages = function ( contLangVariant, messages ) {
|
|
|
|
|
var parser = this;
|
2019-10-20 16:26:00 +00:00
|
|
|
return messages.map( function ( code ) {
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
return parser.data.contLangMessages[ contLangVariant ][ code ];
|
2019-09-26 07:06:56 +00:00
|
|
|
} );
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
|
|
|
|
* Get a regexp that matches timestamps generated using the given date format.
|
|
|
|
|
*
|
|
|
|
|
* This only supports format characters that are used by the default date format in any of
|
|
|
|
|
* MediaWiki's languages, namely: D, d, F, G, H, i, j, l, M, n, Y, xg, xkY (and escape characters),
|
|
|
|
|
* and only dates when MediaWiki existed, let's say 2000 onwards (Thai dates before 1941 are
|
|
|
|
|
* complicated).
|
|
|
|
|
*
|
2020-07-20 21:15:03 +00:00
|
|
|
* @private
|
2020-09-03 20:59:33 +00:00
|
|
|
* @param {string} contLangVariant Content language variant
|
2019-10-20 16:36:43 +00:00
|
|
|
* @param {string} format Date format, as used by MediaWiki
|
2020-05-08 19:21:53 +00:00
|
|
|
* @param {string} digitsRegexp Regular expression matching a single localised digit, e.g. `[0-9]`
|
2021-12-20 17:25:54 +00:00
|
|
|
* @param {Object.<string,string>} tzAbbrs Map of localised timezone abbreviations to IANA abbreviations
|
2019-10-20 16:36:43 +00:00
|
|
|
* for the local timezone, e.g. `{EDT: "EDT", EST: "EST"}`
|
|
|
|
|
* @return {string} Regular expression
|
|
|
|
|
*/
|
2020-09-03 20:59:33 +00:00
|
|
|
Parser.prototype.getTimestampRegexp = function ( contLangVariant, format, digitsRegexp, tzAbbrs ) {
|
2020-08-26 22:46:34 +00:00
|
|
|
function regexpGroup( r ) {
|
|
|
|
|
return '(' + r + ')';
|
2019-10-20 16:26:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function regexpAlternateGroup( array ) {
|
|
|
|
|
return '(' + array.map( mw.util.escapeRegExp ).join( '|' ) + ')';
|
|
|
|
|
}
|
2019-09-26 07:06:56 +00:00
|
|
|
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
var parser = this;
|
|
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var s = '';
|
2019-10-20 16:26:00 +00:00
|
|
|
// Adapted from Language::sprintfDate()
|
2021-04-08 13:46:09 +00:00
|
|
|
for ( var p = 0; p < format.length; p++ ) {
|
|
|
|
|
var num = false;
|
|
|
|
|
var code = format[ p ];
|
2019-09-26 07:06:56 +00:00
|
|
|
if ( code === 'x' && p < format.length - 1 ) {
|
|
|
|
|
code += format[ ++p ];
|
|
|
|
|
}
|
|
|
|
|
if ( code === 'xk' && p < format.length - 1 ) {
|
|
|
|
|
code += format[ ++p ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
switch ( code ) {
|
|
|
|
|
case 'xx':
|
|
|
|
|
s += 'x';
|
|
|
|
|
break;
|
|
|
|
|
case 'xg':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
s += regexpAlternateGroup( parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'january-gen', 'february-gen', 'march-gen', 'april-gen', 'may-gen', 'june-gen',
|
|
|
|
|
'july-gen', 'august-gen', 'september-gen', 'october-gen', 'november-gen',
|
|
|
|
|
'december-gen'
|
|
|
|
|
] ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'd':
|
|
|
|
|
num = '2';
|
|
|
|
|
break;
|
|
|
|
|
case 'D':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
s += regexpAlternateGroup( parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'sun', 'mon', 'tue', 'wed', 'thu', 'fri', 'sat'
|
|
|
|
|
] ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'j':
|
|
|
|
|
num = '1,2';
|
|
|
|
|
break;
|
|
|
|
|
case 'l':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
s += regexpAlternateGroup( parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'sunday', 'monday', 'tuesday', 'wednesday', 'thursday',
|
|
|
|
|
'friday', 'saturday'
|
|
|
|
|
] ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'F':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
s += regexpAlternateGroup( parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'january', 'february', 'march', 'april', 'may_long', 'june',
|
|
|
|
|
'july', 'august', 'september', 'october', 'november',
|
|
|
|
|
'december'
|
|
|
|
|
] ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'M':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
s += regexpAlternateGroup( parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'jan', 'feb', 'mar', 'apr', 'may', 'jun', 'jul', 'aug',
|
|
|
|
|
'sep', 'oct', 'nov', 'dec'
|
|
|
|
|
] ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'n':
|
|
|
|
|
num = '1,2';
|
|
|
|
|
break;
|
|
|
|
|
case 'Y':
|
|
|
|
|
num = '4';
|
|
|
|
|
break;
|
|
|
|
|
case 'xkY':
|
|
|
|
|
num = '4';
|
|
|
|
|
break;
|
|
|
|
|
case 'G':
|
|
|
|
|
num = '1,2';
|
|
|
|
|
break;
|
|
|
|
|
case 'H':
|
|
|
|
|
num = '2';
|
|
|
|
|
break;
|
|
|
|
|
case 'i':
|
|
|
|
|
num = '2';
|
|
|
|
|
break;
|
|
|
|
|
case '\\':
|
|
|
|
|
// Backslash escaping
|
|
|
|
|
if ( p < format.length - 1 ) {
|
2019-10-20 16:34:44 +00:00
|
|
|
s += mw.util.escapeRegExp( format[ ++p ] );
|
2019-09-26 07:06:56 +00:00
|
|
|
} else {
|
2019-10-20 16:34:44 +00:00
|
|
|
s += mw.util.escapeRegExp( '\\' );
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case '"':
|
|
|
|
|
// Quoted literal
|
|
|
|
|
if ( p < format.length - 1 ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var endQuote = format.indexOf( '"', p + 1 );
|
2019-09-26 07:06:56 +00:00
|
|
|
if ( endQuote === -1 ) {
|
|
|
|
|
// No terminating quote, assume literal "
|
|
|
|
|
s += '"';
|
|
|
|
|
} else {
|
2021-11-08 19:03:40 +00:00
|
|
|
s += mw.util.escapeRegExp( format.slice( p + 1, endQuote ) );
|
2019-09-26 07:06:56 +00:00
|
|
|
p = endQuote;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
// Quote at end of string, assume literal "
|
|
|
|
|
s += '"';
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
default:
|
2022-05-16 22:48:24 +00:00
|
|
|
// Copy whole characters together, instead of single UTF-16 surrogates
|
|
|
|
|
var char = charAt( format, p );
|
|
|
|
|
s += mw.util.escapeRegExp( char );
|
|
|
|
|
p += char.length - 1;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
if ( num !== false ) {
|
2020-05-08 19:21:53 +00:00
|
|
|
s += regexpGroup( digitsRegexp + '{' + num + '}' );
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2022-05-16 22:48:24 +00:00
|
|
|
// Ignore some invisible Unicode characters that often sneak into copy-pasted timestamps (T308448)
|
|
|
|
|
s += '[\\u200E\\u200F]?';
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var tzRegexp = regexpAlternateGroup( Object.keys( tzAbbrs ) );
|
2020-05-12 11:51:20 +00:00
|
|
|
// Hard-coded parentheses and space like in Parser::pstPass2
|
|
|
|
|
// Ignore some invisible Unicode characters that often sneak into copy-pasted timestamps (T245784)
|
2022-05-16 22:48:24 +00:00
|
|
|
var regexp = s + ' [\\u200E\\u200F]?\\(' + tzRegexp + '\\)';
|
2019-10-18 12:12:55 +00:00
|
|
|
|
|
|
|
|
return regexp;
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
|
|
|
|
* Get a function that parses timestamps generated using the given date format, based on the result
|
|
|
|
|
* of matching the regexp returned by #getTimestampRegexp.
|
|
|
|
|
*
|
2020-07-20 21:15:03 +00:00
|
|
|
* @private
|
2020-09-03 20:59:33 +00:00
|
|
|
* @param {string} contLangVariant Content language variant
|
2019-10-20 16:36:43 +00:00
|
|
|
* @param {string} format Date format, as used by MediaWiki
|
2020-09-14 21:31:53 +00:00
|
|
|
* @param {string[]|null} digits Localised digits from 0 to 9, e.g. `[ '0', '1', ..., '9' ]`
|
2019-10-20 16:36:43 +00:00
|
|
|
* @param {string} localTimezone Local timezone IANA name, e.g. `America/New_York`
|
2021-12-20 17:25:54 +00:00
|
|
|
* @param {Object.<string,string>} tzAbbrs Map of localised timezone abbreviations to IANA abbreviations
|
2019-10-20 16:36:43 +00:00
|
|
|
* for the local timezone, e.g. `{EDT: "EDT", EST: "EST"}`
|
2020-06-25 12:23:17 +00:00
|
|
|
* @return {TimestampParser} Timestamp parser function
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-09-03 20:59:33 +00:00
|
|
|
Parser.prototype.getTimestampParser = function ( contLangVariant, format, digits, localTimezone, tzAbbrs ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var matchingGroups = [];
|
|
|
|
|
for ( var p = 0; p < format.length; p++ ) {
|
|
|
|
|
var code = format[ p ];
|
2019-09-26 07:06:56 +00:00
|
|
|
if ( code === 'x' && p < format.length - 1 ) {
|
|
|
|
|
code += format[ ++p ];
|
|
|
|
|
}
|
|
|
|
|
if ( code === 'xk' && p < format.length - 1 ) {
|
|
|
|
|
code += format[ ++p ];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
switch ( code ) {
|
|
|
|
|
case 'xx':
|
|
|
|
|
break;
|
|
|
|
|
case 'xg':
|
|
|
|
|
case 'd':
|
|
|
|
|
case 'j':
|
|
|
|
|
case 'D':
|
|
|
|
|
case 'l':
|
|
|
|
|
case 'F':
|
|
|
|
|
case 'M':
|
|
|
|
|
case 'n':
|
|
|
|
|
case 'Y':
|
|
|
|
|
case 'xkY':
|
|
|
|
|
case 'G':
|
|
|
|
|
case 'H':
|
|
|
|
|
case 'i':
|
|
|
|
|
matchingGroups.push( code );
|
|
|
|
|
break;
|
|
|
|
|
case '\\':
|
|
|
|
|
// Backslash escaping
|
|
|
|
|
if ( p < format.length - 1 ) {
|
|
|
|
|
++p;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
case '"':
|
|
|
|
|
// Quoted literal
|
|
|
|
|
if ( p < format.length - 1 ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var endQuote = format.indexOf( '"', p + 1 );
|
2019-09-26 07:06:56 +00:00
|
|
|
if ( endQuote !== -1 ) {
|
|
|
|
|
p = endQuote;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function untransformDigits( text ) {
|
|
|
|
|
if ( !digits ) {
|
|
|
|
|
return text;
|
|
|
|
|
}
|
|
|
|
|
return text.replace(
|
2020-08-31 22:13:00 +00:00
|
|
|
new RegExp( '[' + digits.join( '' ) + ']', 'g' ),
|
2019-09-26 07:06:56 +00:00
|
|
|
function ( m ) {
|
|
|
|
|
return digits.indexOf( m );
|
|
|
|
|
}
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
var parser = this;
|
|
|
|
|
|
2020-06-25 12:23:17 +00:00
|
|
|
/**
|
|
|
|
|
* @typedef {function(Array):moment} TimestampParser
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Timestamp parser
|
|
|
|
|
*
|
|
|
|
|
* @param {Array} match RegExp match data
|
2022-03-03 16:29:39 +00:00
|
|
|
* @return {Object} Result, an object with the following keys:
|
|
|
|
|
* - {moment} date Moment date object
|
|
|
|
|
* - {string|null} warning Warning message if the input wasn't correctly formed
|
2020-06-25 12:23:17 +00:00
|
|
|
*/
|
2019-10-18 12:12:55 +00:00
|
|
|
return function timestampParser( match ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
var
|
|
|
|
|
year = 0,
|
|
|
|
|
monthIdx = 0,
|
|
|
|
|
day = 0,
|
|
|
|
|
hour = 0,
|
2021-04-08 13:46:09 +00:00
|
|
|
minute = 0;
|
|
|
|
|
|
|
|
|
|
for ( var i = 0; i < matchingGroups.length; i++ ) {
|
|
|
|
|
var code2 = matchingGroups[ i ];
|
|
|
|
|
var text = match[ i + 1 ];
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2020-08-26 22:46:34 +00:00
|
|
|
switch ( code2 ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
case 'xg':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
monthIdx = parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'january-gen', 'february-gen', 'march-gen', 'april-gen', 'may-gen', 'june-gen',
|
|
|
|
|
'july-gen', 'august-gen', 'september-gen', 'october-gen', 'november-gen',
|
|
|
|
|
'december-gen'
|
|
|
|
|
] ).indexOf( text );
|
|
|
|
|
break;
|
|
|
|
|
case 'd':
|
|
|
|
|
case 'j':
|
|
|
|
|
day = Number( untransformDigits( text ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'D':
|
|
|
|
|
case 'l':
|
|
|
|
|
// Day of the week - unused
|
|
|
|
|
break;
|
|
|
|
|
case 'F':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
monthIdx = parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'january', 'february', 'march', 'april', 'may_long', 'june',
|
|
|
|
|
'july', 'august', 'september', 'october', 'november',
|
|
|
|
|
'december'
|
|
|
|
|
] ).indexOf( text );
|
|
|
|
|
break;
|
|
|
|
|
case 'M':
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
monthIdx = parser.getMessages( contLangVariant, [
|
2019-09-26 07:06:56 +00:00
|
|
|
'jan', 'feb', 'mar', 'apr', 'may', 'jun', 'jul', 'aug',
|
|
|
|
|
'sep', 'oct', 'nov', 'dec'
|
|
|
|
|
] ).indexOf( text );
|
|
|
|
|
break;
|
|
|
|
|
case 'n':
|
|
|
|
|
monthIdx = Number( untransformDigits( text ) ) - 1;
|
|
|
|
|
break;
|
|
|
|
|
case 'Y':
|
|
|
|
|
year = Number( untransformDigits( text ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'xkY':
|
|
|
|
|
// Thai year
|
|
|
|
|
year = Number( untransformDigits( text ) ) - 543;
|
|
|
|
|
break;
|
|
|
|
|
case 'G':
|
|
|
|
|
case 'H':
|
|
|
|
|
hour = Number( untransformDigits( text ) );
|
|
|
|
|
break;
|
|
|
|
|
case 'i':
|
|
|
|
|
minute = Number( untransformDigits( text ) );
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
throw new Error( 'Not implemented' );
|
|
|
|
|
}
|
|
|
|
|
}
|
2019-10-18 12:12:55 +00:00
|
|
|
// The last matching group is the timezone abbreviation
|
2021-04-08 13:46:09 +00:00
|
|
|
var tzAbbr = tzAbbrs[ match[ match.length - 1 ] ];
|
2019-10-18 12:12:55 +00:00
|
|
|
|
|
|
|
|
// Most of the time, the timezone abbreviation is not necessary to parse the date, since we
|
|
|
|
|
// can assume all times are in the wiki's local timezone.
|
2021-04-08 13:46:09 +00:00
|
|
|
var date = moment.tz( [ year, monthIdx, day, hour, minute ], localTimezone );
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-18 12:12:55 +00:00
|
|
|
// But during the "fall back" at the end of DST, some times will happen twice. Per the docs,
|
|
|
|
|
// "Moment Timezone handles this by always using the earlier instance of a duplicated hour."
|
|
|
|
|
// https://momentjs.com/timezone/docs/#/using-timezones/parsing-ambiguous-inputs/
|
|
|
|
|
|
|
|
|
|
// Since the timezone abbreviation disambiguates the DST/non-DST times, we can detect when
|
|
|
|
|
// that behavior was incorrect...
|
2022-03-03 16:29:39 +00:00
|
|
|
var dateWarning = null;
|
2019-10-18 12:12:55 +00:00
|
|
|
if ( date.zoneAbbr() !== tzAbbr ) {
|
|
|
|
|
// ...and force the correct parsing. I can't find proper documentation for this feature,
|
|
|
|
|
// but this pull request explains it: https://github.com/moment/moment-timezone/pull/101
|
|
|
|
|
moment.tz.moveAmbiguousForward = true;
|
|
|
|
|
date = moment.tz( [ year, monthIdx, day, hour, minute ], localTimezone );
|
|
|
|
|
moment.tz.moveAmbiguousForward = false;
|
|
|
|
|
if ( date.zoneAbbr() !== tzAbbr ) {
|
|
|
|
|
// This should not be possible for "genuine" timestamps generated by MediaWiki.
|
|
|
|
|
// But bots and humans get it wrong when marking up unsigned comments…
|
|
|
|
|
// https://pl.wikipedia.org/w/index.php?title=Wikipedia:Kawiarenka/Artykuły&diff=prev&oldid=54772606
|
2022-03-03 16:29:39 +00:00
|
|
|
dateWarning = 'Timestamp has timezone abbreviation for the wrong time';
|
2019-10-18 12:12:55 +00:00
|
|
|
} else {
|
2022-03-03 16:29:39 +00:00
|
|
|
dateWarning = 'Ambiguous time at DST switchover was parsed';
|
2019-10-18 12:12:55 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-03-03 16:29:39 +00:00
|
|
|
return {
|
|
|
|
|
date: date,
|
|
|
|
|
warning: dateWarning
|
|
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
};
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
2020-09-03 20:59:33 +00:00
|
|
|
* Get a regexp that matches timestamps in the local date format, for each language variant.
|
2019-10-20 16:36:43 +00:00
|
|
|
*
|
|
|
|
|
* This calls #getTimestampRegexp with predefined data for the current wiki.
|
|
|
|
|
*
|
|
|
|
|
* @private
|
2020-09-03 20:59:33 +00:00
|
|
|
* @return {string[]} Regular expressions
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-09-03 20:59:33 +00:00
|
|
|
Parser.prototype.getLocalTimestampRegexps = function () {
|
|
|
|
|
var parser = this;
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
return Object.keys( this.data.dateFormat ).map( function ( contLangVariant ) {
|
2020-09-03 20:59:33 +00:00
|
|
|
return parser.getTimestampRegexp(
|
|
|
|
|
contLangVariant,
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
parser.data.dateFormat[ contLangVariant ],
|
|
|
|
|
'[' + parser.data.digits[ contLangVariant ].join( '' ) + ']',
|
|
|
|
|
parser.data.timezones[ contLangVariant ]
|
2020-09-03 20:59:33 +00:00
|
|
|
);
|
|
|
|
|
} );
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
2020-09-03 20:59:33 +00:00
|
|
|
* Get a function that parses timestamps in the local date format, for each language variant,
|
|
|
|
|
* based on the result of matching the regexps returned by #getLocalTimestampRegexps.
|
2019-10-20 16:36:43 +00:00
|
|
|
*
|
|
|
|
|
* This calls #getTimestampParser with predefined data for the current wiki.
|
|
|
|
|
*
|
|
|
|
|
* @private
|
2020-09-03 20:59:33 +00:00
|
|
|
* @return {TimestampParser[]} Timestamp parser functions
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-09-03 20:59:33 +00:00
|
|
|
Parser.prototype.getLocalTimestampParsers = function () {
|
|
|
|
|
var parser = this;
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
return Object.keys( this.data.dateFormat ).map( function ( contLangVariant ) {
|
2020-09-03 20:59:33 +00:00
|
|
|
return parser.getTimestampParser(
|
|
|
|
|
contLangVariant,
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
parser.data.dateFormat[ contLangVariant ],
|
|
|
|
|
parser.data.digits[ contLangVariant ],
|
|
|
|
|
parser.data.localTimezone,
|
|
|
|
|
parser.data.timezones[ contLangVariant ]
|
2020-09-03 20:59:33 +00:00
|
|
|
);
|
|
|
|
|
} );
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-24 16:24:59 +00:00
|
|
|
/**
|
|
|
|
|
* Callback for document.createTreeWalker that will skip over nodes where we don't want to detect
|
|
|
|
|
* comments (or section headings).
|
|
|
|
|
*
|
|
|
|
|
* @param {Node} node
|
|
|
|
|
* @return {number} Appropriate NodeFilter constant
|
|
|
|
|
*/
|
|
|
|
|
function acceptOnlyNodesAllowingComments( node ) {
|
2022-02-21 18:04:31 +00:00
|
|
|
if ( node instanceof HTMLElement ) {
|
|
|
|
|
var tagName = node.tagName.toLowerCase();
|
|
|
|
|
// The table of contents has a heading that gets erroneously detected as a section
|
|
|
|
|
if ( node.id === 'toc' ) {
|
|
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2023-03-27 12:50:45 +00:00
|
|
|
// Don't detect comments within quotes (T275881)
|
|
|
|
|
if (
|
|
|
|
|
tagName === 'blockquote' ||
|
|
|
|
|
tagName === 'cite' ||
|
|
|
|
|
tagName === 'q'
|
|
|
|
|
) {
|
|
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
|
|
|
|
// Don't attempt to parse blocks marked 'mw-notalk'
|
|
|
|
|
if ( node.classList.contains( 'mw-notalk' ) ) {
|
|
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2022-02-21 18:04:31 +00:00
|
|
|
// Don't detect comments within references. We can't add replies to them without bungling up
|
|
|
|
|
// the structure in some cases (T301213), and you're not supposed to do that anyway…
|
|
|
|
|
if (
|
|
|
|
|
// <ol class="references"> is the only reliably consistent thing between the two parsers
|
|
|
|
|
tagName === 'ol' &&
|
|
|
|
|
node.classList.contains( 'references' )
|
|
|
|
|
) {
|
|
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2021-02-26 20:05:40 +00:00
|
|
|
}
|
2022-02-21 18:04:31 +00:00
|
|
|
var parentNode = node.parentNode;
|
2020-11-04 15:17:39 +00:00
|
|
|
// Don't detect comments within headings (but don't reject the headings themselves)
|
2022-02-21 18:04:31 +00:00
|
|
|
if ( parentNode instanceof HTMLElement && parentNode.tagName.match( /^h([1-6])$/i ) ) {
|
2020-11-04 15:17:39 +00:00
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2019-10-24 16:24:59 +00:00
|
|
|
return NodeFilter.FILTER_ACCEPT;
|
|
|
|
|
}
|
|
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
2020-09-03 20:59:33 +00:00
|
|
|
* Find a timestamp in a given text node
|
2019-10-20 16:36:43 +00:00
|
|
|
*
|
2020-07-20 21:15:03 +00:00
|
|
|
* @private
|
2020-07-10 14:16:49 +00:00
|
|
|
* @param {Text} node Text node
|
2020-09-03 20:59:33 +00:00
|
|
|
* @param {string[]} timestampRegexps Timestamp regexps
|
|
|
|
|
* @return {Object|null} Object with the following keys:
|
|
|
|
|
* - {number} offset Length of extra text preceding the node that was used for matching
|
|
|
|
|
* - {number} parserIndex Which of the regexps matched
|
|
|
|
|
* - {Array} matchData Regexp match data, which specifies the location of the match,
|
|
|
|
|
* and which can be parsed using #getLocalTimestampParsers
|
2022-10-04 12:50:57 +00:00
|
|
|
* - {Object} range Range-like object covering the timestamp
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-09-03 20:59:33 +00:00
|
|
|
Parser.prototype.findTimestamp = function ( node, timestampRegexps ) {
|
|
|
|
|
var matchData, i,
|
2020-08-11 04:22:57 +00:00
|
|
|
nodeText = '',
|
2022-10-04 12:50:57 +00:00
|
|
|
offset = 0,
|
|
|
|
|
// Searched nodes (reverse order)
|
|
|
|
|
nodes = [];
|
|
|
|
|
|
2020-07-10 14:16:49 +00:00
|
|
|
while ( node ) {
|
2020-08-11 04:22:57 +00:00
|
|
|
nodeText = node.nodeValue + nodeText;
|
2022-10-04 12:50:57 +00:00
|
|
|
nodes.push( node );
|
2020-07-10 14:16:49 +00:00
|
|
|
|
|
|
|
|
// In Parsoid HTML, entities are represented as a 'mw:Entity' node, rather than normal HTML
|
|
|
|
|
// entities. On Arabic Wikipedia, the "UTC" timezone name contains some non-breaking spaces,
|
|
|
|
|
// which apparently are often turned into entities by buggy editing tools. To handle
|
|
|
|
|
// this, we must piece together the text, so that our regexp can match those timestamps.
|
|
|
|
|
if (
|
2020-08-11 04:22:57 +00:00
|
|
|
node.previousSibling &&
|
|
|
|
|
node.previousSibling.nodeType === Node.ELEMENT_NODE &&
|
|
|
|
|
node.previousSibling.getAttribute( 'typeof' ) === 'mw:Entity'
|
2020-07-10 14:16:49 +00:00
|
|
|
) {
|
2020-08-11 04:22:57 +00:00
|
|
|
nodeText = node.previousSibling.firstChild.nodeValue + nodeText;
|
|
|
|
|
offset += node.previousSibling.firstChild.nodeValue.length;
|
2022-10-04 12:50:57 +00:00
|
|
|
nodes.push( node.previousSibling.firstChild );
|
2020-07-10 14:16:49 +00:00
|
|
|
|
|
|
|
|
// If the entity is followed by more text, do this again
|
2020-05-05 20:19:04 +00:00
|
|
|
if (
|
2020-08-11 04:22:57 +00:00
|
|
|
node.previousSibling.previousSibling &&
|
|
|
|
|
node.previousSibling.previousSibling.nodeType === Node.TEXT_NODE
|
2020-05-05 20:19:04 +00:00
|
|
|
) {
|
2020-08-11 04:22:57 +00:00
|
|
|
offset += node.previousSibling.previousSibling.nodeValue.length;
|
|
|
|
|
node = node.previousSibling.previousSibling;
|
2020-05-05 20:19:04 +00:00
|
|
|
} else {
|
|
|
|
|
node = null;
|
|
|
|
|
}
|
2020-07-10 14:16:49 +00:00
|
|
|
} else {
|
|
|
|
|
node = null;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
}
|
2020-07-10 14:16:49 +00:00
|
|
|
|
2020-09-03 20:59:33 +00:00
|
|
|
for ( i = 0; i < timestampRegexps.length; i++ ) {
|
|
|
|
|
// Technically, there could be multiple matches in a single text node. However, the ultimate
|
|
|
|
|
// point of this is to find the signatures which precede the timestamps, and any later
|
|
|
|
|
// timestamps in the text node can't be directly preceded by a signature (as we require them to
|
|
|
|
|
// have links), so we only concern ourselves with the first match.
|
|
|
|
|
matchData = nodeText.match( timestampRegexps[ i ] );
|
|
|
|
|
if ( matchData ) {
|
2022-10-04 12:50:57 +00:00
|
|
|
var timestampLength = matchData[ 0 ].length;
|
|
|
|
|
// Bytes at the end of the last node which aren't part of the match
|
|
|
|
|
var tailLength = nodeText.length - timestampLength - matchData.index;
|
|
|
|
|
// We are moving right to left, but we start to the right of the end of
|
|
|
|
|
// the timestamp if there is trailing garbage, so that is a negative offset.
|
|
|
|
|
var count = -tailLength;
|
|
|
|
|
var endContainer = nodes[ 0 ];
|
|
|
|
|
var endOffset = endContainer.nodeValue.length - tailLength;
|
|
|
|
|
|
|
|
|
|
var startContainer, startOffset;
|
|
|
|
|
// eslint-disable-next-line no-loop-func
|
|
|
|
|
nodes.some( function ( n ) {
|
|
|
|
|
count += n.nodeValue.length;
|
|
|
|
|
// If we have counted to beyond the start of the timestamp, we are in the
|
|
|
|
|
// start node of the timestamp
|
|
|
|
|
if ( count >= timestampLength ) {
|
|
|
|
|
startContainer = n;
|
|
|
|
|
// Offset is how much we overshot the start by
|
|
|
|
|
startOffset = count - timestampLength;
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
return false;
|
|
|
|
|
} );
|
|
|
|
|
|
|
|
|
|
var range = {
|
|
|
|
|
startContainer: startContainer,
|
|
|
|
|
startOffset: startOffset,
|
|
|
|
|
endContainer: endContainer,
|
|
|
|
|
endOffset: endOffset
|
|
|
|
|
};
|
|
|
|
|
|
2020-09-03 20:59:33 +00:00
|
|
|
return {
|
|
|
|
|
matchData: matchData,
|
2022-10-04 12:50:57 +00:00
|
|
|
// Bytes at the start of the first node which aren't part of the match
|
|
|
|
|
// TODO: Remove this and use 'range' instead
|
2020-09-03 20:59:33 +00:00
|
|
|
offset: offset,
|
2022-10-04 12:50:57 +00:00
|
|
|
range: range,
|
2020-09-03 20:59:33 +00:00
|
|
|
parserIndex: i
|
|
|
|
|
};
|
|
|
|
|
}
|
2020-08-11 04:22:57 +00:00
|
|
|
}
|
|
|
|
|
return null;
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2021-01-26 18:58:58 +00:00
|
|
|
/**
|
|
|
|
|
* Given a link node (`<a>`), if it's a link to a user-related page, return their username.
|
|
|
|
|
*
|
|
|
|
|
* @param {HTMLElement} link
|
2022-02-04 18:16:24 +00:00
|
|
|
* @return {Object|null} Object, or null:
|
|
|
|
|
* - {string} username Username
|
|
|
|
|
* - {string|null} displayName Display name (link text if link target was in the user namespace)
|
2021-01-26 18:58:58 +00:00
|
|
|
*/
|
2022-01-11 15:52:16 +00:00
|
|
|
Parser.prototype.getUsernameFromLink = function ( link ) {
|
|
|
|
|
var title;
|
|
|
|
|
// Selflink: use title of current page
|
|
|
|
|
if ( link.classList.contains( 'mw-selflink' ) ) {
|
|
|
|
|
title = this.title;
|
|
|
|
|
} else {
|
2022-02-21 22:07:38 +00:00
|
|
|
title = mw.Title.newFromText( utils.getTitleFromUrl( link.href ) || '' );
|
2022-01-11 15:52:16 +00:00
|
|
|
}
|
2021-01-26 18:58:58 +00:00
|
|
|
if ( !title ) {
|
|
|
|
|
return null;
|
|
|
|
|
}
|
2022-02-04 15:50:20 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var username;
|
2022-02-04 18:16:24 +00:00
|
|
|
var displayName = null;
|
2022-02-04 15:50:20 +00:00
|
|
|
var namespaceId = title.getNamespaceId();
|
|
|
|
|
var mainText = title.getMainText();
|
|
|
|
|
var namespaceIds = mw.config.get( 'wgNamespaceIds' );
|
|
|
|
|
|
2021-01-26 18:58:58 +00:00
|
|
|
if (
|
2022-02-04 15:50:20 +00:00
|
|
|
namespaceId === namespaceIds.user ||
|
|
|
|
|
namespaceId === namespaceIds.user_talk
|
2021-01-26 18:58:58 +00:00
|
|
|
) {
|
2022-02-04 15:50:20 +00:00
|
|
|
username = mainText;
|
2021-01-26 18:58:58 +00:00
|
|
|
if ( username.indexOf( '/' ) !== -1 ) {
|
|
|
|
|
return null;
|
|
|
|
|
}
|
2022-02-04 18:16:24 +00:00
|
|
|
if ( namespaceId === namespaceIds.user ) {
|
|
|
|
|
// Use regex trim for consistency with PHP implementation
|
|
|
|
|
var text = link.textContent.replace( /^[\s]+/, '' ).replace( /[\s]+$/, '' );
|
|
|
|
|
// Record the display name if it has been customised beyond changing case
|
|
|
|
|
if ( text && text.toLowerCase() !== username.toLowerCase() ) {
|
|
|
|
|
displayName = text;
|
|
|
|
|
}
|
|
|
|
|
}
|
2022-02-21 22:07:38 +00:00
|
|
|
} else if ( namespaceId === namespaceIds.special ) {
|
|
|
|
|
var parts = mainText.split( '/' );
|
|
|
|
|
if ( parts.length === 2 && parts[ 0 ] === this.data.specialContributionsName ) {
|
|
|
|
|
// Normalize the username: users may link to their contributions with an unnormalized name
|
|
|
|
|
var userpage = mw.Title.makeTitle( namespaceIds.user, parts[ 1 ] );
|
|
|
|
|
if ( !userpage ) {
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
username = userpage.getMainText();
|
2021-01-26 18:58:58 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if ( !username ) {
|
|
|
|
|
return null;
|
|
|
|
|
}
|
|
|
|
|
if ( mw.util.isIPv6Address( username ) ) {
|
|
|
|
|
// Bot-generated links "Preceding unsigned comment added by" have non-standard case
|
|
|
|
|
username = username.toUpperCase();
|
|
|
|
|
}
|
2022-02-04 18:16:24 +00:00
|
|
|
return {
|
|
|
|
|
username: username,
|
|
|
|
|
displayName: displayName
|
|
|
|
|
};
|
2022-01-11 15:52:16 +00:00
|
|
|
};
|
2021-01-26 18:58:58 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
|
|
|
|
* Find a user signature preceding a timestamp.
|
|
|
|
|
*
|
|
|
|
|
* The signature includes the timestamp node.
|
|
|
|
|
*
|
|
|
|
|
* A signature must contain at least one link to the user's userpage, discussion page or
|
|
|
|
|
* contributions (and may contain other links). The link may be nested in other elements.
|
|
|
|
|
*
|
|
|
|
|
* @private
|
|
|
|
|
* @param {Text} timestampNode Text node
|
2020-03-06 16:51:59 +00:00
|
|
|
* @param {Node} [until] Node to stop searching at
|
2022-02-04 15:44:14 +00:00
|
|
|
* @return {Object} Result, an object with the following keys:
|
|
|
|
|
* - {Node[]} nodes Sibling nodes comprising the signature, in reverse order (with
|
|
|
|
|
* `timestampNode` or its parent node as the first element)
|
|
|
|
|
* - {string|null} username Username, null for unsigned comments
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-07-20 21:15:03 +00:00
|
|
|
Parser.prototype.findSignature = function ( timestampNode, until ) {
|
2022-01-11 15:52:16 +00:00
|
|
|
var parser = this;
|
2021-04-08 13:46:09 +00:00
|
|
|
var sigUsername = null;
|
2022-02-04 18:16:24 +00:00
|
|
|
var sigDisplayName = null;
|
2021-04-08 13:46:09 +00:00
|
|
|
var length = 0;
|
|
|
|
|
var lastLinkNode = timestampNode;
|
2020-05-27 17:42:19 +00:00
|
|
|
|
2021-01-26 18:58:58 +00:00
|
|
|
utils.linearWalkBackwards(
|
|
|
|
|
timestampNode,
|
|
|
|
|
function ( event, node ) {
|
|
|
|
|
if ( event === 'enter' && node === until ) {
|
|
|
|
|
return true;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2022-02-21 21:42:14 +00:00
|
|
|
if ( length >= SIGNATURE_SCAN_LIMIT ) {
|
2021-01-26 18:58:58 +00:00
|
|
|
return true;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2021-01-26 18:58:58 +00:00
|
|
|
if ( utils.isBlockElement( node ) ) {
|
|
|
|
|
// Don't allow reaching into preceding paragraphs
|
|
|
|
|
return true;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2021-01-26 18:58:58 +00:00
|
|
|
|
|
|
|
|
if ( event === 'leave' && node !== timestampNode ) {
|
2022-02-04 16:25:42 +00:00
|
|
|
length += node.nodeType === Node.TEXT_NODE ?
|
|
|
|
|
codePointLength( utils.htmlTrim( node.textContent ) ) : 0;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
|
2021-01-26 18:58:58 +00:00
|
|
|
// Find the closest link before timestamp that links to the user's user page.
|
|
|
|
|
//
|
|
|
|
|
// Support timestamps being linked to the diff introducing the comment:
|
|
|
|
|
// if the timestamp node is the only child of a link node, use the link node instead
|
|
|
|
|
//
|
|
|
|
|
// Handle links nested in formatting elements.
|
|
|
|
|
if ( event === 'leave' && node.nodeType === Node.ELEMENT_NODE && node.tagName.toLowerCase() === 'a' ) {
|
2022-02-04 18:16:24 +00:00
|
|
|
var user = parser.getUsernameFromLink( node );
|
|
|
|
|
if ( user ) {
|
2021-01-26 18:58:58 +00:00
|
|
|
// Accept the first link to the user namespace, then only accept links to that user
|
|
|
|
|
if ( sigUsername === null ) {
|
2022-02-04 18:16:24 +00:00
|
|
|
sigUsername = user.username;
|
2021-01-26 18:58:58 +00:00
|
|
|
}
|
2022-02-04 18:16:24 +00:00
|
|
|
if ( user.username === sigUsername ) {
|
2021-01-26 18:58:58 +00:00
|
|
|
lastLinkNode = node;
|
2022-02-04 18:16:24 +00:00
|
|
|
if ( user.displayName ) {
|
|
|
|
|
sigDisplayName = user.displayName;
|
|
|
|
|
}
|
2021-01-26 18:58:58 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Keep looking if a node with links wasn't a link to a user page
|
|
|
|
|
// "Doc James (talk · contribs · email)"
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
}
|
2021-01-26 18:58:58 +00:00
|
|
|
);
|
|
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var range = {
|
2021-01-26 18:58:58 +00:00
|
|
|
startContainer: lastLinkNode.parentNode,
|
|
|
|
|
startOffset: utils.childIndexOf( lastLinkNode ),
|
|
|
|
|
endContainer: timestampNode.parentNode,
|
|
|
|
|
endOffset: utils.childIndexOf( timestampNode ) + 1
|
|
|
|
|
};
|
2021-04-08 13:46:09 +00:00
|
|
|
var nativeRange = ThreadItem.prototype.getNativeRange.call( { range: range } );
|
2021-01-26 18:58:58 +00:00
|
|
|
|
|
|
|
|
// Expand the range so that it covers sibling nodes.
|
|
|
|
|
// This will include any wrapping formatting elements as part of the signature.
|
|
|
|
|
//
|
|
|
|
|
// Helpful accidental feature: users whose signature is not detected in full (due to
|
|
|
|
|
// text formatting) can just wrap it in a <span> to fix that.
|
|
|
|
|
// "Ten Pound Hammer • (What did I screw up now?)"
|
|
|
|
|
// "« Saper // dyskusja »"
|
|
|
|
|
//
|
|
|
|
|
// TODO Not sure if this is actually good, might be better to just use the range...
|
2021-04-08 13:46:09 +00:00
|
|
|
var sigNodes = utils.getCoveredSiblings( nativeRange ).reverse();
|
2021-01-26 18:58:58 +00:00
|
|
|
|
2022-02-04 15:44:14 +00:00
|
|
|
return {
|
|
|
|
|
nodes: sigNodes,
|
2022-02-04 18:16:24 +00:00
|
|
|
username: sigUsername,
|
|
|
|
|
displayName: sigDisplayName
|
2022-02-04 15:44:14 +00:00
|
|
|
};
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2019-10-20 16:36:43 +00:00
|
|
|
/**
|
2020-09-30 18:41:38 +00:00
|
|
|
* Return the next leaf node in the tree order that is likely a part of a discussion comment,
|
|
|
|
|
* rather than some boring "separator" element.
|
2019-10-20 16:36:43 +00:00
|
|
|
*
|
2020-12-14 20:13:55 +00:00
|
|
|
* Currently, this can return a Text node with content other than whitespace, or an Element node
|
|
|
|
|
* that is a "void element" or "text element", except some special cases that we treat as comment
|
|
|
|
|
* separators (isCommentSeparator()).
|
2019-10-20 16:36:43 +00:00
|
|
|
*
|
|
|
|
|
* @private
|
|
|
|
|
* @param {Node} node Node to start searching at. If it isn't a leaf node, its children are ignored.
|
2020-06-04 18:48:58 +00:00
|
|
|
* @return {Node}
|
2019-10-20 16:36:43 +00:00
|
|
|
*/
|
2020-07-20 21:15:03 +00:00
|
|
|
Parser.prototype.nextInterestingLeafNode = function ( node ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var rootNode = this.rootNode;
|
2020-07-20 21:15:03 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var treeWalker = rootNode.ownerDocument.createTreeWalker(
|
2019-09-26 07:06:56 +00:00
|
|
|
rootNode,
|
|
|
|
|
// eslint-disable-next-line no-bitwise
|
|
|
|
|
NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT,
|
|
|
|
|
function ( n ) {
|
|
|
|
|
// Ignore this node and its descendants
|
2020-01-28 23:35:26 +00:00
|
|
|
// (unless it's the root node, this is a special case for "fakeHeading" handling)
|
|
|
|
|
if ( node !== rootNode && ( n === node || n.parentNode === node ) ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2020-12-14 20:13:55 +00:00
|
|
|
// Ignore some elements usually used as separators or headers (and their descendants)
|
2021-12-04 02:06:57 +00:00
|
|
|
if ( utils.isCommentSeparator( n ) ) {
|
2020-12-14 20:13:55 +00:00
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2021-01-26 03:36:27 +00:00
|
|
|
// Ignore nodes with no rendering that mess up our indentation detection
|
|
|
|
|
if ( utils.isRenderingTransparentNode( n ) ) {
|
|
|
|
|
return NodeFilter.FILTER_REJECT;
|
|
|
|
|
}
|
2021-12-04 02:06:57 +00:00
|
|
|
if ( utils.isCommentContent( n ) ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
return NodeFilter.FILTER_ACCEPT;
|
|
|
|
|
}
|
|
|
|
|
return NodeFilter.FILTER_SKIP;
|
|
|
|
|
},
|
|
|
|
|
false
|
|
|
|
|
);
|
|
|
|
|
treeWalker.currentNode = node;
|
|
|
|
|
treeWalker.nextNode();
|
2020-06-04 18:48:58 +00:00
|
|
|
if ( !treeWalker.currentNode ) {
|
|
|
|
|
throw new Error( 'nextInterestingLeafNode not found' );
|
|
|
|
|
}
|
2019-09-26 07:06:56 +00:00
|
|
|
return treeWalker.currentNode;
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2021-02-26 20:57:22 +00:00
|
|
|
/**
|
|
|
|
|
* @param {Node[]} sigNodes
|
|
|
|
|
* @param {Object} match
|
|
|
|
|
* @param {Text} node
|
2022-10-04 12:50:57 +00:00
|
|
|
* @return {Object} Range-like object
|
2021-02-26 20:57:22 +00:00
|
|
|
*/
|
|
|
|
|
function adjustSigRange( sigNodes, match, node ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var firstSigNode = sigNodes[ sigNodes.length - 1 ];
|
|
|
|
|
var lastSigNode = sigNodes[ 0 ];
|
2021-02-26 20:57:22 +00:00
|
|
|
|
|
|
|
|
// TODO Document why this needs to be so complicated
|
2021-04-08 13:46:09 +00:00
|
|
|
var lastSigNodeOffset = lastSigNode === node ?
|
2021-02-26 20:57:22 +00:00
|
|
|
match.matchData.index + match.matchData[ 0 ].length - match.offset :
|
|
|
|
|
utils.childIndexOf( lastSigNode ) + 1;
|
2021-04-08 13:46:09 +00:00
|
|
|
var sigRange = {
|
2021-02-26 20:57:22 +00:00
|
|
|
startContainer: firstSigNode.parentNode,
|
|
|
|
|
startOffset: utils.childIndexOf( firstSigNode ),
|
|
|
|
|
endContainer: lastSigNode === node ? node : lastSigNode.parentNode,
|
|
|
|
|
endOffset: lastSigNodeOffset
|
|
|
|
|
};
|
|
|
|
|
return sigRange;
|
|
|
|
|
}
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
/**
|
|
|
|
|
* @return {ThreadItemSet}
|
|
|
|
|
*/
|
2020-07-20 21:15:03 +00:00
|
|
|
Parser.prototype.buildThreadItems = function () {
|
2022-02-19 06:31:34 +00:00
|
|
|
var result = new ThreadItemSet();
|
|
|
|
|
|
2019-09-26 07:06:56 +00:00
|
|
|
var
|
2020-09-03 20:59:33 +00:00
|
|
|
dfParsers = this.getLocalTimestampParsers(),
|
2022-02-19 06:31:34 +00:00
|
|
|
timestampRegexps = this.getLocalTimestampRegexps();
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var treeWalker = this.rootNode.ownerDocument.createTreeWalker(
|
2020-07-20 21:15:03 +00:00
|
|
|
this.rootNode,
|
2019-09-26 07:06:56 +00:00
|
|
|
// eslint-disable-next-line no-bitwise
|
|
|
|
|
NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT,
|
2019-10-24 16:24:59 +00:00
|
|
|
acceptOnlyNodesAllowingComments,
|
2019-09-26 07:06:56 +00:00
|
|
|
false
|
|
|
|
|
);
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
var curComment, range;
|
|
|
|
|
var curCommentEnd = this.rootNode;
|
2020-01-28 23:35:26 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var node, lastSigNode;
|
2019-09-26 07:06:56 +00:00
|
|
|
while ( ( node = treeWalker.nextNode() ) ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var match;
|
2020-10-01 19:36:11 +00:00
|
|
|
if ( node.tagName && ( match = node.tagName.match( /^h([1-6])$/i ) ) ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var headingNodeAndOffset = utils.getHeadlineNodeAndOffset( node );
|
|
|
|
|
var headingNode = headingNodeAndOffset.node;
|
|
|
|
|
var startOffset = headingNodeAndOffset.offset;
|
2020-02-05 18:30:21 +00:00
|
|
|
range = {
|
2020-10-27 12:18:36 +00:00
|
|
|
startContainer: headingNode,
|
|
|
|
|
startOffset: startOffset,
|
|
|
|
|
endContainer: headingNode,
|
|
|
|
|
endOffset: headingNode.childNodes.length
|
2020-02-05 18:30:21 +00:00
|
|
|
};
|
2020-10-01 19:36:11 +00:00
|
|
|
curComment = new HeadingItem( range, +match[ 1 ] );
|
2020-07-29 23:57:51 +00:00
|
|
|
curComment.rootNode = this.rootNode;
|
2022-02-19 06:31:34 +00:00
|
|
|
result.addThreadItem( curComment );
|
2020-11-16 00:35:51 +00:00
|
|
|
curCommentEnd = node;
|
2020-09-03 20:59:33 +00:00
|
|
|
} else if ( node.nodeType === Node.TEXT_NODE && ( match = this.findTimestamp( node, timestampRegexps ) ) ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var warnings = [];
|
|
|
|
|
var foundSignature = this.findSignature( node, lastSigNode );
|
2022-02-04 15:44:14 +00:00
|
|
|
var author = foundSignature.username;
|
|
|
|
|
lastSigNode = foundSignature.nodes[ 0 ];
|
Only detect comments with real signatures
Consequences of this are visible in the test cases:
* (en) Tech News posts are not detected.
Examples: "21:22, 1 July 2019 (UTC)", "21:42, 29 July 2019 (UTC)"
* (en) Comments by users who customize the timestamp are not detected.
Examples: "10:49, 28 June 2019 (UTC)", "21:34, 14 July 2019 (UTC)"
* (en) Comments with signatures missing a username are not detected.
This sometimes happens if a comment is accidentally signed with
'~~~~~' (five tildes), which only inserts the timestamp.
Examples: "17:17, 27 July 2019 (UTC)", "10:25, 29 July 2019 (UTC)"
* (pl) A lone timestamp at the beginning of a thread is not detected.
It's not part of a post, it was added to aid automatic archiving.
Example: "21:03, 18 paź 2018 (CET)"
Bug: T245692
Change-Id: I0767bb239a1800f2e538917b5995fc4f0fa4d043
2020-02-20 22:06:17 +00:00
|
|
|
|
|
|
|
|
if ( !author ) {
|
|
|
|
|
// Ignore timestamps for which we couldn't find a signature. It's probably not a real
|
|
|
|
|
// comment, but just a false match due to a copypasted timestamp.
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var sigRanges = [];
|
2022-10-04 12:50:57 +00:00
|
|
|
var timestampRanges = [];
|
|
|
|
|
|
2022-02-04 15:44:14 +00:00
|
|
|
sigRanges.push( adjustSigRange( foundSignature.nodes, match, node ) );
|
2022-10-04 12:50:57 +00:00
|
|
|
timestampRanges.push( match.range );
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2020-08-11 04:22:55 +00:00
|
|
|
// Everything from the last comment up to here is the next comment
|
2021-04-08 13:46:09 +00:00
|
|
|
var startNode = this.nextInterestingLeafNode( curCommentEnd );
|
|
|
|
|
var endNode = lastSigNode;
|
2021-01-08 19:20:33 +00:00
|
|
|
|
|
|
|
|
// Skip to the end of the "paragraph". This only looks at tag names and can be fooled by CSS, but
|
|
|
|
|
// avoiding that would be more difficult and slower.
|
2021-02-26 20:57:22 +00:00
|
|
|
//
|
|
|
|
|
// If this skips over another potential signature, also skip it in the main TreeWalker loop, to
|
|
|
|
|
// avoid generating multiple comments when there is more than one signature on a single "line".
|
|
|
|
|
// Often this is done when someone edits their comment later and wants to add a note about that.
|
|
|
|
|
// (Or when another person corrects a typo, or strikes out a comment, etc.) Multiple comments
|
|
|
|
|
// within one paragraph/list-item result in a confusing double "Reply" button, and we also have
|
|
|
|
|
// no way to indicate which one you're replying to (this might matter in the future for
|
|
|
|
|
// notifications or something).
|
2021-01-08 19:20:33 +00:00
|
|
|
utils.linearWalk(
|
|
|
|
|
lastSigNode,
|
|
|
|
|
// eslint-disable-next-line no-loop-func
|
2021-02-26 20:57:22 +00:00
|
|
|
function ( event, n ) {
|
|
|
|
|
var match2, foundSignature2;
|
2022-11-30 16:02:39 +00:00
|
|
|
if ( utils.isBlockElement( n ) || utils.isCommentSeparator( n ) ) {
|
2021-01-08 19:20:33 +00:00
|
|
|
// Stop when entering or leaving a block node
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2021-02-26 20:57:22 +00:00
|
|
|
if (
|
|
|
|
|
event === 'leave' &&
|
|
|
|
|
n.nodeType === Node.TEXT_NODE && n !== node &&
|
|
|
|
|
( match2 = this.findTimestamp( n, timestampRegexps ) )
|
|
|
|
|
) {
|
|
|
|
|
// If this skips over another potential signature, also skip it in the main TreeWalker loop
|
|
|
|
|
treeWalker.currentNode = n;
|
|
|
|
|
// …and add it as another signature to this comment (regardless of the author and timestamp)
|
|
|
|
|
foundSignature2 = this.findSignature( n, node );
|
2022-02-04 15:44:14 +00:00
|
|
|
if ( foundSignature2.username ) {
|
|
|
|
|
sigRanges.push( adjustSigRange( foundSignature2.nodes, match2, n ) );
|
2022-10-04 12:50:57 +00:00
|
|
|
timestampRanges.push( match2.range );
|
2021-02-26 20:57:22 +00:00
|
|
|
}
|
|
|
|
|
}
|
2021-01-08 19:20:33 +00:00
|
|
|
if ( event === 'leave' ) {
|
|
|
|
|
// Take the last complete node which we skipped past
|
2021-02-26 20:57:22 +00:00
|
|
|
endNode = n;
|
2021-01-08 19:20:33 +00:00
|
|
|
}
|
2021-02-26 20:57:22 +00:00
|
|
|
}.bind( this )
|
2021-01-08 19:20:33 +00:00
|
|
|
);
|
2020-08-11 04:22:55 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var length = endNode.nodeType === Node.TEXT_NODE ?
|
2020-11-24 20:58:34 +00:00
|
|
|
endNode.textContent.replace( /[\t\n\f\r ]+$/, '' ).length :
|
|
|
|
|
endNode.childNodes.length;
|
|
|
|
|
range = {
|
|
|
|
|
startContainer: startNode.parentNode,
|
|
|
|
|
startOffset: utils.childIndexOf( startNode ),
|
|
|
|
|
endContainer: endNode,
|
|
|
|
|
endOffset: length
|
|
|
|
|
};
|
2020-08-11 04:22:55 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var startLevel = utils.getIndentLevel( startNode, this.rootNode ) + 1;
|
|
|
|
|
var endLevel = utils.getIndentLevel( node, this.rootNode ) + 1;
|
2019-09-26 07:06:56 +00:00
|
|
|
if ( startLevel !== endLevel ) {
|
2020-05-13 18:23:48 +00:00
|
|
|
warnings.push( 'Comment starts and ends with different indentation' );
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2020-08-20 18:38:25 +00:00
|
|
|
// Should this use the indent level of `startNode` or `node`?
|
2021-04-08 13:46:09 +00:00
|
|
|
var level = Math.min( startLevel, endLevel );
|
2020-08-20 18:38:25 +00:00
|
|
|
|
2022-03-03 16:29:39 +00:00
|
|
|
var parserResult = dfParsers[ match.parserIndex ]( match.matchData );
|
|
|
|
|
var dateTime = parserResult.date;
|
|
|
|
|
if ( parserResult.warning ) {
|
|
|
|
|
warnings.push( parserResult.warning );
|
2020-08-20 18:38:25 +00:00
|
|
|
}
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2020-05-22 16:26:05 +00:00
|
|
|
curComment = new CommentItem(
|
2020-08-20 18:38:25 +00:00
|
|
|
level,
|
2020-05-22 16:26:05 +00:00
|
|
|
range,
|
2021-02-26 20:57:22 +00:00
|
|
|
sigRanges,
|
2022-10-04 12:50:57 +00:00
|
|
|
timestampRanges,
|
2020-05-22 16:26:05 +00:00
|
|
|
dateTime,
|
2022-02-04 18:16:24 +00:00
|
|
|
author,
|
|
|
|
|
foundSignature.displayName
|
2020-05-22 16:26:05 +00:00
|
|
|
);
|
2020-07-29 23:57:51 +00:00
|
|
|
curComment.rootNode = this.rootNode;
|
2020-05-13 18:23:48 +00:00
|
|
|
if ( warnings.length ) {
|
|
|
|
|
curComment.warnings = warnings;
|
|
|
|
|
}
|
2022-02-19 06:31:34 +00:00
|
|
|
if ( result.isEmpty() ) {
|
|
|
|
|
// Add a fake placeholder heading if there are any comments in the 0th section
|
|
|
|
|
// (before the first real heading)
|
|
|
|
|
range = {
|
|
|
|
|
startContainer: this.rootNode,
|
|
|
|
|
startOffset: 0,
|
|
|
|
|
endContainer: this.rootNode,
|
|
|
|
|
endOffset: 0
|
|
|
|
|
};
|
2022-06-06 17:35:43 +00:00
|
|
|
var fakeHeading = new HeadingItem( range, null );
|
2022-02-19 06:31:34 +00:00
|
|
|
fakeHeading.rootNode = this.rootNode;
|
|
|
|
|
result.addThreadItem( fakeHeading );
|
|
|
|
|
}
|
|
|
|
|
result.addThreadItem( curComment );
|
2020-11-16 00:35:51 +00:00
|
|
|
curCommentEnd = curComment.range.endContainer;
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
return result;
|
2020-07-20 21:15:03 +00:00
|
|
|
};
|
|
|
|
|
|
2021-02-02 17:40:18 +00:00
|
|
|
/**
|
|
|
|
|
* Truncate user generated parts of IDs so full ID always fits within a database field of length 255
|
|
|
|
|
*
|
|
|
|
|
* @param {string} text Text
|
|
|
|
|
* @return {string} Truncated text
|
|
|
|
|
*/
|
|
|
|
|
Parser.prototype.truncateForId = function ( text ) {
|
|
|
|
|
return trimByteLength( '', text, 80 ).newVal;
|
|
|
|
|
};
|
|
|
|
|
|
2020-10-21 15:52:04 +00:00
|
|
|
/**
|
|
|
|
|
* Given a thread item, return an identifier for it that is unique within the page.
|
|
|
|
|
*
|
|
|
|
|
* @param {ThreadItem} threadItem
|
2022-02-19 06:31:34 +00:00
|
|
|
* @param {ThreadItemSet} previousItems
|
2021-02-12 23:02:51 +00:00
|
|
|
* @return {string}
|
2020-10-21 15:52:04 +00:00
|
|
|
*/
|
2022-02-19 06:31:34 +00:00
|
|
|
Parser.prototype.computeId = function ( threadItem, previousItems ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var id, headline;
|
2020-10-21 15:52:04 +00:00
|
|
|
|
2020-09-22 23:05:25 +00:00
|
|
|
if ( threadItem instanceof HeadingItem && threadItem.placeholderHeading ) {
|
|
|
|
|
// The range points to the root note, using it like below results in silly values
|
2021-03-17 14:39:41 +00:00
|
|
|
id = 'h-';
|
2020-09-22 23:05:25 +00:00
|
|
|
} else if ( threadItem instanceof HeadingItem ) {
|
2022-02-22 09:36:45 +00:00
|
|
|
// <span class="mw-headline" …>, or <hN …> in Parsoid HTML
|
|
|
|
|
headline = threadItem.range.startContainer;
|
2021-03-17 14:39:41 +00:00
|
|
|
id = 'h-' + this.truncateForId( headline.getAttribute( 'id' ) || '' );
|
2020-09-22 23:05:25 +00:00
|
|
|
} else if ( threadItem instanceof CommentItem ) {
|
2022-03-24 16:48:25 +00:00
|
|
|
id = 'c-' + this.truncateForId( threadItem.author || '' ).replace( / /g, '_' ) + '-' + threadItem.getTimestampString();
|
2020-10-01 20:13:47 +00:00
|
|
|
} else {
|
|
|
|
|
throw new Error( 'Unknown ThreadItem type' );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// If there would be multiple comments with the same ID (i.e. the user left multiple comments
|
|
|
|
|
// in one edit, or within a minute), append sequential numbers
|
2021-04-08 13:46:09 +00:00
|
|
|
var threadItemParent = threadItem.parent;
|
2020-10-01 20:13:47 +00:00
|
|
|
if ( threadItemParent instanceof HeadingItem && !threadItemParent.placeholderHeading ) {
|
2022-02-22 09:36:45 +00:00
|
|
|
// <span class="mw-headline" …>, or <hN …> in Parsoid HTML
|
|
|
|
|
headline = threadItemParent.range.startContainer;
|
2021-03-17 14:39:41 +00:00
|
|
|
id += '-' + this.truncateForId( headline.getAttribute( 'id' ) || '' );
|
2020-10-01 20:13:47 +00:00
|
|
|
} else if ( threadItemParent instanceof CommentItem ) {
|
2022-03-24 16:48:25 +00:00
|
|
|
id += '-' + this.truncateForId( threadItemParent.author || '' ).replace( / /g, '_' ) + '-' + threadItemParent.getTimestampString();
|
2020-10-01 20:13:47 +00:00
|
|
|
}
|
2020-10-21 15:52:04 +00:00
|
|
|
|
2020-10-07 15:48:20 +00:00
|
|
|
if ( threadItem instanceof HeadingItem ) {
|
|
|
|
|
// To avoid old threads re-appearing on popular pages when someone uses a vague title
|
|
|
|
|
// (e.g. dozens of threads titled "question" on [[Wikipedia:Help desk]]: https://w.wiki/fbN),
|
|
|
|
|
// include the oldest timestamp in the thread (i.e. date the thread was started) in the
|
|
|
|
|
// heading ID.
|
2022-07-05 23:21:34 +00:00
|
|
|
var oldestComment = threadItem.getOldestReply();
|
2021-02-22 20:31:15 +00:00
|
|
|
if ( oldestComment ) {
|
2022-03-24 16:48:25 +00:00
|
|
|
id += '-' + oldestComment.getTimestampString();
|
2020-10-07 15:48:20 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
if ( previousItems.findCommentById( id ) ) {
|
2020-10-01 20:13:47 +00:00
|
|
|
// Well, that's tough
|
|
|
|
|
threadItem.warnings.push( 'Duplicate comment ID' );
|
|
|
|
|
// Finally, disambiguate by adding sequential numbers, to allow replying to both comments
|
2021-04-08 13:46:09 +00:00
|
|
|
var number = 1;
|
2022-02-19 06:31:34 +00:00
|
|
|
while ( previousItems.findCommentById( id + '-' + number ) ) {
|
2020-10-21 15:52:04 +00:00
|
|
|
number++;
|
|
|
|
|
}
|
2021-03-17 14:39:41 +00:00
|
|
|
id = id + '-' + number;
|
2020-10-21 15:52:04 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return id;
|
|
|
|
|
};
|
|
|
|
|
|
2021-02-12 19:16:13 +00:00
|
|
|
/**
|
|
|
|
|
* Given a thread item, return an identifier for it that is consistent across all pages and
|
|
|
|
|
* revisions where this comment might appear.
|
|
|
|
|
*
|
|
|
|
|
* Multiple comments on a page can have the same name; use ID to distinguish them.
|
|
|
|
|
*
|
|
|
|
|
* @param {ThreadItem} threadItem
|
|
|
|
|
* @return {string}
|
|
|
|
|
*/
|
|
|
|
|
Parser.prototype.computeName = function ( threadItem ) {
|
|
|
|
|
var name, mainComment;
|
|
|
|
|
|
|
|
|
|
if ( threadItem instanceof HeadingItem ) {
|
|
|
|
|
name = 'h-';
|
2022-07-05 23:21:34 +00:00
|
|
|
mainComment = threadItem.getOldestReply();
|
2021-02-12 19:16:13 +00:00
|
|
|
} else if ( threadItem instanceof CommentItem ) {
|
|
|
|
|
name = 'c-';
|
|
|
|
|
mainComment = threadItem;
|
|
|
|
|
} else {
|
|
|
|
|
throw new Error( 'Unknown ThreadItem type' );
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ( mainComment ) {
|
|
|
|
|
name += this.truncateForId( mainComment.author || '' ).replace( / /g, '_' ) +
|
2022-03-24 16:48:25 +00:00
|
|
|
'-' + mainComment.getTimestampString();
|
2021-02-12 19:16:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return name;
|
|
|
|
|
};
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
/**
|
|
|
|
|
* @param {ThreadItemSet} result
|
|
|
|
|
*/
|
|
|
|
|
Parser.prototype.buildThreads = function ( result ) {
|
|
|
|
|
var lastHeading = null;
|
|
|
|
|
var replies = [];
|
2021-04-08 13:46:09 +00:00
|
|
|
|
|
|
|
|
var i, threadItem;
|
2022-02-19 06:31:34 +00:00
|
|
|
for ( i = 0; i < result.threadItems.length; i++ ) {
|
|
|
|
|
threadItem = result.threadItems[ i ];
|
2019-11-24 15:39:52 +00:00
|
|
|
|
2020-07-20 21:15:03 +00:00
|
|
|
if ( replies.length < threadItem.level ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
// Someone skipped an indentation level (or several). Pretend that the previous reply
|
|
|
|
|
// covers multiple indentation levels, so that following comments get connected to it.
|
2020-07-20 21:15:03 +00:00
|
|
|
threadItem.warnings.push( 'Comment skips indentation level' );
|
|
|
|
|
while ( replies.length < threadItem.level ) {
|
2019-09-26 07:06:56 +00:00
|
|
|
replies[ replies.length ] = replies[ replies.length - 1 ];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-07-20 21:15:03 +00:00
|
|
|
if ( threadItem instanceof HeadingItem ) {
|
2020-05-12 23:21:02 +00:00
|
|
|
// New root (thread)
|
2020-10-01 19:36:11 +00:00
|
|
|
// Attach as a sub-thread to preceding higher-level heading.
|
|
|
|
|
// Any replies will appear in the tree twice, under the main-thread and the sub-thread.
|
2022-02-19 06:31:34 +00:00
|
|
|
var maybeParent = lastHeading;
|
2020-10-01 19:36:11 +00:00
|
|
|
while ( maybeParent && maybeParent.headingLevel >= threadItem.headingLevel ) {
|
|
|
|
|
maybeParent = maybeParent.parent;
|
|
|
|
|
}
|
|
|
|
|
if ( maybeParent ) {
|
|
|
|
|
threadItem.parent = maybeParent;
|
|
|
|
|
maybeParent.replies.push( threadItem );
|
|
|
|
|
}
|
2022-02-19 06:31:34 +00:00
|
|
|
lastHeading = threadItem;
|
2020-07-20 21:15:03 +00:00
|
|
|
} else if ( replies[ threadItem.level - 1 ] ) {
|
2020-05-12 23:21:02 +00:00
|
|
|
// Add as a reply to the closest less-nested comment
|
2020-07-20 21:15:03 +00:00
|
|
|
threadItem.parent = replies[ threadItem.level - 1 ];
|
|
|
|
|
threadItem.parent.replies.push( threadItem );
|
2019-09-26 07:06:56 +00:00
|
|
|
} else {
|
2020-07-20 21:15:03 +00:00
|
|
|
threadItem.warnings.push( 'Comment could not be connected to a thread' );
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
|
|
|
|
|
2020-07-20 21:15:03 +00:00
|
|
|
replies[ threadItem.level ] = threadItem;
|
2020-05-12 23:21:02 +00:00
|
|
|
// Cut off more deeply nested replies
|
2020-07-20 21:15:03 +00:00
|
|
|
replies.length = threadItem.level + 1;
|
2020-10-07 15:48:20 +00:00
|
|
|
}
|
2022-02-19 06:31:34 +00:00
|
|
|
};
|
2020-10-07 15:48:20 +00:00
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
/**
|
|
|
|
|
* Set the IDs and names used to refer to comments and headings.
|
|
|
|
|
* This has to be a separate pass because we don't have the list of replies before
|
|
|
|
|
* this point.
|
|
|
|
|
*
|
|
|
|
|
* @param {ThreadItemSet} result
|
|
|
|
|
*/
|
|
|
|
|
Parser.prototype.computeIdsAndNames = function ( result ) {
|
|
|
|
|
var i, threadItem;
|
|
|
|
|
for ( i = 0; i < result.threadItems.length; i++ ) {
|
|
|
|
|
threadItem = result.threadItems[ i ];
|
2020-10-01 20:13:47 +00:00
|
|
|
|
2021-04-08 13:46:09 +00:00
|
|
|
var name = this.computeName( threadItem );
|
2021-02-12 19:16:13 +00:00
|
|
|
threadItem.name = name;
|
|
|
|
|
|
2022-02-19 06:31:34 +00:00
|
|
|
var id = this.computeId( threadItem, result );
|
2020-10-01 20:13:47 +00:00
|
|
|
threadItem.id = id;
|
2022-02-19 06:31:34 +00:00
|
|
|
|
|
|
|
|
result.updateIdAndNameMaps( threadItem );
|
2019-09-26 07:06:56 +00:00
|
|
|
}
|
2020-10-07 15:48:20 +00:00
|
|
|
};
|
2019-09-26 07:06:56 +00:00
|
|
|
|
2020-10-07 15:48:20 +00:00
|
|
|
/**
|
|
|
|
|
* @param {ThreadItem} threadItem
|
2021-02-22 20:31:15 +00:00
|
|
|
* @return {CommentItem|null}
|
2020-10-07 15:48:20 +00:00
|
|
|
*/
|
2021-02-22 20:31:15 +00:00
|
|
|
Parser.prototype.getThreadStartComment = function ( threadItem ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var oldest = null;
|
2020-10-07 15:48:20 +00:00
|
|
|
if ( threadItem instanceof CommentItem ) {
|
2021-02-22 20:31:15 +00:00
|
|
|
oldest = threadItem;
|
2020-10-07 15:48:20 +00:00
|
|
|
}
|
|
|
|
|
// Check all replies. This can't just use the first comment because threads are often summarized
|
|
|
|
|
// at the top when the discussion is closed.
|
2021-04-08 13:46:09 +00:00
|
|
|
for ( var i = 0; i < threadItem.replies.length; i++ ) {
|
|
|
|
|
var comment = threadItem.replies[ i ];
|
2020-10-07 15:48:20 +00:00
|
|
|
// Don't include sub-threads to avoid changing the ID when threads are "merged".
|
|
|
|
|
if ( comment instanceof CommentItem ) {
|
2021-04-08 13:46:09 +00:00
|
|
|
var oldestInReplies = this.getThreadStartComment( comment );
|
2021-02-22 20:31:15 +00:00
|
|
|
if ( !oldest || oldestInReplies.timestamp.isBefore( oldest.timestamp ) ) {
|
|
|
|
|
oldest = oldestInReplies;
|
2020-10-07 15:48:20 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2021-02-22 20:31:15 +00:00
|
|
|
return oldest;
|
2019-09-26 07:06:56 +00:00
|
|
|
};
|
2020-07-20 21:15:03 +00:00
|
|
|
|
|
|
|
|
module.exports = Parser;
|