Commit graph

3382 commits

Author SHA1 Message Date
Umherirrender b2ec6b2955 Replace isset() with null check in SimpleCaptcha
Found usage of isset() on expression $this->captchaSolved that appears
to be always set. isset() should only be used to suppress errors. Check
whether the expression is null instead.
See https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#isset

Change-Id: I5520786060b2aa2fca81acd40924d84e94e8dff2
2024-04-01 13:38:44 +02:00
Timo Tijhof 5c1fc0f2e0 tests: Remove redundant wgMainCacheType=hash
Follows-up 5b3765f7b, which refactored the way this was set.

Introduced in 2016 with 31c59374a, but redundant since 2020 with
commit c6c62e2c8f in MediaWiki core.

Bug: T139216
Change-Id: Iaf0a2f60833797ecf0b74f69dd797ca3c53cc550
2024-03-29 23:03:41 +00:00
Translation updater bot 42b6bcaa3b Localisation updates from https://translatewiki.net.
Change-Id: I0679113b316d84fb9fab215d5f9720ac6a6f6f27
2024-03-29 08:46:30 +01:00
Translation updater bot a59f780cd4 Localisation updates from https://translatewiki.net.
Change-Id: I73e0b0a7b13210208e6f039f3264c29690be3011
2024-03-26 08:19:21 +01:00
Umherirrender bcdde67ebd Add explicit parentheses around mixed boolean operator
Mixing different binary boolean operators within an expression
without using parentheses to clarify precedence is not allowed (T358966)

Change-Id: I908691348d259d868f39a7737614be82c9ce0c75
2024-03-23 00:52:19 +01:00
Translation updater bot a1a566a1c1 Localisation updates from https://translatewiki.net.
Change-Id: Ifd8ee307ae123da45da4a5b1fc67d2fcbf8f8e21
2024-03-22 08:43:58 +01:00
Reedy ec6f8c5fee GenerateFancyCaptchas: Include stderr result if captcha.py returns an error code
Bug: T360653
Change-Id: Ie998180e5a74441c76e236074961cf0d34aaecaf
2024-03-21 16:40:49 +00:00
Translation updater bot 8a94dca6f2 Localisation updates from https://translatewiki.net.
Change-Id: Iff70272e0cad637401c9fc55e1cdf987c38d383d
2024-03-20 08:23:23 +01:00
Translation updater bot 1ca0b338e2 Localisation updates from https://translatewiki.net.
Change-Id: I39ba5cf12e9a0d86e718d26442bc81c8bfedb527
2024-03-19 08:24:48 +01:00
Translation updater bot 78ba529096 Localisation updates from https://translatewiki.net.
Change-Id: I90c432110e3e63db95889d7064654f660f330d6d
2024-03-18 08:30:41 +01:00
Dringsim f3cd5b0bc9
Replace usage of wfGetDB()
Bug: T357638
Change-Id: Ibb03f914f90e711d5b28fa24073428617fbaf955
2024-03-17 00:44:39 +08:00
Translation updater bot 4d3fa16089 Localisation updates from https://translatewiki.net.
Change-Id: I864416a1632386f82f0feeb2305d78c35d01d27c
2024-03-13 08:25:22 +01:00
Translation updater bot 3dd3e02b80 Localisation updates from https://translatewiki.net.
Change-Id: I5778377294be13e85203be81e668e3c28877b0a9
2024-03-12 08:24:15 +01:00
Translation updater bot fc342c4c8f Localisation updates from https://translatewiki.net.
Change-Id: Iee04a7e56831d68294f0b2fd4044694938fb5a68
2024-03-11 08:26:37 +01:00
Umherirrender af6ecdecf7 build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Change-Id: I5b46168e1e845747ae0a92b28a7f9e56e06309aa
2024-03-10 17:18:48 +01:00
jenkins-bot 6588e7c57e Merge "Fix ConfirmEdit to avoid global state" 2024-03-08 16:36:47 +00:00
Translation updater bot 619143041a Localisation updates from https://translatewiki.net.
Change-Id: I44b854dfc3437ab0e2daada115b59280de018237
2024-03-08 08:22:51 +01:00
Derick Alangi 5b3765f7b5
Fix ConfirmEdit to avoid global state
ConfirmEdit will try to mess with ObjectCache::$instances, clean this
up so that we migrate consumers to go through ObjectCacheFactory.

Bug: T358346
Change-Id: I317a1a17f4f39e99a9b31660eebcd0185adb88f8
2024-03-07 15:05:23 +03:00
Translation updater bot 43f2f36462 Localisation updates from https://translatewiki.net.
Change-Id: Icb81ed4ae441b5c6582e8c3f2907a244658bd31d
2024-03-07 08:48:18 +01:00
Translation updater bot 613f419b8a Localisation updates from https://translatewiki.net.
Change-Id: I6545a2f056671afd0215a49ab8767d260e509a82
2024-03-04 08:23:10 +01:00
Translation updater bot 00741aac24 Localisation updates from https://translatewiki.net.
Change-Id: I32503e97df61b88cc7e30a7ed77767260e69e8a4
2024-02-29 08:35:45 +01:00
Translation updater bot a59c010195 Localisation updates from https://translatewiki.net.
Change-Id: I4c833ded00377a3db4dee02909410bb613110c88
2024-02-28 08:14:06 +01:00
Translation updater bot 9d93795d18 Localisation updates from https://translatewiki.net.
Change-Id: I8a282e84d78be52014b6a14a88498976012fb0b5
2024-02-27 08:19:47 +01:00
Translation updater bot be4c730cf8 Localisation updates from https://translatewiki.net.
Change-Id: Ide9e4cbcfbb694087f93b48d178ae248b0bc678c
2024-02-26 08:35:45 +01:00
Translation updater bot 6f42354e94 Localisation updates from https://translatewiki.net.
Change-Id: I12e0b745375ffd5347c8884b2996ab2084527ebe
2024-02-22 08:43:17 +01:00
Translation updater bot d523383d6e Localisation updates from https://translatewiki.net.
Change-Id: I96cbb18680f3dbf0d1077d942fcb5352b8bf07a7
2024-02-21 08:35:28 +01:00
Reedy 86af079ed9 Deprecate use of captcha-old.py
Bug: T357930
Change-Id: I69a2e68d430d7a5769fb8b4391f1163ee99ad8fb
2024-02-19 19:11:43 +00:00
Translation updater bot be305ed8a5 Localisation updates from https://translatewiki.net.
Change-Id: I903b38ce6a9f1adb230b29213740baf42a7c5b6e
2024-02-19 08:39:54 +01:00
jenkins-bot 7fed1dc57a Merge "Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()" 2024-02-17 03:20:15 +00:00
Bartosz Dziewoński 1349c099c6 Use OutputPage::setPageTitleMsg() instead of ::setPageTitle()
Bug: T343994
Change-Id: I706a44af75c85bb8d1e4dd6b8e813e436fd8943b
2024-02-17 02:55:53 +01:00
Translation updater bot b56abdc0b3 Localisation updates from https://translatewiki.net.
Change-Id: I6b7c8d58dc6613fa2e4fa6826ee6a95b2551e444
2024-02-15 13:27:54 +01:00
Translation updater bot c7d116c779 Localisation updates from https://translatewiki.net.
Change-Id: Ib3d9940e5d39540fa16bcd23b7cbe649319c57df
2024-02-14 08:18:33 +01:00
Translation updater bot bc07ba7ac8 Localisation updates from https://translatewiki.net.
Change-Id: I7cddc35be6a4b4b01e82302e267f5e73f5920b4f
2024-02-12 14:49:14 +01:00
libraryupgrader ccaeae13c5 build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Change-Id: I3644fbc31d47b6b056122eb6f958de76e81e22ce
2024-02-10 16:10:33 +00:00
Translation updater bot 8d84937609 Localisation updates from https://translatewiki.net.
Change-Id: I5ad1b58ff9eebef2867ab14244527bc947803ac1
2024-02-08 09:14:51 +01:00
Translation updater bot 43dc2b2059 Localisation updates from https://translatewiki.net.
Change-Id: If50e27e7066726e37e7564dbbf29011333668ba2
2024-02-05 08:49:28 +01:00
jenkins-bot 26a4cafe14 Merge "FancyCaptcha: Switch to codex text input" 2024-01-29 21:11:48 +00:00
Amir Sarabadani e00901f634 FancyCaptcha: Switch to codex text input
It's only adding css and relying on classes in divs which is not
beautiful but it stops the field from being unstyled.

Bug: T355436
Change-Id: I103c95733ba60252db0e2b913eb6f3fc5323c122
2024-01-29 21:45:27 +01:00
jenkins-bot ebb8f73ae3 Merge "captca.py: Fix PIL 10 support again" 2024-01-29 19:36:50 +00:00
jenkins-bot 578a11b779 Merge "FancyCaptcha: Remove deprecated blacklist parameter" 2024-01-29 16:43:36 +00:00
Translation updater bot b0227d4ab7 Localisation updates from https://translatewiki.net.
Change-Id: I4a8d5b54fa90a08c8fd6cb07d5b4534922c3241d
2024-01-28 16:05:59 +01:00
Reedy cbbe6611b4 FancyCaptcha: Remove deprecated blacklist parameter
Bug: T277936
Depends-On: Ia467c4fb56e9920826a2e4e505e277683ab154b8
Change-Id: Ia64c20bf4638cdba85860dbd2852ee04f9498561
2024-01-27 15:07:32 +00:00
Reedy bdd127a276 captca.py: Fix PIL 10 support again
Bug: T354099
Follows-Up: Ia17157d45995b78c6a73f844dfe7d20d09564748
Change-Id: I9d1fe7ad7f12fd79c960574daf79e558d88cb02c
2024-01-27 14:26:02 +00:00
Reedy db932b2ae2 FancyCaptcha: Add missing trailing /
Bug: T355962
Change-Id: Id266aa5671550410b570da41b1ccdc537752aa16
Depends-On: Iecc48db5237adc5b89c99019faac0af425e4eb5d
2024-01-26 22:50:58 +00:00
jenkins-bot 9625c91e18 Merge "FancyCaptcha: Allow configuration of the actual directory captchas are stored in" 2024-01-26 16:18:10 +00:00
gerritbot 8a42f0c0ea Remove indirect calls to IDBAccessObject::READ_* constants
We are getting rid of the schema of implementing this interface and
calling self::READ_* constants, it's confusing, inconsistent, prone to
clashes and isn't really useful for non-ORM systems (which we are not)

Bug: T354194
Change-Id: I03c893130aea133c7df3b1e81213f0cf9191ae3e
2024-01-26 14:27:20 +00:00
jenkins-bot 4fda05d19d Merge "*.py: Fixup a couple more linting issues" 2024-01-24 22:17:10 +00:00
jenkins-bot d6675a34c0 Merge "GenerateFancyCaptchas: Add ->disableSandbox() to shell command" 2024-01-24 05:15:15 +00:00
Umherirrender a672544be1 Turnstile: Drop RL targets definitions, no longer honoured
Bug: T328497
Follow-Up: Id8501de1d372b7eca8e49c669d401322b2a51371
Change-Id: Ibc1ba4895a38f7f34838e4f4faa8144b0f889d76
2024-01-24 00:00:04 +01:00
jenkins-bot 7d5404d0d0 Merge "Drop RL targets definitions from module definition, no longer honoured" 2024-01-23 22:26:10 +00:00