In this patch, we can now make use of MicroStash only and
drop dead code.
At this point, we're sure that there are no captchas in the
main stash, freeing up this memory for other requests to use.
Bug: T336004
Change-Id: I6aa69636f2f94e3bd18afc66eac37146d00771d1
This has nothing to do with CAPTCHA generation, and the only thing it
needs from the SimpleCaptcha class is checking whether a CAPTCHA on
bad login is enabled at all.
Also improve comments in CaptchaPreAuthenticationProvider. I found the
session flag business really difficult to understand.
Change-Id: I8200531718aaa11effcb07539204e1a05ed432e0
Changes to the use statements done automatically via script
Addition of missing use statements done manually
Change-Id: Id44f211320e56bc83e4c8f243369dc4eb562cf37
ConfirmEdit uses MainStash as the backend to write its captchas. We
are migrating this extension to use the MicroStash store instead which
is more suitable.
This patch will store the captcha in MicroStash, read it from there
or fallback to MainStash if lookup was not successful. The code will
then clear both stores once after processing.
Migration plan
==============
step .1: Write to microstash store only, read from it or
fallback to mainstash store. Then delete from
both backends.
step .2: Read from microstash store only, delete from the
microstash store, and remove dead code afterward.
Bug: T336004
Change-Id: Ie7c50a6efe7a0aefc97a712b2ad961e7837cc4cf
Status now provides declared $statusData property for holding
arbitrary data that can be used instead.
Bug: T326479
Depends-On: Ibe3f1f8b81bcfcb18551d3ca4cda464e4bdbcbce
Change-Id: I1342a8a8ca64b4040ed2b2d101d4574aedd888af
* `require()` is more direct and likely faster than a synchronous
file read into user land and then sync JSON.parse (as grunt.file
does) than Node natively reading and parsing a file in one go.
Also benefits being less Grunt-specific and theoretically some minor
benefit to IDE and static analysis.
* Inline loop as for-of without the forEach function calls.
Change-Id: I06c8f8729b2f4ba2c574c7aaeaa2ae56513b4595
This repo is a little tricky, as it's made up of multiple sub-
extensions, each using relative paths, but at least this way it
is clear that adding additional i18n paths to a manifest will
also add it to the linting set-up.
Change-Id: I7bc4f0cd5d2b431fe47a4d3bee2ca69a06aeea6d
Most MediaWiki extensions use "website" and not "web site",
so removing the space here for consistency.
Also adding commas after introductory words in the same message
and clarifying the pronouns.
Change-Id: I0f2d1e647a0f01af4a98053744c639658bbc2454
Details in Ia4df6350f849ca27.
The global variable will still work in most cases, but the way it was
used here (as wgExtensionFunctions callback) will stop working to
allow MW core to run plain `phpunit` (T90875).
Migrate to the MW_QUIBBLE_CI constant instead, which is set in all
the same circumstances
Change-Id: I25acee1e6e88ca745435cbfa0b398041f04c94d6
