Commit graph

3849 commits

Author SHA1 Message Date
thiemowmde fa44741f26 Hide wrong "this reference is used 0 times" in citation dialog
This fixes a minor regression introduced in Ib003b8a. The problem is
that undefined is not equal to anything in JavaScript, and not smaller
than 2 either.

Bug: T241885
Bug: T335410
Change-Id: Ia6deb291d923b88a08ceac8fbc0efb682e14f358
2023-04-26 14:45:33 +00:00
Translation updater bot 3c902a8f34 Localisation updates from https://translatewiki.net.
Change-Id: Ifb96b94e80763ea5e5e7d9f3582ca835f5a17823
2023-04-24 09:15:43 +02:00
Arlo Breault 984aa7750c Disable tests to break circular dependency
Needed-By: Ifd4001e312a5fa4b7beaad63ba8c4e79e3201b9b
Change-Id: Ie85ee7048273023a2c51f42a333a9c1493360404
2023-04-20 16:00:43 -04:00
jenkins-bot 23d7c3d3bf Merge "Fix wrong "this reference is used twice" in VisualEditor" 2023-04-17 06:40:44 +00:00
Translation updater bot a93bf69abc Localisation updates from https://translatewiki.net.
Change-Id: Iddc47ad6255118a105e89f824599f0311e758511
2023-04-13 08:45:53 +02:00
Ed Sanders ec88bde672 Drop IE CSS hacks
IE is no longer supported

Change-Id: I27901e87301a4ce0993f789913c83d151f264562
2023-04-12 16:33:23 +01:00
thiemowmde ce63522726 Fix wrong "this reference is used twice" in VisualEditor
This patch also updates a second place that does almost the same.

That other place also excludes placeholders. We intentionally don't
do this in this new place.

Bug: T241885
Change-Id: Ib003b8a7bbe247db6f7da0a4efcfd4e5967fd033
2023-04-12 15:19:11 +02:00
thiemowmde 4ac067c0fa Fix broken selector in MWReferenceNode.less
This issue was introduced in I7a8ec9f. I tried to understand what this
does but can't see an effect. The behavior and appearence seems to be
identical with and without this code. In case it turns out this is dead
code (e.g. not needed any more with our current browser requirements)
it should be removed. Otherwise the selector fixed.

Change-Id: I0bfae951aa4543c528dd7e04c00a0e978f1ce49e
2023-04-11 20:39:51 +02:00
jenkins-bot bada094fb2 Merge "Localisation updates from https://translatewiki.net." 2023-04-10 07:57:44 +00:00
Translation updater bot f36497ed62 Localisation updates from https://translatewiki.net.
Change-Id: I454ab89ca402b97535f5ba8d0a6918d0f5605912
2023-04-10 09:44:46 +02:00
Translation updater bot 545491a21f Localisation updates from https://translatewiki.net.
Change-Id: Iefcf05de017e0fa4d10b81414051e1aae8efc22d
2023-04-10 09:20:22 +02:00
Translation updater bot faa8173d40 Localisation updates from https://translatewiki.net.
Change-Id: Ie541a2a6701a64d712245e959a2acfdb142e618e
2023-04-03 09:17:11 +02:00
Ed Sanders 9b9eccc21b ve-cite: Simplify LESS files with nesting
Change-Id: I7a8ec9fceb3563a4561afd95e18a5667a363a1ab
2023-03-28 11:06:14 +00:00
Ed Sanders ca9ef93409 ve-cite: Convert .css files to .less
Change-Id: If831c23721cc2c3ec3cc17d4cd9c9533a0aa4cb4
2023-03-27 15:01:45 +01:00
Translation updater bot e95f55921a Localisation updates from https://translatewiki.net.
Change-Id: I3da809daa882be628cafbb3df7ee13c1c5980fae
2023-03-27 08:40:38 +02:00
jenkins-bot 39a3ee0ce8 Merge "selenium: Refactor WebdriverIO tests from sync to async mode" 2023-03-20 17:07:25 +00:00
Peter Wangai 27ab8a437d selenium: Refactor WebdriverIO tests from sync to async mode
WebdriverIO has dropped support of sync mode, hence changed to async.

Update npm packages: @wdio/*, wdio-mediawiki
because async mode needs at least @wdio v7.9.

Remove npm packages: @wdio/dot-reporter and @wdio/sync.

Bug: T300196
Change-Id: I8a2ba7f87496b19cc22c347088d52e56741cac71
2023-03-20 19:13:40 +03:00
jenkins-bot d8aee328cf Merge "Replace string|false in CiteParserTagHooks with nullable ?string" 2023-03-20 09:36:39 +00:00
Translation updater bot ea5e7202a0 Localisation updates from https://translatewiki.net.
Change-Id: Ibb51e8e00877fb1d3dd653c33acf7f9db2969614
2023-03-20 09:00:43 +01:00
libraryupgrader 09e81680e6 build: Updating npm dependencies
* eslint-config-wikimedia: 0.22.1 → 0.24.0
* grunt: 1.5.3 → 1.6.1

Change-Id: I8af7b599bb58e0097cce61394c782db4c641910c
2023-03-16 01:50:57 +00:00
Translation updater bot dc1d15cb64 Localisation updates from https://translatewiki.net.
Change-Id: I9f17e5ed55e38d8774997449b20364f6d479ec52
2023-03-15 08:49:26 +01:00
Subramanya Sastry 8d93818fc8 Use double-colon for pseudo-elements
* Linting rule has been fixed to accept these now.

Change-Id: I51d866ec18c9e1d675f43b3c60f3ad874bba041e
2023-03-14 16:49:10 -04:00
jenkins-bot 5964899b42 Merge "Document Parsoid's differing HTML for follows" 2023-03-14 20:45:13 +00:00
Subramanya Sastry fc0a239887 Document Parsoid's differing HTML for follows
* Add a file-level comment in the cite tests file.
* Document the CSS rule that hides the Parsoid HTML.

Change-Id: I27dc6d5f6ab09b67e28ce88a2e13bf2d1a13e9c0
2023-03-13 14:38:30 -05:00
libraryupgrader b30d10bc60 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 39.0.0 → 41.0.0

npm:
* http-cache-semantics: 4.1.0 → 4.1.1
  * https://github.com/advisories/GHSA-rc47-6667-2j5j
* qs: 6.5.2 → 6.5.3
  * https://github.com/advisories/GHSA-hrpp-h998-j3pp
* ua-parser-js: 0.7.31 → 0.7.34
  * https://github.com/advisories/GHSA-fhg7-m89q-25r3

Change-Id: I1b2d97aa0541af1990fd5d9157dde40156413610
2023-03-11 23:06:17 +00:00
jenkins-bot 6b286ab789 Merge "Update output of diff test" 2023-03-10 16:45:56 +00:00
Translation updater bot 50df0785b9 Localisation updates from https://translatewiki.net.
Change-Id: Iadba4ac67acc5e98780d471ad8f3de052a565826
2023-03-10 08:48:02 +01:00
Translation updater bot b398619d3c Localisation updates from https://translatewiki.net.
Change-Id: Ie2803c8e16f7bd3fc468ce0849045486f399e333
2023-03-09 09:04:13 +01:00
jenkins-bot 1c8d43b175 Merge "Enable integrated testing with Parsoid" 2023-03-08 17:55:28 +00:00
jenkins-bot 664607022e Merge "Add small gap between reference body and re-use warning" 2023-03-08 16:27:53 +00:00
jenkins-bot ba3130a9f7 Merge "ve-cite: Show $originalRefList even if there are no refs in the model" 2023-03-08 16:18:11 +00:00
Ed Sanders bae4a409a5 Update output of diff test
For I93a88abc8e9ecf38992b396c151215781057a6f4.

Change-Id: Ia743b0c37bbd33b95dd4824018ae59fbb6e45c3e
2023-03-08 15:52:02 +00:00
Subramanya Sastry d8da2cbb28 Enable integrated testing with Parsoid
* The failing tests added to known failures are the tests
  known to fail as documented in T307741.

Bug: T307741
Change-Id: I5e5163a4bd093768d1364516ed79fb2d225ee656
2023-03-07 00:22:55 -06:00
thiemowmde c207e343a2 Add test case with conflicting dir="…" values
Just to document the current behavior.

Bug: T202593
Change-Id: I87c4118cd8ca9f860319dc1d3a25f448019339c4
2023-03-01 08:54:56 -06:00
thiemowmde 899775b5ce Remove problematic spaces from a parser test case + Rename a test file
IDEs like my PHPStorm trim spaces from the end of the line. It looks
like they are not relevant for the test and can as well be removed.

Change-Id: I54cb4fdf74dd7174450dcc552b077d388dbac749
2023-03-01 08:54:11 -06:00
jenkins-bot d30256b121 Merge "Update incomplete ReferencesFormatterTest" 2023-02-28 14:07:20 +00:00
Translation updater bot 245ac89794 Localisation updates from https://translatewiki.net.
Change-Id: Ic43c1fcefcb5910b79df4bbded97deb3a2e5158b
2023-02-28 08:28:33 +01:00
thiemowmde b2be6f4ece Update incomplete ReferencesFormatterTest
The mock was incomplete, leaving a feature uncovered.

Change-Id: I657728f89c94602a7aa9b3fbfabc53e7fdac348c
2023-02-27 17:40:56 +01:00
thiemowmde 6f302bf3f0 Replace string|false in CiteParserTagHooks with nullable ?string
This allows us to use strict types in one more place.

Change-Id: Id31a427b61a5eca720ec695fe219809a8e37d208
2023-02-27 15:32:04 +01:00
Translation updater bot 02603baca4 Localisation updates from https://translatewiki.net.
Change-Id: I0b5e779399c9dec3bdca537407e747b4f4cf9790
2023-02-27 08:27:14 +01:00
Translation updater bot 33d72f78f0 Localisation updates from https://translatewiki.net.
Change-Id: I02eb5002c1b152b1f1bf9918f96046783cd43160
2023-02-24 08:59:25 +01:00
thiemowmde fd90304b23 Make auto-generated reference names like name=":0" visible in VE
This is a prerequisite before any work related to T52568 (being able
to manually name references in VisualEditor) can start.

Why these names should not be hidden:
* We don't know if the name is actually part of the auto-generated
  sequence in the current article or copy-pasted from somewhere else.
* Manually given names that start with a colon are currently hidden
  even if they are unrelated to the auto-generated sequence.
* The information is highly relevant for users switching between VE
  and wikitext. Especially when a reference is used multiple times
  the relevant wikitext can be as short as <ref name=":0" />. The
  literally only information in this case is the number.

Since these numbers are still more technical than anything we make
them very dim to emphasize the contrast to non-numeric names.

Bug: T52568
Bug: T92432
Change-Id: I65cb6998cb5f8659cd9043f3d4aaeac1c5f69da8
2023-02-23 12:28:02 +01:00
Translation updater bot 91ebe18ee3 Localisation updates from https://translatewiki.net.
Change-Id: I198e3dfe9cf3dd9b377b33301f69eab406ea99ef
2023-02-23 08:38:32 +01:00
jenkins-bot d1ed02e21d Merge "Fix icon of re-use reference tool" 2023-02-22 17:58:49 +00:00
Ed Sanders 59d900d951 ve-cite: Show $originalRefList even if there are no refs in the model
This original use case at T187495 is for he.wiki, where it is likely
that all the references are defined in templates, so the model
will always be empty, even though $originalRefList is populated.

Change-Id: Ia2785a20bf82ab97466276a57936bc9299e1cabe
2023-02-22 17:19:22 +00:00
Translation updater bot d190578c9c Localisation updates from https://translatewiki.net.
Change-Id: I3e7da01af17e7aa9dca3344cd89277fa67072549
2023-02-20 09:46:06 +01:00
Translation updater bot 3e018e8893 Localisation updates from https://translatewiki.net.
Change-Id: I72da543bcd82e15db49498a70c66332ecb05bc3d
2023-02-16 08:45:58 +01:00
Subramanya Sastry fa1cb6c6cd Parsoid CSS: Remove list-style-type styles added in e5a8b3ec
I copied these from the visualdiffing repo, but I may have
over-generalized these from some wiki that might have customized
this to all wikis. enwiki doesn't use this, for example.

In any case, this styling should be left to individual wikis.
similar to the argument in 8412fb64 where I removed CSS rules
for standard refgroups as overreach.

Change-Id: Ie37408d7a92af88e39e345eb464c6fa2210d57e3
2023-02-13 22:18:45 -06:00
Translation updater bot 88bbaba129 Localisation updates from https://translatewiki.net.
Change-Id: I7f37d8bb63a41c98f845e4c21e06a88223b3649c
2023-02-13 08:29:40 +01:00
Ed Sanders f292da4254 Fix icon of re-use reference tool
Also update documentation in qqq.json with newer icon names.

Change-Id: I3cefe65c78e9438a7d29fbcd436ffad043d500e2
2023-02-11 14:07:01 +00:00