It can happen that an error is reported multiple times for a given
reference. In this case, we only display one.
We still display different errors if a reference contains multiple
different errors. This behaviour is differs from the legacy parser's
(so, in this case, we add the category
cite-tracking-category-cite-diffing-error), but not from the legacy
parser's desired behaviour, as hinted by the various comments and TODO
in this area.
Bug: T380153
Change-Id: I9b3d5cbd086fc72c66a2afbae8f92297681989ce
The type hints added in I3e0df790ff9db2fa630f82408a7254a359fe61ca
were sufficient to allow phan to detect that we were possibly passing
a null value in one instance. The other instance was a false positive.
Follows-Up: I3e0df790ff9db2fa630f82408a7254a359fe61ca
Change-Id: I3bacc2aff3d36719133554a8f70d50a3790b84e4
Tests are disabled until the next Parsoid tag.
The rearranged failure looks like it started in
Ifeb3b216e898bec1c3eb5917262820c5809fda45
Needed-By: I9a2f75ea137a8a10842191ad0ea3e92eab41202c
Change-Id: Ibf8656ab344ed79b3740f3b98e96ff4353375b62
There is only one child, so first/last element child are the same, but
it's a little less confusing to use 'first' here.
Follows-Up: Ifeb3b216e898bec1c3eb5917262820c5809fda45
Depends-On: I753bbbfaf99fb486384b0fa97de71159abb504b3
Change-Id: I65873c117cbd3e1d6efd82797c7b49bf707f5c3a
"cite_references_link_many" message unconditionally includes an id
attribute, even if empty.
Follows-Up: Iec3c919ed1ea51acef9efabe979bd8d0feaf651a
Depends-On: I3c547f5524530e976eb7aa960751265c8383f7b4
Change-Id: I9d3f660788fab9af7bdc8c1fa093a9a7912da2ad
The application logic is not quite ready even if the inspector is
shown. So we should always wait before clicking there.
Change-Id: If81dfb676b6a25c9eba0711e774ae45b3988bca2
This doesn't change behavior yet, it's pure wiring to make the
attribute available to Parsoid logic.
Bug: T378567
Change-Id: I6182b601f6fee66a9c32d5006d0a36150eb47e7f
After this patch, Parsoid-rendered pages will include the same
footnote markers as the legacy parser for custom group markers.
The divergent CSS implementation is left intact, for a soft migration.
Bug: T377454
Change-Id: I576dfff4155fb8c2f91ef0d28a65b319aa5bbb07
This isn't needed until patch I576dfff415, but is split into a
predecessor to keep the test and logic changes obviously separate.
Bug: T377454
Change-Id: Iff4a96be77af53a71a1ebe179f31bcc214182bfe
Intended as workaround to make sure that the temp account notice is
closed before opening Citoid. But does not hurt in any case I guess.
Bug: T378537
Bug: T378417
Bug: T377666
Change-Id: I4c3bf156cbb7306eda924bcebc2fbed3b5864f8a
