Commit graph

3813 commits

Author SHA1 Message Date
thiemowmde c207e343a2 Add test case with conflicting dir="…" values
Just to document the current behavior.

Bug: T202593
Change-Id: I87c4118cd8ca9f860319dc1d3a25f448019339c4
2023-03-01 08:54:56 -06:00
thiemowmde 899775b5ce Remove problematic spaces from a parser test case + Rename a test file
IDEs like my PHPStorm trim spaces from the end of the line. It looks
like they are not relevant for the test and can as well be removed.

Change-Id: I54cb4fdf74dd7174450dcc552b077d388dbac749
2023-03-01 08:54:11 -06:00
jenkins-bot d30256b121 Merge "Update incomplete ReferencesFormatterTest" 2023-02-28 14:07:20 +00:00
Translation updater bot 245ac89794 Localisation updates from https://translatewiki.net.
Change-Id: Ic43c1fcefcb5910b79df4bbded97deb3a2e5158b
2023-02-28 08:28:33 +01:00
thiemowmde b2be6f4ece Update incomplete ReferencesFormatterTest
The mock was incomplete, leaving a feature uncovered.

Change-Id: I657728f89c94602a7aa9b3fbfabc53e7fdac348c
2023-02-27 17:40:56 +01:00
Translation updater bot 02603baca4 Localisation updates from https://translatewiki.net.
Change-Id: I0b5e779399c9dec3bdca537407e747b4f4cf9790
2023-02-27 08:27:14 +01:00
Translation updater bot 33d72f78f0 Localisation updates from https://translatewiki.net.
Change-Id: I02eb5002c1b152b1f1bf9918f96046783cd43160
2023-02-24 08:59:25 +01:00
thiemowmde fd90304b23 Make auto-generated reference names like name=":0" visible in VE
This is a prerequisite before any work related to T52568 (being able
to manually name references in VisualEditor) can start.

Why these names should not be hidden:
* We don't know if the name is actually part of the auto-generated
  sequence in the current article or copy-pasted from somewhere else.
* Manually given names that start with a colon are currently hidden
  even if they are unrelated to the auto-generated sequence.
* The information is highly relevant for users switching between VE
  and wikitext. Especially when a reference is used multiple times
  the relevant wikitext can be as short as <ref name=":0" />. The
  literally only information in this case is the number.

Since these numbers are still more technical than anything we make
them very dim to emphasize the contrast to non-numeric names.

Bug: T52568
Bug: T92432
Change-Id: I65cb6998cb5f8659cd9043f3d4aaeac1c5f69da8
2023-02-23 12:28:02 +01:00
Translation updater bot 91ebe18ee3 Localisation updates from https://translatewiki.net.
Change-Id: I198e3dfe9cf3dd9b377b33301f69eab406ea99ef
2023-02-23 08:38:32 +01:00
jenkins-bot d1ed02e21d Merge "Fix icon of re-use reference tool" 2023-02-22 17:58:49 +00:00
Translation updater bot d190578c9c Localisation updates from https://translatewiki.net.
Change-Id: I3e7da01af17e7aa9dca3344cd89277fa67072549
2023-02-20 09:46:06 +01:00
Translation updater bot 3e018e8893 Localisation updates from https://translatewiki.net.
Change-Id: I72da543bcd82e15db49498a70c66332ecb05bc3d
2023-02-16 08:45:58 +01:00
Subramanya Sastry fa1cb6c6cd Parsoid CSS: Remove list-style-type styles added in e5a8b3ec
I copied these from the visualdiffing repo, but I may have
over-generalized these from some wiki that might have customized
this to all wikis. enwiki doesn't use this, for example.

In any case, this styling should be left to individual wikis.
similar to the argument in 8412fb64 where I removed CSS rules
for standard refgroups as overreach.

Change-Id: Ie37408d7a92af88e39e345eb464c6fa2210d57e3
2023-02-13 22:18:45 -06:00
Translation updater bot 88bbaba129 Localisation updates from https://translatewiki.net.
Change-Id: I7f37d8bb63a41c98f845e4c21e06a88223b3649c
2023-02-13 08:29:40 +01:00
Ed Sanders f292da4254 Fix icon of re-use reference tool
Also update documentation in qqq.json with newer icon names.

Change-Id: I3cefe65c78e9438a7d29fbcd436ffad043d500e2
2023-02-11 14:07:01 +00:00
Arlo Breault 1dd994a28a Re-enable test
Change-Id: I9c909e10170a0437676bdf1290cc6421073a8284
Follow-Up: If9cdabdfac26656272fcf3b4aaae0576aaed1346
Depends-On: If1e55feb86ce8b32f772e3b78bc9d29f122f4d58
2023-02-09 17:30:52 -05:00
Arlo Breault 5fa75277b7 Disable test for CI
Needed-By: If1e55feb86ce8b32f772e3b78bc9d29f122f4d58
Change-Id: If9cdabdfac26656272fcf3b4aaae0576aaed1346
2023-02-09 17:28:08 -05:00
Arlo Breault d5b5a83ae9 Sync up Cite repo with Parsoid
This now aligns with Parsoid commit b520b8092db6f092603e7244cdac5f1fc645e89a

Change-Id: I671c5831d90bbeb088f5ff2133df553142e1af53
2023-02-09 16:58:34 -05:00
Translation updater bot 50d784ada6 Localisation updates from https://translatewiki.net.
Change-Id: I8ef437920037c0ba1db2b4ab28c0b954479ed27f
2023-02-09 10:11:02 +01:00
Subramanya Sastry eee7a43d77 Parsoid CSS: Use more W3C-supported counter types
* This ensures that Safari can also render these counter styles
  since Safari doesn't support @counter-style CSS rules yet.

Change-Id: Ib104a6d22197037bae0c58766d3363176022add3
2023-02-08 13:20:47 -06:00
jenkins-bot 6427249c8b Merge "Parsoid CSS: mw-ref-linkback counter inits to -1, not 0" 2023-02-08 16:19:36 +00:00
jenkins-bot 951a5f4a34 Merge "Parsoid CSS: Remove default rendering for "standard" ref groups" 2023-02-08 16:18:30 +00:00
Translation updater bot 5cd7fa82a0 Localisation updates from https://translatewiki.net.
Change-Id: Idce3d50dfbd235dafede1c6238da70335415e21e
2023-02-08 08:39:25 +01:00
Subramanya Sastry b9400d1bf0 Parsoid CSS: mw-ref-linkback counter inits to -1, not 0
* This has always been a bug but was hidden because enwiki
  uses lower-alpha custom rendering and so we never noticed it
  when we tested this on enwiki.

* Fixing the default gets rid of the need to override this for
  every single language that defined a non-decimal counter.

* This also eliminates the need for some rules where the overrides
  were identical to the baseline definitions (counter-type is
  decimal and separator is '.').

Bug: T86782
Bug: T156350
Change-Id: I51f8a06c80bb897b66a0978b117fbc5560efd6cb
2023-02-07 20:59:23 -06:00
Subramanya Sastry 8412fb6406 Parsoid CSS: Remove default rendering for "standard" ref groups
* This was obviously a mistake for 'decimal' since the previous CSS
  would have rendered refs with the "decimal" group and refs without
  any group identically making it hard to distinguish between the
  two ref types.

* But, not all wikis define custom messages for these "standard"
  ref groups. So, by providing default rendering for these, we would
  need custom overrides for wikis that didn't define them (the vast
  majority). Instead, for wikis that define them, define wiki-specific
  CSS for these groups that can be added to their Common.css pages.

* Discovered as I set about trying to update CSS on wikis and my
  test wikitext with different groups were rendering decimal groups
  differently and I had no custom CSS for it anywhere.

Bug: T86782
Change-Id: I5598580e96eead94bb09574b2af5cef3ce4241c5
2023-02-07 20:45:29 -06:00
Translation updater bot 768d492b61 Localisation updates from https://translatewiki.net.
Change-Id: I351a29e995c922ac2764d6449f66b06139da9e8f
2023-02-03 08:47:23 +01:00
jenkins-bot b85fcb759c Merge "Mark config parameter as optional in context classes" 2023-02-02 17:08:53 +00:00
Translation updater bot 466f5331b1 Localisation updates from https://translatewiki.net.
Change-Id: Ie72e35230204399a3b2668dd2ef86ed5584595e4
2023-01-30 08:29:23 +01:00
Translation updater bot 5258191f6e Localisation updates from https://translatewiki.net.
Change-Id: Ibea8dc3f8f0df6dbdcede368349c876f36d0eacb
2023-01-27 08:35:49 +01:00
Translation updater bot bfd01b97fe Localisation updates from https://translatewiki.net.
Change-Id: I744faafaa4a4824e1ae9ece7cef7e36a341452c9
2023-01-26 08:50:53 +01:00
Bartosz Dziewoński a845923a65 Specify document base URLs in more test cases
Depends-On: I0e301bef38d97fa2234aa901c787360d9fbde8a3
Change-Id: I07a8c097dba0f5572c0aedf4febdf1434063ea6f
2023-01-22 16:00:09 +01:00
Translation updater bot 30d02d99ac Localisation updates from https://translatewiki.net.
Change-Id: Ie79348824713b6e7b14f50f270f7e09143f36375
2023-01-17 08:07:02 +01:00
Peter Wangai ec5f77e840 selenium: Remove webdriverio npm package from the Cite extension
The `webdriverio` package does not need to be an explicit dependency.
It is a dependency of `@wdio/cli`.

Bug: T325059
Change-Id: I16501b07145641d15671e43561e258df2d5a3457
2023-01-11 15:15:29 +03:00
Translation updater bot ff32593b73 Localisation updates from https://translatewiki.net.
Change-Id: I533d5633e9f60f8d13289903bb8a5b2bf4c280c5
2023-01-11 09:01:23 +01:00
Translation updater bot 68ffe543d5 Localisation updates from https://translatewiki.net.
Change-Id: Icf539e9cd3be8578a443240359d10cbf0885efe9
2023-01-10 08:24:16 +01:00
jenkins-bot 0771532b25 Merge "Remove 'origTitle' in tests" 2023-01-09 18:50:12 +00:00
Translation updater bot 8c50157d78 Localisation updates from https://translatewiki.net.
Change-Id: I31fa4326793e8ea398af83fb2c6db03b5a5756cf
2023-01-09 09:25:43 +01:00
Subramanya Sastry d044c0c166 Parsoid CSS counters: Use child selectors instead of descendent selectors
In both cases:
(a) ref counter display for .mw-ref sups
(b) backlink labels in the references section for multiple named refs
the a-tags are direct children of the <sup>/<span> tag.

The child selectors are more precise. I am not really sure why we
went with descendant selectors in the first place.

Bug: T156350
Change-Id: If5be7cd14de40c2372f27ae5e2f32671c0a4e20c
2023-01-09 01:28:34 +00:00
Subramanya Sastry ea4c16c037 Ensure Parsoid's linkback ref CSS counters are properly incremented
* Turned out there were 2 counters defined on references li nodes.
* One was added as part of the extends functionality added by WMDE's
  book referenceing project.
* The other one was added as part of Parsoid's Cite CSS work.
* Since the counter increments were defined separately and applied
  to the same node, only one of the increments would apply.
  This breaks counter rendering on wikis where custom wiki-specific
  rules aren't defined in that wiki's Mediawiki:Common.css
* Discovered after running visual diff tests after ad919e37
  was deployed.

Change-Id: I826faac3564d63b8a4fbd80015fd5cc8f0069b7a
2023-01-07 19:36:55 -06:00
eranroz fef36c2da9 Remove lower-alpha hack
Lower-alpha is enwiki/community specific preference and as such should
be defined in Common.css of that wiki.

Bug: T326467

Change-Id: I1c254031185b130de90fad2410a21533e8c3ba96
Signed-off-by: eranroz <eranroz89@gmail.com>
2023-01-07 12:37:09 +02:00
Translation updater bot bfa8df9e2c Localisation updates from https://translatewiki.net.
Change-Id: I24273ca182f249fd39ac956b09b7bad068066894
2023-01-03 08:20:16 +01:00
Bartek Łukawski 780f9e1439 Highlight markup inside <references> in CodeMirror
See also: 9fd55c5f38
Bug: T294546
Change-Id: I55747e89242f0b53ec1f41c86c3523ad545e8470
2023-01-02 19:21:06 +00:00
Translation updater bot c42c4b88f1 Localisation updates from https://translatewiki.net.
Change-Id: I8d9b60ed936428cc9d79cb0ed5526f1f468ecd36
2022-12-29 10:01:01 +01:00
Translation updater bot b5b311cfee Localisation updates from https://translatewiki.net.
Change-Id: I6ff34e3836537f5f4fe3710bc0f8169629f857e7
2022-12-26 09:09:19 +01:00
Translation updater bot d9b2934262 Localisation updates from https://translatewiki.net.
Change-Id: I5c01f5c81480703ee8f962321685badacb59fd12
2022-12-23 09:05:52 +01:00
Bartosz Dziewoński c0746c7fa8 Remove 'origTitle' in tests
Depends-On: I0ad0a655380eb2fb29b5ac01e2e399ac550ce34a
Bug: T325766
Change-Id: Ib5c33aceb9430aba49c692552b54427e64a787f3
2022-12-22 17:57:41 +00:00
Bartosz Dziewoński b89db98b7a Use more realistic fake data in test cases
Change-Id: Ie5a30fe254bd69db4f8fe363baeb926282897d00
2022-12-22 10:47:15 +00:00
Translation updater bot ccaaec68f0 Localisation updates from https://translatewiki.net.
Change-Id: I8bf6a0f67c44f1e66580fcbd93b58f560b955cad
2022-12-21 09:14:24 +01:00
Translation updater bot 8013badd20 Localisation updates from https://translatewiki.net.
Change-Id: I3e4071ba144218f06ffc988ba0e66cdbf310626b
2022-12-19 09:03:36 +01:00
jenkins-bot 7019e585a3 Merge "Add 'ext.cite.ux-enhancements to mobile pages" 2022-12-15 13:59:35 +00:00