Commit graph

3220 commits

Author SHA1 Message Date
Volker E e5b6ae0323 Reduce reference code padding
Don't use inherited one, but set a small one instead.

Change-Id: Ib38102478ed53a6e4fd8cc25d118f346f81758bb
2020-03-18 07:16:13 +00:00
jenkins-bot 3dc212e730 Merge "Fix cite error ref code color contrast ratio" 2020-03-18 06:46:31 +00:00
libraryupgrader 3df0f16358 build: Updating minimist to 1.2.5
* https://npmjs.com/advisories/1179

Change-Id: Ide732616d562684edab9a71c1998976297b54629
2020-03-18 04:41:02 +00:00
Volker E 774fda06a9 Fix cite error ref code color contrast ratio
Using `background-color: transparent` here to step away from inheritance of whatever `code` would provide theme-independent.

Bug: T247903
Change-Id: Ibeb6b68556b6ad83dacaf1b8fed59a2b971c0221
2020-03-17 21:43:17 +00:00
Translation updater bot 60c5e728ea Localisation updates from https://translatewiki.net.
Change-Id: I55031c78575c34b6edc1123ec24810c497f29a85
2020-03-17 10:23:55 +01:00
Translation updater bot ed873e549b Localisation updates from https://translatewiki.net.
Change-Id: I57e7504a86e8f4b992d2ca3e4d9dace705605090
2020-03-16 14:29:37 +01:00
Translation updater bot a840790cdb Localisation updates from https://translatewiki.net.
Change-Id: Ia6e8512c204d5e0068437f55f30234f195e9a4f2
2020-03-13 08:53:57 +01:00
Translation updater bot c318b8d720 Localisation updates from https://translatewiki.net.
Change-Id: I5d5ff7a30904e75eec4797f48215c0ad64d7bc3d
2020-03-12 08:42:12 +01:00
Timo Tijhof ce27a400e1 CiteHooks: Remove wgResourceModules check (redundant with isModuleRegistered)
The isModuleRegistered() method was introduced a few years ago,
when the load order in ResourceLoader was undergoing a change.

It used to be that hooks like were run first to register modules, and then
wgResourceModules was registered afterwards. This was reversed to disallow
mutating the config at run-time from foreign modules and to allow better
caching and error detection.

It's been several years since then, so this redundant check is no longer
needed. ServiceWiring.php in MW core for ResourceLoader always processes
config and extension.json first before this hook is called.

Bug: T247265
Change-Id: I466f1fa70b8f0e9fe5e8e8df90bb0001b3329b87
2020-03-10 16:18:46 +00:00
libraryupgrader 5f51fec081 build: Updating acorn to 7.1.1
* https://npmjs.com/advisories/1488

Change-Id: Iacb4464bc9c81a45b45ad22fa98bbb05dbd31c6b
2020-03-07 23:06:54 +00:00
jenkins-bot e15743b74d Merge "Fix unit tests for whitespace change in Html5 fragments" 2020-03-06 16:55:25 +00:00
Translation updater bot 11dffd7ca8 Localisation updates from https://translatewiki.net.
Change-Id: Icbd41637a59cacc9ee620401d574c994adc67666
2020-03-06 08:17:36 +01:00
Translation updater bot 7837135165 Localisation updates from https://translatewiki.net.
Change-Id: Ic671cdc23fdb943fcf90fdccfce4e115f18c82e8
2020-03-05 08:37:47 +01:00
Translation updater bot 197c13c801 Localisation updates from https://translatewiki.net.
Change-Id: I95723982546c984c936fae703c01b91f6fc8a9ee
2020-03-03 08:13:55 +01:00
Translation updater bot 157130b75a Localisation updates from https://translatewiki.net.
Change-Id: I75ed92076fad74276c9ed0c176aed183bc7c0a23
2020-03-02 09:09:02 +01:00
Translation updater bot 1fc962e1fa Localisation updates from https://translatewiki.net.
Change-Id: I79fcb110c036c2533e9123b9faad4bea3c60a95d
2020-02-27 08:36:09 +01:00
Translation updater bot 5ce4cc479d Localisation updates from https://translatewiki.net.
Change-Id: Ib73625846daac60c79b184de8354e87116bd7f88
2020-02-26 08:24:28 +01:00
Brian Wolff 5ed973a49a Fix unit tests for whitespace change in Html5 fragments
Bug: T238385
Depends-On: Ie2b7c9429691e2c491c3359d5b400d8f078aa789
Change-Id: Ie2b7c9429691e2c491c3359d5b400d8f078ab111
2020-02-25 13:56:53 +00:00
Brian Wolff 1c6a92ca9b Temp disable test to work around circular dependency in unit test
Html5 fragment mode now bans whitespace per html5 spec

See Ie2b7c9429691e2c491c3359d5b400d8f078aa789

Change-Id: Ie6fa40798f06a358f6082110b4d8cc0028c80321
2020-02-25 04:38:06 -08:00
Translation updater bot a633c9d5dc Localisation updates from https://translatewiki.net.
Change-Id: Ie6fa40798f06a358f6082110b4d8cc0028c807d4
2020-02-25 08:52:07 +01:00
Translation updater bot fd79d68049 Localisation updates from https://translatewiki.net.
Change-Id: Ife3c127de785f3d436f676c4d6f4370b220358a1
2020-02-24 09:02:03 +01:00
libraryupgrader ece1d6a9a6 build: Updating npm dependencies
* grunt-stylelint: 0.13.0 → 0.14.0
* stylelint-config-wikimedia: 0.8.0 → 0.9.0

Change-Id: I2eb91238d8468051d3f62424f3025e6e6324d030
2020-02-20 19:43:20 +00:00
Translation updater bot 5b3640f635 Localisation updates from https://translatewiki.net.
Change-Id: Ie38542a1b29bd9d11bbfb98c08699e27041c1469
2020-02-20 09:26:30 +01:00
Translation updater bot 5684c8823e Localisation updates from https://translatewiki.net.
Change-Id: I59d1cfeae8f911fab2b95af322aedec0d1d66b0d
2020-02-19 08:23:11 +01:00
libraryupgrader 81e6643baf build: Updating composer dependencies
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.1
* mediawiki/minus-x: 0.3.2 → 1.0.0

Change-Id: Ica218e63fd747980b7acc39ac7403f19239fa861
2020-02-19 01:25:06 +00:00
Translation updater bot 247e80d781 Localisation updates from https://translatewiki.net.
Change-Id: I5c9efab6cce150f6c58f2dc8dc9fba39c2f0cf7e
2020-02-17 08:45:44 +01:00
Translation updater bot e1423ecaf4 Localisation updates from https://translatewiki.net.
Change-Id: I6e0628876b7b6bc397924d4e9b1b62d7c8516f03
2020-02-14 08:25:22 +01:00
Translation updater bot ac2edf5f57 Localisation updates from https://translatewiki.net.
Change-Id: I125e052175b48a2cb2a44865a682b6cb88a6d676
2020-02-13 08:54:21 +01:00
jenkins-bot 7ee2e81ade Merge "Add two extreme follow edge cases back to parser tests" 2020-02-11 09:11:20 +00:00
Translation updater bot cb30637732 Localisation updates from https://translatewiki.net.
Change-Id: Ia93d4b3cf054b9c24a8b9eadd954c624354104dd
2020-02-11 08:18:57 +01:00
jenkins-bot 43cf5ac7bd Merge "Don't talk about follow being "broken" but "incomplete"" 2020-02-10 12:41:50 +00:00
Translation updater bot efaba3aef0 Localisation updates from https://translatewiki.net.
Change-Id: Ia7bafb7deb9353cdd95e598d924ef4e08e517116
2020-02-10 08:32:57 +01:00
Translation updater bot 36285bb9f7 Localisation updates from https://translatewiki.net.
Change-Id: Ifaebba26a97fb0737d623da5834121a97c9a76dd
2020-02-07 09:57:04 +01:00
Translation updater bot fe43bbbc8a Localisation updates from https://translatewiki.net.
Change-Id: Icb2ddad2fd37bffff96c13e5434016d0fa2913d3
2020-02-06 08:19:00 +01:00
Thiemo Kreuz 400ce89f30 Don't talk about follow being "broken" but "incomplete"
Bug: T240858
Change-Id: Iab6563fdf19d6e85795911e4140476fceabf7334
2020-02-05 16:38:49 +00:00
Thiemo Kreuz 48e2f02e20 Add two extreme follow edge cases back to parser tests
This reverts parts of the revert I3bee35f, which reverted a3d312c8.
I believe it's helpful to keep these test cases just to document how
the code currently behaves. I removed all TODO because we don't know
if and how we want to touch this again.

Bug: T240858
Change-Id: Ib91acfcb7292e5c03ce9cc4d7be782085e10aa27
2020-02-05 15:04:49 +01:00
Adam Wight f2bd6b6dcc Revert "Standardize "follow" validation"
This reverts commit a3d312c8f4.

Bug: T240858
Change-Id: I3bee35f27797a04c41c265f7e598d8383414b67a
2020-02-05 11:42:28 +01:00
Adam Wight b15f1b81a0 Revert "Remove "follow" special case from ReferencesFormatter"
This reverts commit 38122d91cd.

Bug: T240858
Change-Id: I7198d5534acded94bc83962262c4cdfed9782454
2020-02-05 11:42:27 +01:00
Adam Wight eb799af3df Revert "Remove broken "follow" special case from ReferenceStack"
This reverts commit d01cba60fb.

Bug: T240858
Change-Id: I5b528a285ed6a658ceb333b58f0f4a81a64c7f15
2020-02-05 11:42:26 +01:00
Translation updater bot f9dc478a46 Localisation updates from https://translatewiki.net.
Change-Id: I9131c0d08d28ae4ed040bb7709a5a0b87b7c2562
2020-02-05 08:18:41 +01:00
Translation updater bot 7defec4d7a Localisation updates from https://translatewiki.net.
Change-Id: Ibce9dfe736f8b3097b883103dd6a1caa1d752019
2020-02-04 08:33:03 +01:00
jenkins-bot ef65edf6e9 Merge "Update documentation of ReferenceStack::$refs data structure" 2020-02-03 15:11:12 +00:00
jenkins-bot 7c3ace4fef Merge "Rewrite ErrorReporter for performance and separation of concerns" 2020-02-03 14:58:55 +00:00
jenkins-bot 74fab9755f Merge "Remove one unnecessary LogicException from ReferenceStack" 2020-02-03 14:50:40 +00:00
Thiemo Kreuz d80bd3ef97 Rewrite ErrorReporter for performance and separation of concerns
This patch is mostly moving code around without changing the behavior.
Exceptions:

* The ErrorReporter creates a <span> container. This was previously
parsed. The only benefit might be error checking and escaping. Rather
pointless. The code just created this HTML. With this patch, it is not
parsed any more. The unit test reflects this change. The output in
production will not change, as the parser tests show.

* Parsing of the message key (to detect it's type and id) is simplified
a lot, using explode. With this the code can, in theory, support more
types.

Bug: T239572
Change-Id: If2fe5f55db46dfc7e0ce445348608bef00bec64e
2020-02-03 15:23:40 +01:00
Adam Wight d01cba60fb Remove broken "follow" special case from ReferenceStack
This is unreachable now that broken follow refs fail validation.

Bug: T240858
Change-Id: I22adaee9c4eaeb94bee953ae15c642e044b6a54b
2020-02-03 12:27:59 +01:00
Adam Wight 38122d91cd Remove "follow" special case from ReferencesFormatter
This is unreachable, now that broken follow refs fail validation.

Bug: T240858
Change-Id: I77faeaac4bc53632ab8b82bff7e335ee8c99dfa5
2020-02-03 12:27:57 +01:00
Thiemo Kreuz 563225d5f9 Update documentation of ReferenceStack::$refs data structure
Change-Id: Ie6e43b147c8eb7cfb67fecfa045b63f9011fcece
2020-02-03 12:25:03 +01:00
Translation updater bot 402eadfbec Localisation updates from https://translatewiki.net.
Change-Id: I6a0114644b710e58aaa5ddc5d1c4565d86fe728d
2020-02-03 08:26:22 +01:00
jenkins-bot a8d94a19a2 Merge "Standardize "follow" validation" 2020-01-31 12:36:34 +00:00