wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-09-23 18:29:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove "follow" special case from ReferencesFormatter

Browse source 
This is unreachable, now that broken follow refs fail validation.

Bug: T240858
Change-Id: I77faeaac4bc53632ab8b82bff7e335ee8c99dfa5
This commit is contained in:
Adam Wight 2019-12-20 09:24:43 +01:00 committed by Thiemo Kreuz
parent 402eadfbec
commit 38122d91cd
4 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
i18n/en.json
View file

@ -45,7 +45,6 @@
"cite_references_link_prefix": "cite_note-",
"cite_references_link_suffix": "",
"cite_reference_link": "<sup id=\"$1\" class=\"reference\">[[#$2|&#91;$3&#93;]]</sup>",
"cite_references_no_link": "<p id=\"$1\">$2</p>",
"cite_references_link_one": "<li id=\"$1\"$4><span class=\"mw-cite-backlink\">[[#$2|↑]]</span> $3</li>",
"cite_references_link_many": "<li id=\"$1\"$4><span class=\"mw-cite-backlink\">↑ $2</span> $3</li>",
"cite_references_link_many_format": "<sup>[[#$1|$2]]</sup>",

1
i18n/qqq.json
View file

@ -46,7 +46,6 @@
"cite_references_link_prefix": "{{optional}}",
"cite_references_link_suffix": "{{ignored}}",
"cite_reference_link": "{{optional}}\n\nParameters:\n* $1 - ref key\n* $2 - references key\n* $3 - link label",
"cite_references_no_link": "{{notranslate}}\n\nParameters:\n* $1 - references key\n* $2 - reference text",
"cite_references_link_one": "{{optional}}\n\nParameters:\n* $1 - references key\n* $2 - ref key\n* $3 - reference text\n* $4 - optional CSS class for direction",
"cite_references_link_many": "{{optional}}\n\nParameters:\n* $1 - references key\n* $2 - list of links\n* $3 - reference text\n* $4 - optional CSS class for direction",
"cite_references_link_many_format": "{{optional}}\n\nParameters:\n* $1 - reference key\n* $2 - canonical numeric backlink label for the link, always in the form \"1.2\"\n* $3 - optional alternate backlink label as defined via [[MediaWiki:cite_references_link_many_format_backlink_labels]]",

10
src/ReferencesFormatter.php
View file

@ -173,16 +173,6 @@ class ReferencesFormatter {
$extraAttributes = Html::expandAttributes( [ 'class' => 'mw-cite-dir-' . $dir ] );
}
// Fallback for a broken, and therefore unprocessed follow="…". Note this returns a <p>, not
// an <li> as expected!
if ( isset( $val['follow'] ) ) {
return $this->messageLocalizer->msg(
'cite_references_no_link',
$this->anchorFormatter->getReferencesKey( $val['follow'] ),
$text
)->plain();
}
// This counts the number of reuses. 0 means the reference appears only 1 time.
if ( isset( $val['count'] ) && $val['count'] < 1 ) {
// Anonymous, auto-numbered references can't be reused and get marked with a -1.

8
tests/phpunit/unit/ReferencesFormatterTest.php
View file

@ -257,14 +257,6 @@ class ReferencesFormatterTest extends \MediaWikiUnitTestCase {
'(cite_references_link_many|||<span class="reference-text">t</span>' .
"\n" . '| class="mw-cite-dir-rtl")'
],
'Broken follow' => [
1,
[
'follow' => 'f',
'text' => 't',
],
'(cite_references_no_link||<span class="reference-text">t</span>' . "\n)"
],
'Count zero' => [
1,
[