Commit graph

5265 commits

Author SHA1 Message Date
Translation updater bot a67fc07c5f Localisation updates from https://translatewiki.net.
Change-Id: I49867e15e95203760ae57650b3d59c7ff26ab176
2020-12-15 08:35:22 +01:00
jenkins-bot 3350aacbdf Merge "Move ext.cite.ux-enhancements to extension.json" 2020-12-14 16:39:50 +00:00
jenkins-bot b0d9a03993 Merge "Show reason and/or date in CitationNeededContextItem" 2020-12-14 16:39:48 +00:00
Ed Sanders 6e3eedd40a Show reason and/or date in CitationNeededContextItem
Bug: T270107
Depends-On: I7fdd4810118e72b9719b840fa5e0887006a74a25
Change-Id: I873fb28f5e8fbac469f0fe050818c58dc782fea9
2020-12-14 08:06:02 -08:00
jenkins-bot ccb0627fb5 Merge "Unconditionally register the VisualEditor integration statically" 2020-12-14 15:17:25 +00:00
jenkins-bot 453097c021 Merge "ve-cite: Add dependency on ext.visualEditor.mwtransclusion" 2020-12-14 15:09:58 +00:00
Ed Sanders 35b704dc2f Move ext.cite.ux-enhancements to extension.json
Change-Id: Ia6a0c34800b018e76b9e246898ddfb991f238d55
2020-12-14 10:38:32 +00:00
Translation updater bot e7f86f69ce Localisation updates from https://translatewiki.net.
Change-Id: I07c9c27bae4b7d17620589e45bb430cc76b98eac
2020-12-14 08:41:08 +01:00
Ed Sanders 10c525b5b7 Unconditionally register the VisualEditor integration statically
This is how we handle this in othe repos; CI ensures that VisualEditor
is indeed loaded alongside the Cite extension whenever it's required,
and this significantly reduces the complexity of the code in the repo
and the processing time needed from Cite's hooks on every PHP init.

I'm leaving the "ux-enhancements" module for now, as you can't mix
static (late) module registration with dynamic (immediate) code.

Change-Id: I974654d00687b0dea6aed342d8fa9dcb6ef90768
2020-12-13 22:11:27 +00:00
Ed Sanders 10f7f716f0 ve-cite: Add dependency on ext.visualEditor.mwtransclusion
ReferencesListNode needs to be registered after
MWTransclusionNode so that it has a higher specificity
when matching.

Change-Id: I93610fac2ec9715a14b34efb76abc55d2d2c6900
2020-12-13 22:10:44 +00:00
libraryupgrader 8bda698bb3 build: Updating ini to 1.3.8
* https://npmjs.com/advisories/1589

Change-Id: I5ecf217b5dcf8e82dad88ab2d318d49f3e82a65b
2020-12-12 22:07:53 +00:00
Translation updater bot 8e22ee549e Localisation updates from https://translatewiki.net.
Change-Id: Ic8baa6c98d73cf54505d73bd3275d22650ce4146
2020-12-11 08:34:52 +01:00
Subramanya Sastry 07bcfd9add Purge Sanitizer proxying from ParsoidExtensionAPI
Sanitizer is heavily used by extensions and we decided to let
extensions directly access it.

So, stop proxying those methods from ParsoidExtensionAPI.

Change-Id: I5ff285bf33733878135e2091d53ae12f7340c8fc
2020-12-10 16:54:30 +00:00
sbailey e0322afd84 Parsoid Cite add class mw-ref-follow for refs with follow
* Addresses a FIXME (T263052) where Parsoid Cite injects
   style = "display: none;" in refs with follow instead of
   having css do that triggered by having a class "mw-ref-follow"
   as part of the refs html.

Bug: T263052
Depends-On: I351516b81566aba0adb4d298e39806dfb4fc7b03
Change-Id: I8bfc4ee3df162e2040e3c6f0c37fbf2a7c30d7f6
2020-12-10 16:54:25 +00:00
Translation updater bot ca1628d5e3 Localisation updates from https://translatewiki.net.
Change-Id: Iaaf9d440ba8c219489c0d6efb712bf776fa6edd4
2020-12-10 08:34:15 +01:00
libraryupgrader ef30aa0a92 build: Updating mediawiki/mediawiki-phan-config to 0.10.5
Change-Id: Ib7125b5f8029507dc6d3154fa80a670600308404
2020-12-10 03:39:44 +00:00
Arlo Breault 8d4543954f Cast references attributes to strings
Follow up to 01cf61a

Numeric array keys are returned as integers.

echo "<references 2/>" | php bin/parse.php

Bug: T269748
Change-Id: I892753c330f95d258e0310626f109386fd020177
2020-12-09 16:05:12 +00:00
Translation updater bot d0bf84be0c Localisation updates from https://translatewiki.net.
Change-Id: I484d78ceef164292edb659f69a64ba490b277d45
2020-12-09 08:41:28 +01:00
Translation updater bot 950c62fa02 Localisation updates from https://translatewiki.net.
Change-Id: I0af718d42e568a1f87b15a37357fc717e0d4b4bc
2020-12-08 08:20:46 +01:00
Translation updater bot 74344a461b Localisation updates from https://translatewiki.net.
Change-Id: Id1dcd835bff0a50917ec301ceade5d6fd9192e1e
2020-12-07 08:43:37 +01:00
libraryupgrader e1a3aa67de build: Updating mediawiki/mediawiki-codesniffer to 34.0.0
Change-Id: Ifc33e23b11dc59bde9cfb909f2291b2e6fbfd202
2020-12-06 03:37:29 +00:00
sbailey 8f42623520 Add a definition for .mw-ref-follow to Parsoid's stylesheet
This lets us remove the inlined style on follow refs.

It will be used in I8bfc4ee3df162e2040e3c6f0c37fbf2a7c30d7f6

Bug: T263052
Change-Id: I351516b81566aba0adb4d298e39806dfb4fc7b03
2020-12-03 22:50:57 +00:00
Arlo Breault 3c15454851 Refine adding module(style)?s in extapi
Bug: T269022
Change-Id: Ic2c56c554934ced2aea04317d988098ca840076f
2020-11-30 17:15:27 -05:00
Translation updater bot e7524ce17b Localisation updates from https://translatewiki.net.
Change-Id: I3192d870e725bbdf0e08014078afa9e1d97c3e6b
2020-11-30 08:46:02 +01:00
Arlo Breault 6525d69200 Reconcile some ref errors cases with $hasFollow
Change-Id: I5e3a27366f177af6c221d57da6e31f28cc91bb0c
2020-11-25 13:51:37 -05:00
sbailey de5d806335 Cite error tag name defined in references not used before
Bug: T51538
Change-Id: Id89b3cc186de42e5e5c05f15d7546db9d64ec864
2020-11-25 13:50:25 -05:00
sbailey 703dc8dc05 Adding cite error ref in reference with mismatched group
Bug: T51538
Change-Id: I5492dbaebb7bca79e83be09fdcfe810eaef8c053
2020-11-24 17:22:56 +00:00
Arlo Breault 680df4379c Use inReferencesContent flag to get rid of processRefsInReferences
It's sufficient to handle this case in processRefs.

Also moves $referencesGroup to the ReferencesData instance, rather than
passing it around as a variable (inconsistently).

Change-Id: I8637e3ce644642259e353d0df3d9c0dbc3102c7b
2020-11-24 17:22:01 +00:00
Arlo Breault b88f9ca881 Fix porting bug from 005176a
Bug: T249742
Change-Id: Iabe86266c06b2cbc3c51b16b73d360a7182878f1
2020-11-24 10:54:23 -05:00
Translation updater bot bcdaadea83 Localisation updates from https://translatewiki.net.
Change-Id: I2510bbb6db4815214f2a5adf38b8f8be4867b59c
2020-11-24 08:39:01 +01:00
sbailey 4c7108f553 Adding cite error ref in reference no content defined
Bug: T51538
Change-Id: I4cdcf1a36f472f582812dbb5e7050c0ead614639
2020-11-23 18:32:26 -05:00
sbailey 1f0221e327 Add reporting of cite error of a ref in reference without name specified
Bug: 51538
Change-Id: I193d5583b31be32741088fb25c348878f34b5016
2020-11-23 23:30:14 +00:00
Arlo Breault e3ca32c9ff Add method to check if in references content
More specific than just embedded content, needed for adding errors in
follow up patches.

Change-Id: I4bf659cd208c3322870e3ea0126bda4a2a7037d8
2020-11-23 18:53:03 +00:00
Translation updater bot 301214aab5 Localisation updates from https://translatewiki.net.
Change-Id: I373d403c5930aae37741cd2d02c0716de3f90f95
2020-11-23 08:38:35 +01:00
libraryupgrader 0c615fc36f build: Updating npm dependencies
* grunt-stylelint: 0.15.0 → 0.16.0
* stylelint-config-wikimedia: 0.10.1 → 0.10.3

Change-Id: I0d9879effbe670cd83dca5fac9722dafaeff7b48
2020-11-21 21:53:19 +00:00
libraryupgrader 5f3d03ba3b build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Change-Id: I756a44578fe43a6a6c2e08fb0416b9ec3977f825
2020-11-20 01:19:07 +00:00
Arlo Breault b664b64fcb Use $extApi->pushError for invalid references parameters
Follow up to 01cf61a

Change-Id: Ic4483f151d12352cc9e6f6094e4df442eabca376
2020-11-16 22:19:54 +00:00
Translation updater bot 74eddfff9c Localisation updates from https://translatewiki.net.
Change-Id: Ifce667ef7462afbe482cbbf6efb2c38d3dc4e2e2
2020-11-16 08:36:32 +01:00
Translation updater bot ef29758429 Localisation updates from https://translatewiki.net.
Change-Id: Iba7b247d31baa47de5c7bb1a1e02fa88cd420db9
2020-11-13 08:29:56 +01:00
Arlo Breault 2f1bbc1804 Only look for data-mw.body.id in the top level dom
Follow up to 6c15f6e where the same approach was taken in dom diff'ing.

Clarifies where the "id" is expected to point and the limitations of the
approach vis-a-vis embedded content.

For example,

<ref>hi ho</ref>
[[File:Test.png|<references />]]

won't roundtrip, and never did, because the references section the "id"
would point to is in embedded content.

This was really only ever about the case where the <ref> itself was
found in embedded content, like an image caption, and we wanted to find
a top level references section, like,

[[File:Test.png|<ref>hi ho</ref>]]
<references />

The one case old approach was ostensibly doing something smarter was if
both the references section and the ref were in the same embedded
content, as in,

[[File:Test.png|<ref>hi ho</ref><references />]]

However, at least for file captions, those were always serialized in a
fragment of the top level doc and suffer from same dropping as the first
example here.  Maybe some other embedded content is handled differently,
in which case this is probably an acceptable regression.

Change-Id: Ia90eadcc5099a8c27f0bf3fda0ce2f0effca7bcc
2020-11-10 21:56:16 +00:00
jenkins-bot 586b9e65f7 Merge "Add "reference" class to references in VisualEditor" 2020-11-10 21:05:32 +00:00
sbailey 01cf61ad67 Adding check for illegal attributes in references tag
Bug: T51538
Change-Id: I7dbc577a61abb660d2bdb66ead0d7b71fd66cf47
2020-11-10 19:47:04 +00:00
Translation updater bot df0c1bd889 Localisation updates from https://translatewiki.net.
Change-Id: I9388c85127ad9824fcc6197d99824da9db6a6e3e
2020-11-09 08:34:17 +01:00
Arlo Breault 4310b6a243 Mark up cite errors in embedded content
It's a feature of named refs that we only know at the time of inserting
the references list whether they have content or not, and are therefore
in err.  The strategy of 4438a72 was to keep pointers to all named ref
nodes so that if an error does occur, we can mark them up.

The problem with embedded content is that, at the time when we find out
about the errors, it's been serialized and stored, and so any pointers
we might have kept around are no longer live or relevant.  We need to go
back and process all that embedded content again to find where the refs
with errors are hiding.

This patch slightly optimizes that by keeping a map of all the errors
for refs in embedded content so that only one pass is necessary, rather
than for each references list.  Also note that, in the common case, this
pass won't run since we won't have any errors in embedded content.

Bug: T266356
Change-Id: I32e7bfa796cd4382c43b3b1d17b925dc97ce9f7f
2020-11-06 18:31:26 -05:00
Arlo Breault b2e2732674 Switch some uses of matchTypeOf to hasTypeOf in Cite
Change-Id: I99986c337944547ae398851676de13377f4114b1
2020-11-06 13:14:04 -05:00
Arlo Breault c675396445 Fix adding 'cite_error_group_refs_without_references' to unnamed refs
Follow up to 02fb17d, which was only iterating over named refs.

Bug: T51538
Change-Id: I1a1ce39029c2e9e6e29e768675bcde266ccf3247
2020-11-06 13:14:03 -05:00
Bartosz Dziewoński 72f79aae3b Add "reference" class to references in VisualEditor
* Add it to CE HTML, for compatibility with site styles.
* Add it to DM HTML of newly created references only. Existing
  references just use whatever classes we got from Parsoid, to avoid
  unnecessary DOM changes and dirty diffs.

Bug: T265930
Depends-On: I61a2132f3876e2d9567d985358f51eb51c479813
Change-Id: I9d6856f03071c09617b8ae7db938135a3e30fe8e
2020-11-06 18:04:13 +00:00
Arlo Breault 049735ba0e Clean up signatures of ref group accessors
No need to hedge on null.

Change-Id: I2afb7619a113d784741bd7d29eccf4d8368fe56f
2020-11-06 17:45:18 +00:00
Arlo Breault 0254f138ab Suppress linkbacks for all refs in embedded content
Not just for refs in references content, since they'll be equally
inaccessible everywhere.

Change-Id: Id0a2361b41d9b8103e011ff4f809fa0809169bb3
2020-11-06 17:45:16 +00:00
sbailey 095b2c2388 Add "reference" class to <sup> in addition to the "mw-ref" class
* Added, required adjusting many tests and knownFailures info.

 * Change impacted parserTests.txt as well, updated.

Bug: T265930
Change-Id: I79d915ebd811bdb83344bf7295862588fe7d46ea
2020-11-05 00:17:54 +00:00