wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cite error tag name defined in references not used before

Browse source 
Bug: T51538
Change-Id: Id89b3cc186de42e5e5c05f15d7546db9d64ec864
This commit is contained in:
sbailey 2020-11-24 12:22:25 -08:00 committed by Arlo Breault
parent 703dc8dc05
commit de5d806335
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/Parsoid/References.php
View file

@ -177,8 +177,16 @@ class References extends ExtensionTagHandler {
$validFollow = false;
if ( !$hasRefName && $refsData->inReferencesContent() ) {
$errs[] = [ 'key' => 'cite_error_references_no_key' ];
// FIXME: Reconcile this with `$hasFollow`
if ( $refsData->inReferencesContent() ) {
if ( $hasRefName ) {
$group = $refsData->getRefGroup( $groupName );
if ( !isset( $group->indexByName[$refName] ) ) {
$errs[] = [ 'key' => 'cite_error_references_missing_key' ];
}
} else {
$errs[] = [ 'key' => 'cite_error_references_no_key' ];
}
}
if ( $hasFollow ) {
@ -213,6 +221,11 @@ class References extends ExtensionTagHandler {
// This will be set below with `$ref->contentId = $contentId;`
}
} else {
// FIXME: This key isn't exactly appropriate since this
// is more general than just being in a <references>
// section and it's the $followName we care about, but the
// extension to the legacy parser doesn't have an
// equivalent key and just outputs something wacky.
$errs[] = [ 'key' => 'cite_error_references_missing_key' ];
}
}