Commit graph

3566 commits

Author SHA1 Message Date
Thiemo Kreuz 7b30a165e4 Use correct Sanitizer method for id/fragment escaping
Note how only the HTML5 mode behavior changes, but nothing in
legacy mode.

Also note this does not 100% fix the issue. The esample with a
non-breaking space is still broken. But it's already much better
than before.

Bug: T298278
Change-Id: Idf50dad4219ff4c594a0cc15f63cb10fdac5ffb7
2022-01-03 16:23:45 +01:00
Thiemo Kreuz 83041449a7 Add parser & unit test cases for different $wgFragmentMode's
This is only to document the current status quo and make later patches
smaller and easier to review.

Bug: T298278
Change-Id: I6c78f4d3ee32de596f2b5ee081d56eaffb1cc7bd
2022-01-03 14:14:47 +01:00
Translation updater bot 7e064c34ed Localisation updates from https://translatewiki.net.
Change-Id: I090f340ce0df54f758338bcc85ad0d8524cbd5e6
2022-01-03 08:10:55 +01:00
Translation updater bot d050c6f48c Localisation updates from https://translatewiki.net.
Change-Id: I69e36c43f9efde457f3b419af36671c3f6b408f3
2021-12-31 09:41:58 +01:00
Translation updater bot c9a5442ee4 Localisation updates from https://translatewiki.net.
Change-Id: I1bd8c35a6a24c28b1c002e60eb495d04ce78c09b
2021-12-27 09:29:44 +01:00
Translation updater bot ee3f10c59d Localisation updates from https://translatewiki.net.
Change-Id: I1605066c0f84cda40fba124cf2c7f7d228aef5ca
2021-12-24 09:09:27 +01:00
Translation updater bot e6180d68fa Localisation updates from https://translatewiki.net.
Change-Id: I2b907c6460ac77b19566e7261897983ded694080
2021-12-23 08:37:48 +01:00
Ed Sanders 84489c15b3 Don't attach DOM nodes from the DM store to the main document
Bug: T298147
Change-Id: I194ff1d576547dc717c523a490083fbcf903d87c
2021-12-21 20:32:05 +00:00
Translation updater bot 378f031a00 Localisation updates from https://translatewiki.net.
Change-Id: Id8df69cf761472ac5807c16a5aead70a0e76dcee
2021-12-20 08:20:51 +01:00
Translation updater bot 32f7e6dbd6 Localisation updates from https://translatewiki.net.
Change-Id: I0579d423942ddbed2296cb72656a7b31a2e9b531
2021-12-17 08:16:52 +01:00
Translation updater bot 01df31ecef Localisation updates from https://translatewiki.net.
Change-Id: I640a4c2fc55d66789319918b3ed9c93b93623637
2021-12-14 08:42:30 +01:00
Translation updater bot 6bd726d2eb Localisation updates from https://translatewiki.net.
Change-Id: I0ce6f5fb816cc0802819a1695df30e661e5278a7
2021-12-13 08:21:12 +01:00
Translation updater bot ef7eefd089 Localisation updates from https://translatewiki.net.
Change-Id: Ib5d5b0ff458ecd6110a224821164f570c78abbc1
2021-12-10 09:19:16 +01:00
Translation updater bot b28834ebbd Localisation updates from https://translatewiki.net.
Change-Id: I6c138aab2d247c3a7dce5b1d5b3964dd9c12e524
2021-12-10 08:23:34 +01:00
Bartosz Dziewoński 90fb1eba04 ve.ui.MWReferencesListDialog: Fix exception caused by a copy-paste mistake
Follow-up to cf95dbd4be.

Bug: T297418
Change-Id: I7c3970cf5a9b3632438e96513e9e983a5527aa21
2021-12-09 20:53:50 +01:00
Timo Tijhof bee357337c ve-cite: Export citationTools as native object instead of JSON string message
* Remove the overhead of serializing and then re-parsing client-side,
  instead assign it directly as native object literal.

* Move code for array slicing to PHP.

Change-Id: Iedcc8d57d3bddd3fa32a78b4e7ecc25615d94277
2021-12-07 12:53:24 +00:00
Timo Tijhof 471e73a7db ve-cite: Remove redundant check for visualeditor-cite-tool-definition.json
The server always defines this message as `cite-tool-definition.json`
in CiteVisualEditorModule.php, including a transparent fallback that
defines it with the content of `visualeditor-cite-tool-definition.json`.

Change-Id: I27426ed1947c1665e5284e64ec1946b1abeff7d1
2021-12-07 12:53:13 +00:00
Translation updater bot db02766664 Localisation updates from https://translatewiki.net.
Change-Id: I877a7076611026b88529810919f35c888888f43e
2021-12-06 08:18:45 +01:00
Translation updater bot 58772cb7f2 Localisation updates from https://translatewiki.net.
Change-Id: I0bf67b6f987f3994d5fa3316792dbe25d6656381
2021-12-02 08:41:07 +01:00
Translation updater bot ae9e5bd470 Localisation updates from https://translatewiki.net.
Change-Id: Id67e11201f2a16f244cfa084816b3687465ca0ed
2021-12-01 08:14:23 +01:00
jenkins-bot a55f2b97cc Merge "ve-cite: Use proper method for comparing linear data (attempt 2)" 2021-11-30 22:22:35 +00:00
jenkins-bot 345766683c Merge "ve-cite: Add test for simple case of re-used reference" 2021-11-30 21:59:59 +00:00
jenkins-bot ca53985924 Merge "ve-cite: Update CSS classes in tests" 2021-11-30 21:59:57 +00:00
Translation updater bot fbeae29418 Localisation updates from https://translatewiki.net.
Change-Id: Ia2ee9707b2c23169b94081c388ca710c4afd87a8
2021-11-30 08:21:11 +01:00
Translation updater bot b8e80d9c11 Localisation updates from https://translatewiki.net.
Change-Id: Ie3e73467398dd5b684cbb006727cfbe316b70922
2021-11-29 08:11:20 +01:00
jenkins-bot 3dd36dd5a0 Merge "Localisation updates from https://translatewiki.net." 2021-11-25 08:05:31 +00:00
Translation updater bot 03138ffc2d Localisation updates from https://translatewiki.net.
Change-Id: I32e7420f96fcf417acc32a4dff02270034c282fb
2021-11-25 09:01:52 +01:00
Translation updater bot 2594ab60f8 Localisation updates from https://translatewiki.net.
Change-Id: I18ecafb1930e6abcd1f269d0ce6475c970cfb8ca
2021-11-25 08:24:01 +01:00
jenkins-bot 962f84728c Merge "Combine ext.cite.visualEditor.data into ext.cite.visualEditor" 2021-11-23 03:41:01 +00:00
Timo Tijhof fb2c7c37db Combine ext.cite.visualEditor.data into ext.cite.visualEditor
Rather than depending on a separate module with one line of generated
JS code, generate it as a prepended statement to the same module.

Should be a no-op.

Depends-On: I809951d34feb2dbd01b7ae0f4bd98dac7c3f6fe2
Change-Id: I5886bf9f82025048976b7750e8cb751681021fb4
2021-11-19 16:56:51 +00:00
Ed Sanders 1a2ae0682f ve-cite: Use proper method for comparing linear data (attempt 2)
In Ifb0ba3caf8d we removed this reference equality check and replaced
it with a deep object comparison, however due to the fact that
hashes for MWReferenceNodes were simplified in I8c26686d7b to
improve visual diffs, this resulted in a overly simplified comparison
that couldn't distinguish references with the same "name".

Instead do a deep object comparions of the standard node hash object.

Tests added in Ia0bbd40528 assert that this doesn't result in the
regression that caused T296044.

Bug: T296086
Change-Id: I7b37fb54e14bfe28a07f722a2c45fd4e4a2d44f2
2021-11-19 14:24:42 +00:00
Ed Sanders e539a60fb9 ve-cite: Add test for simple case of re-used reference
In our first case we have a reference re-used before it
is defined, but that doesn't trigger the bug that caused
T296044.

Change-Id: Ia0bbd40528228275f0a978a0a459388a04ea2e79
2021-11-19 13:51:21 +00:00
Ed Sanders 638dbbff60 ve-cite: Update CSS classes in tests
Change-Id: I4546a71d541e1d22a4c34e6d0f5173a993792ff9
2021-11-19 13:51:21 +00:00
jenkins-bot ea7f9bf0d3 Merge "Revert "Use proper method for comparing linear data"" 2021-11-19 00:59:20 +00:00
Bartosz Dziewoński 4fcc4bc42d Revert "Use proper method for comparing linear data"
This reverts commit bad697bd32.

Bug: T296044
Change-Id: Ie442e482aa3b60754fe457d835c4cf6400f42d94
2021-11-19 00:35:28 +00:00
Translation updater bot d4c853e0f0 Localisation updates from https://translatewiki.net.
Change-Id: I5bd94ff0d6f6e71046889e3537a6199d1451df0b
2021-11-18 08:41:50 +01:00
Ed Sanders c8b691b8d1 Follow-up cf95dbd: Fix incorrect scope in loop
Change-Id: Iae5ec0321e19bfa1c5f53326bf9d9a3082d96f77
2021-11-15 14:39:15 +00:00
Translation updater bot 021e456751 Localisation updates from https://translatewiki.net.
Change-Id: Ife5dc45d0f4935586ce37027758a887ee8f1c626
2021-11-15 08:11:20 +01:00
Timo Tijhof 635850aae8 build: Remove unused npm package fields
The name/version/desc keys are not used and usually not set when the
repo package is marked "private", as the case for repos where npm is
only used for development purposes.

Change-Id: Idf796dfa5cc269109c7be397764850ee4ffe04e6
2021-11-10 20:28:30 +00:00
jenkins-bot 0a8a7d41d4 Merge "build: Update eslint-config-wikimedia to 0.21.0" 2021-11-09 18:18:09 +00:00
jenkins-bot cc111ca5fd Merge "Move eslint client config to modules, fix warnings" 2021-11-09 18:14:37 +00:00
jenkins-bot a11cf9858c Merge "Move var declarations inline" 2021-11-09 18:14:35 +00:00
Ed Sanders cb60e7aa04 build: Update eslint-config-wikimedia to 0.21.0
Change-Id: I86a44d7c73a107fb318abeda9e503e99083f48db
2021-11-09 14:25:34 +00:00
jenkins-bot a90c67b6e8 Merge "Use proper method for comparing linear data" 2021-11-09 14:00:01 +00:00
Translation updater bot 06938337e5 Localisation updates from https://translatewiki.net.
Change-Id: I6c12f73274cbc10ed9d2103baffde73b4b66c68c
2021-11-05 08:16:57 +01:00
libraryupgrader 434462a7e5 build: Updating validator to 13.7.0
* https://npmjs.com/advisories/1004784 (CVE-2021-3765)

Change-Id: Idc38efc79e39f019e555aedfab71ea6edf5e3563
2021-11-04 10:17:23 +00:00
Ed Sanders 0d4bb626f1 Move eslint client config to modules, fix warnings
Change-Id: I86857b82fa7d5c47c0056da4ad270fcb2a4d965f
2021-11-03 16:38:31 +00:00
Ed Sanders cf95dbd4be Move var declarations inline
Change-Id: I824a65e72a72e5acf65c54a63299469f7acb649d
2021-11-03 16:38:31 +00:00
Adam Wight 3c02ee38b2 Clean up javascript code smells
These were discovered using SonarCloud.

Change-Id: Ie36fa248e4b395bb97b8969ece6688ec055afb55
2021-11-03 12:28:07 +00:00
Translation updater bot cb957cc565 Localisation updates from https://translatewiki.net.
Change-Id: Ie359d7a24f9bf10835464c75e97cfb33e515a1a7
2021-11-03 08:20:21 +01:00