Commit graph

5172 commits

Author SHA1 Message Date
jenkins-bot b87116d12f Merge "Cite: Move margin in column references" 2021-02-09 13:56:39 +00:00
Steven Rawson fdf17f326f Cite: Move margin in column references
In Vector, Timeless, and Monobook ("desktop"), there is a 0.3em margin applied to <ol>. When in
columns, this causes the first column to be offset from any others vertically. This change moves
the margin from the references <ol> (i.e., sets the list margin-top to 0) to the enclosing div
(sets the div margin-top to 0.3em) when the div has the columns class. This approach is currently
employed by some wikis such as en.wp for their {{reflist}} template.

Minerva doesn't seem to have the relevant top margin.

Bug: T249441
Change-Id: I3eeb3fe9fd690cd8f74df5541b3ef5e10eeed123
2021-02-08 21:56:39 +00:00
jenkins-bot c2c1d8d3f1 Merge "tests: Align setup/teardown function naming with QUnit 2.x" 2021-02-08 19:36:08 +00:00
Translation updater bot d27ff3ecdb Localisation updates from https://translatewiki.net.
Change-Id: Iac3f1056c96ffdea2b3e20b17ab69f1d23894038
2021-02-08 08:39:37 +01:00
James D. Forrester 34199178e1 tests: Align setup/teardown function naming with QUnit 2.x
Bug: T170872
Depends-On: I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7
Change-Id: I992e16fae6fcf4d5e7f2d5109ff16a30b6e73882
2021-02-05 10:58:27 -08:00
Translation updater bot c72df22934 Localisation updates from https://translatewiki.net.
Change-Id: I90889843fe016430ac281dd9d8d6073af165e336
2021-02-05 08:46:40 +01:00
Translation updater bot b079140ec1 Localisation updates from https://translatewiki.net.
Change-Id: I79ceb7c88c922920083bd746d9a4a6918593a021
2021-02-04 08:39:00 +01:00
jenkins-bot f9f81bd93f Merge "MWReferenceNode: Ignore changes to reference list index" 2021-02-03 14:46:31 +00:00
Translation updater bot a01bb16af8 Localisation updates from https://translatewiki.net.
Change-Id: I35b37ef2f434eb0807fce0e8cbec7aa8545caf48
2021-02-03 08:38:45 +01:00
Translation updater bot 88de96c8ff Localisation updates from https://translatewiki.net.
Change-Id: Iddd38f48b3864a03fcbcc4c2508ae52e034f05f9
2021-02-01 08:47:08 +01:00
jenkins-bot 681b1908e6 Merge "build: Updating dependencies" 2021-01-29 17:42:05 +00:00
Translation updater bot 653b0f2cf3 Localisation updates from https://translatewiki.net.
Change-Id: I600c12dcc167e7e1d3e9103d8c024b1d5b54f306
2021-01-29 08:37:16 +01:00
libraryupgrader be7f1b3bd7 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 34.0.0 → 35.0.0
* mediawiki/minus-x: 1.1.0 → 1.1.1

npm:
* eslint-config-wikimedia: 0.17.0 → 0.18.1

Additional changes:
* Added the "composer phan" command to conveniently run phan.

Change-Id: I2e27a8ae5547829501c25402da5b72b390897ca1
2021-01-29 06:21:06 +00:00
Translation updater bot f9d63d51a1 Localisation updates from https://translatewiki.net.
Change-Id: I38eca797cae3e3377bff859eb3f1beff34528909
2021-01-28 08:35:27 +01:00
Translation updater bot fb3e02f921 Localisation updates from https://translatewiki.net.
Change-Id: I25db0fb5456d07e280e9eb2aa43699fea64d0297
2021-01-27 08:33:52 +01:00
Translation updater bot e4759477e0 Localisation updates from https://translatewiki.net.
Change-Id: I896fadc71bf392ff47be4fb2f96b6e56c9fd181c
2021-01-26 08:52:43 +01:00
Translation updater bot 033f5ee078 Localisation updates from https://translatewiki.net.
Change-Id: If6ff09145a44ee8532c7e122a5a671d98d0cdd24
2021-01-25 08:52:59 +01:00
Translation updater bot b2b2c1d0f4 Localisation updates from https://translatewiki.net.
Change-Id: I78ae3744e7f2f806c5d102d37183fabd796c3ff5
2021-01-22 08:30:10 +01:00
Ed Sanders c763fb5cc3 MWReferenceNode: Ignore changes to reference list index
This means that all reference nodes are treated as comparable
in the diff (provided they are in the same group) so will
not show up in the article diff if their index changes.

Changes to the reference list are already handled separately
by the visual diff.

Bug: T170235
Change-Id: I8c26686d7b2fe3bf91af7d4dcab1caf3247dbe47
2021-01-21 14:40:15 +00:00
Translation updater bot d9e86c24a0 Localisation updates from https://translatewiki.net.
Change-Id: I5fdb50078ed43827f5f3d360c56e4deb800452b3
2021-01-21 08:31:16 +01:00
Ed Sanders 349fc3b12c CitationNeededContext: Support encapsulated content
When a canonical 'encapsulate' param is defined, the contents
of this parameter will get inserted into the document before
adding a citation after it, effectively "unwrapping" the template
around it.

Bug: T265907
Depends-On: Ie9e41ad46e4154de7e9807c5216abbadd08365f9
Depends-On: Ia53c0a641b231bb81c25c011624357acf4dc42a3
Change-Id: Icf200465bcc8fe87ba8612dc8fa9f4359a2289a9
2021-01-20 21:25:16 +00:00
Jforrester e3d34e6f9f Merge "ve-cite: Update DiffElement test with fixed output" 2021-01-20 19:32:12 +00:00
Translation updater bot 6d6b3acdb2 Localisation updates from https://translatewiki.net.
Change-Id: Id8bce4f91df3c26f89132633ac32f6fb04d1e60b
2021-01-20 08:26:25 +01:00
Ed Sanders b955439be1 ve-cite: Update DiffElement test with fixed output
Change-Id: I9a73d0e0ee3c8b12e0b5c3202eb5882258539920
2021-01-19 23:27:32 +00:00
Umherirrender e30f055226 Improve function and property documentation
Removed some wrong @param from test function,
the @dataProvider should be a enough here

Change-Id: Ib84ce497fef4d48df7547ebc38515fc377e7de01
2021-01-16 13:44:19 +01:00
Translation updater bot 6aa96067ba Localisation updates from https://translatewiki.net.
Change-Id: I5fdf89e90da37847333305c536ca5fd83ec17288
2021-01-15 08:38:49 +01:00
Translation updater bot 2c4a2c2384 Localisation updates from https://translatewiki.net.
Change-Id: Ib3acb99d1b781b52c6b44edc6cc1c1ab8784cd33
2021-01-14 08:49:40 +01:00
Translation updater bot b103982c03 Localisation updates from https://translatewiki.net.
Change-Id: Ic90d32534adfef9474ffedffdf114394798615d0
2021-01-13 08:35:58 +01:00
Translation updater bot 8df720a8b4 Localisation updates from https://translatewiki.net.
Change-Id: I58852651e8dbaf82d2b5762e6070ffe9724fe523
2021-01-12 08:37:08 +01:00
Arlo Breault e047ff7afc Refactor sanitization in a normalizeKey function
This matches the legacy parser extension.

Change-Id: Iecec58e793e4a7c0ecd3a139773f225484f4be8f
2021-01-12 00:04:43 +00:00
sbailey c3bc1f00b0 Contract multiple underbars in a row in refnames to a single underbar
* Inlcudes test coverage for refnames with single and more than
   one underbar in a row which are maintained as separate keys but
   serialized without the multiple underbars

Bug: T267974
Change-Id: I9c21a6ff761f4b9a22b1185280b5676e2c160208
2021-01-11 23:14:11 +00:00
Subramanya Sastry 6ebe050750 Get rid of rtTestMode
Back in the early days of Parsoid, we introduced rtTestMode so
we can suppress lots of noisy (but harmless) diffs in rt-testing
so we can isolate the harmful diffs that absolutely needed fixing.
This mode was critical to running large scale round-trip testing on
a large test corpus and let us get a lot of confidence in Parsoid's
ability to handle VisualEditors edits.

But, now that Parsoid is established and selective serialization is
also fairly robust, it is time to get rid of this mode altogether.
This mode was adding clutter to the codebase and was potentially confusing
in some cases. We won't lose our ability to identify regressions in
rt-testing since all we care about is semantic diff changes relative
to a baseline. We just end up with a lower-fidelity baseline.

Change-Id: I22a1b3ecf4e0224000f1df6a98cf7ea9bcb4ee4e
2021-01-11 15:39:06 -06:00
Translation updater bot 330670bb2d Localisation updates from https://translatewiki.net.
Change-Id: Iecdffdbe471f32eb5ac1e492e422e30170a57cfc
2021-01-11 08:33:52 +01:00
sbailey 9679519b0a Fix for Parsoid Cite refname whitespace handling
* Refnames such as 'a b' and 'a_b' are now kept seperate like
   in Core Cite. Refnames with unicode whitespace characters
   such as "a\u2028b' are handled as distinct refnames from 'a b'
   and their ID's are sanitized appropriately to have underbars.

Bug: T267974
Change-Id: Ie06d1f2b8614dbdcf8572ed4647ec9093ef006d5
2021-01-08 17:22:44 +00:00
Subramanya Sastry 97f965f9cb Parsoid/JS: Purge majority of code not used by roundtrip-test.js
* Tweaked a few of the remaining js files to enable me to purge more
  files.

* In another pass, we can consolidate most of the utils into a couple
  rt-test helper classes and purge more.

* Verified that bin/roundtrip-test.js runs by using a parsoid/js service
  installed via the deb package.

$ bin/roundtrip-test.js --parsoidURL http://localhost:8142 Hospet --outputContentVersion 2.1.0

* Haven't touched the package.* files

Change-Id: I79657250de3baaa09bda6be2f440ba5363b62eaf
2021-01-08 17:15:04 +00:00
Translation updater bot 5780fe9038 Localisation updates from https://translatewiki.net.
Change-Id: I7131cd444c1a45ed069c3afd947e245b7e77366b
2021-01-08 08:55:23 +01:00
Translation updater bot 27aced60ef Localisation updates from https://translatewiki.net.
Change-Id: I8ef019e0d652bc33f9910cbc3c54fd312c4589ba
2021-01-07 08:31:16 +01:00
Arlo Breault e8d8481f60 More papering over in References.php
This is the same fix as in 5e5e360 for T259676

The root of the issue is described in T260082

Bug: T271357
Bug: T260082
Change-Id: I7ccf0b20f6b0be0f31101a2c4a88010675dc72ba
2021-01-06 18:53:55 -05:00
Translation updater bot ad3e01a300 Localisation updates from https://translatewiki.net.
Change-Id: Id83bbd0ac6a9abd434d367d2042d172b56477904
2021-01-04 08:42:41 +01:00
jenkins-bot 557d3fd90e Merge "Update Cite to use the new HookContainer/HookRunner system" 2020-12-31 01:49:59 +00:00
Translation updater bot e1a4b6f779 Localisation updates from https://translatewiki.net.
Change-Id: I75ef0e3deff8ee0ff3582b812909c70b7692b732
2020-12-29 09:47:21 +01:00
Taavi Väänänen 9293e2d5ca Update Cite to use the new HookContainer/HookRunner system
Bug: T270875
Change-Id: Ieb29603cde24a1c52829c12ae431eca09ba37bf9
2020-12-28 17:55:34 +02:00
Translation updater bot 34aff2e666 Localisation updates from https://translatewiki.net.
Change-Id: I5350bbad5046be58bfbcce2f3f539ade45f57e7c
2020-12-28 10:37:33 +01:00
Translation updater bot f42688074a Localisation updates from https://translatewiki.net.
Change-Id: I432f5dbb18e0e83f23546c1a2bdad523be9819b4
2020-12-23 08:31:55 +01:00
Translation updater bot e3f805432f Localisation updates from https://translatewiki.net.
Change-Id: I850a4e99f55acebee8151d98ed96e6feedd6b7ff
2020-12-22 08:30:19 +01:00
sbailey 394015a38b Add ref/follow name to Cite error cite_error_references_missing_key
Bug: T51538
Change-Id: Id19a4e4c37169ca6eb7aecdce66b1662546ae31a
2020-12-21 18:08:21 -08:00
sbailey 511543e3f1 Add refname parameter to cite_error_empty_references_define error
Bug: T51538
Change-Id: I2850b7f181f44465437bc486bc544c5cd58aa5e3
2020-12-21 13:31:37 -08:00
Translation updater bot db7ccab956 Localisation updates from https://translatewiki.net.
Change-Id: I986b73b067e8b0cad97a3a6bb9b6d7606734a5ad
2020-12-21 08:38:25 +01:00
libraryupgrader e6f7d8c021 build: Updating mediawiki/mediawiki-phan-config to 0.10.6
Change-Id: I2cc37b889bf5503f48caec5291c8cc707ae5265e
2020-12-19 12:04:52 +00:00
sbailey b9b10a3fe0 Add group name to Cite error cite_error_references_group_mismatch
Bug: T51538
Change-Id: Ie6e04edcdf4b9760711ec53021d65970691a3813
2020-12-18 22:16:28 +00:00