wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-09-24 18:58:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Simplify private listToText() implementation"

Browse source
This commit is contained in:
jenkins-bot 2019-10-25 08:32:49 +00:00 committed by Gerrit Code Review
parent 714996d72a 7f99a1bfe1
commit f62736c58c
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
includes/Cite.php
View file

@ -1099,16 +1099,15 @@ class Cite {
* @return string
*/
private function listToText( array $arr ) {
$cnt = count( $arr );
if ( $cnt === 1 ) {
// Enforce always returning a string
return (string)$arr[0];
$lastElement = array_pop( $arr );
if ( $arr === [] ) {
return (string)$lastElement;
}
$sep = wfMessage( 'cite_references_link_many_sep' )->inContentLanguage()->plain();
$and = wfMessage( 'cite_references_link_many_and' )->inContentLanguage()->plain();
$t = array_slice( $arr, 0, $cnt - 1 );
return implode( $sep, $t ) . $and . $arr[$cnt - 1];
return implode( $sep, $arr ) . $and . $lastElement;
}
/**