wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-24 15:04:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify private listToText() implementation

Browse source 
Motivation is to make the code shorter and faster to read, and also
perform better.

Bug: T236260
Change-Id: I9186370a628833c1563eb5fa4f2e062fb27d6ed7
This commit is contained in:
Thiemo Kreuz 2019-10-25 10:17:05 +02:00
parent f743aa058e
commit 7f99a1bfe1
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
includes/Cite.php
View file

@ -1101,16 +1101,15 @@ class Cite {
* @return string
*/
private function listToText( array $arr ) {
$cnt = count( $arr );
if ( $cnt === 1 ) {
// Enforce always returning a string
return (string)$arr[0];
$lastElement = array_pop( $arr );
if ( $arr === [] ) {
return (string)$lastElement;
}
$sep = wfMessage( 'cite_references_link_many_sep' )->inContentLanguage()->plain();
$and = wfMessage( 'cite_references_link_many_and' )->inContentLanguage()->plain();
$t = array_slice( $arr, 0, $cnt - 1 );
return implode( $sep, $t ) . $and . $arr[$cnt - 1];
return implode( $sep, $arr ) . $and . $lastElement;
}
/**