wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-12-18 17:50:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] Parsoid: Extract methods when composing a reference

Browse source 
Just starting point to give that massive method a bit more
structure.

Bug: T382232
Change-Id: I050cc32220b0f0faac2470afa757c23ee06b1b62
This commit is contained in:
WMDE-Fisch 2024-12-05 11:33:59 +01:00 committed by Thiemo Kreuz (WMDE)
parent b43b3546e8
commit bb6ad5721b
1 changed files with 66 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

97
src/Parsoid/References.php
View file

@ -372,38 +372,17 @@ class References extends ExtensionTagHandler {
} }
} }
$class = 'mw-ref reference'; $this->addLinkBackAttributes(
if ( $hasValidFollow ) {
$class .= ' mw-ref-follow';
}
$lastlinkBack = $ref->linkbacks[count( $ref->linkbacks ) - 1] ?? null;
DOMUtils::addAttributes( $linkBackSup, [
'about' => $about,
'class' => $class,
'id' => ( $referencesData->inEmbeddedContent() || $hasValidFollow ) ?
null : ( $ref->name ? $lastlinkBack : $ref->id ),
'rel' => 'dc:references',
'typeof' => DOMCompat::getAttribute( $node, 'typeof' ),
]
);
DOMUtils::removeTypeOf( $linkBackSup, 'mw:DOMFragment/sealed/ref' );
DOMUtils::addTypeOf( $linkBackSup, 'mw:Extension/ref' );
$dataParsoid = new DataParsoid;
if ( isset( $nodeDp->src ) ) {
$dataParsoid->src = $nodeDp->src;
}
if ( isset( $nodeDp->dsr ) ) {
$dataParsoid->dsr = $nodeDp->dsr;
}
if ( isset( $nodeDp->pi ) ) {
$dataParsoid->pi = $nodeDp->pi;
}
DOMDataUtils::setDataParsoid( $linkBackSup, $dataParsoid );
DOMDataUtils::setDataMw(
$linkBackSup, $linkBackSup,
$this->getLinkbackId( $ref, $referencesData, $hasValidFollow ),
DOMCompat::getAttribute( $node, 'typeof' ),
$about,
$hasValidFollow
);
$this->addLinkBackData(
$linkBackSup,
$nodeDp,
$isTemplateWrapper ? $templateDataMw : $refDataMw $isTemplateWrapper ? $templateDataMw : $refDataMw
); );
@ -875,4 +854,60 @@ class References extends ExtensionTagHandler {
return false; return false;
} }
private function addLinkBackData(
Element $linkBackSup,
DataParsoid $nodeDp,
?DataMw $dataMw
): void {
$dataParsoid = new DataParsoid();
if ( isset( $nodeDp->src ) ) {
$dataParsoid->src = $nodeDp->src;
}
if ( isset( $nodeDp->dsr ) ) {
$dataParsoid->dsr = $nodeDp->dsr;
}
if ( isset( $nodeDp->pi ) ) {
$dataParsoid->pi = $nodeDp->pi;
}
DOMDataUtils::setDataParsoid( $linkBackSup, $dataParsoid );
DOMDataUtils::setDataMw( $linkBackSup, $dataMw );
}
private function addLinkBackAttributes(
Element $linkBackSup,
?string $id,
?string $typeof,
?string $about,
bool $hasValidFollow
): void {
$class = 'mw-ref reference';
if ( $hasValidFollow ) {
$class .= ' mw-ref-follow';
}
DOMUtils::addAttributes( $linkBackSup, [
'about' => $about,
'class' => $class,
'id' => $id,
'rel' => 'dc:references',
'typeof' => $typeof,
] );
DOMUtils::removeTypeOf( $linkBackSup, 'mw:DOMFragment/sealed/ref' );
DOMUtils::addTypeOf( $linkBackSup, 'mw:Extension/ref' );
}
private function getLinkbackId(
?RefGroupItem $ref,
ReferencesData $refsData,
bool $hasValidFollow
): ?string {
if ( $refsData->inEmbeddedContent() || $hasValidFollow ) {
return null;
}
$lastLinkBack = $ref->linkbacks[count( $ref->linkbacks ) - 1] ?? null;
return $ref->name ? $lastLinkBack : $ref->id;
}
} }