wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-23 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Page properties should always be strings"

Browse source
This commit is contained in:
jenkins-bot 2022-04-04 22:47:24 +00:00 committed by Gerrit Code Review
parent d075d71c97 e7dd9b5549
commit 896b20bc3d
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Cite.php
View file

@ -299,7 +299,7 @@ class Cite {
// Tag every page where Book Referencing has been used, whether or not the ref tag is valid. // Tag every page where Book Referencing has been used, whether or not the ref tag is valid.
// This code and the page property will be removed once the feature is stable. See T237531. // This code and the page property will be removed once the feature is stable. See T237531.
if ( array_key_exists( self::BOOK_REF_ATTRIBUTE, $argv ) ) { if ( array_key_exists( self::BOOK_REF_ATTRIBUTE, $argv ) ) {
$parser->getOutput()->setPageProperty( self::BOOK_REF_PROPERTY, true ); $parser->getOutput()->setPageProperty( self::BOOK_REF_PROPERTY, '' );
} }
$status = $this->parseArguments( $status = $this->parseArguments(

2
tests/phpunit/unit/CiteUnitTest.php
View file

@ -658,7 +658,7 @@ class CiteUnitTest extends \MediaWikiUnitTestCase {
// This will be our most important assertion. // This will be our most important assertion.
$mockOutput->expects( $this->once() ) $mockOutput->expects( $this->once() )
->method( 'setPageProperty' ) ->method( 'setPageProperty' )
->with( Cite::BOOK_REF_PROPERTY, true ); ->with( Cite::BOOK_REF_PROPERTY, '' );
$mockParser = $this->createMock( Parser::class ); $mockParser = $this->createMock( Parser::class );
$mockParser->method( 'getOutput' )->willReturn( $mockOutput ); $mockParser->method( 'getOutput' )->willReturn( $mockOutput );