wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-13 17:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add extra safe-guard to ve.ui.MWCitationDialogTool

Browse source 
Note this doesn't fully solve T374068. The issue is probably that the
reuse tab shouldn't be visible in the first place. Still I think this
is a useful safe-guard that cannot hurt. We are doing the same in
almost all other places already.

Bug: T374068
Change-Id: I9b91374dbda74af75d8c36e24ffe5b9448da1aa7
This commit is contained in:
thiemowmde 2024-09-05 17:54:50 +02:00
parent 2890772a9f
commit 878a29b727
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve-cite/ve.ui.MWCitationDialogTool.js
View file

@ -49,7 +49,7 @@ ve.ui.MWCitationDialogTool.static.isCompatibleWith = function ( model ) {
// Check if content of the reference node contains only a template with the same name as // Check if content of the reference node contains only a template with the same name as
// this.template // this.template
const internalItem = model.getInternalItem(); const internalItem = model.getInternalItem();
const branches = internalItem.getChildren(); const branches = internalItem ? internalItem.getChildren() : [];
if ( branches.length === 1 && branches[ 0 ].canContainContent() ) { if ( branches.length === 1 && branches[ 0 ].canContainContent() ) {
const leaves = branches[ 0 ].getChildren(); const leaves = branches[ 0 ].getChildren();
if ( leaves.length === 1 && leaves[ 0 ] instanceof ve.dm.MWTransclusionNode ) { if ( leaves.length === 1 && leaves[ 0 ] instanceof ve.dm.MWTransclusionNode ) {