wikimedia/mediawiki-extensions-Cite
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite synced 2024-11-15 02:55:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark private MWReferenceModel setters as such

Browse source 
This just documents the current status quo. These methods are not
used anywhere, and probably shouldn't:
https://codesearch.wmcloud.org/search/?q=%5Cbset%28ExtendsRef%7CList%28Key%7CGroup%7CIndex%29%29%5Cb
The only place these should ever be called from is from
newFromReferenceNode in the same class.

Bug: T363096
Change-Id: Ic28dbb5cbb2beb98c9fe6d283ed87d879728da0f
This commit is contained in:
thiemowmde 2024-04-24 13:54:54 +02:00
parent 646f167a2b
commit 14fe315c62
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-cite/ve.dm.MWReferenceModel.js
View file

@ -245,6 +245,7 @@ ve.dm.MWReferenceModel.prototype.getDocument = function () {
/** /**
* Set key of reference in list. * Set key of reference in list.
* *
* @private
* @param {string} listKey Reference's list key * @param {string} listKey Reference's list key
*/ */
ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) { ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) {
@ -254,6 +255,7 @@ ve.dm.MWReferenceModel.prototype.setListKey = function ( listKey ) {
/** /**
* Set the name of the parent reference that is being extended by the current reference. * Set the name of the parent reference that is being extended by the current reference.
* *
* @private
* @param {string} extendsRef References parent * @param {string} extendsRef References parent
*/ */
ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) { ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) {
@ -263,6 +265,7 @@ ve.dm.MWReferenceModel.prototype.setExtendsRef = function ( extendsRef ) {
/** /**
* Set name of the group a references list is in. * Set name of the group a references list is in.
* *
* @private
* @param {string} listGroup References list's group * @param {string} listGroup References list's group
*/ */
ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) { ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) {
@ -272,6 +275,7 @@ ve.dm.MWReferenceModel.prototype.setListGroup = function ( listGroup ) {
/** /**
* Set the index of reference in list. * Set the index of reference in list.
* *
* @private
* @param {string} listIndex Reference's list index * @param {string} listIndex Reference's list index
*/ */
ve.dm.MWReferenceModel.prototype.setListIndex = function ( listIndex ) { ve.dm.MWReferenceModel.prototype.setListIndex = function ( listIndex ) {